Commit Graph

44 Commits

Author SHA1 Message Date
Andrew Gaul 1f995879d6 Address FindBugs errors 2013-02-22 20:59:29 -08:00
adriancole dc4ca1efbd removed deprecated methods which were easy to do 2013-01-19 08:32:45 -08:00
Adrian Cole 3ac6f475e7 unwound dependencies relating to ssh keys and crypt 2013-01-13 20:53:59 -08:00
Adrian Cole bb953c981e fix issue #1101: Move to Guava 14 BaseEncoding and Hashing 2012-12-31 14:48:31 -08:00
Adrian Cole 878ec1bcab undid Serializable and added checkstyle InterfaceIsType:allowMarkerInterfaces=false 2012-11-18 09:23:44 -08:00
Andrew Gaul f94ee03626 Remove commons-io dependency from sshj
FilterInputStream suffices since we only override close.
2012-11-02 16:07:36 -07:00
Andrew Gaul 93d69ece2b Enforce newline at end of file via Checkstyle
Also address all warnings, via:

find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
Andrew Gaul 28d7a6f143 Prefer immutable over empty collections
The former does not create an object when calling iterator(), as
discussed here:

https://groups.google.com/d/msg/jclouds-dev/l7BviKDXreA/mP6Ow_RYxIgJ
2012-10-20 15:35:29 -07:00
Andrew Gaul 2b8b72758f Prefer Files.toString over FileInputStream 2012-10-10 21:33:22 -07:00
Andrew Gaul 985cccff9a Prefer valueOf over explicit object creation
This allows use of cached values.  Patched with:

find -name \*.java | xargs sed -i 's/new Boolean(false)/Boolean.FALSE/g'
find -name \*.java | xargs sed -i 's/new Boolean(true)/Boolean.TRUE/g'
find -name \*.java | xargs sed -i 's/new Boolean(/Boolean.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Integer(/Integer.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Long(/Long.valueOf(/g'
2012-07-22 21:01:46 -07:00
Andrew Gaul a40983a39d Prefer InputSupplier helpers
These ensure that inputs are closed properly.

Updated with: find -name \*.java | xargs sed -i
's/toStringAndClose(\(.*\)\.getInput())/toString(\1)/'
2012-07-18 17:42:48 -07:00
Adrian Cole 05fd64af44 cleaned up http builders and expect tests 2012-07-15 01:50:38 -07:00
Aled Sage 95c35487f0 Issue 1004: changes default SocketOpen impl
Sets it to InetSocketAddressConnect, instead of SocketOpenUnsupported.
Removes overriding the impl from Jsch and Sshj's client modules.
2012-07-05 16:00:29 +01:00
Adrian Cole 6407700de4 prevent assertions in sshj from borking tests 2012-05-18 15:58:51 -07:00
Matt Stephenson 381851b8ab Remove IPSocket class, replace with Guava's HostAndPort class. 2012-04-25 17:52:01 -07:00
Adrian Cole 5c6ce9f081 organize imports 2012-03-28 03:37:48 -04:00
Adrian Cole 728f9612e0 moved logback.xml up to compute module 2012-03-21 13:05:03 -07:00
Adrian Cole 755485537b allow execChannel to survive sshclient.disconnect, and not be bound by sessionTimeout 2012-03-10 13:25:12 -08:00
Adrian Cole 06ab36ae76 execChannel shouldn't allocate PTY 2012-03-10 10:15:44 -08:00
Adrian Cole d67aa3bbf5 more realistic test of ssh channel 2012-03-08 16:51:33 -08:00
Adrian Cole e39fc48901 accidental close on finally block 2012-03-08 16:51:09 -08:00
Adrian Cole dd7b16075e Issue 861:SSHClient should provide access to input/output streams 2012-03-08 15:48:51 -08:00
Adrian Cole 4837cf92c5 set a sane tty for ssh connections 2012-02-03 00:29:41 -08:00
Adrian Cole bc172850c1 retry sftp failures 2012-01-14 21:06:32 -08:00
Adrian Cole f390f314ee Issue 803: changes needed when guice is in production mode 2012-01-07 06:08:32 -08:00
Adrian Cole f9b38f646c Issue 730: removed deprecated methods from ComputeService RunScript/TemplateOptions SshClient.Factory and replaced occurences of Credentials with LoginCredentials whereever possible 2011-12-20 23:19:45 -08:00
Adrian Cole b8c6c73fe8 add md5 of password to log file 2011-12-20 23:19:39 -08:00
Alex Heneveld 067ed6d6ce test for 738, downgrading some warnings to info 2011-12-04 22:43:07 +00:00
Alex Heneveld c8d614e360 don't log warning if exception is retryable, downgraded to an info message 2011-12-04 22:43:07 +00:00
Alex Heneveld 4d11d4ef05 removed redundant error logging
(was done by caller and also in propagate method; have removed from caller;
might be better to remove from propagate, and leave at discretion of caller,
because some places the "error" might be benign, and shouldn't log error at all,
or not at >=WARN, but rather just leave at discretion of caller)
2011-12-04 22:43:06 +00:00
Alex Heneveld f55e4a5d3e merged duplicate code branches 2011-12-04 22:43:06 +00:00
Adrian Cole 09678a1df0 Issue 760:sshj driver throws exception disconnecting when client is already disconnected 2011-11-28 12:11:55 -05:00
Adrian Cole 264a542428 Issue 756:recreate ssh client on failure, rather than session 2011-11-20 10:45:33 +02:00
Adrian Cole 6b2cfa7f3a retry on user auth exception when flag set 2011-11-16 14:02:22 +02:00
Alex Heneveld 524bf68dd9 tests for 739 2011-11-14 01:47:39 +00:00
Alex Heneveld f4656c9e05 patch as per issue 739 2011-11-14 01:11:16 +00:00
Adrian Cole 06f418c8ba added another sshj test 2011-10-31 09:31:26 +00:00
Adrian Cole 4dae25ce2c more retryable sshj exceptions 2011-10-14 19:04:59 -07:00
Adrian Cole 3a9ac55e4a Issue 721:Connect errors not automatically retried in sshj 2011-10-14 10:40:01 -07:00
Adrian Cole 7e5a6e68cf Issue 719: add sha1 support to SshKeys 2011-10-13 23:57:46 -07:00
Adrian Cole bf4db76152 Issue 720: added live profile and logging to sshj 2011-10-13 11:11:27 -07:00
Adrian Cole c28a2e38c3 Issue 719: added some logging for ssh fingerprints 2011-10-13 01:49:49 -07:00
Adrian Cole 960bfe709f Issue 663:Update license headers to jclouds, Inc. and setup NOTICE file 2011-08-16 18:14:30 -07:00
Adrian Cole edc1b10610 Issue 637: moved to sshj and tested on aws-ec2 gogrid cloudservers elastichosts-lon-p trmk-* 2011-07-25 03:59:01 -07:00