Commit Graph

7109 Commits

Author SHA1 Message Date
Andrew Gaul bfa3458b97 Prefer specific asserts where possible 2012-11-04 14:40:24 -08:00
Adrian Cole 9212d4ff26 Merge pull request #952 from jclouds/remote-resources-plugin-version
update and centralize plugin version for maven-remote-resources-plugin
2012-11-04 09:11:49 -08:00
Adrian Cole beb36eac75 Merge pull request #940 from andrewgaul/checkstyle-misc
Miscellaneous Checkstyle fixes
2012-11-04 08:50:47 -08:00
Adrian Cole 7bc40e7fd5 Merge pull request #949 from andrewgaul/assert-fail
Prefer Assert.fail over assert
2012-11-04 08:45:03 -08:00
Adrian Cole 1c2f550600 Merge pull request #951 from andrewgaul/java-7-gogrid
Implement Comparable in GoGrid ErrorResponse
2012-11-04 08:43:45 -08:00
Adrian Cole a63f927deb Issue 1116: update and centralize plugin version for maven-remote-resources-plugin 2012-11-04 08:32:56 -08:00
Adrian Cole 14c056a077 Merge pull request #944 from andrewgaul/sshj-remove-commons-io
Remove commons-io dependency from sshj
2012-11-04 07:30:29 -08:00
Adrian Cole d0b83b88d5 Merge pull request #928 from andrewgaul/maven-plugins
Upgrade Maven plugins
2012-11-04 07:28:31 -08:00
Andrew Gaul b4eaa4330e Upgrade Maven plugins
Also specify minimum Maven version.

Test with mvn versions:display-plugin-updates
2012-11-03 18:17:03 -07:00
Andrew Gaul 0e35b3f623 Implement Comparable in GoGrid ErrorResponse
Gson collects errors in a TreeMap which requires a well-behaved
Comparable method.  This addresses a Java 7 GoGrid failure seen in
GridServerClientExpectTest.testGetServerCredentialsWhenNotFoundThrowsResourceNotFoundExceptionWithNiceMessage:

java.lang.ClassCastException: org.jclouds.gogrid.domain.internal.ErrorResponse cannot be cast to java.lang.Comparable
2012-11-03 17:08:43 -07:00
Andrew Gaul 0761874578 Prefer Assert.fail over assert
The former cannot be disabled.
2012-11-03 14:51:52 -07:00
Adrian Cole 10ab929097 Merge pull request #947 from andrewgaul/virtualbox-remove-commons-io
Remove commons-io dependency from virtualbox
2012-11-03 11:47:43 -07:00
Andrew Gaul 281172e637 Remove commons-io dependency from virtualbox 2012-11-03 11:03:58 -07:00
Adrian Cole 6d0071401c Merge pull request #946 from andrewgaul/jsch-remove-commons-io
Remove commons-io dependency from jsch
2012-11-03 10:43:19 -07:00
Andrew Gaul 981b0d047f Remove commons-io dependency from jsch
FilterInputStream suffices since we only override close and we can get
away with using java.io.ByteArrayOutputStream.
2012-11-03 10:29:48 -07:00
Andrew Gaul f94ee03626 Remove commons-io dependency from sshj
FilterInputStream suffices since we only override close.
2012-11-02 16:07:36 -07:00
Adrian Cole ea75c96560 Merge pull request #938 from andrewgaul/clear-container-cancel-futures
Cancel Futures in clearContainer
2012-11-02 09:56:50 -07:00
Adrian Cole bce3b0f2e6 Merge pull request #941 from andrewgaul/checkstyle-modifier-order
Enforce modifier order via Checkstyle
2012-11-02 09:55:23 -07:00
Andrew Gaul 08b9982384 Enforce modifier order via Checkstyle
Also fix violations, via:

find -name \*.java | xargs sed -i 's/final static/static final/'
find -name \*.java | xargs sed -i 's/static private/private static/'
find -name \*.java | xargs sed -i 's/static abstract/abstract static/'
2012-11-01 20:01:30 -07:00
Adrian Cole d4c01e6c2e Merge pull request #939 from andrewgaul/checkstyle-empty-statement
Enforce no empty statements via Checkstyle
2012-11-01 19:49:34 -07:00
Andrew Gaul 38b95f5ad9 Miscellaneous Checkstyle fixes
Nothing can extend a byte[] and remove a previous hidden unused import.
2012-11-01 19:11:59 -07:00
Andrew Gaul 88d53b8792 Enforce no empty statements via Checkstyle 2012-11-01 18:59:18 -07:00
Andrew Gaul 76a5538229 Cancel Futures in clearContainer
This prevents Futures from hanging around on exceptional code paths like
interrupts and timeouts.
2012-11-01 17:18:38 -07:00
Adrian Cole ddbb41130d Merge pull request #935 from andrewgaul/spelling
Correct typos
2012-11-01 15:23:34 -07:00
Andrew Gaul 35ce78f15a Correct typos 2012-11-01 13:25:44 -07:00
Adrian Cole d4eb847a55 Merge pull request #936 from abiquo/cleanup-strategies
Cleanup unnecessary strategies
2012-11-01 13:12:32 -07:00
Adrian Cole 5dad12764e Merge pull request #937 from andrewgaul/mailmap
.mailmap updates
2012-11-01 13:12:21 -07:00
Adrian Cole 4c72c5c803 Merge pull request #927 from iocanel/jclouds-osgi-fixes
Jclouds osgi fixes
2012-11-01 13:12:01 -07:00
Andrew Gaul dc2f60fd17 .mailmap updates 2012-10-31 15:08:04 -07:00
Ignasi Barrera f39c1add89 Removed all unnecessary interfaces from strategies
Removed all interfaces from the strategy classes that only have one
implementation.
2012-10-31 19:00:32 +01:00
Adrian Cole 308416b7b2 Merge pull request #934 from andrewgaul/filesystem-remove-ioutils
Remove filesystem dependency on Apache commons-io
2012-10-31 10:54:59 -07:00
Ignasi Barrera 5ba08d8448 Cleanup unnecessary strategies
Removed all over engineering introduced by strategies that did
not perform anything else than a simple api call.
2012-10-31 18:46:16 +01:00
Ioannis Canellos af7f14e76e Specified a wider version range for slf4j
.
2012-10-31 11:11:27 +02:00
Ioannis Canellos 0932195d33 Specified a wider version range for netty. 2012-10-31 11:11:12 +02:00
Ioannis Canellos f76b67ac33 Specified a wider version range for rocoto. 2012-10-31 11:10:57 +02:00
Ioannis Canellos f49cca46f0 MetadataBundleListener now works with multiple providers/apis per bundle. Added a class assignable check in MetadataBundleListener. Added unit test for MetadataBundleListener. Fixed spelling and formatting of MetadataBundleListener and MetadataBundleListenerTest. 2012-10-31 11:10:20 +02:00
Andrew Gaul b3da8e4603 Remove filesystem dependency on Apache commons-io 2012-10-30 20:48:58 -07:00
Adrian Cole cd330a759b Merge pull request #931 from abiquo/abiquo-live-tests
Added live tests in the Abiquo provider
2012-10-30 11:32:38 -07:00
Ignasi Barrera 98787ecc00 Override setupContext and tearDownContext to avoid ordering issues when running live tests 2012-10-30 17:13:09 +01:00
Adrian Cole 5da5161485 Merge pull request #909 from andrewgaul/clear-container-timeout-exception
Throw TimeoutException from awaitCompletion
2012-10-30 08:57:20 -07:00
Adrian Cole 7a46979e66 Merge pull request #922 from andrewgaul/checkstyle-newline-eof
Enforce newline at end of file via Checkstyle
2012-10-30 08:55:16 -07:00
Adrian Cole c5892ad522 Merge pull request #930 from andrewgaul/filesystem-test-teardown
Simplify FilesystemAsyncBlobStoreTest.tearDown
2012-10-30 08:50:11 -07:00
Susana Acedo 6b257340eb Added live tests in the Abiquo provider
This commit adds a few more relevant live tests to be executed by any
user, covering the virtual machine deployment and their lifecycle.
2012-10-30 11:21:18 +01:00
Andrew Gaul fd26ba0d40 Simplify FilesystemAsyncBlobStoreTest.tearDown
We should not swallow an IOException and resourcesToBeDeleted only ever
has one file.
2012-10-30 03:01:44 -07:00
Andrew Gaul 93d69ece2b Enforce newline at end of file via Checkstyle
Also address all warnings, via:

find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
Adrian Cole 7eadbf84ad Merge pull request #923 from andrewgaul/checkstyle-unused-imports
Enforce that all imports are used via Checkstyle
2012-10-29 20:55:22 -07:00
Andrew Gaul 709ca69a2d Enforce that all imports are used via Checkstyle
Also remove all unused imports, via:

mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | awk -v FS=: '/warning/{print "sed -i " $2 "d " $1}' | while read i; do $i; done
2012-10-29 17:11:08 -07:00
Adrian Cole 3a2905ee1e Merge pull request #926 from andrewgaul/to-string-and-close-exception-handling
Propagate exceptions from toStringAndClose
2012-10-29 16:50:37 -07:00
Adrian Cole 3a00a2c389 Merge pull request #924 from andrewgaul/copyright-notice
Address minor copyright notice typos
2012-10-29 16:50:01 -07:00
Adrian Cole afa3018dd0 Merge pull request #918 from andrewgaul/hpcloud-clearcontainer
Work around failed CDN metadata lookups with HPCS
2012-10-29 16:48:04 -07:00