Commit Graph

105 Commits

Author SHA1 Message Date
Andrew Gaul bfa3458b97 Prefer specific asserts where possible 2012-11-04 14:40:24 -08:00
Andrew Gaul 08b9982384 Enforce modifier order via Checkstyle
Also fix violations, via:

find -name \*.java | xargs sed -i 's/final static/static final/'
find -name \*.java | xargs sed -i 's/static private/private static/'
find -name \*.java | xargs sed -i 's/static abstract/abstract static/'
2012-11-01 20:01:30 -07:00
Andrew Gaul 35ce78f15a Correct typos 2012-11-01 13:25:44 -07:00
Andrew Gaul 93d69ece2b Enforce newline at end of file via Checkstyle
Also address all warnings, via:

find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
Andrew Gaul 709ca69a2d Enforce that all imports are used via Checkstyle
Also remove all unused imports, via:

mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | awk -v FS=: '/warning/{print "sed -i " $2 "d " $1}' | while read i; do $i; done
2012-10-29 17:11:08 -07:00
Andrew Gaul 28d7a6f143 Prefer immutable over empty collections
The former does not create an object when calling iterator(), as
discussed here:

https://groups.google.com/d/msg/jclouds-dev/l7BviKDXreA/mP6Ow_RYxIgJ
2012-10-20 15:35:29 -07:00
Andrew Gaul 71080cf2e1 Use Resources.toString where possible
Replaces calls to
CharStreams.toString(Resources.newReaderSupplier(...)).
2012-10-07 15:37:40 -07:00
Dies Koper b7666da170 nslookup on CentOS 6.2 doesn't set error code when failing, so grep expected output instead 2012-08-27 14:31:33 +10:00
Dies Koper cc5dc55bb0 configure .gitattributes to not convert shell scripts to CRLF on Windows 2012-08-24 17:29:40 +10:00
Adrian Cole b6c7c51606 test for resolveFunctionDependenciesForStatements 2012-08-21 11:44:21 -07:00
Adrian Cole cd98f16408 added statement to rebase dist packages 2012-08-13 14:20:27 -07:00
Ioannis Canellos 758e01a4d2 Fixed a possible NPE when ServiceFunctionLoader finds no OSGi service for a function. 2012-08-12 21:01:13 +03:00
Adrian Cole 52e61b7024 missing class 2012-08-11 22:41:12 -07:00
Adrian Cole c7f35d3bb1 removed invalid @Nullable usage and also usage of javax package usage 2012-08-11 20:59:16 -07:00
Adrian Cole faa3f7ff45 added epel repo dep to git install 2012-08-09 17:53:30 -07:00
Adrian Cole b478b02bbe switched to binary-based package manager checks 2012-08-01 11:35:10 -07:00
Adrian Cole da6307e3a7 added git statements 2012-07-30 19:14:12 -07:00
vijaykiran 829e4af9ee optimize imports 2012-07-24 07:53:52 +02:00
vijaykiran 7227d70c4e Issue-1020 Add full name option for AdminUser and UserAdd 2012-07-23 23:42:31 +02:00
Adrian Cole c4dde78b0c Merge pull request #725 from dralves/nodepool
issue 558 - nodepool
2012-07-19 04:38:59 -07:00
Andrew Phillips 16314f906c Made scriptbuilder tests compatible with Windows 2012-07-18 09:50:59 -04:00
David Ribeiro Alves cdde419b24 re-enabled most tests and corrected some minor bugs, only destoyPoolNodes is missing 2012-07-18 01:58:18 +01:00
Adrian Cole 05fd64af44 cleaned up http builders and expect tests 2012-07-15 01:50:38 -07:00
David Ribeiro Alves d4453b2ac2 nodepool progress and AdminAccessBuilderSpec 2012-07-12 11:04:55 -07:00
Andrew Bayer 4aa8e1055a Issue #1020. Fill in GECOS field when creating a user.
We'll just use the username there as well for now.
2012-07-11 17:48:20 -07:00
Adrian Cole 4d6e8fdd73 Issue 1005:openjdk install fails on ubuntu precise 2012-07-03 22:13:53 -07:00
Andrew Gaul 227dbf777a Correct spelled from delimeter to delimiter 2012-06-14 10:05:13 -04:00
Andrew Gaul 736554d049 Correct spelling errors 2012-06-14 10:03:39 -04:00
Adrian Cole 4dd8fdd0e2 Issue 964:change script builder variable case format from lowerCamel to UPPER_UNDERSCORE 2012-06-12 19:11:09 -07:00
Adrian Cole dcad558752 Issue 966: removed pid bracketing 2012-06-08 17:44:16 -07:00
Adrian Cole 73e026b314 functionloader cleanup 2012-06-08 13:00:38 -07:00
Ioannis Canellos 5627ceb2b9 Added a FunctionLoader interfaces for loading functions and also added a basic implementation and an OSGi implementation. 2012-06-08 11:12:14 -07:00
Adrian Cole 40bd08ee6b Issue 915: don't create full path on useradd 2012-05-22 23:10:41 -06:00
Aled Sage 8b6af79214 Issue 915: supports AdminAccess.adminHome, and UserAdd.home
Previously, UserAdd only supported 'defaultHome'. Now it supports 
'home' as well. This involved changing the `mkdir` from making 
defaultHome to making the actual home (felt like easier 
production-code than getting the parent directory of 'home' to mkdir,
but turned out to be a lot of test-code changes!).

Added AdminAccess.adminHome, which is a direct pass-through to 
UserAdd.home.
2012-05-21 21:10:28 +01:00
Adrian Cole 886d2cafb9 created base Context class with ProviderMetadata and Identity 2012-04-23 16:16:51 -07:00
Andrew Bayer 9b80b984a4 Switch to calling apt-get update before every apt-get install.
I found that the previous "apt-get install || (apt-get update; apt-get
install) didn't work in all cases, but switching to always calling
apt-get update got things working properly.
2012-04-19 13:02:47 -07:00
Adrian Cole 98a205b603 Issue 891: ensure we run apt update when install jdk fails 2012-04-18 15:02:06 -07:00
Andrew Gaul a3161ba7ba Throw return value instead of returning null
Throwables.propagate always throws its argument and throwing its
impossible return value better represents our intent than returning
null.
2012-04-16 13:45:23 -07:00
Adrian Cole 5a3d2a11d6 revert back to openjdk6 and without implicit apt-upgrade 2012-04-11 19:47:22 -06:00
Andrew Gaul b47860afc1 Use inference to elide duplicated type parameters
Found with:
grep 'Builder.*<.*>.*Immutable.*<.*>.*builder();'
2012-04-08 22:32:04 -07:00
Adrian Cole 95b33d335a Issue 891: update to support lucid 2012-04-03 16:22:02 -07:00
Adrian Cole 7e6b419068 Issue 891: ubuntu and centos now work with openjdk 2012-03-30 18:34:52 -07:00
Adrian Cole a6429398fd Issue 891: switch to openjdk; tested on ubuntu 2012-03-30 16:57:31 -07:00
Adrian Cole 5c6ce9f081 organize imports 2012-03-28 03:37:48 -04:00
Adrian Cole c72b3ae236 InstallJDK for 32bit vms 2012-02-26 16:55:42 +02:00
Adrian Cole 636c3bb6e5 Issue 357:Init script should check for errors + herefile fixes + script events 2012-02-19 01:53:19 +02:00
Adrian Cole 2da5d297a5 Issue 838: convert jboss tests and java tests to use InstallJDK 2012-02-14 23:22:24 +01:00
Adrian Cole 66c4a66159 new support for InstallJDK statement and setupPublicCurl fn 2012-02-14 02:01:42 +01:00
Adrian Cole c151e5bdd7 Issue 730: last deprecated methods scheduled for removal in 1.3 2012-01-10 18:10:55 -08:00
Adrian Cole f9b38f646c Issue 730: removed deprecated methods from ComputeService RunScript/TemplateOptions SshClient.Factory and replaced occurences of Credentials with LoginCredentials whereever possible 2011-12-20 23:19:45 -08:00