Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
lucene/gradle/validation/error-prone.gradle

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

503 lines
30 KiB
Groovy
Raw Normal View History

LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation (#1816) LUCENE-9497: Integrate Error Prone, a static analysis tool during compilation
2020-09-07 17:42:48 -04:00
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
Skip errorprone on non-nightlies. (#45)
2021-03-26 16:42:15 -04:00
def skipReason
Fix errorprone with alternative runtime (#12808)
2023-11-14 16:56:55 -05:00
if (rootProject.usesAltJvm) {
skipReason = "won't work with alternative java toolchain"
Skip errorprone on non-nightlies. (#45)
2021-03-26 16:42:15 -04:00
}
Detect CI builds and enable errorprone by default for those CI builds (#890)
2022-05-14 14:49:50 -04:00
if (!propertyOrDefault("validation.errorprone", isCIBuild).asBoolean()) {
skipReason = "skipped on builds not running inside CI environments, pass -Pvalidation.errorprone=true to enable"
Skip errorprone on non-nightlies. (#45)
2021-03-26 16:42:15 -04:00
}
if (skipReason) {
LUCENE-9650: errorprone plugin doesn't work on jdk16. A different workaround that keeps the dependency.
2021-03-15 05:19:27 -04:00
configure(rootProject) {
task errorProneSkipped() {
doFirst {
Skip errorprone on non-nightlies. (#45)
2021-03-26 16:42:15 -04:00
logger.warn("WARNING: errorprone disabled (${skipReason})")
LUCENE-9650: errorprone plugin doesn't work on jdk16. A different workaround that keeps the dependency.
2021-03-15 05:19:27 -04:00
}
}
}
LUCENE-9650: disable errorprone on jdk16+ (#2171)
2020-12-28 17:20:52 -05:00
}
LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation (#1816) LUCENE-9497: Integrate Error Prone, a static analysis tool during compilation
2020-09-07 17:42:48 -04:00
allprojects { prj ->
plugins.withType(JavaPlugin) {
Gradle build: cleanup of dependency resolution and consolidation of dependency versions (#13484)
2024-06-17 03:49:21 -04:00
// LUCENE-9650: Errorprone does not work when running as a plugin inside a forked Javac process.
// Javac running inside Gradle works, because we have additional module system opens in place.
Skip errorprone on non-nightlies. (#45)
2021-03-26 16:42:15 -04:00
if (skipReason) {
LUCENE-9650: errorprone plugin doesn't work on jdk16. A different workaround that keeps the dependency.
2021-03-15 05:19:27 -04:00
tasks.withType(JavaCompile) { task -> task.dependsOn ":errorProneSkipped" }
Gradle build: cleanup of dependency resolution and consolidation of dependency versions (#13484)
2024-06-17 03:49:21 -04:00
// Error prone plugin adds error prone to test classpath. We need to add it here too (manually) so that
// versions.lock is consistent with or without error prone.
LUCENE-9650: errorprone plugin doesn't work on jdk16. A different workaround that keeps the dependency.
2021-03-15 05:19:27 -04:00
configurations {
errorprone
}
dependencies {
Gradle build: cleanup of dependency resolution and consolidation of dependency versions (#13484)
2024-06-17 03:49:21 -04:00
errorprone deps.errorprone
LUCENE-9650: errorprone plugin doesn't work on jdk16. A different workaround that keeps the dependency.
2021-03-15 05:19:27 -04:00
}
Gradle build: cleanup of dependency resolution and consolidation of dependency versions (#13484)
2024-06-17 03:49:21 -04:00
configurations.annotationProcessor.extendsFrom(configurations.errorprone)
LUCENE-9650: errorprone plugin doesn't work on jdk16. A different workaround that keeps the dependency.
2021-03-15 05:19:27 -04:00
} else {
Gradle build: cleanup of dependency resolution and consolidation of dependency versions (#13484)
2024-06-17 03:49:21 -04:00
prj.apply plugin: deps.plugins.errorprone.get().pluginId
LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation (#1816) LUCENE-9497: Integrate Error Prone, a static analysis tool during compilation
2020-09-07 17:42:48 -04:00
LUCENE-9650: errorprone plugin doesn't work on jdk16. A different workaround that keeps the dependency.
2021-03-15 05:19:27 -04:00
dependencies {
Gradle build: cleanup of dependency resolution and consolidation of dependency versions (#13484)
2024-06-17 03:49:21 -04:00
errorprone deps.errorprone
LUCENE-9650: errorprone plugin doesn't work on jdk16. A different workaround that keeps the dependency.
2021-03-15 05:19:27 -04:00
}
LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation (#1816) LUCENE-9497: Integrate Error Prone, a static analysis tool during compilation
2020-09-07 17:42:48 -04:00
Always include errorprone dependency, even if we're not checking. This ensures consistent use patterns across JVMs.
2021-03-11 16:27:25 -05:00
tasks.withType(JavaCompile) { task ->
Clean up MR-JAR build, so we do not have hardcoded "19" everywhere in validation tasks (#11835) As long as soureSets are named "mainXX", with XX a feature version, we check everything automatically: - ECJ is disabled (we can't do a check without forking ECJ as a separate process using toolkit, we may support this later) - forbiddenapis (we disable checks for missing classes) - errorprone is disabled (errorprone does not work correctly at moment with forked compiler)
2022-10-02 14:41:46 -04:00
// Disable errorprone on the MR-JAR tasks
if (task.name ==~ /compileMain\d+Java/) {
MR-JAR rewrite of MMapDirectory with JDK-19 preview Panama APIs (>= JDK-19-ea+23) (#912) This uses Gradle's auto-provisioning to compile Java 19 classes and build a multi-release JAR from them. Please make sure to regenerate gradle.properties (delete it) or change "org.gradle.java.installations.auto-download" to "true"
2022-09-26 09:22:04 -04:00
options.errorprone.enabled = false
return
}
LUCENE-10510: Check module access prior to running gjf/spotless tasks (#802)
2022-04-10 14:35:45 -04:00
task.dependsOn ":checkJdkInternalsExportedToGradle"
Always include errorprone dependency, even if we're not checking. This ensures consistent use patterns across JVMs.
2021-03-11 16:27:25 -05:00
options.errorprone.disableWarningsInGeneratedCode = true
options.errorprone.errorproneArgs = [
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-XepDisableAllChecks', // only enable specific checks
enable error-prone "narrow calculation" check (#11923) This check finds bugs such as https://github.com/apache/lucene/pull/11905. See https://errorprone.info/bugpattern/NarrowCalculation
2022-11-15 06:42:41 -05:00
'-XepAllErrorsAsWarnings', // warnings still fail build by default, but allows usage of -Pjavac.failOnWarnings=false
LUCENE-10364: Prepare and update errorprone plugin for Java 17 (#590)
2022-01-07 13:19:46 -05:00
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
// List of enabled/disabled checks
// Please keep this synced with https://errorprone.info/bugpatterns when upgrading!
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// Do *NOT* enable checks based on their name or description. Read the source code and make sure they are useful!
// Most error-prone checks are not useful for non-google software.
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
// On by Default : ERROR
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:AlwaysThrows:OFF', // we don't use google collections
// '-Xep:AndroidInjectionBeforeSuper:OFF', // we don't use android
fix use of wrong array equals() method in test, enable check (#11977)
2022-11-25 11:46:48 -05:00
'-Xep:ArrayEquals:ERROR',
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:ArrayFillIncompatibleType:ERROR',
fix use of wrong array toString() method in test, enable check (#11978)
2022-11-25 11:47:04 -05:00
'-Xep:ArrayHashCode:ERROR',
'-Xep:ArrayToString:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:ArraysAsListPrimitiveArray:OFF', // we don't use guava
// '-Xep:AsyncCallableReturnsNull:OFF', // we don't use guava
// '-Xep:AsyncFunctionReturnsNull:OFF', // we don't use guava
// '-Xep:AutoValueBuilderDefaultsInConstructor:OFF', // we don't use autovalue
// '-Xep:AutoValueConstructorOrderChecker:OFF', // we don't use autovalue
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:BadAnnotationImplementation:ERROR',
fix bad shift amounts and enable check (#11979)
2022-11-25 11:47:25 -05:00
'-Xep:BadShiftAmount:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:BanJNDI:OFF', // implemented with forbidden APIs instead
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:BoxedPrimitiveEquality:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:BundleDeserializationCast:OFF', // we don't use android
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:ChainingConstructorIgnoresParameter:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:CheckNotNullMultipleTimes:OFF', // we don't use guava
// '-Xep:CheckReturnValue:OFF', // we don't use these annotations
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:CollectionToArraySafeParameter:ERROR',
// '-Xep:ComparableType:OFF',
'-Xep:ComparingThisWithNull:ERROR',
'-Xep:ComparisonOutOfRange:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:CompatibleWithAnnotationMisuse:OFF', // we don't use this annotation
// '-Xep:CompileTimeConstant:OFF', // we don't use this annotation
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:ComputeIfAbsentAmbiguousReference:ERROR',
'-Xep:ConditionalExpressionNumericPromotion:ERROR',
'-Xep:ConstantOverflow:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:DaggerProvidesNull:OFF', // we don't use dagger
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:DangerousLiteralNull:ERROR',
'-Xep:DeadException:ERROR',
'-Xep:DeadThread:ERROR',
'-Xep:DiscardedPostfixExpression:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:DoNotCall:OFF', // we don't use this annotation
// '-Xep:DoNotMock:OFF', // we don't use mocking libraries
// '-Xep:DoubleBraceInitialization:OFF', // we don't use guava
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:DuplicateMapKeys:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:DurationFrom:OFF', // we don't use Duration.from()
// '-Xep:DurationGetTemporalUnit:OFF', // we don't use Duration.get()
// '-Xep:DurationTemporalUnit:OFF', // we don't use Duration.of() etc
// '-Xep:DurationToLongTimeUnit:OFF', // we don't use TimeUnit.convert Duration, etc
// '-Xep:EmptyTopLevelDeclaration:OFF', // noisy
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:EqualsHashCode:ERROR',
'-Xep:EqualsNaN:ERROR',
'-Xep:EqualsNull:ERROR',
'-Xep:EqualsReference:ERROR',
'-Xep:EqualsWrongThing:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:FloggerFormatString:OFF', // we don't use flogger
// '-Xep:FloggerLogVarargs:OFF', // we don't use flogger
// '-Xep:FloggerSplitLogStatement:OFF', // we don't use flogger
// '-Xep:ForOverride:OFF', // we don't use this annotation
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
// '-Xep:FormatString:OFF',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:FormatStringAnnotation:OFF', // we don't use this annotation
// '-Xep:FromTemporalAccessor:OFF', // we don't use .from(LocalDate) etc
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:FunctionalInterfaceMethodChanged:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:FuturesGetCheckedIllegalExceptionType:OFF', // we don't use guava
// '-Xep:FuzzyEqualsShouldNotBeUsedInEqualsMethod:OFF', // we don't use guava
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:GetClassOnAnnotation:ERROR',
'-Xep:GetClassOnClass:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:GuardedBy:OFF', // we don't use this annotation
// '-Xep:GuiceAssistedInjectScoping:OFF', // we don't use guice
// '-Xep:GuiceAssistedParameters:OFF', // we don't use guice
// '-Xep:GuiceInjectOnFinalField:OFF', // we don't use guice
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:HashtableContains:ERROR',
// '-Xep:IdentityBinaryExpression:OFF',
'-Xep:IdentityHashMapBoxing:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:IgnoredPureGetter:OFF', // we don't use these annotations
// '-Xep:Immutable:OFF', // we don't use this annotation
Update to error-prone 2.17 (#12056)
2023-01-14 11:38:39 -05:00
// '-Xep:ImpossibleNullComparison:OFF', // we don't use protobuf
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:Incomparable:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:IncompatibleArgumentType:OFF', // we don't use this annotation
// '-Xep:IncompatibleModifiers:OFF', // we don't use this annotation
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:IndexOfChar:ERROR',
'-Xep:InexactVarargsConditional:ERROR',
// '-Xep:InfiniteRecursion:OFF',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:InjectMoreThanOneScopeAnnotationOnClass:OFF', // we don't use this annotation
// '-Xep:InjectOnMemberAndConstructor:OFF', // we don't use this annotation
// '-Xep:InlineMeValidator:OFF', // we don't use this annotation
// '-Xep:InstantTemporalUnit:OFF', // we don't use Instant apis with strange temporal units
// '-Xep:InvalidJavaTimeConstant:OFF', // we don't use impacted java.time classes (Month, etc)
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
// '-Xep:InvalidPatternSyntax:OFF',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:InvalidTimeZoneID:OFF', // we don't use getTimeZone with constant IDs except UTC/GMT
// '-Xep:InvalidZoneId:OFF', // we don't use ZoneId.of
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:IsInstanceIncompatibleType:ERROR',
'-Xep:IsInstanceOfClass:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:IsLoggableTagLength:OFF', // we don't use android
// '-Xep:JUnit3TestNotRun:OFF', // we don't use junit3
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:JUnit4ClassAnnotationNonStatic:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:JUnit4SetUpNotRun:OFF', // LuceneTestCase takes care
// '-Xep:JUnit4TearDownNotRun:OFF', // LuceneTestCase takes care
// '-Xep:JUnit4TestNotRun:OFF', // noisy
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:JUnit4TestsNotRunWithinEnclosed:ERROR',
'-Xep:JUnitAssertSameCheck:ERROR',
'-Xep:JUnitParameterMethodNotFound:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:JavaxInjectOnAbstractMethod:OFF', // we don't this annotation
// '-Xep:JodaToSelf:OFF', // we don't use joda-time
Update to error-prone 2.17 (#12056)
2023-01-14 11:38:39 -05:00
// '-Xep:LenientFormatStringValidation:OFF' // we don't use these google libraries
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:LiteByteStringUtf8:OFF', // we don't use protobuf
// '-Xep:LocalDateTemporalAmount:OFF', // we don't use LocalDate math
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:LockOnBoxedPrimitive:ERROR',
'-Xep:LoopConditionChecker:ERROR',
'-Xep:LossyPrimitiveCompare:ERROR',
'-Xep:MathRoundIntLong:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:MislabeledAndroidString:OFF', // we don't use android
// '-Xep:MisplacedScopeAnnotations:OFF', // we don't use this annotation
// '-Xep:MissingSuperCall:OFF', // we don't use this annotation
// '-Xep:MissingTestCall:OFF', // we don't use guava
// '-Xep:MisusedDayOfYear:OFF', // we don't use date patterns
// '-Xep:MisusedWeekYear:OFF', // we don't use date patterns
// '-Xep:MixedDescriptors:OFF', // we don't use protobuf
// '-Xep:MockitoUsage:OFF', // we don't use mockito
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:ModifyingCollectionWithItself:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:MoreThanOneInjectableConstructor:OFF', // we don't use this annotation
// '-Xep:MustBeClosedChecker:OFF', // we don't use this annotation
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:NCopiesOfChar:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:NoCanIgnoreReturnValueOnClasses:OFF', // we don't use this annotation
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:NonCanonicalStaticImport:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:NonFinalCompileTimeConstant:OFF', // we don't use this annotation
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:NonRuntimeAnnotation:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:NullArgumentForNonNullParameter:OFF', // we don't use this annotation
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:NullTernary:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:NullableOnContainingClass:OFF', // we don't use this annotation
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:OptionalEquality:ERROR',
'-Xep:OptionalMapUnusedValue:ERROR',
'-Xep:OptionalOfRedundantMethod:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:OverlappingQualifierAndScopeAnnotation:OFF', // we don't use this annotation
// '-Xep:OverridesJavaxInjectableMethod:OFF', // we don't use this annotation
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:PackageInfo:ERROR',
'-Xep:ParametersButNotParameterized:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:ParcelableCreator:OFF', // we don't use android
// '-Xep:PeriodFrom:OFF', // we don't use Period
// '-Xep:PeriodGetTemporalUnit:OFF', // we don't use Period
// '-Xep:PeriodTimeMath:OFF', // we don't use Period
// '-Xep:PreconditionsInvalidPlaceholder:OFF', // we don't use guava
// '-Xep:PrivateSecurityContractProtoAccess:OFF', // we don't use protobuf
// '-Xep:ProtoBuilderReturnValueIgnored:OFF', // we don't use protobuf
// '-Xep:ProtoFieldNullComparison:OFF', // we don't use protobuf
// '-Xep:ProtoStringFieldReferenceEquality:OFF', // we don't use protobuf
// '-Xep:ProtoTruthMixedDescriptors:OFF', // we don't use protobuf
// '-Xep:ProtocolBufferOrdinal:OFF', // we don't use protobuf
// '-Xep:ProvidesMethodOutsideOfModule:OFF', // we don't use guice
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:RandomCast:ERROR',
'-Xep:RandomModInteger:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:RectIntersectReturnValueIgnored:OFF', // we don't use android
// '-Xep:RequiredModifiers:OFF', // we don't use this annotation
// '-Xep:RestrictedApiChecker:OFF', // we don't use this annotation
// '-Xep:ReturnValueIgnored:OFF', // noisy
fix variable assigned to itself in test and enable check (#11980)
2022-11-25 11:45:45 -05:00
'-Xep:SelfAssignment:ERROR',
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:SelfComparison:ERROR',
'-Xep:SelfEquals:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:ShouldHaveEvenArgs:OFF', // we don't use truth
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:SizeGreaterThanOrEqualsZero:ERROR',
'-Xep:StreamToString:ERROR',
'-Xep:StringBuilderInitWithChar:ERROR',
'-Xep:SubstringOfZero:ERROR',
'-Xep:SuppressWarningsDeprecated:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:TemporalAccessorGetChronoField:OFF', // we don't use TemporalAccessor.get
// '-Xep:TestParametersNotInitialized:OFF', // we don't use this annotation
// '-Xep:TheoryButNoTheories:OFF', // we don't use junit theory apis/runner
// '-Xep:ThrowIfUncheckedKnownChecked:OFF', // we don't use this annotation
// '-Xep:ThrowNull:OFF', // noisy (LuceneTestCase)
// '-Xep:TreeToString:OFF', // we don't use javac API
// '-Xep:TruthSelfEquals:OFF', // we don't use truth
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
// '-Xep:TryFailThrowable:OFF',
'-Xep:TypeParameterQualifier:ERROR',
'-Xep:UnicodeDirectionalityCharacters:ERROR',
enable error-prone's DisableUnicodeInCode check (#12936) Closes #12931
2023-12-13 08:19:22 -05:00
'-Xep:UnicodeInCode:ERROR',
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:UnnecessaryCheckNotNull:ERROR',
'-Xep:UnnecessaryTypeArgument:ERROR',
'-Xep:UnsafeWildcard:ERROR',
'-Xep:UnusedAnonymousClass:ERROR',
'-Xep:UnusedCollectionModifiedInPlace:ERROR',
'-Xep:VarTypeName:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:WrongOneof:OFF', // we don't use protobuf
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:XorPower:ERROR',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:ZoneIdOfZ:OFF', // we don't use ZoneId.of
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
// On by Default : WARNING
Update to error-prone 2.17 (#12056)
2023-01-14 11:38:39 -05:00
// '-Xep:ASTHelpersSuggestions:OFF', // we don't use ASTHelpers
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:AlmostJavadoc:OFF', // noisy (e.g. commented-out code misinterpreted as javadocs)
// '-Xep:AlreadyChecked:OFF', // TODO: there are problems
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
// '-Xep:AmbiguousMethodReference:OFF',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:AnnotateFormatMethod:OFF', // we don't use this annotation
// '-Xep:ArgumentSelectionDefectChecker:OFF', // noisy
// '-Xep:ArrayAsKeyOfSetOrMap:OFF', // TODO: there are problems
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:AssertEqualsArgumentOrderChecker:WARN',
'-Xep:AssertThrowsMultipleStatements:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:AssertionFailureIgnored:OFF', // TODO: there are problems
// '-Xep:AssistedInjectAndInjectOnSameConstructor:OFF', // we don't use this annotation
// '-Xep:AutoValueFinalMethods:OFF', // we don't use autovalue
// '-Xep:AutoValueImmutableFields:OFF', // we don't use autovalue
// '-Xep:AutoValueSubclassLeaked:OFF', // we don't use autovalue
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:BadComparable:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:BadImport:OFF', // TODO: there are problems
// '-Xep:BadInstanceof:OFF', // TODO: there are problems
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:BareDotMetacharacter:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:BigDecimalEquals:OFF', // BigDecimal barely used, can use forbidden-apis for this
// '-Xep:BigDecimalLiteralDouble:OFF', // BigDecimal barely used, can use forbidden-apis for this
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
// '-Xep:BoxedPrimitiveConstructor:OFF', // we have forbiddenapis for that
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:BugPatternNaming:OFF', // we don't use this annotation
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
// '-Xep:ByteBufferBackingArray:OFF',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:CacheLoaderNull:OFF', // we don't use guava
// '-Xep:CanonicalDuration:OFF', // barely use Duration.of (one test), just a style thing
// '-Xep:CatchAndPrintStackTrace:OFF', // noisy
// '-Xep:CatchFail:OFF', // TODO: there are problems
// '-Xep:ChainedAssertionLosesContext:OFF', // we don't use truth
// '-Xep:CharacterGetNumericValue:OFF', // noisy
// '-Xep:ClassCanBeStatic:OFF', // noisy
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:ClassNewInstance:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:CloseableProvides:OFF', // we don't use this annotation
// '-Xep:CollectionUndefinedEquality:OFF', // TODO: there are problems
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:CollectorShouldNotUseState:WARN',
'-Xep:ComparableAndComparator:WARN',
'-Xep:CompareToZero:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:ComplexBooleanConstant:OFF', // TODO: there are problems
// '-Xep:DateChecker:OFF', // we don't use these Date setters/ctors
// '-Xep:DateFormatConstant:OFF', // we don't use Date setters
// '-Xep:DefaultCharset:OFF', // we have forbiddenapis for that
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
// '-Xep:DefaultPackage:OFF',
'-Xep:DeprecatedVariable:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:DirectInvocationOnMock:OFF', // we don't use mocking libraries
// '-Xep:DistinctVarargsChecker:OFF', // we don't use google collections
// '-Xep:DoNotCallSuggester:OFF', // we don't use this annotation
// '-Xep:DoNotClaimAnnotations:OFF', // we don't use annotation processors
// '-Xep:DoNotMockAutoValue:OFF', // we don't use autovalue
// '-Xep:DoubleCheckedLocking:OFF', // TODO: there are problems
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:EmptyBlockTag:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:EmptyCatch:OFF', // ECJ takes care
// '-Xep:EmptySetMultibindingContributions:OFF', // we don't use this annotation
// '-Xep:EqualsGetClass:OFF', // noisy
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
// '-Xep:EqualsIncompatibleType:OFF',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:EqualsUnsafeCast:OFF', // noisy
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:EqualsUsingHashCode:WARN',
'-Xep:ErroneousBitwiseExpression:WARN',
'-Xep:ErroneousThreadPoolConstructorChecker:WARN',
// '-Xep:EscapedEntity:OFF',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:ExtendingJUnitAssert:OFF', // noisy
// '-Xep:ExtendsObject:OFF', // TODO: there are problems
// '-Xep:FallThrough:OFF', // TODO: there are problems
Upgrade to errorprone 2.18 (#12086)
2023-01-14 14:39:23 -05:00
'-Xep:Finalize:WARN', // catches actual finalizers that don't call super
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:Finally:OFF', // TODO: there are problems
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:FloatCast:WARN',
'-Xep:FloatingPointAssertionWithinEpsilon:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:FloatingPointLiteralPrecision:OFF', // TODO: there are problems
// '-Xep:FloggerArgumentToString:OFF', // we don't use flogger
// '-Xep:FloggerStringConcatenation:OFF', // we don't use flogger
// '-Xep:FragmentInjection:OFF', // we don't use android
// '-Xep:FragmentNotInstantiable:OFF', // we don't use android
// '-Xep:FutureReturnValueIgnored:OFF', // TODO: there are problems
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:GetClassOnEnum:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:HidingField:OFF', // noisy
// '-Xep:IdentityHashMapUsage:OFF', // noisy
// '-Xep:ImmutableAnnotationChecker:OFF', // we don't use this annotation
// '-Xep:ImmutableEnumChecker:OFF', // noisy
// '-Xep:InconsistentCapitalization:OFF', // TODO: there are problems
// '-Xep:InconsistentHashCode:OFF', // noisy
Update to error-prone 2.17 (#12056)
2023-01-14 11:38:39 -05:00
// '-Xep:IgnoredPureGetter:OFF', // we don't use these google libraries
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:IncorrectMainMethod:WARN',
'-Xep:IncrementInForLoopAndHeader:WARN',
'-Xep:InheritDoc:WARN',
Upgrade to errorprone 2.18 (#12086)
2023-01-14 14:39:23 -05:00
// '-Xep:InjectOnBugCheckers:OFF', // we don't use this annotation
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:InjectInvalidTargetingOnScopingAnnotation:OFF', // we don't use this annotation
// '-Xep:InjectOnConstructorOfAbstractClass:OFF', // we don't use this annotation
// '-Xep:InjectScopeAnnotationOnInterfaceOrAbstractClass:OFF', // we don't use this annotation
// '-Xep:InjectedConstructorAnnotations:OFF', // we don't use this annotation
// '-Xep:InlineFormatString:OFF', // noisy
// '-Xep:InlineMeInliner:OFF', // we don't use this annotation
// '-Xep:InlineMeSuggester:OFF', // we don't use this annotation
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
// '-Xep:InputStreamSlowMultibyteRead:OFF',
'-Xep:InstanceOfAndCastMatchWrongType:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:IntLongMath:OFF', // noisy
// '-Xep:InvalidBlockTag:OFF', // noisy (e.g. lucene.experimental)
// '-Xep:InvalidInlineTag:OFF', // TODO: there are problems
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:InvalidLink:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:InvalidParam:OFF', // TODO: there are problems
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:InvalidThrows:WARN',
'-Xep:InvalidThrowsLink:WARN',
'-Xep:IterableAndIterator:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:JUnit3FloatingPointComparisonWithoutDelta:OFF', // we don't use junit3
// '-Xep:JUnit4ClassUsedInJUnit3:OFF', // we don't use junit3
// '-Xep:JUnitAmbiguousTestClass:OFF', // we don't use junit3
// '-Xep:JavaDurationGetSecondsGetNano:OFF', // we don't use these Duration methods
// '-Xep:JavaDurationWithNanos:OFF', // we don't use these Duration methods
// '-Xep:JavaDurationWithSeconds:OFF', // we don't use these Duration methods
// '-Xep:JavaInstantGetSecondsGetNano:OFF', // we don't use these Instant methods
// '-Xep:JavaLangClash:OFF', // TODO: there are problems
// '-Xep:JavaLocalDateTimeGetNano:OFF', // we don't use LocalDateTime
// '-Xep:JavaLocalTimeGetNano:OFF', // we don't use LocalTime
// '-Xep:JavaPeriodGetDays:OFF', // we don't use Period
// '-Xep:JavaTimeDefaultTimeZone:OFF', // forbidden-apis checks this
// '-Xep:JavaUtilDate:OFF', // noisy
// '-Xep:JavaxInjectOnFinalField:OFF', // we don't use this annotation
// '-Xep:JdkObsolete:OFF', // noisy
// '-Xep:JodaConstructors:OFF', // we don't use joda-time
// '-Xep:JodaDateTimeConstants:OFF', // we don't use joda-time
// '-Xep:JodaDurationWithMillis:OFF', // we don't use joda-time
// '-Xep:JodaInstantWithMillis:OFF', // we don't use joda-time
// '-Xep:JodaNewPeriod:OFF', // we don't use joda-time
// '-Xep:JodaPlusMinusLong:OFF', // we don't use joda-time
// '-Xep:JodaTimeConverterManager:OFF', // we don't use joda-time
// '-Xep:JodaWithDurationAddedLong:OFF', // we don't use joda-time
Upgrade to errorprone 2.18 (#12086)
2023-01-14 14:39:23 -05:00
// '-Xep:LabelledBreakTarget:OFF', // stylistic
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:LiteEnumValueOf:OFF', // we don't use protobuf
// '-Xep:LiteProtoToString:OFF', // we don't use protobuf
// '-Xep:LockNotBeforeTry:OFF', // TODO: there are problems
fix wrong serialization by ShapeDocValues (#11974) Closes #11973
2022-12-01 20:32:42 -05:00
'-Xep:LogicalAssignment:WARN',
Enable LongDoubleConversion error-prone check (#12010)
2022-12-12 20:55:39 -05:00
'-Xep:LongDoubleConversion:WARN',
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:LongFloatConversion:WARN',
'-Xep:LoopOverCharArray:WARN',
'-Xep:MalformedInlineTag:WARN',
Update to error-prone 2.17 (#12056)
2023-01-14 11:38:39 -05:00
// '-Xep:MathAbsoluteNegative:OFF', // TODO: there are problems
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:MemoizeConstantVisitorStateLookups:OFF', // we don't use this class
// '-Xep:MissingCasesInEnumSwitch:OFF', // redundant with ECJ incompleteEnumSwitch/missingEnumCaseDespiteDefault
// '-Xep:MissingFail:OFF', // TODO: there are problems
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:MissingImplementsComparable:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:MissingOverride:OFF', // ECJ takes care of this
// '-Xep:MissingSummary:OFF', // TODO: there are problems
// '-Xep:MixedMutabilityReturnType:OFF', // noisy
// '-Xep:MockNotUsedInProduction:OFF', // we don't use mocking libraries
// '-Xep:ModifiedButNotUsed:OFF', // TODO: there are problems
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:ModifyCollectionInEnhancedForLoop:WARN',
'-Xep:ModifySourceCollectionInStream:WARN',
'-Xep:MultipleParallelOrSequentialCalls:WARN',
'-Xep:MultipleUnaryOperatorsInMethodCall:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:MutablePublicArray:OFF', // TODO: there are problems
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:NarrowCalculation:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:NarrowingCompoundAssignment:OFF', // noisy
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:NegativeCharLiteral:WARN',
'-Xep:NestedInstanceOfConditions:WARN',
Update to error-prone 2.17 (#12056)
2023-01-14 11:38:39 -05:00
// '-Xep:NewFileSystem:OFF', // we don't create new filesystems
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:NonAtomicVolatileUpdate:OFF', // TODO: there are problems
// '-Xep:NonCanonicalType:OFF', // noisy
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:NonOverridingEquals:WARN',
'-Xep:NullOptional:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:NullableConstructor:OFF', // we don't use this annotation
// '-Xep:NullablePrimitive:OFF', // we don't use this annotation
// '-Xep:NullablePrimitiveArray:OFF', // we don't use this annotation
// '-Xep:NullableVoid:OFF', // we don't use this annotation
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:ObjectEqualsForPrimitives:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:ObjectToString:OFF', // TODO: there are problems
// '-Xep:ObjectsHashCodePrimitive:OFF', // TODO: there are problems
// '-Xep:OperatorPrecedence:OFF', // noisy
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:OptionalMapToOptional:WARN',
'-Xep:OptionalNotPresent:WARN',
'-Xep:OrphanedFormatString:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:OutlineNone:OFF', // we don't use gwt
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:OverrideThrowableToString:WARN',
'-Xep:Overrides:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:OverridesGuiceInjectableMethod:OFF', // we don't use guice
// '-Xep:ParameterName:OFF', // we don't pass parameters with comments in this way
// '-Xep:PreconditionsCheckNotNullRepeated:OFF', // we don't use guava
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:PrimitiveAtomicReference:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:ProtectedMembersInFinalClass:OFF', // we don't use protobuf
// '-Xep:ProtoDurationGetSecondsGetNano:OFF', // we don't use protobuf
// '-Xep:ProtoRedundantSet:OFF', // we don't use protobuf
// '-Xep:ProtoTimestampGetSecondsGetNano:OFF', // we don't use protobuf
// '-Xep:QualifierOrScopeOnInjectMethod:OFF', // we don't use this annotation
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:ReachabilityFenceUsage:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:ReferenceEquality:OFF', // noisy
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:RethrowReflectiveOperationExceptionAsLinkageError:WARN',
'-Xep:ReturnFromVoid:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:RobolectricShadowDirectlyOn:OFF', // we don't use robolectric
// '-Xep:RxReturnValueIgnored:OFF', // we don't use rxjava
// '-Xep:SameNameButDifferent:OFF', // TODO: there are problems
// '-Xep:SelfAlwaysReturnsThis:OFF', // we don't use self() methods, this isn't python.
// '-Xep:ShortCircuitBoolean:OFF', // TODO: there are problems
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
// '-Xep:StaticAssignmentInConstructor:OFF',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:StaticAssignmentOfThrowable:OFF', // noisy
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
// '-Xep:StaticGuardedByInstance:OFF',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:StaticMockMember:OFF', // we don't use mock libraries
// '-Xep:StreamResourceLeak:OFF', // TODO: there are problems
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:StreamToIterable:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:StringSplitter:OFF', // noisy, can use forbidden-apis for this
// '-Xep:SwigMemoryLeak:OFF', // we don't use swig
// '-Xep:SynchronizeOnNonFinalField:OFF', // noisy
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
// '-Xep:ThreadJoinLoop:OFF',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:ThreadLocalUsage:OFF', // noisy
// '-Xep:ThreadPriorityCheck:OFF', // noisy, forbidden APIs can do this
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:ThreeLetterTimeZoneID:WARN',
'-Xep:TimeUnitConversionChecker:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:ToStringReturnsNull:OFF', // TODO: there are problems
// '-Xep:TruthAssertExpected:OFF', // we don't use truth
// '-Xep:TruthConstantAsserts:OFF', // we don't use truth
// '-Xep:TruthGetOrDefault:OFF', // we don't use truth
// '-Xep:TruthIncompatibleType:OFF', // we don't use truth
// '-Xep:TypeEquals:OFF', // we don't use this internal javac api
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:TypeNameShadowing:WARN',
// '-Xep:TypeParameterShadowing:OFF',
// '-Xep:TypeParameterUnusedInFormals:OFF',
'-Xep:URLEqualsHashCode:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:UndefinedEquals:OFF', // TODO: there are problems
// '-Xep:UnescapedEntity:OFF', // TODO: there are problems
// '-Xep:UnicodeEscape:OFF', // noisy
// '-Xep:UnnecessaryAssignment:OFF', // we don't use these annotations
// '-Xep:UnnecessaryLambda:OFF', // TODO: there are problems
// '-Xep:UnnecessaryLongToIntConversion:OFF', // TODO: there are problems
// '-Xep:UnnecessaryMethodInvocationMatcher:OFF', // we don't use spring
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:UnnecessaryMethodReference:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:UnnecessaryParentheses:OFF', // noisy
Update to error-prone 2.17 (#12056)
2023-01-14 11:38:39 -05:00
// '-Xep:UnqualifiedYield:OFF', // javac takes care
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:UnrecognisedJavadocTag:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:UnsafeFinalization:OFF', // we don't use finalizers, deprecated for removal, fails build
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:UnsafeReflectiveConstructionCast:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:UnsynchronizedOverridesSynchronized:OFF', // TODO: there are problems
Upgrade to errorprone 2.18 (#12086)
2023-01-14 14:39:23 -05:00
// '-Xep:UnusedLabel:OFF', // TODO: there are problems
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:UnusedMethod:OFF', // TODO: there are problems
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:UnusedNestedClass:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:UnusedTypeParameter:OFF', // TODO: there are problems
// '-Xep:UnusedVariable:OFF', // noisy, can use ECJ
// '-Xep:UseBinds:OFF', // we don't use this annotation
// '-Xep:UseCorrectAssertInTests:OFF', // noisy
Invert error-prone configuration to be allow-list vs deny-list (#11970) This does not change the semantics or performance of our setup. Instead, it explicitly enables checks that we want vs disabling checks that we don't want. Also reordered checks to match the error-prone website list of checks for easier maintenance. It is now clear that many useless checks are enabled, we can disable some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
'-Xep:VariableNameSameAsType:WARN',
Disable useless error-prone checks (libraries/frameworks we do not use) (#11971) These are easy/obvious ones to disable since we don't use the functionality at all: the checks are literally useless. This gives some performance boost to the error-prone, although it is still pretty slow. triage most of the previously disabled checks into TODO, noisy, etc
2022-12-01 08:46:23 -05:00
// '-Xep:WaitNotInLoop:OFF', // TODO: there are problems
// '-Xep:WakelockReleasedDangerously:OFF', // we don't use android
// '-Xep:WithSignatureDiscouraged:OFF', // we aren't using this error-prone internal api
Always include errorprone dependency, even if we're not checking. This ensures consistent use patterns across JVMs.
2021-03-11 16:27:25 -05:00
]
}
LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation (#1816) LUCENE-9497: Integrate Error Prone, a static analysis tool during compilation
2020-09-07 17:42:48 -04:00
}
}
}