A new replicaType property has been added to NodeAddTrigger so that new replicas of the given type are added when the preferredOp is addreplica. The default value of replicaType is `NRT`.
This closes#821.
(cherry picked from commit ed137dbe281cfb314af340673a7b646922a2e7d1)
my previous commit added waitForState calls to doIntegrationTest that forgot to take into account initial repFactor when createShard was called
as a result, the test could only pass if wather was called after a initial leader went live, before other replicas became live
this commit fixes this mistake, and hardens the assertions about the location of those replicas given the rule in use
also adds new expecation that trying to add additional replicas that would violate rule will cause request ot fail
(cherry picked from commit 9e250f7219a358e158229551e7c2a9eac2d7aea6)
These fixes all relate to testWatcher + testMultipleWatchers:
* add additional asserts to the test methods to assert the expected property values are found
* mark Watcher.props volatile to prevent stale read by test thread
* add some randomization to Watcher.props to either come from the onStateChanged() input or
from an explicit call to ZkStateReader.getCollectionProperties
- previuosly, for reasons i don't understand, the test only consulted
ZkStateReader.getCollectionProperties inside the Watcher, and ignored the onStateChanged()
input
- now the test validates both
* move all Watcher.triggered access into the existing synchronization blocks to prevent
waitForTrigger() from returning prematurely due to gaining synch lock _after_
Watcher.triggered was incremented in onStateChanged(), but _before_ onStateChanged() updated
Watcher.props
* add detailed logging to provide additional info to help debug any additional jenkins failures
that might pop up in the future if these fixes aren't sufficient
(cherry picked from commit e8418adedbcd0e64cbe53e9b7b935107ce24237a)
* ensure all collections/replicas are active
* use waitForState or waitForActiveCollection before checking rules/snitch to prevent false failures on stale state
* ensure cluster policy is cleared after each test method
Some of these changes should also help ensure we don't get (more) spurious failures due to SOLR-13616
(cherry picked from commit 4050ddc59beeff2be5a862782579ceb8e5775c60)
