Dawid Weiss
34776ed640
LUCENE-9561: workaround for POMs that have superfluous dependencyManagement section.
2020-10-04 21:39:58 +02:00
Timothy Potter
e879a52291
SOLR-14659: Remove restlet as dependency for the ManagedResource API ( #1938 )
...
Co-authored-by: noblepaul <noble.paul@gmail.com>
2020-10-04 11:21:49 -06:00
Dawid Weiss
d9a410920a
LUCENE-9548: Apache repository publishing ( #1929 )
2020-10-04 19:18:29 +02:00
Robert Muir
7eee4fd102
LUCENE-9557: regeneration should use python3, not python2
...
python2 will change the DFA, but using python3 re-generates the sources
as they exist today. plus, we don't want to depend on EOL python2.
2020-10-03 12:30:22 -04:00
Erick Erickson
f6c4f8a755
SOLR-14910: Use in-line tags for logger declarations in Gradle ValidateLogCalls that are non-standard, change //logok to //nowarn
2020-10-03 09:47:37 -04:00
Adrien Grand
f8b7a60562
LUCENE-9550: Upgrade to Gradle 6.6.1. ( #1933 )
2020-09-30 11:17:55 +02:00
Dawid Weiss
9bfaca0606
LUCENE-9549: add command-line quotes for 'reproduce with'.
2020-09-30 09:49:52 +02:00
Dawid Weiss
2b692ccb71
LUCENE-9547: Race condition in maven artifact configuration results in wrong group/ artifact name
2020-09-29 10:24:17 +02:00
Dawid Weiss
3ae0b50646
LUCENE-9546: Configure Nori and Kuromoji generation lazily when java plugin is applied to the projects
2020-09-29 10:24:17 +02:00
Namgyu Kim
00d7f5ea68
LUCENE-9544: Port Nori dictionary compilation ( #1926 )
2020-09-28 20:28:21 +09:00
Dawid Weiss
6b0149ec1a
Revert "add regenerate gradle script for nori dictionary ( #1924 )"
...
This reverts commit e28e8c0e0c
.
2020-09-28 09:52:34 +02:00
Tomoko Uchida
5e617ccc33
LUCENE-9317: Clean up split package in analyzers-common ( #1836 )
2020-09-28 16:49:28 +09:00
Namgyu Kim
e28e8c0e0c
add regenerate gradle script for nori dictionary ( #1924 )
2020-09-28 08:54:27 +02:00
Dawid Weiss
5ec2bac91c
LUCENE-9531: Consolidate duplicated generated classes CharStream and FastCharStream ( #1886 )
2020-09-18 08:53:30 +02:00
Erik Hatcher
2364a7aded
SOLR-14792: Remove VelocityResponseWriter
2020-09-17 08:45:13 -04:00
Dawid Weiss
6c9d7adf79
LUCENE-9527: upgrade javacc to 7.0.4 ( #1884 )
2020-09-17 13:29:18 +02:00
Dawid Weiss
4f344cb0d4
LUCENE-9530: cleaned up javacc gradle generation scripts. ( #1883 )
...
* LUCENE-9530: cleaned up gradle javacc generation/ tweaks script so that it's consistent across runs. Removed ant remnants.
2020-09-17 10:53:02 +02:00
Uwe Schindler
8debc9d0c2
LUCENE-9517: Don't subclass Deflater and instead create a patch for setDictionary() using a functional interface ( #1850 )
2020-09-10 11:12:59 +02:00
Dawid Weiss
a05a055d9d
LUCENE-9518: Add sanity to gradle archiving tasks (predictable order, default permissions, fail on duplicates) ( #1851 )
2020-09-10 09:48:04 +02:00
Uwe Schindler
f0d3bab321
LUCENE-9512: Move LockFactory stress test to be a unit/integration test ( #1842 )
...
Co-authored-by: Dawid Weiss <dawid.weiss@carrotsearch.com>
2020-09-09 18:42:30 +02:00
Dawid Weiss
b988d557d7
LUCENE-9506: Gradle: split validateSourcePatterns into per-project an… ( #1830 )
...
* LUCENE-9506: Gradle: split validateSourcePatterns into per-project and root-specific tasks (allow parallelism)
Co-authored-by: Uwe Schindler <uschindler@apache.org>
2020-09-08 10:08:51 +02:00
Varun Thacker
121b262389
LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation ( #1816 )
...
LUCENE-9497: Integrate Error Prone, a static analysis tool during compilation
2020-09-07 14:42:48 -07:00
Erick Erickson
8c5ce090dd
LUCENE-9475: Enhance the Gradle build as necessary after removing Ant support, some minor text changes to solr/README.md and help.gradle
2020-09-06 17:16:08 -04:00
Dawid Weiss
e3437a467e
LUCENE-9475: remove obsolete ant-only jar sha's from Solr.
2020-09-06 22:42:28 +02:00
Dawid Weiss
d31a42763b
LUCENE-9505: add dummy outputs. ( #1829 )
2020-09-04 11:11:57 +02:00
Uwe Schindler
469d742384
Remove the explicit dependency to "check", as fobiddenapis installs it automatically (especially for all source sets; if we want this explicit dependency, it should depend on 'forbiddenApis' not each task). In addition precommit, also adds it.
2020-09-03 17:50:57 +02:00
Adrien Grand
7f68272575
LUCENE-9438: Add resources to the Eclipse classpath.
2020-09-03 09:46:54 +02:00
Robert Muir
784ede4eda
LUCENE-9215: replace checkJavaDocs.py with doclet ( #1802 )
...
This has the same logic as the previous python, but no longer relies
upon parsing HTML output, instead using java's doclet processor.
The errors are reported like "normal" javadoc errors with source file
name and line number and happen when running "gradlew javadoc"
Although the "rules" are the same as the previous python, the python had
some bugs where the checker didn't quite do exactly what we wanted, so
some fixes were applied throughout.
Co-authored-by: Dawid Weiss <dawid.weiss@carrotsearch.com>
Co-authored-by: Uwe Schindler <uschindler@apache.org>
2020-09-02 08:29:17 -04:00
Uwe Schindler
f8329378af
LUCENE-9492: Fix beasting to accept also task names in form ":project:beast"; fix bug with default value rejected by Integer.parseInt ( #1808 )
2020-08-31 18:09:21 +02:00
Dawid Weiss
9445d2c10e
Move Solr-specific config.
2020-08-31 15:43:56 +02:00
Dawid Weiss
3e47bfb7b4
Cleanup remaining scripts to use script-relative resource location.
2020-08-31 15:35:14 +02:00
Dawid Weiss
66eb9f7f3d
LUCENE-9438: moved eclipse template files under corresponding gradle's script.
2020-08-31 15:23:35 +02:00
Dawid Weiss
4a2a2da462
LUCENE-9435: revert Solr's packaging stuff for now.
2020-08-31 14:55:59 +02:00
Uwe Schindler
bbf3aec38e
LUCENE-9475: Switch validateSourcePatterns away from Ant legacy ( #1806 )
2020-08-31 12:52:04 +02:00
Dawid Weiss
5e8bb7922b
LUCENE-9491: Consolidate test options and improve support for dynamic… ( #1807 )
...
* LUCENE-9491: Consolidate test options and improve support for dynamically computed values.
2020-08-31 12:20:30 +02:00
Robert Muir
4129daa6dd
master is on java 11!
2020-08-31 04:53:44 -04:00
Uwe Schindler
14df77295d
LUCENE-9490: Disable both tasks in :lucene:core on Java 15+
2020-08-31 02:09:13 +02:00
Dawid Weiss
d847f40237
LUCENE-9474: make externalTool a function and add a build-stopping message on Windows for snowball generator.
2020-08-30 17:10:18 +02:00
Dawid Weiss
def82ab556
LUCENE-9435: Clean up ant compatability remnants in Gradle build
...
* Removing ant-only unused tasks.
* Correct message in TestVersion.java
* Remove unused file.
* Removing forbidden API rules for ant.
* Remove 'resolve' emulation.
* Move ecj-lint to task-definition-relative folder.
* Remove 'packaging' specification. It'll have to wait until proper new packaging is implemented for Solr distribution.
* Move render-javadoc tasks's files to task-relative location.
* Moved security manager policies and default JDK logging file to gradle's task relative locations.
* Removing obsolete ant tools. Moving check source patterns under gradle's folder.
* Correct paths.
* Correct property name in task selector.
2020-08-30 14:01:04 +02:00
Dawid Weiss
346dde3395
LUCENE-9490: skip checkMissingDocsDefault on runtime Java > 14.
2020-08-29 17:17:24 +02:00
Alexandre Rafalovitch
a57ba25400
SOLR-14783: Remove DIH from 9.0 ( #1794 )
...
* Remove DIH example directory
* Remove contrib code directories
* Remove contrib package related configurations for build tools
* Remove mention of DIH example
* remove dih as build dependencies and no-longer needed version pins
* Remove README references to DIH
* Remove dih mention from the script that probably does need to exist at all
* More build artifact references
* More removed dependencies leftovers (licenses/versions)
* No need to smoke exclude DIH anymore
* Remove Admin UI's DIH integration
* Remove DIH from shortname package list
* Remove unused DIH (related? not?) dataset
Unclear what is happening here, but there is no reference to that directory anywhere else
The other parallel directories ARE referenced in a TestConfigSetsAPI.java
* Hidden Idea files references
* No DIH to ignore anymore
* Remove last Derby DB references
* Remove DIH from documentation
Add the information in Major Changes document with the link to the external repo
* Added/updated a mention to CHANGES
* Fix leftover library mentions
* Fix Spellings
2020-08-29 10:52:04 -04:00
Tomoko Uchida
c11d32faed
LUCENE-9441: Fix ant-specific Javadoc links in accordance with Gradle build
2020-08-29 22:28:03 +09:00
Uwe Schindler
6abce32a3e
LUCENE-9479: Forbiddenapis & Gradle: Add commons-io bundled signatures ( #1780 )
2020-08-25 09:05:06 +02:00
Uwe Schindler
42d07d878e
LUCENE-9474: Add back tests.haltonfailure for jenkins compatibility (use boolean as default) - type fix
2020-08-24 01:01:38 +02:00
Uwe Schindler
863d544378
LUCENE-9474: Add back tests.haltonfailure for jenkins compatibility
2020-08-24 00:52:51 +02:00
Uwe Schindler
5c2e96b585
LUCENE-9474: Property "tests.badapples" is missing in Gradle, which is needed for Hoss's statistics. Also Jenkins does not run BadApple tests by default
2020-08-23 23:37:54 +02:00
Uwe Schindler
79f3a1783f
LUCENE-9474: Easier Jenkins automation, by allowing to pass test JVM args as environment variable (this goes inline with RUNTIME_JAVA_HOME)
2020-08-23 22:10:32 +02:00
Uwe Schindler
59736814b6
LUCENE-9474: Remove bad warning (we sometimes have non-existing directories in classpaths during compile). This warnings is not source-code related so shouldn't be enforced (Java 14)
2020-08-23 21:31:44 +02:00
Uwe Schindler
494a8a8e04
LUCENE-9474: Make external tools configurable like in ant through those sysprops: perl.exe, python3.exe, python2.exe
2020-08-23 20:16:22 +02:00
Dawid Weiss
b1e2d0c890
LUCENE-9438: Eclipse IDE support with gradle build system ( #1761 )
2020-08-21 21:47:11 +02:00
Dawid Weiss
581e836569
LUCENE-9471: clean up task and global temporary junk files (workaround). ( #1767 )
2020-08-20 13:49:24 +02:00
Dawid Weiss
83ed210fd0
LUCENE-9465: 'beast' task from within gradle ( #1757 )
2020-08-18 09:28:50 +02:00
Tomoko Uchida
5d46361024
LUCENE-9321: Fix offline link base url for snapshot build ( #1695 )
2020-07-28 08:04:21 +09:00
Dawid Weiss
8ebf2d0b21
LUCENE-9312: Allow builds against arbitrary JVMs (squashed
...
jira/LUCENE-9312)
2020-07-21 09:19:38 +02:00
Dawid Weiss
1d143744bd
SOLR-14523: moved logger message to info so that it doesn't pollute console on regular runs.
2020-07-20 12:47:14 +02:00
Dawid Weiss
f9fff6e1ed
LUCENE-9436: use release flag for javac rather than source and target.
2020-07-20 12:35:29 +02:00
Erick Erickson
294caa8154
LUCENE-9411: Fail complation on warnings, 9x gradle-only. Explicitly list warnings to check for
2020-07-08 15:51:59 -04:00
Erick Erickson
743234ed83
SOLR-14523: Enhance gradle logging calls validation: eliminate getMessage(). Added Gradle validation check.
2020-07-04 09:38:41 -04:00
Erick Erickson
76e1d901cb
SOLR-14592: Upgrade Zookeeper to 3.6.1
2020-07-01 19:47:16 -04:00
Erick Erickson
9c1772f094
LUCENE-9411: Fail complation on warnings, 9x gradle-only
2020-06-23 16:21:10 -04:00
Erick Erickson
c8f48d4701
SOLR-14547: Fix or suppress warnings in solr/client/solrj/io/stream
2020-06-09 19:21:36 -04:00
Dawid Weiss
3e8e5d8cf6
LUCENE-9382: update gradle to 6.4.1. ( #1549 )
...
* LUCENE-9382: update gradle to 6.4.1. Requires minor changes around log call validation by restructuring the code around switches to a series of ifs. Piggybacking: apply log validation to :solr modules. Add inputs declaration so that task is not re-run on unmodified files.
2020-06-02 13:49:57 +02:00
Dawid Weiss
da3dbb1921
LUCENE-9301: include build time and user name only in non-snapshot builds so that jars are not recompiled on each build in development.
2020-06-01 10:09:44 +02:00
Tomoko Uchida
84ea0cb87d
LUCENE-9374: Add checkBrokenLinks gradle task ( #1522 )
2020-05-20 23:23:24 +09:00
Tomoko Uchida
51c15b8660
LUCENE-9333: Use DirectoryProperty instead of directly having Provider; move script file to input field.
2020-05-19 21:26:38 +09:00
Tomoko Uchida
10d1ecb431
LUCENE-9333: lazily evaluate for 'docroot' property
2020-05-18 23:36:15 +09:00
Uwe Schindler
b7c60e53eb
LUCENE-9321: Lazy evaluate project properties in the render-javadocs / changes2html task, also make URL (as its passed on command line) an input of task
2020-05-18 09:03:25 +02:00
Uwe Schindler
06df50e759
LUCENE-9321: Port markdown task to Gradle ( #1477 )
2020-05-17 14:46:26 +02:00
Uwe Schindler
c2b59f16bf
LUCENE-9321: Use @CompileClasspath annotation instead of @ClassPath, as only signatures are relevant for Javadocs
2020-05-16 00:14:05 +02:00
Uwe Schindler
010168c57b
LUCENE-9321, LUCENE-9278: Refactor renderJavadoc to allow relative links with multiple Gradle tasks ( #1488 )
...
This also automatically collects linked projects by its dependencies, so we don't need to maintain all inter-project javadocs links.
Co-authored-by: Dawid Weiss <dweiss@apache.org>
2020-05-14 13:16:16 +02:00
Erick Erickson
08841b634f
Mistakenly checked in gradle/defaults-java.gradle with warning limit of 10000
2020-05-13 19:39:05 -04:00
Erick Erickson
687dd42f57
SOLR-14475: Fix deprecation warnings resulting from upgrading commons cli to 1.4
2020-05-13 19:30:57 -04:00
Uwe Schindler
9ee8aa61de
LUCENE-9278: Fix passing of Java properties for locale: The arguments must be separated.
2020-05-05 12:10:38 +02:00
Uwe Schindler
951efc95be
LUCENE-9278: Improved options file creation: All parameters are escaped automatically, arguments don't need to be strings (they are converted during building options file) ( #1479 )
2020-05-02 09:53:51 +02:00
Philippe Ouellet
7a849f6943
LUCENE-9354: Sync French stop words with latest version from Snowball. ( #1474 )
...
* Sync French stop words with latest version from Snowball.
This new version removed some French homonyms from the list
* Use latest master commit from snowball-website
* LUCENE-9354: regenerate with 'gradle snowball
* LUCENE-9354: add CHANGES.txt entry
2020-05-01 21:11:35 -04:00
Erick Erickson
217c2faa2c
LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects
2020-05-01 13:06:57 -04:00
Uwe Schindler
26b0b54bd3
LUCENE-9278: Fix javadocs task to work on windows and with whitespace in project folder ( #1476 )
2020-05-01 17:49:47 +02:00
Erick Erickson
9ae05e9b4f
LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects
2020-04-30 19:50:31 -04:00
Dawid Weiss
26c9fce5db
LUCENE-9278: concatenate paths for sourcepath using path separator rather than whitespace (which causes invalid option to be passed to javadoc).
2020-04-30 10:24:23 +02:00
Tomoko Uchida
5354f7e88e
LUCENE-9333: Add gradle task to compile changes.txt to a html ( #1468 )
2020-04-30 17:21:53 +09:00
Erick Erickson
6e96d01efc
LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects
2020-04-29 10:56:54 -04:00
Erick Erickson
960610a615
LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects
2020-04-27 20:45:57 -04:00
Erick Erickson
ff4363675e
LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects
2020-04-27 08:34:10 -04:00
Tomoko Uchida
f03e6aac59
SOLR-14429: Convert .txt files to properly formatted .md files ( #1450 )
2020-04-27 08:43:04 +09:00
Erick Erickson
8867f465dc
LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects
2020-04-26 09:15:21 -04:00
Erick Erickson
ecc98e8698
LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects
2020-04-24 13:34:03 -04:00
Erick Erickson
e43b17962a
LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects
2020-04-22 22:32:49 -04:00
Erick Erickson
c94770c2b9
LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects
2020-04-20 21:08:15 -04:00
Erick Erickson
f01c040ab3
LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects
2020-04-19 15:58:50 -04:00
Erick Erickson
1f1cdbffdf
LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects
2020-04-18 19:08:15 -04:00
Erick Erickson
3af165b32a
LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects
2020-04-17 20:40:32 -04:00
Shalin Shekhar Mangar
13f19f6555
SOLR-9906: SolrjNamedThreadFactory is deprecated in favor of SolrNamedThreadFactory. DefaultSolrThreadFactory is removed from solr-core in favor of SolrNamedThreadFactory in solrj package and all solr-core classes now use SolrNamedThreadFactory
2020-04-13 08:16:35 +05:30
Dawid Weiss
7279190c89
LUCENE-9316: Incorporate all :precommit tasks into :check
2020-04-12 13:32:54 +02:00
Dawid Weiss
9244558752
LUCENE-9201: remove javadoc task remnants. Make javadoc depend on renderJavadoc and skip the default gradle's implementation.
2020-04-12 12:55:56 +02:00
Dawid Weiss
fea1ce0062
LUCENE-9278: move declaration calling getTemporaryDir inside the execution block closure so that gradlew clean renderJavadoc doesn't wipe out the temporary directory before the task has a chance to run.
2020-04-12 12:27:14 +02:00
Dawid Weiss
2437f3f56c
LUCENE-9311: detect intellij reimport and modify sourceset to exclude solr-ref-guide/tools ( #1422 )
2020-04-09 13:55:42 +02:00
Tomoko Uchida
4f92cd414c
LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects ( #1388 )
2020-04-09 08:44:07 +09:00
Dawid Weiss
dbb4be1ca9
LUCENE-9310: workaround for IntelliJ gradle import
2020-04-08 19:46:35 +02:00
Erick Erickson
e1e2085e94
SOLR-14386: Update Jetty to 9.4.27 and dropwizard-metrics version to 4.1.5
2020-04-04 16:14:57 -04:00
Dawid Weiss
d32858b127
LUCENE-9301: add manifest entries to JARs (gradle build).
2020-04-04 20:56:35 +02:00
Mike Drob
e25ab4204f
LUCENE-9266 remove gradle wrapper jar from source
...
ASF Release Policy states that we cannot have binary JAR files checked
in to our source releases, a few other projects have solved this by
modifying their generated gradlew scripts to download a copy of the
wrapper jar.
We now have a version and checksum file in ./gradle/wrapper directory
used for verifying the wrapper jar, and will take advantage of single
source java execution to verify and download.
The gradle wrapper jar will continue to be available in the git
repository, but will be excluded from src tarball generation. This
should not change workflows for any users, since we expect the gradlew
script to get the jar when it is missing.
Co-authored-by: Dawid Weiss <dweiss@apache.org>
2020-04-02 11:30:01 -05:00
Tomoko Uchida
d4a137d2b6
LUCENE-9242: generate javadocs by calling Ant javadoc task ( #1304 )
2020-03-12 00:09:26 +09:00
Tomoko Uchida
312d6b2a0d
LUCENE-9201: Add an equivalent to "check missing javadocs" task to gradle build
...
Co-Authored-By: Dawid Weiss <dawid.weiss@carrotsearch.com>
2020-02-24 11:05:35 +09:00
Dawid Weiss
cb68d7d2c5
LUCENE-9232: add a script-hack check so that in case somebody upgrades the scripts automatically they'll know they need to add the hack.
2020-02-21 10:40:27 +01:00
Dawid Weiss
f8a2c39906
LUCENE-9155: add missing naist dictionary generation, clean up the code a bit.
2020-02-21 10:24:05 +01:00
Robert Muir
9302eee1e0
LUCENE-9235: upgrade all python to python3
...
Die, python2, die.
Some generated .java files change (parameterized automata for
spell-correction).
This is because the order of python dictionaries was not well-defined
previously. A sort() was added so that the python code now generates
reproducible output (Thanks @mikemccand).
So we'll suffer a change once, but the automata are equivalent. If you
run the script again you should not see source code changes.
The relevant unit tests are exhaustive (if you trust the paper!), so we can
be confident it does not break things, even though it looks very scary.
2020-02-20 21:27:38 -05:00
Anshum Gupta
cb18586ea0
LUCENE-9155: Add Apache License header to the Kuromoji dictionary compilation ( #1271 )
2020-02-20 14:59:06 -08:00
Dawid Weiss
62662e477a
LUCENE-9155: Port Kuromoji dictionary compilation (regenerate).
2020-02-20 19:00:56 +01:00
Dawid Weiss
7604639b59
Move jgit version declaration to scriptDepVersions.
2020-02-20 13:54:07 +01:00
Robert Muir
b9a569e7be
LUCENE-9230: explicitly call python version we want from builds
...
On newer linux distros, at least, 'python' now means python3. So
we can't rely on what version of python it will invoke (at least for a
few years).
For example in Fedora Linux:
https://fedoraproject.org/wiki/Changes/Python_means_Python3
For python2.x code, explicitly call 'python2.7' and for python3.x code,
explicitly call 'python3'.
Ant variable names are cleaned up, e.g. 'python.exe' is renamed to
'python2.exe' and 'python32.exe' is renamed to 'python3.exe'. This also
makes it easy to identify remaining python 2.x code that should be
migrated to python 3.x
2020-02-18 18:58:17 -05:00
Dawid Weiss
491c99a3de
LUCENE-9232: tone down daemon defaults in generated local settings.
2020-02-18 19:43:39 +01:00
Dawid Weiss
2a88aa9d0f
LUCENE-9219: Port ECJ-based linter to gradle
...
Co-authored-by: Tomoko Uchida <tomoko@apache.org>
2020-02-19 02:43:47 +09:00
Robert Muir
ccb390d4a6
LUCENE-9220: prevent zip file reproducibility issues based on users umask
2020-02-17 13:34:00 -05:00
Robert Muir
0203815ab2
LUCENE-9220: regenerate all stemmers/stopwords/test data from snowball 2.0 ( #1262 )
...
Previous situation:
* The snowball base classes (Among, SnowballProgram, etc) had accumulated local performance-related changes. There was a task that would also "patch" generated classes (e.g. GermanStemmer) after-the-fact.
* Snowball classes had many "non-changes" from the original such as removal of tabs addition of javadocs, license headers, etc.
* Snowball test data (inputs and expected stems) was incorporated into lucene testing, but this was maintained manually. Also files had become large, making the test too slow (Nightly).
* Snowball stopwords lists from their website were manually maintained. In some cases encoding fixes were manually applied.
* Some generated stemmers (such as Estonian and Armenian) exist in lucene, but have no corresponding `.sbl` file in snowball sources at all.
Besides this mess, snowball project is "moving along" and acquiring new languages, adding non-BSD-licensed test data, huge test data, and other complexity. So it is time to automate the integration better.
New situation:
* Lucene has a `gradle snowball` regeneration task. It works on Linux or Mac only. It checks out their repos, applies the `snowball.patch` in our repository, compiles snowball stemmers, regenerates all java code, applies any adjustments so that our build is happy.
* Tests data is automatically regenerated from the commit hash of the snowball test data repository. Not all languages are tested from their data: only where the license is simple BSD. Test data is also (deterministically) sampled, so that we don't have huge files. We just want to make sure our integration works.
* Randomized tests are still set to test every language with generated fake words. The regeneration task ensures all languages get tested (it writes a simple text file list of them).
* Stopword files are automatically regenerated from the commit hash of the snowball website repository.
* The regeneration procedure is idempotent. This way when stuff does change, you know exactly what happened. For example if test data changes to a different license, you may see a git deletion. Or if a new language/stopwords/test data gets added, you will see git additions.
2020-02-17 12:38:01 -05:00
Dawid Weiss
dcf448efeb
LUCENE-9134: Minor cleanups.
2020-02-13 11:18:01 +01:00
Erick Erickson
f9357ab0d2
LUCENE-9134: Port ant-regenerate tasks to Gradle build (util and packed) ( #1251 )
...
* LUCENE-9134: Port ant-regenerate tasks to Gradle build
2020-02-11 18:56:11 -05:00
Robert Muir
f41eabdc5f
LUCENE-8279: fix javadocs wrong header levels and accessibility issues
...
Java 13 adds a new doclint check under "accessibility" that the html
header nesting level isn't crazy.
Many are incorrect because the html4-style javadocs had horrible
font-sizes, so developers used the wrong header level to work around it.
This is no issue in trunk (always html5).
Java recommends against using such structured tags at all in javadocs,
but that is a more involved change: this just "shifts" header levels
in documents to be correct.
2020-02-08 10:00:00 -05:00
Robert Muir
a77bb1e6f5
LUCENE-9201: add overview.html from correct location to the javadocs in gradle build
2020-02-07 00:18:20 -05:00
Robert Muir
0d339043e3
LUCENE-9209: fix javadocs to be html5, enable doclint html checks, remove jtidy
...
Current javadocs declare an HTML5 doctype: !DOCTYPE HTML. Some HTML5
features are used, but unfortunately also some constructs that do not
exist in HTML5 are used as well.
Because of this, we have no checking of any html syntax. jtidy is
disabled because it works with html4. doclint is disabled because it
works with html5. our docs are neither.
javadoc "doclint" feature can efficiently check that the html isn't
crazy. we just have to fix really ancient removed/deprecated stuff
(such as use of tt tag).
This enables the html checking in both ant and gradle. The docs are
fixed via straightforward transformations.
One exception is table cellpadding, for this some helper CSS classes
were added to make the transition easier (since it must apply padding
to inner th/td, not possible inline). I added TODOs, we should clean
this up. Most problems look like they may have been generated from a
GUI or similar and not a human.
2020-02-06 22:30:52 -05:00
Tomoko Uchida
f3cd1dbde3
LUCENE-9077: Force locale en_US on Javadoc task (workaroud for JDK-8222793)
2020-02-07 01:36:45 +09:00
Erick Erickson
b0bb299dc4
LUCENE-9134: Port ant-regenerate tasks to Gradle build ( #1230 )
...
LUCENE-9134: Port ant-regenerate tasks to Gradle build (Solr javacc)
2020-02-04 09:16:38 -05:00
Erick Erickson
5253c0cb74
LUCENE-9134 Port ant-regenerate tasks to Gradle build ( #1226 )
...
LUCENE-9134: Port ant-regenerate tasks to Gradle build Javacc sub-task. Closes #1226
2020-01-31 17:04:10 -05:00
Robert Muir
4b5105e167
LUCENE-9193: heap allocations for tests.profile
...
Can be a bit noisier than cpu sampling, due to how threads are allocated
in tests... maybe we can improve that in the future.
2020-01-30 08:29:10 -05:00
Dawid Weiss
3a8ed5e8ed
LUCENE-9134: add python-based regeneration of HTMLCharacterEntities.jflex inside jflexHTMLStripCharFilter.
2020-01-30 13:48:16 +01:00
Dawid Weiss
e25dac085f
LUCENE-9134: this adds initial javacc support (without follow-up tweaks required to make the sources identical as those generated by ant).
2020-01-29 17:02:59 +01:00
Robert Muir
e504798a44
LUCENE-9185: add "tests.profile" to gradle build to aid fixing slow tests
...
Run test(s) with -Ptests.profile=true to print a histogram at the end of
the build.
2020-01-28 11:27:18 -05:00
Jan Høydahl
53f7b394e4
SOLR-11207: Mute warnings for owasp false positives
2020-01-27 21:03:20 +01:00
Dawid Weiss
ff635cf701
LUCENE-9184, LUCENE-9183: allow skipping git status check in precommit with -Pvalidation.git.failOnModified=false (or place this in gradle.properties to make it permanent).
2020-01-27 20:47:02 +01:00
Uwe Schindler
7dc35e3a62
Let precommit depend on generic forbiddenApis task
2020-01-27 19:47:54 +01:00
Robert Muir
fd5a0ce7c2
LUCENE-9182: the rat-sources.gradle was the one .gradle file already with a license header, we don't need it twice
2020-01-27 12:11:44 -05:00
Robert Muir
975df9ddd3
LUCENE-9182: add apache license headers to all .gradle files and enforce in rat task
2020-01-27 12:05:34 -05:00
Dawid Weiss
b420ef8f77
LUCENE-9179: don't invoke the same build recursively upon first run, just continue. Seems like gradle bug but let's not cry about it - it just happens once and CI defaults can be passed independently on command-line.
2020-01-27 17:34:13 +01:00
Robert Muir
8e357b167b
LUCENE-9180: dos2unix files that don't need dos line endings
2020-01-27 11:29:59 -05:00
Dawid Weiss
6bde0f3ec8
LUCENE-9134: UAX29URLEmailTokenizerImpl regeneration. This requires TONS
...
of memory and time... insane compared to the size of the input. None of my
machines pass it without at least 12 gigs of heap (!).
2020-01-27 12:36:13 +01:00
Jan Høydahl
39df74de37
SOLR-11207: Exclude configuration 'unifiedClasspath'
...
It is generated by consistent-versions plugin and triggers owasp warnings for deps even for excluded projects
2020-01-27 12:17:31 +01:00
Robert Muir
2bb63afdaf
LUCENE-9166: gradle build: test failures need stacktraces
2020-01-27 06:09:04 -05:00
Jan Høydahl
9ddd05cd14
SOLR-11207: Exclude solr-ref-guide from owasp check
...
It picked up log4j1 dependency only used during build
2020-01-27 09:55:12 +01:00
Dawid Weiss
ae95f0ab68
LUCENE-9134: lucene:core:jflexStandardTokenizerImpl
2020-01-27 09:03:19 +01:00
Dawid Weiss
6f85ec0460
LUCENE-9174: Bump default gradle memory to 2g
2020-01-26 18:27:41 +01:00
Dawid Weiss
5ab59f59ac
SOLR-11207: minor changes:
...
- added 'owasp' task to the root project. This depends on
dependencyCheckAggregate which seems to be a better fit for multi-module
projects than dependencyCheckAnalyze (the difference is vague to me
from plugin's documentation).
- you can run the "gradlew owasp" task explicitly and it'll run the
validation without any flags.
- the owasp task is only added to check if validation.owasp property
is true. I think this should stay as the default on non-CI systems
(developer defaults) because it's a significant chunk of time it takes
to download and validate dependencies.
- I'm not sure *all* configurations should be included in the check...
perhaps we should only limit ourselves to actual runtime dependencies
not build dependencies, solr-ref-guide, etc.
2020-01-26 10:45:05 +01:00
Jan Høydahl
74a8d6d5ac
SOLR-11207: Add OWASP dependency checker to gradle build ( #1121 )
...
* SOLR-11207: Add OWASP dependency checker to gradle build
2020-01-26 10:01:51 +01:00
Robert Muir
f5e9bb9493
LUCENE-9165: explicitly cast with the horrible groovy language so that numbers above 9 don't fail
2020-01-24 09:53:47 -05:00
Robert Muir
4d61e4aaab
change generate-defaults.gradle not to cap testsJvms at 4
2020-01-24 08:49:17 -05:00
Robert Muir
9dae566ee7
LUCENE-9160: add params/docs to override jvm params in gradle build, default C2 off in tests.
...
Adds some build parameters to tune how tests run. There is an example
shown by "gradle helpLocalSettings"
Default C2 off in tests as it is wasteful locally and causes slowdown of
tests runs. You can override this by setting tests.jvmargs for gradle,
or args for ant.
Some crazy lucene stress tests may need to be toned down after the
change, as they may have been doing too many iterations by default...
but this is not a new problem.
2020-01-22 09:58:30 -05:00
Robert Muir
3ecd7a03aa
LUCENE-9159: merge gradle/ant test security policies (main file)
2020-01-21 23:43:31 -05:00
Robert Muir
7e0534d87c
LUCENE-9159: merge gradle/ant test security policies
2020-01-21 21:26:37 -05:00
Dawid Weiss
351b30489c
LUCENE-9077: Enable javac linting as in ant. TONS of warnings are currently printed.
2020-01-20 10:10:48 +01:00
Dawid Weiss
1ad6bc9361
LUCENE-9077: Allow locally staged files in git status precommit check.
2020-01-20 09:36:14 +01:00
Nicholas Knize
78655239c5
LUCENE-8369: Remove obsolete spatial module
2020-01-16 11:22:05 -06:00
Dawid Weiss
087b2e1c0d
LUCENE-9077: Emit the location of test output on failure.
2020-01-15 14:01:20 +01:00
Dawid Weiss
44c203d72f
Add workaround for https://github.com/palantir/gradle-consistent-versions/issues/383
2020-01-15 11:44:21 +01:00
Dawid Weiss
ae2e4f3ae9
Add git help to help/
2020-01-15 10:40:41 +01:00
Dawid Weiss
e6d85cd4bc
Cleaning up minor things in rat task.
2020-01-15 10:07:24 +01:00
Mike
c9e7eebe28
Add RAT check using Gradle ( #1157 )
...
Merging Apache rat checks.
2020-01-15 09:55:41 +01:00
Dawid Weiss
4a8762cc2c
Add javadoc generation/linter to precommit.
2020-01-13 19:11:43 +01:00
Dawid Weiss
d800b8060b
Javadoc workarounds for LUCENE-9132
2020-01-13 19:11:01 +01:00
Dawid Weiss
3beb1cfd1e
Add initial support for rendering javadocs.
2020-01-10 16:43:52 +01:00
Dawid Weiss
34aa8714d8
Correct class->classname.
2020-01-10 12:53:30 +01:00
Dawid Weiss
b4d26f94d3
Don't load all of groovy's tasks, just groovy.
2020-01-10 12:51:46 +01:00
Dawid Weiss
39a5323999
Add config file sanity check for precommit.
2020-01-10 12:49:04 +01:00
Dawid Weiss
109444fc5b
Add an equivalent of validate-source-patterns task, delegating to the same groovy script.
2020-01-10 12:02:30 +01:00
Dawid Weiss
4599c51f0d
LUCENE-9122: add support for running tests against alternate jvms.
2020-01-09 19:00:32 +01:00
Dawid Weiss
cf51dfdb37
Silence gradle warnings. We'll deal with them when we upgrade the wrapper.
2020-01-09 17:41:53 +01:00
Dawid Weiss
10baa68b60
Revert "Disable checkUnusedConstraints in palantir's plugin (bug)."
...
This reverts commit b32db8ee6a
.
2020-01-09 17:40:51 +01:00
Dawid Weiss
b32db8ee6a
Disable checkUnusedConstraints in palantir's plugin (bug).
2020-01-09 17:05:02 +01:00
Dawid Weiss
c7ed133910
LUCENE-9122: upgrade gradle wrapper to 6.0.1. Relax JVM requirement to require at least Java 11. We can't even check for higher bound because gradle itself breaks before it can execute the check script. I verified locally and it works with 11-13.
2020-01-09 14:13:32 +01:00
Dawid Weiss
e713ca62b9
Remove buildscan configuration.
2020-01-08 20:17:20 +01:00
Dawid Weiss
e87228982c
Remove travis support for now.
2020-01-08 15:14:11 +01:00
Dawid Weiss
7a12c89ce6
Move precommit dependencies to precommit for clarity.
2020-01-08 14:20:16 +01:00
Dawid Weiss
7808dd5c3a
Add minimum repro line at the end of the build.
2020-01-08 12:20:09 +01:00
Dawid Weiss
d9e5daf01b
Move printing tests.verbose to error reporting test listener since we're already catching the output and handle it there anyway.
2020-01-08 11:38:34 +01:00
Dawid Weiss
85d261339b
Speed up spill writer. Echo failed test output to disk.
2020-01-08 10:55:07 +01:00
Dawid Weiss
14dd5a5e4d
Initial error reporting test listener that mirrors failed suite's output.
2020-01-07 22:23:18 +01:00
Dawid Weiss
c9c0bab2eb
Ensure versions.props contains sorted entries (like check-lib-versions did for ant).
2020-01-03 16:04:12 +01:00
Dawid Weiss
37fb4a5f49
Verify lock state on precommit.
2020-01-03 15:53:29 +01:00
Dawid Weiss
ae4a2e381d
Hook up license checks to precommit.
2020-01-03 15:50:04 +01:00
Dawid Weiss
797f571fc3
Hook up forbidden apis to precommit.
2020-01-03 15:35:15 +01:00
Dawid Weiss
8b03a7104e
Add a precommit placeholder task and working copy's git status check.
2020-01-03 15:22:36 +01:00
Dawid Weiss
ca8661bc3a
Reworked dependency resolution for license checks to work around a problem with gradle. Consolidated licenses with the ant build (excluding some jars from the ref-guide).
2019-12-30 14:05:08 +01:00
Dawid Weiss
a96bf612d7
Merge with master.
2019-12-25 13:26:56 +01:00
Dawid Weiss
496b6b1d51
Follow-up to merge with master.
2019-12-20 17:38:04 +01:00
Dawid Weiss
7c762c969a
Allow simultaneous call to sha regeneration and validation by introducing soft ordering constraint.
2019-12-18 14:54:13 +01:00
Dawid Weiss
d2d28329ef
Changed license checksum regeneration task name to updateLicenses.
2019-12-18 14:14:39 +01:00
Dawid Weiss
0e2a493446
Add transitive Lucene dependencies so that Solr licenses/ folder is (more) consistent with ant. This is an insane hack at the build-level. Mark it for removal once we get rid of ant.
2019-12-17 15:02:08 +01:00
Dawid Weiss
faadb65202
Regenerate checksum for a single dependency once. Add trailing newline for consistency with ant code.
2019-12-17 14:27:25 +01:00
Dawid Weiss
8906c2ddbe
Merge forbidden APIs rules.
2019-12-17 13:39:10 +01:00
Dawid Weiss
8ca1d4d144
Enable security manager by default.
2019-12-16 15:56:29 +01:00
Dawid Weiss
401ddc6dd1
Upgrade gradlew. Add environment sanity check.
2019-12-16 15:23:06 +01:00
Dawid Weiss
b4a6a63949
Solr test policy changes.
2019-12-16 11:28:21 +01:00
Dawid Weiss
208d094262
Remove checksum files from ref guide.
2019-12-13 17:09:25 +01:00
Dawid Weiss
981ddb825b
Remove leftover junk.
2019-12-13 15:24:59 +01:00
Dawid Weiss
3aff1664e5
updateChecksums, validation of dangling unreferenced files under licenses/. Separated licenses-gradle for Solr for now (doesn't include transitive Lucene dependencies).
2019-12-13 15:07:59 +01:00
Dawid Weiss
d8cac07d2a
Sort output of dangling license files.
2019-12-13 14:03:06 +01:00
Dawid Weiss
4500f0e327
Consolidating versions between gradle and ant.
2019-12-13 13:31:23 +01:00
Dawid Weiss
25fc0487a1
Working jar checksums and aligned with ant build.
2019-12-13 12:12:29 +01:00
Dawid Weiss
73e8b49f0d
Align versions with ant build.
2019-12-13 12:01:26 +01:00
Dawid Weiss
f97c276a81
Merge master changes to solr tests policy.
2019-12-13 10:53:59 +01:00
Dawid Weiss
a392a83558
Add support for validating the presence of licenses and notices.
2019-12-12 19:25:46 +01:00
Dawid Weiss
6c7eb3ffe6
Merging changes to solr policy done on master.
2019-12-12 14:22:02 +01:00
Dawid Weiss
453eee3987
Initial work on jar checksums/ license file validation.
2019-12-11 18:41:27 +01:00