Prior to this change, it was not feasible to write a custom aggregate function in plugin code
because the FacetContext class did not expose its fields for access outside its package. Also
some of the useful abstract classes for SlotAcc were package-private too
Adds two metrics to the SolrCloud Overseer: solr_metrics_overseer_stateUpdateQueueSize and solr_metrics_overseer_collectionWorkQueueSize with corresponding entries in the the Prometheus exporter's default/stock configuration.
Co-authored-by: Saatchi Bhalla <s.bhalla@salesforce.com>
Disable sort optimization in comparators on index sort.
Currently, if search sort is equal or a part of the index sort, we have
an early termination in TopFieldCollector.
But comparators are not aware of the index sort, and may run
sort optimization even if the search sort is congruent with
the index sort.
This patch:
- adds `disableSkipping` method to `FieldComparator`,
This method is called by `TopFieldCollector`, and currently called
when the search sort is congruent with the index sort,
but more conditions can be added.
- disables sort optimization in comparators in this case.
- removes a private `MultiComparatorLeafCollector` class, because the only
class that extends `MultiComparatorLeafCollector` was `TopFieldLeafCollector`.
The logic of the deleted `TopFieldLeafCollector` is added to `TopFieldLeafCollector`.
Relates to #1351
This addresses review feedback from David Smiley on Jira. It moves the request registration to the ContentStreamHandlerBase class instead of doing a hack-ish instanceof check inside HttpSolrCall.
* Reduced dependencies from Solr server down to just SolrJ. Don't add WEB-INF/lib.
* Was missing some dependencies in lib/; now has all except SolrJ & logging.
* Can run via gradle, "gradlew run"
* Has own log4j2.xml now
Has own CHANGES.md now.
The Dockerfile should not initialize /var/solr's contents because this is confusing and redundant with init_var_solr.sh.
No need for init_var_solr.sh to echo what it does; VERBOSE can be used to accomplish that.
Separate CHANGES.md for Docker and contrib modules.
DWStallControl expects the caller to loop on top of the wait call to make
progress with flushing if the DW is stalled. This logic wasn't applied such that
DW only stalled for one second and then released the indexing thread. This can cause
OOM if for instance during a full flush one DWPT gets stuck and onther threads keep on
indexing.
TestVectorUtil occasionally fails because of floating point errors. This
change slightly increases the epsilon in equality checks -- testing shows that
this will greatly decrease the chance of failure.
Andrzej Bialecki
Tim Owen
David Smiley
saatchibhalla
Mike Drob
Mayya Sharipova
Patrick Zhai
Dawid Weiss
Timothy Potter
Chris Hostetter
Jan Høydahl
David Smiley
Shalin Shekhar Mangar
Thomas Mortagne
Ilan Ginzburg
Simon Willnauer
Cassandra Targett
Mike Drob
gf2121
Ignacio Vera
Alessandro Benedetti
jimczi
Erick Erickson
Julie Tibshirani
Christine Poerschke
Michael Sokolov
Marcus
Adrien Grand
Tomoko Uchida
Nazerke Seidan
Noble Paul