Commit Graph

34234 Commits

Author SHA1 Message Date
Simon Willnauer c258905bd0
LUCENE-9535: Commit DWPT bytes used before locking indexing (#1918)
Currently we calculate the ramBytesUsed by the DWPT under the flushControl
lock. We can do this calculation safely outside of the lock without any downside.
The FlushControl lock should be used with care since it's a central part of indexing
and might block all indexing.
2020-09-24 09:39:33 +02:00
noblepaul cafa449769 SOLR-14613: Avoid multiple ZK write 2020-09-24 17:26:41 +10:00
noblepaul 26bb6415d1 SOLR-14894: ASL header 2020-09-24 12:40:05 +10:00
noblepaul 565c5b1ac4 SOLR-14894: Use annotations to implement V2 collection APIs 2020-09-24 12:37:12 +10:00
noblepaul 1c9c1509fa SOLR-14890: syncing with 8x 2020-09-24 10:58:40 +10:00
Thomas M. DuBuisson 6599cc835a
SOLR-14883 Add a Muse (Continuous assurance platform) configuration (#1901)
* Add a Muse (Continuous assurance platform) configuration

The full documentation is docs.muse.dev.  Most interesting is the
repository configuration reference
https://docs.muse.dev/docs/repository-configuration/ which details how
to change which tools runs, add custom tools (other than those built
into the platform by default), filter for or against certain bug types,
etc.

For example, an explicit `.muse/config.toml` file might be:

```
jdk11 = true
build = "./gradlew assemble"
tools = [ "infer", "errorprone", "findsecbugs" ]
customTools = [ ]
```

* Add a comment to the toml file
2020-09-23 17:42:19 -07:00
Adrien Grand d226abd448
LUCENE-9535: Make ByteBuffersDataOutput#ramBytesUsed run in constant-time. (#1917) 2020-09-23 19:49:15 +02:00
Damiano Albani ef54042315
Fix minor typo (#1916) 2020-09-23 10:08:23 -05:00
Mayya Sharipova 7d90b858c2
Fix bug in sort optimization (#1903)
Fix bug how iterator with skipping functionality
advances and produces docs

Relates to #1725
2020-09-23 09:09:43 -04:00
Uwe Schindler e19239d96b Upgrade forbiddenapis to version 3.1 2020-09-23 14:56:46 +02:00
Simon Willnauer 17c285d617
LUCENE-9539: Remove caches from SortingCodecReader (#1909)
SortingCodecReader keeps all docvalues in memory that are loaded from this reader.
Yet, this reader should only be used for merging which happens sequentially. This makes
caching docvalues unnecessary.

Co-authored-by: Jim Ferenczi <jim.ferenczi@elastic.co>
2020-09-23 14:21:28 +02:00
Noble Paul fd0c08615d
SOLR-14890: Refactor code to use annotations for configset API (#1911) 2020-09-23 21:55:51 +10:00
Adrien Grand 12dd19427e LUCENE-9535: Reduce the size of compressed blocks of stored fields by 2x.
In order to see whether this has any effect on nigthly benchmarks.
2020-09-23 12:22:22 +02:00
David Smiley 7b53671920
SOLR-14768: Fix multipart POST to Solr. (#1838)
Regression from 8.6
Multipart POST would fail due to a NoClassDefFoundError of Jetty MultiPart.  Solr cannot access many Jetty classes, which is not noticeable in our tests.
2020-09-22 17:42:18 -04:00
David Smiley 2197776be6
SOLR-13181: param macro expansion could throw (#1877)
...StringIndexOutOfBoundsException on bad syntax
* failOnMissingParams: should have been returning null (failing) on bad syntax cases

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>
2020-09-22 15:46:59 -04:00
Mike Drob a77817a08c
Use github actions cache (#1910) 2020-09-22 13:08:24 -05:00
Tomas Fernandez Lobbe 7b7a5a16ce
SOLR-10391: Add overwrite option to UPLOAD ConfigSet action (#1861)
When set to true, Solr will overwrite an existing configset in ZooKeeper in an UPLOAD.
A new cleanup parameter can also be passed to let Solr know what to do with the files that existed in the old configset, but no longer exist in the new configset (remove or keep)
2020-09-22 10:36:59 -07:00
Simon Willnauer c82b99464d
LUCENE-9539: Use more compact datastructures for sorting doc-values (#1908)
This change cuts over from object based data-structures to primitive / compressed data-structures.
2020-09-22 15:10:53 +02:00
Alexandre Rafalovitch 1611586417
SOLR-14880: Support coreRootDirectory setting when create new cores from command line, in standalone mode
Update to match latest code with shorter name
2020-09-22 09:02:14 -04:00
Ilan Ginzburg d898edaf93
SOLR-14840: Overseer doc in asciidoc
Work done by Cassandra Targett <cassandra.targett@lucidworks.com>
2020-09-22 09:03:35 +02:00
Alexandre Rafalovitch 91b6223f38
SOLR-14878: Expose coreRootDirectory via API (Correction to make name shorter and always return value) 2020-09-21 22:56:08 -04:00
noblepaul 4087958d31 SOLR-14884: TestContainerPlugin.testApiFromPackage jenkins failures 2020-09-22 11:20:49 +10:00
Houston Putman da44d09164
Adding dev-docs around the use of Git Worktree. (#1899) 2020-09-21 14:23:24 -04:00
Tomas Fernandez Lobbe f1921b99b4
Improve TestConfigSetsAPI (#1892)
* Replace Auth plugin with mocks

* Remove unused password param

* Start cluster only once

* Use SolrCloudTestCase

* Use MiniSolrCloudCluster's methods to remove collections and configsets
2020-09-21 10:03:47 -07:00
Jason Gerlowski 9a6ca2dcd0 SOLR-14859: Set fieldType defaults for DateRangeField
AbstractSpatialPrefixTreeFieldType (and its children) create index
fields based on a prototype with options frozen in PrefixTreeStrategy,
regardless of options specified in the schema.  This works fine most of
the time, but causes problems when QParsers or other query optimization
logic makes decisions based on these options (which are potentially out
of sync with the underlying index data).  Most commonly this causes
issues with "exists" (e.g. [* TO *]) queries.

This commit enforces fieldType defaults that line up with the 'hardcoded'
FieldType used by PrefixTreeStrategy.  Options on either the fieldType
or the field itself which contradict these defaults will result in
exceptions at schema load/modification time.
2020-09-21 12:57:08 -04:00
Alexandre Rafalovitch da2714cb86
SOLR-9607: Finalize move of Terms component and request handler into the implicit definitions (#1897)
* Updated implicit definition with terms=true, distrib=false
* Commented out terms handler with notice, as this is the config used in tests
* Remove spurious mentions cluttering other test configs
* Remove implicit terms=true param
* Remove definitions from shipped configsets
* Improve documentation
* Add CHANGES record
2020-09-21 09:05:37 -04:00
noblepaul 73c06e35e8 SOLR-14881: ManagedSchemaRoundRobinCloudTest test failures 2020-09-21 15:08:23 +10:00
noblepaul 64ca559042 SOLR-14879: address TestPackages test failures 2020-09-21 14:55:54 +10:00
Tom Edge fa756b1c31
SOLR-14802: geodist: Support most spatial field types as an arg
FunctionQParser: overload parseValueSourceList with flags
2020-09-20 23:19:48 -04:00
Uwe Schindler aa071f72b1 SOLR-14824: Hotfix for escaping windows paths. IMHO, the template appraoch is not good, we should take care of escaping other props, too 2020-09-20 10:42:19 +02:00
Noble Paul 3664182d24
SOLR-14879: address TestPackages test failures (#1895) 2020-09-20 13:01:47 +10:00
Alexandre Rafalovitch f6e8bc8c31
SOLR-14878: Expose solr.xml's coreRootDirectory property via the System Settings API (#1894) 2020-09-19 22:07:03 -04:00
Erick Erickson ab3f1f0d1d SOLR-14876: Upgrade to zookeeper 3.6.2 2020-09-18 22:37:29 -04:00
Chris Hostetter 5e034d7348 SOLR-14824: remove cruft from the ref-guide gradle build and simpliy the publish process
some things being cleaned up here are simplifications of changes that were 1-to-1 ported from ant, others are left over from when we had a 'released' PDF and are no longer needed
2020-09-18 14:36:51 -07:00
Houston Putman ebb980fd7b
SOLR-14856: Adding docker test to github workflow. (#1859) 2020-09-18 17:05:58 -04:00
Cassandra Targett 4ed7c13c86 Ref Guide: escape non-attributes to avoid conversion warnings 2020-09-18 13:09:54 -05:00
Simon Willnauer 208a1c07b0
LUCENE-9534: Ensure DWPT#ramBytesUsed is only called unter lock (#1889)
Consumers of the used RAM of a DWPT should use it's committed bytesUsed
value that's threadsafe.
2020-09-18 17:59:05 +02:00
noblepaul 745fc31785 SOLR-14871: Wrong field name in POJO 2020-09-18 20:33:59 +10:00
Dawid Weiss 3a92e1b93e
LUCENE-9528: cleanup of flexible query parser's grammar (#1879) 2020-09-18 09:38:20 +02:00
Dawid Weiss 5ec2bac91c
LUCENE-9531: Consolidate duplicated generated classes CharStream and FastCharStream (#1886) 2020-09-18 08:53:30 +02:00
Ignacio Vera fbf8e4f044
LUCENE-9523: Speed up query shapes for geometries that generate multiple points (#1866)
In query shapes over shape fields, skip points while traversing the BKD tree when the relationship with the document is already known
2020-09-18 07:50:58 +02:00
Noble Paul ee0a374bb8
SOLR-14875: Make SolrEventListeners load from packages (#1887) 2020-09-18 12:07:29 +10:00
Adrien Grand 33f7280078
LUCENE-9529: Track dirtiness of stored fields via a number of docs, not chunks. (#1882)
The problem of tracking dirtiness via numbers of chunks is that larger
chunks make stored fields readers more likely to be considered dirty, so
I'm trying to work around it by tracking numbers of docs instead.
2020-09-17 18:59:08 +02:00
Adrien Grand e0a64908d8
Further tune Lucene87StoredFieldsFormat for small documents. (#1888)
The increase of the maximum number of chunks per doc done in previous
issues was mostly random. I'd like to provide users with a similar
trade-off with what the old versions of BEST_SPEED and BEST_COMPRESSION
used to do. So since BEST_SPEED used to compress at most 128 docs at
once, I think we should roughly make it 128*10 now since there are 10
sub blocks. I made it 1024 to account for the fact that there is a preset
dict as well that need decompressing. And similarly BEST_COMPRESSION used
to allow 4x more docs than BEST_SPEED, so I made it 4096.

With such larger numbers of docs per chunk, the decoding of metadata
became a bottleneck for stored field access so I made it a bit faster by
doing bulk decoding of the packed longs.
2020-09-17 18:30:57 +02:00
Ilan Ginzburg dbba48b3e5
SOLR-14613: use set-placement-plugin for both setting and unsetting plugin config 2020-09-17 15:01:19 +02:00
Erik Hatcher 2364a7aded SOLR-14792: Remove VelocityResponseWriter 2020-09-17 08:45:13 -04:00
Dawid Weiss 6c9d7adf79
LUCENE-9527: upgrade javacc to 7.0.4 (#1884) 2020-09-17 13:29:18 +02:00
noblepaul 515608a087 SOLR-14151: fixed the classloading issue 2020-09-17 19:10:04 +10:00
Dawid Weiss 4f344cb0d4
LUCENE-9530: cleaned up javacc gradle generation scripts. (#1883)
* LUCENE-9530: cleaned up gradle javacc generation/ tweaks script so that it's consistent across runs. Removed ant remnants.
2020-09-17 10:53:02 +02:00
noblepaul cbb1659640 Revert "Revert "SOLR-14151: Bug fixes (#1815)""
This reverts commit 27a14fe481.

Undoing accidental commit
2020-09-17 11:19:21 +10:00