33302 Commits

Author SHA1 Message Date
Michael Sokolov
e308e53873 Add CHANGES entry for LUCENE-8962 2020-03-02 18:34:13 -05:00
msfroh
f017ae465e
LUCENE-8962: Fix intermittent test failures (#1307)
1. TestIndexWriterMergePolicy.testMergeOnCommit will fail if the last
   commit (the one that should trigger the full merge) doesn't have any
   pending changes (which could occur if the last indexing thread
   commits at the end). We can fix that by adding one more document
   before that commit.
2. The previous implementation was throwing IOException if the commit
   thread gets interrupted while waiting for merges to complete. This
   violates IndexWriter's documented behavior of throwing
   ThreadInterruptedException.
2020-03-02 18:29:12 -05:00
Cassandra Targett
422d994612 SOLR-14241: fix typos & incorrect example param 2020-03-02 16:53:12 -06:00
Cassandra Targett
27523b5e40 SOLR-14270: Move .gz example to CLI page; Remove bin/solr export from command-line-utilities.adoc 2020-03-02 16:53:12 -06:00
Nicholas Knize
a6e80d004d LUCENE-9150: Restore support for dynamic PlanetModel in spatial3d 2020-03-02 16:06:17 -06:00
Cassandra Targett
a7ebe0c906 Ref Guide: Add license header, typos in Package Manager docs 2020-03-02 15:44:55 -06:00
Cassandra Targett
153d7bcfee Ref Guide: standardize i.e., e.g., spellings; fix typos 2020-03-02 15:44:55 -06:00
msfroh
043c5dff6f
LUCENE-8962: Add ability to selectively merge on commit (#1155)
* LUCENE-8962: Add ability to selectively merge on commit

This adds a new "findCommitMerges" method to MergePolicy, which can
specify merges to be executed before the
IndexWriter.prepareCommitInternal method returns.

If we have many index writer threads, they will flush their DWPT buffers
on commit, resulting in many small segments, which can be merged before
the commit returns.

* Add missing Javadoc

* Fix incorrect comment

* Refactoring and fix intermittent test failure

1. Made some changes to the callback to update toCommit, leveraging
SegmentInfos.applyMergeChanges.
2. I realized that we'll never end up with 0 registered merges, because
we throw an exception if we fail to register a merge.
3. Moved the IndexWriterEvents.beginMergeOnCommit notification to before
we call MergeScheduler.merge, since we may not be merging on another
thread.
4. There was an intermittent test failure due to randomness in the time
it takes for merges to complete. Before doing the final commit, we wait
for pending merges to finish. We may still end up abandoning the final
merge, but we can detect that and assert that either the merge was
abandoned (and we have > 1 segment) or we did merge down to 1 segment.

* Fix typo

* Fix/improve comments based on PR feedback

* More comment improvements from PR feedback

* Rename method and add new MergeTrigger

1. Renamed findCommitMerges -> findFullFlushMerges.
2. Added MergeTrigger.COMMIT, passed to findFullFlushMerges and to
   MergeScheduler when merging on commit.

* Update renamed method name in strings and comments
2020-03-02 12:19:47 -05:00
Namgyu Kim
b2dbd18f96
LUCENE-9253: Support custom dictionaries in KoreanTokenizer
Signed-off-by: Namgyu Kim <namgyu@apache.org>
2020-03-03 02:11:44 +09:00
Adrien Grand
f4b5069c1f LUCENE-9247: Fix test failures with ExtraFS. 2020-03-02 08:59:13 +01:00
Ignacio Vera
c653c04bb1
LUCENE-9243: Add fudge factor when creating a bounding box of a xycircle (#1278) 2020-03-02 06:56:29 +01:00
Shalin Shekhar Mangar
4897a64713 SOLR-13996: Rename LegacyReplicaSource to StandaloneReplicaSource 2020-03-01 07:00:51 +05:30
Tomoko Uchida
5f9bf6b707 SOLR-14295: Add the parameter description about 'discardCompoundToken' for JapaneseTokenizer in RefGuide 2020-02-29 17:43:25 +09:00
Adrien Grand
c929b65c81 LUCENE-9247: Exclude write.lock from files whose integrity is expected to be verified. 2020-02-29 08:46:16 +01:00
Adrien Grand
30944d3520 LUCENE-9247: Fix class visibility issue discovered when backporting. 2020-02-28 15:34:36 +01:00
Bruno Roustant
99af698107
LUCENE-9237: Faster UniformSplit intersect TermsEnum.
Closes #1270
2020-02-28 14:52:19 +01:00
Adrien Grand
d10db0d98f LUCENE-9247: Add missing commit. 2020-02-28 14:48:44 +01:00
Adrien Grand
cd984e2dc0
LUCENE-9247: Add tests for checkIntegrity. (#1284)
This adds a test to `BaseIndexFileFormatTestCase` that the combination
of opening a reader and calling `checkIntegrity` on it reads all bytes
of all files (including index headers and footers). This would help
detect most cases when `checkIntegrity` is not implemented correctly.
2020-02-28 14:19:56 +01:00
Adrien Grand
ebdfdaed9f
LUCENE-9246: Remove dOff argument from LZ4#decompress. (#1283)
It is always set to 0 at call sites.
2020-02-28 11:26:56 +01:00
Bruno Roustant
e0164d1ac8
LUCENE-9245: Reduce AutomatonTermsEnum memory usage.
Closes #1281
2020-02-28 10:42:06 +01:00
Jan Høydahl
198d9db674
SOLR-14287: Admin UI Properties screen does not show colons (#1300) 2020-02-28 10:32:09 +01:00
Ignacio Vera
988ce9bff7
LUCENE-9250: Add support for Circle2d#intersectsLine around the dateline. (#1289) 2020-02-28 10:22:27 +01:00
Cao Manh Dat
3ad9915547 SOLR-14286: Try and fix sha1 file. 2020-02-28 08:35:29 +07:00
Jan Høydahl
62f5bd50cd
SOLR-14281: Make sharedLib configurable through SysProp (#1288) 2020-02-27 14:16:33 +01:00
Michael Sokolov
294b8d4ee1 LUCENE-9202: refactor leaf collectors in TopFieldCollector 2020-02-27 08:05:49 -05:00
Andrzej Bialecki
c6bf8b6cec SOLR-14252: NullPointerException in AggregateMetric. 2020-02-27 13:00:43 +01:00
Mikhail Khludnev
3befb8be94 SOLR-13411: reject incremental update for route.field, uniqueKey and
_version_.
2020-02-27 14:51:34 +03:00
Cao Manh Dat
d9c43d9fa3 SOLR-14286: Fix gradle precommit 2020-02-27 18:24:39 +07:00
Cao Manh Dat
043a3cf849 SOLR-14286: Move entry in CHANGES.txt to 8.5.0 2020-02-27 15:13:22 +07:00
Cao Manh Dat
e059455004 SOLR-14286: Update sha files 2020-02-27 15:07:03 +07:00
Cao Manh Dat
666bd493c8 SOLR-14286: Upgrade Jaegar to 1.1.0 2020-02-27 14:51:45 +07:00
noble
edefcf156b SOLR-14270: fix incorrect date format 2020-02-27 17:28:31 +11:00
Christine Poerschke
fc24fa9506 SOLR-14267: complete <query><HashDocSet> solrconfig.xml removal 2020-02-26 17:47:25 +00:00
Eric Pugh
b4f3efbf94 SOLR-13965: In GraphHandler, support <expressible> configuration and deprecate <streamFunctions> configuration.
(Eric Pugh via Christine Poerschke)

Closes #1033 pull request.
2020-02-26 17:36:33 +00:00
Mike McCandless
61e0b4cd87 LUCENE-9252: fix javac linter warnings in spatial-extras (thanks Andras Salamon) 2020-02-26 09:34:58 -05:00
Alan Woodward
98dafe2e10
LUCENE-9207: Don't build span queries in QueryBuilder (#1239)
QueryBuilder currently has special logic for graph phrase queries with no slop,
constructing a spanquery that attempts to follow all paths using a combination of
OR and NEAR queries. However, this type of query has known bugs(LUCENE-7398).
This commit removes this logic and just builds a disjunction of phrase queries, one 
phrase per path.
2020-02-26 14:32:34 +00:00
Chris Hostetter
852f02b4b7 Some additional testing to prove 'defered function computation' in a syntax variant i was recently asked about 2020-02-25 13:21:13 -07:00
David Smiley
50a7075862
SOLR-14256: Remove HashDocSet; add DocSet.getBits.
* DocSet is now fixed at two implementations, read-only and doc ordered.
* DocSetBase removed; not needed anymore.  DocSet is now an abstract class.
2020-02-25 09:48:20 -05:00
David Smiley
25892271e8
SOLR-14258: DocList should not extend DocSet 2020-02-25 09:39:43 -05:00
Mike
1770797387
SOLR-14223 Create RSAKeyPair from disk (#1217)
* Create properties for PublicKeyHandler to read existing keys from disk
* Move pregenerated keys from core/test-files to test-framework
* Update tests to use existing keys instead of new keys each run
2020-02-24 12:07:10 -08:00
Anshum Gupta
7ba9d4d756
SOLR-14272: Remove autoReplicaFailoverBadNodeExpiration and autoReplicaFailoverWorkLoopDelay for 9.0 as it was deprecated in 7.1 (#1269)
* SOLR-14272: Remove autoReplicaFailoverBadNodeExpiration and autoReplicaFailoverWorkLoopDelay for 9.0 as it was deprecated in 7.1
2020-02-24 09:46:05 -08:00
Alan Woodward
b4c2e279a9 LUCENE-9212: Fix precommit 2020-02-24 14:17:04 +00:00
Alan Woodward
19fe1eee68 LUCENE-9212: Remove deprecated Intervals.multiterm() methods 2020-02-24 11:16:37 +00:00
Alan Woodward
ffb7cafe93 LUCENE-9212: Intervals.multiterm() should take CompiledAutomaton 2020-02-24 11:08:48 +00:00
Alessandro Benedetti
663611c99c
[SOLR-12238] Synonym Queries boost (#357)
SOLR-12238: Handle boosts in QueryBuilder

QueryBuilder now detects per-term boosts supplied by a BoostAttribute when
building queries using a TokenStream.  This commit also adds a DelimitedBoostTokenFilter
that parses boosts from tokens using a delimiter token, and exposes this in Solr
2020-02-24 10:29:41 +00:00
Jan Høydahl
57c7139ea3
SOLR-14114: Add WARN to Solr log that embedded ZK is not supported in production (#1273) 2020-02-24 09:59:33 +01:00
Jan Høydahl
8b98befe93
SOLR-10306: Document in Reference Guide how to disable or reduce swapping (#1256) 2020-02-24 09:50:01 +01:00
Tomoko Uchida
312d6b2a0d LUCENE-9201: Add an equivalent to "check missing javadocs" task to gradle build
Co-Authored-By: Dawid Weiss <dawid.weiss@carrotsearch.com>
2020-02-24 11:05:35 +09:00
Dawid Weiss
c1c5d07d9d LUCENE-9240: Add full validation equivalent for precommit. 2020-02-23 15:54:10 +01:00
Anshum Gupta
bc41f25cc9
SOLR-14271: Delete CollectionsAPIAsyncDistributedZkTest.testAsyncIdBackCompat as that is no longer required (#1275) 2020-02-21 09:53:10 -08:00