Commit Graph

2603 Commits

Author SHA1 Message Date
Atri Sharma a074418da0
SOLR-13528: Implement Request Rate Limiters (#1686)
This commit introduces two functionalities: request rate limiting and ability to identify requests based on type (indexing, search, admin). The default rate limiter rate limits query requests based on configurable parameters which can be set in web.xml. Note that this rate limiting works at a JVM level, not a core/collection level.
2020-08-08 01:36:06 +05:30
Marcus 7110118ad4
SOLR-14702: Remove oppressive language (part1) (#1711)
Replace references to "master" and "slave" with "leader" and "follower"
2020-08-05 14:52:48 -07:00
Munendra S N 07a89e7bf6 SOLR-14516: fix NPE is resp writer while writing docvalue only field
This issue occurs only while fetching uncommitted doc through /get.
Instead of directly calling stringValue() on IndexableField use
FieldType's toExtern() or toObject() to get the writable value for the field.
2020-07-31 20:05:41 +05:30
Marcus f443edebd2
SOLR-14681: Introduce ability to delete .jar stored in the Package Store (#1702) 2020-07-31 18:23:18 +10:00
Jan Høydahl ebb5219b1b
SOLR-14671: Parsing dynamic ZK config sometimes cause NuberFormatException (#1701) 2020-07-29 10:33:02 +02:00
David Smiley a3624029ad
SOLR-14651: Metrics History could disable better (#1672)
* SolrRrdBackendFactory should not be created if history is disabled
* Disable MetricsHistoryHandler by default in tests
* Await shutdown of all executors
2020-07-28 16:46:27 -04:00
Erick Erickson 6bf5f4a87f SOLR-11868: CloudSolrClient.setIdField is confusing, it's really the routing field. Should be deprecated. 2020-07-26 18:18:05 -04:00
Erick Erickson 67da34ac3b SOLR-14676: Update commons-collections to 4.4 and use it in Solr 2020-07-23 17:09:15 -04:00
Ishan Chattopadhyaya cc0c111949 SOLR-14656: Removing Autoscaling Framework
The following were removed:
 *  Autoscaling policy, triggers etc.
 *  withCollection handling
 *  UTILIZENODE command
 *  Sim framework
 *  Suggestions tab in UI
 *  Reference guide pages for autoscaling
 *  autoAddReplicas feature
 *  UTILIZENODE
2020-07-20 17:47:01 +05:30
Erick Erickson 1a7db1c9f5 SOLR-14653: Replace usages of org.apache.hadoop.fs.Path that are used to construct Zookeeper paths 2020-07-17 16:18:21 -04:00
Ishan Chattopadhyaya db4516bc66 SOLR-13391: Removing unused imports 2020-07-17 04:14:41 +05:30
Erick Erickson f3de646560 SOLR-13939: Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort (thread leaks) 2020-07-15 09:23:27 -04:00
Eric Pugh 1d5a0ad8a3
SOLR-14637 update CloudSolrClient examples to remove deprecated .Builder() method (#1670)
* update CloudSolrClient examples to remove deprecated .Builder() method

* remove extra method lines that arent specific to what we are explaining.
2020-07-14 10:23:18 -04:00
Andrzej Bialecki a0488c1cf1 SOLR-14244: Remove ReplicaInfo. 2020-07-14 15:01:23 +02:00
Erick Erickson c346881ad6 SOLR-13939: https://issues.apache.org/jira/browse/SOLR-13939 2020-07-12 22:41:08 -04:00
S N Munendra 8c9c0640cf
SOLR-11262: XML writer implements writeMap and writeIterator (#1665) 2020-07-13 11:21:14 +10:00
noblepaul 2155258974 SOLR-14610 : Use Methodhandles instead of VarHandle. Works with java8 as well 2020-07-09 18:08:22 +10:00
Andrzej Bialecki cf742f4596 SOLR-12847: Remove support for maxShardsPerNode. 2020-07-08 17:57:24 +02:00
Jason Gerlowski 80f8ab717c
SOLR-14566: Add request-ID to all distrib-search requests (#1574) 2020-07-08 08:38:23 -04:00
Ilan Ginzburg 06b1f3e866
SOLR-14462: adjust test so less sessions are used even if test runs slowly. fix synchronization issue. (#1656) 2020-07-07 17:13:22 +02:00
Cao Manh Dat a80eb84d56
SOLR-14354: HttpShardHandler send requests in async (#1470) 2020-07-07 09:17:26 +07:00
Noble Paul 05324e7b18
SOLR-14610: ReflectMapWriter to use VarHandle instead of old legacy reflection (#1635) 2020-07-03 15:25:58 +10:00
Andrzej Bialecki 1b8fb70216 SOLR-14537: Improve performance of ExportWriter. 2020-07-02 17:34:50 +02:00
Erick Erickson d0864a19c7 SOLR-14523: Enhance gradle logging calls validation: eliminate getMessage() 2020-07-01 22:07:59 -04:00
Erick Erickson 76e1d901cb SOLR-14592: Upgrade Zookeeper to 3.6.1 2020-07-01 19:47:16 -04:00
Jan Høydahl 49a3f0a11d
SOLR-14561 Followup - validate params for more core operations (#1629)
Add template to solr.in scripts
Also testes Windows paths
Added RefGuide documentation to some params
2020-06-29 13:18:24 +02:00
noble 94684cc014 SOLR-14481: precommit error 2020-06-29 13:46:21 +10:00
Joel Bernstein 7bb9926ef2 SOLR-14481: Add drill Streaming Expression 2020-06-28 20:41:40 -04:00
Noble Paul 1590ed56bb
SOLR-14404: support for openResource() in PackageResourceLoader & path-prefix for container plugins 2020-06-28 14:49:06 +10:00
Erick Erickson 11538e52a2 SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings 2020-06-25 16:35:56 -04:00
David Smiley 3000bbd05a
SOLR Move "userfiles" stuff from SolrPaths to CoreContainer. (#1600)
And convert String and File paths to Path API
2020-06-25 00:18:58 -04:00
Noble Paul 57a892f896
SOLR-14404 CoreContainer level custom requesthandlers (#1432)
SOLR-14404 CoreContainer level custom requesthandlers
2020-06-25 13:08:51 +10:00
Noble Paul 419560ef2a
SOLR-14409: Existing violations allow bypassing policy rules when add… (#1598)
* SOLR-14409: Existing violations allow bypassing policy rules when adding new replicas
2020-06-25 10:33:28 +10:00
Mike Drob fa44f822e3
LUCENE-6669 Fix repeated "the the"
Co-Authored-By: Rich Bowen <rbowen@apache.org>
2020-06-24 16:15:51 -05:00
Ilan Ginzburg 25428013fb
SOLR-14462: cache more than one autoscaling session (#1504)
SOLR-14462: cache more than one autoscaling session
2020-06-24 22:02:43 +02:00
Erick Erickson db986086f5 SOLR-14541: Remove IntelliJ //noinspection comments 2020-06-23 19:36:51 -04:00
Erick Erickson 9c1772f094 LUCENE-9411: Fail complation on warnings, 9x gradle-only 2020-06-23 16:21:10 -04:00
Erick Erickson ea1bb9f2e9 SOLR-13268: Clean up any test failures resulting from defaulting to async logging 2020-06-23 15:35:08 -04:00
Ilan Ginzburg 3e42286e9e
SOLR-14546: OverseerTaskProcessor can process messages out of order (#1561)
SOLR-14546: OverseerTaskProcessor can process messages out of order
2020-06-23 16:16:46 +02:00
Jan Høydahl 936b9d770e
SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated (#1572) 2020-06-18 16:13:52 +02:00
Erick Erickson 6357b3bdaa SOLR-14573: Fix or suppress warnings in solrj/src/test 2020-06-16 13:27:53 -04:00
noble fabc704748 SOLR-14516: NPE in JsonTextWriter 2020-06-15 19:17:23 +10:00
Erick Erickson 8426dc7a6a SOLR-14556: Fix or suppress warnings in solrj/cloud/autoscaling 2020-06-14 15:43:30 -04:00
Erick Erickson 4e90e48ac2 SOLR-14567: Fix or suppress remaining warnings in solrj 2020-06-14 08:11:23 -04:00
Gus Heck 396490b65c SOLR-13169 Improve docs for MOVEREPLICA - better parity with ref guide for v2 api descriptions 2020-06-13 16:24:45 -04:00
Gus Heck b00d747eb6 SOLR-13169 Improve docs for MOVEREPLICA - document additional existing parameters, second pass fixing spelling and other details. 2020-06-13 15:55:32 -04:00
Erick Erickson 6801d4c139 SOLR-14565: Fix or suppress warnings in solrj/impl and solrj/io/graph 2020-06-12 20:06:16 -04:00
Mike Drob fb98f30a61
SOLR-8392 type safety on SolrParam (#1556) 2020-06-11 14:21:54 -05:00
murblanc b4dcbfa3de
SOLR-12823: fix failures in CloudHttp2SolrClientTest CloudSolrClientTest TestCloudSolrClientConnections (#1565)
Co-authored-by: Ilan Ginzburg <iginzburg@salesforce.com>
2020-06-11 10:50:16 -05:00
Munendra S N 53040984f6 SOLR-14345: return correct err msg when non-binary resp parser is used
* This adds support to parse error properly in case of non-binary
  resp parser but the problem still exists for noopResponseParser
2020-06-10 19:11:52 +05:30
murblanc d4f7c90bab
SOLR-14347: fix cached session update to not depend on Zookeeper state (#1542)
SOLR-14347: fix cached session update to not depend on Zookeeper state
2020-06-10 21:13:55 +10:00
Mike Drob 2660139aa3 few more awaitsfix 2020-06-09 22:00:44 -05:00
Erick Erickson c8f48d4701 SOLR-14547: Fix or suppress warnings in solr/client/solrj/io/stream 2020-06-09 19:21:36 -04:00
Mike Drob 8ee6e6797b
SOLR-14548 Address warning: static member should be qualified by type… (#1555) 2020-06-09 15:33:37 -05:00
murblanc 1ab9b811c6
SOLR-12823: remove /clusterstate.json (#1528)
* SOLR-12823: remove /clusterstate.json

Remove all code dealing with Zookeeper's /clusterstate.json, remove Collection API's MIGRATESTATEVERSION, remove legacyCloud option.

Also fixes SOLR-11877 DocCollection.getStateFormat is buggy

Co-authored-by: Ilan Ginzburg <iginzburg@salesforce.com>
2020-06-09 13:59:17 -05:00
Adrien Grand 684c2e6afe SOLR-14470: Fix precommit 2020-06-09 09:37:51 +02:00
Andrzej Bialecki 30924f23d6 SOLR-14470: Add streaming expressions to /export handler. 2020-06-08 16:03:07 +02:00
Erick Erickson 7bf59a16bd SOLR-14544: Fix or suppress warnings in solr/client/solrj/io/eval 2020-06-07 21:31:51 -04:00
Jan Høydahl f404a38fa6
SOLR-9679: Exception when removing zk node /security.json (#1403) 2020-06-08 01:11:56 +02:00
Erick Erickson 6d5b1ae7f4 SOLR-14536: Fix or suppress warnings in apache/solr/common 2020-06-06 09:30:17 -04:00
Gus Heck 4b496b364f SOLR-13169 Improve docs for MOVEREPLICA - correct existing parameter docs. 2020-06-05 17:47:11 -04:00
Erick Erickson 07a9b5d1b0 SOLR-14474: Fix remaining auxilliary class warnings in Solr 2020-05-27 12:06:29 -04:00
Tomas Fernandez Lobbe 3ca7628c43
SOLR-13289: Rename minExactHits to minExactCount (#1511) 2020-05-21 16:42:37 -07:00
David Smiley 2ac640f9d0
SOLR-14484: avoid putting null into MDC
Co-authored-by: Andras Salamon
2020-05-20 09:46:15 -04:00
Joel Bernstein a795047c6c SOLR-14476: Fix precommit 2020-05-19 09:10:23 -04:00
Joel Bernstein 16aad55369 SOLR-14476: Add percentiles and standard deviation aggregations to stats, facet and timeseries Streaming Expressions 2020-05-19 09:10:23 -04:00
David Smiley d3d0df9da1
SOLR-14472: Autoscale "cores": use metrics to count
Also counts all cores (lazy, transient), although currently impossible to use these in SolrCloud.
2020-05-18 17:41:29 -04:00
murblanc d2825282c9
SOLR-14473: Improve Overseer Javadoc (#1510)
Co-authored-by: Ilan Ginzburg <iginzburg@salesforce.com>
2020-05-18 15:21:16 -05:00
Uwe Schindler 06df50e759
LUCENE-9321: Port markdown task to Gradle (#1477) 2020-05-17 14:46:26 +02:00
Michael Gibney 54dca800a9
SOLR-14471: Fix last-place replica after shards.preference rules (#1507)
Properly apply base replica ordering to last-place shards.preference matches
2020-05-14 21:31:35 -07:00
Joel Bernstein f1db56afaf SOLR-14478: Allow the diff Stream Evaluator to operate on the rows of a matrix 2020-05-14 09:52:05 -04:00
Andrzej Bialecki dd4fa8f2f8 SOLR-14423: Additional fixes for object caching and incorrect test assumptions. 2020-05-13 19:37:12 +02:00
Samuel García Martínez adddab9d14
SOLR-14456: Fix Content-Type header forwarding on compressed requests (#1480)
Co-authored-by: Samuel García Martínez <samuelgma@inditex.com>
2020-05-12 17:50:07 -04:00
Andrzej Bialecki 4680e9245f SOLR-14423: Move static SolrClientCache from StreamHandler to CoreContainer for wider reuse and better life-cycle management. 2020-05-12 21:44:00 +02:00
Tomas Fernandez Lobbe d9f9d6dd47
SOLR-13289: Add Support for BlockMax WAND (#1456)
Add support for BlockMax WAND via a minExactHits parameter. Hits will be counted accurately at least until this value, and above that, the count will be an approximation. In distributed search requests, the count will be per shard, so potentially the count will be accurately counted until numShards * minExactHits. The response will include the value numFoundExact which can be true (The value in numFound is exact) or false (the value in numFound is an approximation).
2020-05-08 14:25:47 -07:00
Erick Erickson 9ae05e9b4f LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects 2020-04-30 19:50:31 -04:00
Erick Erickson 6e96d01efc LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects 2020-04-29 10:56:54 -04:00
Erick Erickson 960610a615 LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects 2020-04-27 20:45:57 -04:00
Mike Drob 950a34ce13 SOLR-14412 use parameterized logging 2020-04-22 12:11:53 -05:00
Andrzej Bialecki 5d60ff4613 SOLR-12845: Add a default autoscaling cluster policy. 2020-04-22 17:46:39 +02:00
Mike Drob 58f9c79c6d
SOLR-14412 zkRun+https (#1437)
SOLR-14412

Check for results after retries failed in SolrClientNodeStateProvider
Set urlScheme=https with zkRun
2020-04-20 12:55:43 -05:00
Jan Høydahl 03363f413f
SOLR-14371 Zk StatusHandler should know about dynamic zk config (#1392) 2020-04-17 16:30:27 +02:00
Markus Schuch 74ecc13816 SOLR-14387 add testcase for ids with separators to GetByIdTest and fix SolrClient to escape ids properly 2020-04-16 11:52:03 -05:00
Shalin Shekhar Mangar 3e0f7b1971 SOLR-9909: Actually delete SolrjNamedThreadFactory.java 2020-04-13 13:47:20 +05:30
Shalin Shekhar Mangar 13f19f6555 SOLR-9906: SolrjNamedThreadFactory is deprecated in favor of SolrNamedThreadFactory. DefaultSolrThreadFactory is removed from solr-core in favor of SolrNamedThreadFactory in solrj package and all solr-core classes now use SolrNamedThreadFactory 2020-04-13 08:16:35 +05:30
Erick Erickson 1ca7067a81 SOLR-12028: BadApple and AwaitsFix annotations usage, Unannotated tests that haven't failed in a while 2020-03-30 20:37:55 -04:00
Ishan Chattopadhyaya 782ded2d7a SOLR-14317: HttpClusterStateProvider throws exception when only one node down (Closes #1342) 2020-03-29 07:20:32 +05:30
Munendra S N 132228d450 SOLR-14344: remove deprecated HttpSolrClient's Remote*Exception
* All usages are replaced by BaseHttpSolrClient's Remote*Exception
2020-03-28 11:36:06 +05:30
Andy Throgmorton d1601f6fdf SOLR-14260: SolrJ pluggable ConnectionSocketFactory in HttpClientUtil
see SocketFactoryRegistryProvider
Fixes #1261
2020-03-26 22:15:50 -04:00
mariemat aad814ba63 SOLR-14340: Remove unnecessary configset verification checks
Improves CLUSTERSTATUS times for massive clusters.
Closes #1373
2020-03-24 15:34:20 -04:00
Andrzej Bialecki 68e4304453 SOLR-14347: Autoscaling placement wrong when concurrent replica placements are calculated. 2020-03-23 18:21:40 +01:00
Munendra S N 5630619dfd SOLR-14343: set initcapacity properly in NamedList
* This is when map or map.entry array is passed in constructor
2020-03-23 19:54:54 +05:30
Munendra S N e36733d01d SOLR-14350: fix test failure due to SOLR-14012 2020-03-19 22:43:29 +05:30
Aroop 9a8602c96e
SOLR-14316: Fix unchecked type warning in JavaBinCodec (#1344)
Fix an unchecked type conversion warning in JavaBinCodec's readMapEntry's equals() method
Add test

Co-authored-by: Aroop Ganguly <aroop_ganguly@apple.com>
2020-03-12 09:55:01 -07:00
David Smiley 732348ec7f SOLR-14197: SolrResourceLoader refactorings to reduce API
* Remove SRL.listConfigDir (unused)
* Remove SRL.getDataDir
* Remove SRL.getCoreName
* Remove SRL.getCoreProperties
 XmlConfigFile needs to be passed in the substitutableProperties
 IndexSchema needs to be passed in the substitutableProperties
 Remove redundant Properties from CoreContainer constructors
* Remove SRL.newAdminHandlerInstance (unused)
* Remove SRL.openSchema and openConfig
* Avoid SRL.getConfigDir
 Also harmonized similar initialization logic between DIH Tika processor & ExtractingRequestHandler.
* Ensure SRL.addToClassLoader and reloadLuceneSPI are called at most once
 Don't auto-load "lib" in constructor; wrong place for this logic.
* Avoid SRL.getInstancePath
 Added SolrCore.getInstancePath instead
 Use CoreContainer.getSolrHome instead
 NodeConfig should track solrHome separate from SolrResourceLoader
* Simplify some SolrCore constructors
* Move locateSolrHome to new SolrPaths
* Move "User Files" stuff to SolrPaths
2020-03-11 09:20:28 -04:00
Marc A. Morissette 051133c13f
SOLR-12550: ConcurrentUpdateSolrClient doesn't respect timeouts for commits and optimize (#417)
ConcurrentUpdateSolrClient now propagates its connection and read timeouts to the private HttpSolrClient used to commit and optimize.
2020-02-20 04:29:20 -08:00
Christine Poerschke 003303a9cc SOLR-13041: Add hashCode for autoscaling.Condition to accompany the already present equals.
(Zsolt Gyulavari via Christine Poerschke)
2020-02-18 14:47:44 +00:00
Chris Hostetter 49e20dbee4 SOLR-14245: Fix ReplicaListTransformerTest
Previous changes to this issue 'fixed' the way the test was creating mock Replica instances,
to ensure all properties were specified -- but these changes tickled a bug in the existing test
scaffolding that caused it's "expecations" to be based on a regex check against only the base "url"
even though the test logic itself looked at the entire "core url"

The result is that there were reproducible failures if/when the randomly generated regex matched
".*1.*" because the existing test logic did not expect that to match the url or a Replica with
a core name of "core1" because it only considered the base url
2020-02-12 11:10:26 -07:00
Andrzej Bialecki 9a19093586 SOLR-14245: Validate Replica / ReplicaInfo on creation. 2020-02-07 17:56:39 +01:00
Robert Muir 0d339043e3
LUCENE-9209: fix javadocs to be html5, enable doclint html checks, remove jtidy
Current javadocs declare an HTML5 doctype: !DOCTYPE HTML. Some HTML5
features are used, but unfortunately also some constructs that do not
exist in HTML5 are used as well.

Because of this, we have no checking of any html syntax. jtidy is
disabled because it works with html4. doclint is disabled because it
works with html5. our docs are neither.

javadoc "doclint" feature can efficiently check that the html isn't
crazy. we just have to fix really ancient removed/deprecated stuff
(such as use of tt tag).

This enables the html checking in both ant and gradle. The docs are
fixed via straightforward transformations.

One exception is table cellpadding, for this some helper CSS classes
were added to make the transition easier (since it must apply padding
to inner th/td, not possible inline). I added TODOs, we should clean
this up. Most problems look like they may have been generated from a
GUI or similar and not a human.
2020-02-06 22:30:52 -05:00