lucene/.github/PULL_REQUEST_TEMPLATE.md
Jason Gerlowski 27f7875d2d
SOLR-13775: Add note about permissions to "PR Template" (#891)
By default, when a Solr contributor creates their own fork, only they
have access to that fork.  This creates a bit of a roadblock when users
contribute PRs from these forks - others can't build off of their work -
something that is done often with patches.  An initial user might
contribute a feature, a committer might add tests or change formatting,
etc.

This commit introduces a bullet point to our PR checklist to nudge users
towards making their PR branches more open so that it's easier for committers
to help them.
2019-09-19 15:37:48 -04:00

2.0 KiB

Description

Please provide a short description of the changes you're making with this pull request.

Solution

Please provide a short description of the approach taken to implement your solution.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the master branch.
  • I have run ant precommit and the appropriate test suite.
  • I have added tests for my changes.
  • I have added documentation for the Ref Guide (for Solr changes only).