Commit Graph

6196 Commits

Author SHA1 Message Date
Carlos Sanchez Gonzalez 0ca8675e19 [MNG-3400] Implement clone properly following Effective Java' book considerations
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@627935 13f79535-47bb-0310-9956-ffa450edef68
2008-02-15 03:10:09 +00:00
Carlos Sanchez Gonzalez 53e9189566 [MNG-3400] Implement clone properly following Effective Java' book considerations
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@627932 13f79535-47bb-0310-9956-ffa450edef68
2008-02-15 02:39:02 +00:00
Carlos Sanchez Gonzalez 17d401df6c [MNG-3400] MavenProject is not extensible
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@627670 13f79535-47bb-0310-9956-ffa450edef68
2008-02-14 06:08:07 +00:00
John Dennis Casey 0fc4704f30 [MNG-2184] Commenting this out again, until I can figure out how to make aggregators run once and only once, regardless of the contents of the reactor.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@619724 13f79535-47bb-0310-9956-ffa450edef68
2008-02-08 01:20:22 +00:00
John Dennis Casey 80f538bc52 Putting aggregator skip logic from previous commit ahead of warning messages, and adding some doco to the javadoc for the method to note the skip behavior.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@619721 13f79535-47bb-0310-9956-ffa450edef68
2008-02-08 01:06:16 +00:00
John Dennis Casey 34c390602c [MNG-2184] Skip aggregator-mojo execution when bound to the lifecycle (or bound as a report), and the current project is not the root project...in other words, detect aggregator mojos bound to the lifecycle in some way, and only execute them once using the root project.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@619720 13f79535-47bb-0310-9956-ffa450edef68
2008-02-08 01:03:03 +00:00
John Dennis Casey cc6b280343 Add warnings for deprecation of aggregator-mojos bound to the lifecycle, and add error/error-logging (error when directly in the pom, error-logging when brought in via lifecycle mapping, etc.) when a direct-invocation mojo (@requiresDirectInvocation) is bound to the lifecycle.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@619711 13f79535-47bb-0310-9956-ffa450edef68
2008-02-08 00:46:16 +00:00
Vincent Siveton 621d238877 MNG-3388: DefaultPluginManager needs to catch LinkageError
o added another catch
o based on r619408

git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@619410 13f79535-47bb-0310-9956-ffa450edef68
2008-02-07 13:41:13 +00:00
Vincent Siveton 738cb3016b MNG-3388: DefaultPluginManager needs to catch LinkageError
o added the catch
o based on r619234

git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@619237 13f79535-47bb-0310-9956-ffa450edef68
2008-02-07 00:57:42 +00:00
Vincent Siveton f8bc0a121f o fixed plexus-classworlds due to r619106
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@619231 13f79535-47bb-0310-9956-ffa450edef68
2008-02-07 00:37:34 +00:00
John Dennis Casey 37b11eb9e9 [MNG-2178] Modding M2_HOME detection for winnt.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@619114 13f79535-47bb-0310-9956-ffa450edef68
2008-02-06 19:26:54 +00:00
John Dennis Casey 1611fcfbdf [MNG-3354] & [MNG-3296] Patching Windows batch files for maven, to improve support for Windows+Novell integration, and to handle the end of winnt's local scope with the errorlevel preserved.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@619106 13f79535-47bb-0310-9956-ffa450edef68
2008-02-06 19:03:43 +00:00
John Dennis Casey 04ad40121c [MNG-1493] Modifying to allow <module> to specify a full path, including alternate pom file, rather than just a directory wherein a normal 'pom.xml' is expected to reside. This works more like <relativePath> has worked for awhile now.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@618780 13f79535-47bb-0310-9956-ffa450edef68
2008-02-05 21:27:53 +00:00
John Dennis Casey ad27233c7c Bumping to next version of plexus-container-default to take advantage of mutable ComponentMap modifications, so things like gpg:sign will work again.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@618779 13f79535-47bb-0310-9956-ffa450edef68
2008-02-05 21:26:28 +00:00
John Dennis Casey 256d3cf86b [MNG-3331] Correcting URI.normalize call for only non-windows environments, since this apparently destroys UNC paths.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@618735 13f79535-47bb-0310-9956-ffa450edef68
2008-02-05 18:30:45 +00:00
John Dennis Casey 91d2e5abf9 [MNG-3331] Modified module path calculation to use URI.normalize to handle relative directory references, so there is no confusion about such references causing false positives on symlink detection (where getCanonicalPath() != getAbsolutePath()).
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@618708 13f79535-47bb-0310-9956-ffa450edef68
2008-02-05 17:31:57 +00:00
John Dennis Casey 10da177f1d [MNG-3119] Modifying MavenProject.addAttachment(..) and MavenProjectHelper.attachArtifact(..) implementations to throw an unchecked exception when a project attachment will collide with existing attachments. This includes tests to verify the behavior. The unchecked exception allows Maven to deal with it as a real build failure, while avoiding the need to modify the MavenProjectHelper API, which is part of Maven's core and which would render many existing plugins incompatible with new Maven releases.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@618497 13f79535-47bb-0310-9956-ffa450edef68
2008-02-05 00:09:27 +00:00
John Dennis Casey e38fa6fcc5 [MNG-3099] Modify the call to get the super-pom in cases where maven is not using any pom files, to ensure that profiles from the settings are used.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@618391 13f79535-47bb-0310-9956-ffa450edef68
2008-02-04 19:36:35 +00:00
Jason van Zyl e30510f0c9 o rolling back to r617947
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@618044 13f79535-47bb-0310-9956-ffa450edef68
2008-02-03 17:47:10 +00:00
Vincent Siveton 2282145d52 o merged from r618026
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@618028 13f79535-47bb-0310-9956-ffa450edef68
2008-02-03 17:18:15 +00:00
Jason van Zyl a093415971 o committing my changes and i'll quickly make a branch
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@618021 13f79535-47bb-0310-9956-ffa450edef68
2008-02-03 17:08:57 +00:00
Jason van Zyl 00206c8dbd o updating for the changes I just made to maven-artifact
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@617948 13f79535-47bb-0310-9956-ffa450edef68
2008-02-03 04:50:45 +00:00
Vincent Siveton 4733739db6 o merged r617829
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@617830 13f79535-47bb-0310-9956-ffa450edef68
2008-02-02 16:44:10 +00:00
John Dennis Casey e86a507c5d Fixing formatting on transitive resolution error (again).
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@617669 13f79535-47bb-0310-9956-ffa450edef68
2008-02-01 21:57:26 +00:00
John Dennis Casey c9d88e6ce3 Fixing formatting on transitive resolution error.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@617663 13f79535-47bb-0310-9956-ffa450edef68
2008-02-01 21:44:10 +00:00
John Dennis Casey ebf314c5a3 [MNG-2145] Adding some more unit tests to protect against these problems in future.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@617330 13f79535-47bb-0310-9956-ffa450edef68
2008-02-01 02:13:36 +00:00
John Dennis Casey 5e8a0a0906 [MNG-2145] Correcting several merge issues between profiles and main build, and also of duplicate plugin declarations within a single build section.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@617325 13f79535-47bb-0310-9956-ffa450edef68
2008-02-01 01:53:21 +00:00
John Dennis Casey f838337b7a Refactor the artifact-scanning logic from the realm manager and the plugin-artifact resolution logic in the plugin manager into two separate classes, one a component and one a static class, to allow the new PluginPrefixLoader to reuse some of both and create a lighter-weight approach to grabbing the PluginDescriptor for build-planning purposes...also avoids some needless error messages during build planning.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@617293 13f79535-47bb-0310-9956-ffa450edef68
2008-01-31 23:29:18 +00:00
John Dennis Casey e670bd3ea3 Adding the concept of recommended stacktrace hints for reported errors, and add the ability to directly access the list of exceptions that actually hit the error reporter (instead of having to use MavenExecutionResult.getExceptions() in conjunction with findReportedException(..) to unwrap them.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@617178 13f79535-47bb-0310-9956-ffa450edef68
2008-01-31 18:17:05 +00:00
John Dennis Casey b7ce1b8c93 Fixing the case where there were exceptions in the build, but for whatever reason they didn't trigger a reactor-manager build failure flag...in cases where there isn't really a project against which to log the error, for instance.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@616968 13f79535-47bb-0310-9956-ffa450edef68
2008-01-31 00:36:26 +00:00
John Dennis Casey f2d7a5aa5f Fine-tuning an error reporting pointcut, and also adding a method to the embedder to allow a third party access to the build plan for a specific project, given a set of goals to be invoked.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@616825 13f79535-47bb-0310-9956-ffa450edef68
2008-01-30 18:13:07 +00:00
John Dennis Casey 6c103fff87 Adding the build-plan instance for each project to the session and MavenExecutionResponse.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@616824 13f79535-47bb-0310-9956-ffa450edef68
2008-01-30 18:11:50 +00:00
John Dennis Casey 30342818f0 Make sure that all calls to buildFromRepository use a normalized List of remote repositories (a list of ArtifactRepository instances, not of model Repository instances, for example)...this should be less of a concern when we can use Java5 generics (someday).
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@616610 13f79535-47bb-0310-9956-ffa450edef68
2008-01-30 04:18:41 +00:00
John Dennis Casey ba9624676d Cleanup use of repositories for resolving plugin dependencies by using a LinkedHashSet to avoid duplicated repository defs (although two defs pointing to the same URL but with different id's will still look like two repos).
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@615004 13f79535-47bb-0310-9956-ffa450edef68
2008-01-24 21:29:12 +00:00
John Dennis Casey b7960dce75 Add a little more safety for people passing in a null activation context.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614923 13f79535-47bb-0310-9956-ffa450edef68
2008-01-24 16:51:34 +00:00
John Dennis Casey 48db18c81b Cleanup on pointcuts to make them slightly more efficient.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614756 13f79535-47bb-0310-9956-ffa450edef68
2008-01-24 00:33:24 +00:00
John Dennis Casey 268d08b8a3 [MNG-3372] Improve error handling where a mojo is referenced but the plugin doesn't contain it (in direct-invocation cases), and fix plugin-version discovery where a plugin pom gives a maven prereq.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614708 13f79535-47bb-0310-9956-ffa450edef68
2008-01-23 22:18:23 +00:00
John Dennis Casey 22e2b4ab35 Commenting out debug pointcut because it causes class sizes to balloon.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614620 13f79535-47bb-0310-9956-ffa450edef68
2008-01-23 18:54:20 +00:00
John Dennis Casey 4a4699c6ad Add a little more information for unparseable POMs during project dependency-tree discovery.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614372 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 23:24:53 +00:00
John Dennis Casey 8d42ef1ce3 Fixing error-reporting pointcut that I broke.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614342 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 22:01:57 +00:00
John Dennis Casey d78402daab separating READMEs so the bootstrap info doesn't get into the distro.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614338 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 21:53:20 +00:00
John Dennis Casey a23ed648fd adding basic bootstrapping instructions to the README.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614337 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 21:52:28 +00:00
John Dennis Casey f2ea396212 Widening the pointcut to catch more potential places where plugin-loading could be a problem.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614330 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 21:33:50 +00:00
John Dennis Casey 8b762300ef Improve diagnosis when no goals are passed in via the request (the goals List is null, not just empty). This can happen when used via the embedder in a non-cli scenario.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614319 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 20:52:11 +00:00
John Dennis Casey 77352f07f7 remove a debugging sysout.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614318 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 20:51:00 +00:00
John Dennis Casey 6d0563662c Improve error reporting bindings for two exception cases, to get away from handler(..) pointcuts which are less versatile for later debugging aspects to manipulate.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614317 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 20:50:16 +00:00
John Dennis Casey 0cee304d37 Restore JDK 1.4 compat, and add a profile to do a strict build that enforces the use of JDK 1.4.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614316 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 20:49:07 +00:00
Vincent Siveton d818cc018b o fixed the superpom version to 2.1
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614085 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 01:27:35 +00:00
Vincent Siveton 309fadbdcc o fixed duplicate license header
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614084 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 01:26:47 +00:00
Milos Kleint 3c61f8a55b 604980 doesn't seem to work when plugin accesses the field by reflection.
See:
Caused by: java.lang.NoSuchFieldException: processedProjectCache
        at java.lang.Class.getDeclaredField(Class.java:1854)
        at org.apache.maven.shared.repository.DefaultRepositoryAssembler.invalidateProccessedProjectCache(DefaultRepositoryAssembler.java:495)

git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613673 13f79535-47bb-0310-9956-ffa450edef68
2008-01-20 20:38:58 +00:00