10919 Commits

Author SHA1 Message Date
Tamas Cservenak
2963769b77 [MNG-7846] Break out of endless loop (#1206)
This is most probably "just" about broken Throwable implementations.
Some override getCause but does not perform checks to what it was inited
as "this" means "not yet inited" actually.

Backport of 36db1e35cac5e8c72bf0c795dd08756e50079e05

---

https://issues.apache.org/jira/browse/MNG-7846
2023-07-19 17:42:02 +02:00
Bruno Volpato
3f37e6a2f6
Bump guava from 31.1-jre to 32.0.1-jre (#1189) 2023-07-11 16:40:53 +02:00
Tamas Cservenak
07491eb9ee [maven-release-plugin] prepare for next development iteration 2023-06-23 15:01:06 +02:00
Tamas Cservenak
2112292682 [maven-release-plugin] prepare release maven-3.9.3 maven-3.9.3 2023-06-23 15:00:37 +02:00
Tamas Cservenak
958112991d
[MNG-7823] Improve plugin validation level parsing (#1182)
Changes:
* always parse it at session start
* hence, will WARN if needed there as well, and will warn once
* do not re-parse and possibly warn always, reuse parsed enum

---

https://issues.apache.org/jira/browse/MNG-7823
2023-06-23 13:04:57 +02:00
Lenny Primak
b050257c05
[MNG-7818] Removed exclusion of hamcrest from JUnit 4 (#1178)
Fix hamcrest versiob to 2.2 but do not remove transitive dep for downstream consumers.

----

https://issues.apache.org/jira/browse/MNG-7818
2023-06-23 11:24:18 +02:00
Tamas Cservenak
917e9561cf
[MNG-7800] Update to resolver 1.9.13 (#1180)
---

https://issues.apache.org/jira/browse/MNG-7800
2023-06-23 10:55:44 +02:00
Hervé Boutemy
ec5e1ce599 update logging documentation 2023-06-19 23:08:59 +02:00
Tamas Cservenak
bd71dd72a9
[MNG-7800] Update resolver to 1.9.12 (#1176)
Resolver 1.9.12

---

https://issues.apache.org/jira/browse/MNG-7800
2023-06-19 11:16:18 +02:00
Tamas Cservenak
98016979eb
[MNG-7816] Update parent to 40, align maven requirements with those from plugins (#1172)
Update parent to 40. Also align plugin requirements with those from parent.

This lowers plugin validation "external" warnings from 12 to 3 (site, plexus-component-metadata and rat).

---

https://issues.apache.org/jira/browse/MNG-7816
2023-06-16 12:58:14 +02:00
Tamas Cservenak
adc0d3bd67
[MNG-7800] Update to Resolver 1.9.11 (#1140)
Resolver 1.9.11 release notes:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353188

---

https://issues.apache.org/jira/browse/MNG-7800
2023-06-16 12:01:42 +02:00
Slawomir Jaranowski
e625606588 [MNG-7811] Plugins verification - reporting improvements 2023-06-16 09:01:13 +02:00
Tamas Cservenak
804b845c4d
[3.9.x] Update some ancient build plugins (#1165)
Changes:
* buildnumber 1.4 -> 3.2.0
* buildhelper 1.12 -> 3.4.0
* checksum ? -> 1.11
2023-06-15 15:09:52 +02:00
Tamas Cservenak
302f55a4b7
MNG-7790] Update lifecycle plugins, take 2 (#1162)
Changes:
* war 3.3.3 -> 3.4.0

---

https://issues.apache.org/jira/browse/MNG-7790
2023-06-15 14:09:16 +02:00
Hervé Boutemy
45262ccd1d [MNG-5987] document goals execution order
fixes #1145
2023-06-14 07:43:55 +02:00
Slawomir Jaranowski
3135553e2d [MNG-7806] Plugins verification - remove used in module(s) report 2023-06-13 20:15:51 +02:00
Tamas Cservenak
7e0fa3ec52
[MNG-7807] Super POM plugin updates (#1152)
Changes:
* antrun: 1.3 -> 3.1.0
* assembly: 2.2-beta-5 -> 3.6.0
* dependency: 2.8 -> 3.6.0
* release: 2.5.3 -> 3.0.1 (and removed config)

---

https://issues.apache.org/jira/browse/MNG-7807
2023-06-12 11:18:41 +02:00
Tamas Cservenak
8695b6d66e
[MNG-7790] Update lifecycle plugins (#1153)
Changes:
install: 3.1.0 -> 3.1.1
deploy: 3.1.0 -> 3.1.1
resources: 3.3.0 -> 3.3.1
compiler: 3.10.1 -> 3.11.0
surefire: 3.0.0 -> 3.1.2
plugin: 3.7.0 -> 3.9.0
wrapper: 3.1.1 -> 3.2.0

---

https://issues.apache.org/jira/browse/MNG-7790
2023-06-12 11:18:10 +02:00
Hervé Boutemy
434ec3b476 fix unintended s/javacocs/Javadocs/ 2023-06-04 18:16:38 +02:00
Hervé Boutemy
e83192cd56 s/JavaDocs/Javadocs/ 2023-06-04 18:09:59 +02:00
Tamas Cservenak
3c29fa5e74
[MNG-7698] Allow comments in .mvn/maven.config (#1141)
Backport of https://github.com/apache/maven/pull/1134

---

https://issues.apache.org/jira/browse/MNG-7698
2023-06-04 07:11:11 +02:00
Guillaume Nodet
76b27ec321 Revert "[MNG-7587] Upgrade to sisu 0.9.0.M2 (#1121)"
This reverts commit 27caa8c120a78ddcbb6c7702ffd6a0cdd72a6a22.
2023-06-02 15:51:49 +02:00
Andreas Dangel
23a3a9127d
[MNG-7795] IllegalArgumentException: 'other' has different root during plugin validation (#1128)
Checks the paths before relativizing them.
Normalize and relative before adding to result
Rename local vars
Apply to ExecutionEventLogger

---

https://issues.apache.org/jira/browse/MNG-7795
2023-06-01 19:05:07 +02:00
Tamas Cservenak
8cc6b2710d
[MNG-7799] Plugin validation may falsely report there are issues (#1136)
But to show no issue, as locality to be shown is not same as reported
issues.

---

https://issues.apache.org/jira/browse/MNG-7799
2023-06-01 19:00:06 +02:00
Tamas Cservenak
1ee2c0111e [MNG-7797] Return BRIEF mode (#1132)
Make BRIEF a legal value again.

---

https://issues.apache.org/jira/browse/MNG-7797
2023-06-01 17:25:31 +02:00
Guillaume Nodet
dd1922bd24
[MNG-7796] Be lenient when using toRealPath (#1131) 2023-05-31 09:40:48 +02:00
Guillaume Nodet
27caa8c120
[MNG-7587] Upgrade to sisu 0.9.0.M2 (#1121) 2023-05-31 09:38:08 +02:00
Tamas Cservenak
39dd668adf
[MNG-7791] Split validation issues by "locality" aspect (#1122)
Changes:
* introduce "internal" (to project) and "external" aspect
* make "inline" default as it was in 3.9.0 and 3.9.1
* remove "default" report level
* summary and verbose reports "internal only" or ALL issues

Example of outputs while building maven-3.8.x:
https://gist.github.com/cstamas/defd6a52939f5a277bf5fc669c01aedb

---

https://issues.apache.org/jira/browse/MNG-7791
2023-05-26 18:19:12 +02:00
Tamas Cservenak
c8d93c0552 [MNG-7789] Cleanup
PR had a leftover (unused but injected member). Removed.

---

https://issues.apache.org/jira/browse/MNG-7789
2023-05-24 12:51:35 +02:00
Tamas Cservenak
6c562a46ee
[MNG-7789] Dependency validation rules used wrong data (#1115)
Refactored and now dropped the unused pluginDescriptor/dependencies validation. Now we have "plugin dependency" (using POM) components to perform dependency validation.

Also, two "inlined" validation from plugin dependencies resolver factored out to components, along with 3 existing moved to newly added (they were wrongly validating descriptor dependencies while intent was to validate "real" dependencies) validators.

---

https://issues.apache.org/jira/browse/MNG-7789
2023-05-24 08:28:24 +02:00
Tamas Cservenak
4d6f16918a [MNG-7786] Fix plugin validation misleading message
Bugfix post merge: all scopes EXCEPT provided and test...

---

https://issues.apache.org/jira/browse/MNG-7786
2023-05-19 18:07:27 +02:00
Tamas Cservenak
1a19a0f58d
[MNG-7788] Plugin Validation Report logged before summary (#1114)
This change uses different technique to hook into "session end", and thus is invoked before ExecutionEventLogger is.

---

https://issues.apache.org/jira/browse/MNG-7788
2023-05-19 17:47:32 +02:00
Tamas Cservenak
e5135698f4
[MNG-7787] Introduce new options for plugin validation report (#1113)
Added NONE and INLINE modes.

---

https://issues.apache.org/jira/browse/MNG-7787
2023-05-19 17:47:03 +02:00
Tamas Cservenak
20910f26db
[MNG-7786] Fix plugin validation misleading message (#1112)
Reword the validation warning and add new check for real plugin dependencies in wrong scopes (do not rely on build-time derived descriptor, but on real data instead).

---

https://issues.apache.org/jira/browse/MNG-7786
2023-05-19 17:46:39 +02:00
Petr Široký
b42f2100a7 [MNG-7743] Make the build work on JDK 20 (#1065)
* [MNG-7743] Make the build work on JDK 20

 * the behaviour before the fix was already pretty confusing. JDK 19 and
   older do not check the presense of '{' in the constructor, so the
   URL object got created, but when converting to file the result would
   be e.g. '/../../src/test/remote-repo' which is completely wrong.
   But it seems the affected tests did not really care, as all of them
   were passing

* Remove forgotten println

Co-authored-by: Yeikel <email@yeikel.com>

* Test with latest JDK

* Do not run ITs with jdk 20, but just the "build itself"

---------

Co-authored-by: Yeikel <email@yeikel.com>
Co-authored-by: Guillaume Nodet <gnodet@gmail.com>
# Conflicts:
#	.github/workflows/maven_build_itself.yml
#	maven-core/src/test/java/org/apache/maven/repository/TestRepositoryConnector.java
2023-05-16 11:40:11 +02:00
Guillaume Nodet
f0c2c65526
[MNG-7785] Clean usage of SessionData (#1111) 2023-05-16 11:17:16 +02:00
Tamas Cservenak
42594643c3 [maven-release-plugin] prepare for next development iteration 2023-05-08 11:05:52 +02:00
Tamas Cservenak
c9616018c7 [maven-release-plugin] prepare release maven-3.9.2 maven-3.9.2 2023-05-08 11:05:23 +02:00
Tamas Cservenak
c2331d37f5 [MNG-7778] - Include suppressed exceptions when logging failures (#1103)
Instead of only including causes, suppressed exceptions are now included
as well. A similar indentation strategy as in
`Throwable.printStackTrace` is used.

Back ported 56674cdc90ee45dc807b44850be5918d1cb3085b

---

https://issues.apache.org/jira/browse/MNG-7778
2023-05-05 17:37:27 +02:00
Tamas Cservenak
79556ddc6b
[MNG-7774] Maven config and command line interpolation (#1098)
Reuse as much as possible from master, but keep existing stuff like multiModuleProjectDirectory alone.

Changes:
* interpolate user properties and arguments
* introduce session.topDirectory and session.rootDirectory expressions (for interpolation only)
* Maven fails to start if any of the new properties are undefined but their use is attempted
* leave everything else untouched

---

https://issues.apache.org/jira/browse/MNG-7774
2023-05-05 14:01:38 +02:00
Tamas Cservenak
7cb87a6686
[MNG-7769] Update Resolver to 1.9.10 (#1101)
---

https://issues.apache.org/jira/browse/MNG-7769
2023-05-05 10:00:41 +02:00
Tamas Cservenak
a2428a6914
[MNG-7767] Tone down plugin validator (#1092)
This change reduces default output making it more compact, and also renames the "levels" to brief, default and verbose.

---

https://issues.apache.org/jira/browse/MNG-7767
2023-04-26 15:51:39 +02:00
Tamas Cservenak
924dbfecf8
[MNG-7670] Update misc dependencies (#1089)
And do align them. Max Level is Java 8, but
we had several conflicts, like HttpClient
(used by Wagon but also by Resolver-Transport-Http).

---

https://issues.apache.org/jira/browse/MNG-7670
2023-04-17 15:23:48 +02:00
Tamas Cservenak
a4b7532535
[MNG-7753] Upgrade to Resolver 1.9.8 (#1077)
Upgrade resolver to 1.9.8 (was 1.9.7).

---

https://issues.apache.org/jira/browse/MNG-7753
2023-04-17 14:22:43 +02:00
Tamas Cservenak
eb7cdefaaa
[MNG-7759] Maven2 plugins will not have even session setter (#1084)
As setter was added in Maven3. Still, this causes unexpected NPE
during plugin execution, while Maven3 should support Maven2
plugins.

---

https://issues.apache.org/jira/browse/MNG-7759
2023-04-13 11:56:13 +02:00
Grzegorz Grzybek
bc138dc3ba
[MNG-7741] Track missing files, plugin and parent pom dependencies (#1058)
Add more information when using `-Dmaven.repo.local.recordReverseTree=true`.

Signed-off-by: Grzegorz Grzybek <gr.grzybek@gmail.com>

---

https://issues.apache.org/jira/browse/MNG-7741
2023-04-12 13:05:59 +02:00
Niels Basjes
0f18470576
[MNG-7750] Fix unwanted interpolation in plugins from profiles. (#1075)
This is ONLY the reproduction of the problem I found.

If you disable the activeProfile (in buildPom and remove the assert) then all checks pass.

If you enable this profile (provided code) then in several places the ${project.basedir} has been interpolated and shows the path of the build and the assertions fail the build.

---

https://issues.apache.org/jira/browse/MNG-7750
2023-04-12 12:26:47 +02:00
Tamas Cservenak
36a4e9ff64
[MNG-7754] Improvement and extension of plugin validation (#1079)
This is general rework of current Maven 3.9.x line how it handles plugin and mojo validations.

Changes:
* added plugin validations for dependencies
* introduced pluginValidationManager that gathers violations
* manager creates a report at build end, with dense and non repeating data
* this is in spirit to lessen already too verbose logging, as current solution would report violations as many times plugin is used in reactor, and that can be many (ie. a plugin from parent for each module)


Example report of Maven 3.9.x build: https://gist.github.com/cstamas/b62fdcd53eaf316123cf183f5a24e6a5

---

https://issues.apache.org/jira/browse/MNG-7754
2023-04-12 11:42:30 +02:00
Slawomir Jaranowski
54b2dc6b3b [MNG-7749] Upgrade animal-sniffer from 1.21 to 1.23 2023-03-27 19:22:04 +02:00
Guillaume Nodet
64227e25a5 [MNG-7720] Simplify code (#1063) 2023-03-23 06:32:46 +01:00