Commit Graph

464 Commits

Author SHA1 Message Date
Guillaume Nodet 53f04f03e3 [MNG-6705] Speep up Artifact version check and Parent interpolation
This closes #260
2019-07-10 21:29:23 +02:00
Michael Osipov 3ac9718f82 [MNG-6655] Add support for "release" qualifier
This closes #249
2019-05-12 18:16:31 +02:00
rfscholte 4ff24e3678 [MNG-6643] Integration test 2019-04-29 23:27:58 +02:00
Hervé Boutemy d34e8fbdc0 [MNG-6631] documented the performance intent 2019-04-27 18:22:32 +02:00
Stefan Oehme 44ad1aafa6 [MNG-6631] - Make DefaultArtifactVersion faster
Use if-statements instead of exception-based control flow.
Throwing exceptions is very expensive and should not be used
for normal flow.
2019-04-27 18:03:38 +02:00
Stefan Oehme ebac165990 [MNG-6630] - Make ComparableVersion faster
By not allocating the canonical representation for equals/hashcode,
but instead using the items we already have. This saves both time
and memory.

I left the canonical field around for testing purposes.
2019-04-27 18:03:31 +02:00
Karl Heinz Marbaise 80c6fe3a01
[MNG-6643] - Version comparison CLI does not work anymore 2019-04-24 19:56:24 +02:00
Gabriel Belingueres f5a13746e1 [MNG-6572] use int or long instead of BigIntegers for little numbers in
ComparableVersion

- Added class IntItem and LongItem for handling numbers lower than 2^31
and 2^63.
- Renamed IntegerItem to BigIntegerItem for handling larger numbers.
- Changed old Stack implementation to LinkedList.
- Changed LinkedList to ArrayDeque.
- Changed thrown RuntimeException by IllegalStateException.
- Ensure numeric values don't have leading zeroes, therefore ensuring
that IntItem, LongItem and BigIntItem represent bigger numeric values,
respectively.
- Only compare item value when the other Item is of the same type.
Otherwise infer comparison result from the quantity of digits of the
numerical value representing the other Item.
- Added tests.
2019-03-17 10:58:26 +01:00
Hervé Boutemy 961746f25f [MNG-6571] separate caches for create from spec and version 2019-02-11 14:31:13 +01:00
Hervé Boutemy 657fbb76cf Revert "[MNG-6571] forgot to put new instance in cache"
This reverts commit 6bd8bb9ba6.
2019-02-06 08:49:04 +01:00
Hervé Boutemy 6bd8bb9ba6 [MNG-6571] forgot to put new instance in cache 2019-02-05 08:34:55 +01:00
Hervé Boutemy 8f9075d3ad [MNG-6571] cache VersionRange instances, they are immutable 2019-02-05 00:38:25 +01:00
Christian Schulte 44826ab446 [MNG-6164] Collections inconsistently immutable
Make non-empty collections returned immutable just like those returned by
java.util.Collections.
2018-10-09 22:12:50 +02:00
Hervé Boutemy 1f83d50db2 fixed typo + little javadoc improvements 2018-08-20 11:25:07 +02:00
Hervé Boutemy f5674713a6 improved documentation 2018-08-12 00:01:17 +02:00
Michael Osipov 9021d66e53 Move ArtifactUtilsTest and friends from maven-compat to maven-artifact 2018-05-08 00:18:49 +02:00
kevin-canadian 14365baabe [MNG-6403] Artifact#VERSION_FILE_PATTERN does not escape period between date and time
This closes #112
2018-05-08 00:14:09 +02:00
Sylwester Lachiewicz d925081794 Reduce number of global checkstyle rule violations
Fix code for following checkstyle rules:
ConstantName, FileLength, InnerAssignment, JavadocType, MagicNumber, MethodLength, MethodName, NewlineAtEndOfFile, ParameterNumber, RedundantThrows, VisibilityModifier

Fixes #149
2018-02-11 11:41:16 +01:00
Hervé Boutemy 0dc70cc691 upgrade m-site-p to 3.7 + Fluido 1.7 + edit button 2018-02-10 11:42:33 +01:00
Hervé Boutemy cf7b0a3ec0 fixed new issues reported by Checkstyle 6.18 2018-02-10 11:42:33 +01:00
Hervé Boutemy 567af0d964 use "java -jar" command 2017-04-12 03:59:44 +02:00
Lubomir Varga 6a93bbea23 Improve Javadoc of ComparableVersion#main()
This closes #108
2017-04-11 16:02:21 +02:00
rfscholte 0e7e3eeb59 [MNG-6176] Javadoc errors prevent release with Java 8
Upgrade to modello-1.9.1
Fix javadoc errors in tests
2017-03-18 12:55:05 +01:00
LuboVarga 10a18cfee7 Added some javadoc
Added javadoc help for making easier to compare two versions in command line.
2017-03-13 13:23:04 +01:00
rfscholte 587317b009 [MNG-6176] Javadoc errors prevent release with Java 8
Upgrade modello to 1.9.0
Fix invalid Javadoc
2017-03-10 16:17:28 +01:00
Michael Osipov b66bdb9cbc [MNG-6150] Javadoc improvements for 3.5.0
* Remove duplicate plugin configuration
* Add workaround for Javadoc locale
* Clean up errors reported by Javadoc 7

Note: Javadoc 8 fails immediately because Modello generates invalid
Javadoc
2017-02-15 17:30:46 +01:00
Alex Henrie 8d91726f78 [MNG-5934] String handling issues identified by PMD 2017-02-11 14:08:24 +01:00
Josh Soref 1740265984 [MNG-6146] Several small stylistic and spelling improvements to code and documentation
Spelling fixes:

* system
* tokenizer
* toolchain
* trailing
* transitive
* unsupported
* version
* artifact
* attachment
* codehaus
* colleagues
* comparison
* concurrency
* configure
* creation
* dependency
* descriptor
* downstream
* efficient
* e.g.
* elements
* encountered
* encounters
* environments
* executed
* explicitly
* happens
* hierarchical
* hierarchy
* ignore
* implemented
* implementers
* independence
* indicates
* inheritance
* inherited
* inherits
* install
* interface
* javascript
* laziness
* management
* maven
* metadata
* mgmt
* minimalist
* nonexistent
* objects
* overridden
* print
* project
* properties
* recessive
* referring
* repository
* representation
* retrieval
* retrieve
* rigorous
* should
* spontaneously
* subsequent

Literal fixes:

*  use static final values

Style fixes:

* use the proper term for char U+002D (-) hyphen(-minus) instead of dash

This closes #100
2017-02-03 10:12:28 +01:00
Michael Osipov 618e62dd33 [MNG-5649] Use Commons Lang's Validate to intercept invalid input
Use wherever possible Validate with consistent messages and exceptions.
2015-10-16 17:32:57 +02:00
Karl Heinz Marbaise 15223116a6 Fixed URL's to issue tracking after transition to
Apache Software Foundation.
2015-07-19 09:53:50 +02:00
Kristian Rosenvold 7badeb5b5b Upgraded to java7 language features 2015-06-20 10:56:07 +02:00
Hervé Boutemy 9afde51528 removed unused import 2014-11-30 23:34:00 +01:00
Hervé Boutemy 14e4885de9 [MNG-5568] fixed edge case version parsing bug causing inconsistent
comparison results
2014-11-30 23:26:12 +01:00
Hervé Boutemy 09d64bdf5c [MNG-5730] added CLI to test Maven version parsing and comparison 2014-11-30 21:57:07 +01:00
Michael Osipov 0343c52601 Trimmed trailing whitespace 2014-11-23 13:04:30 +01:00
Hervé Boutemy 366f57c563 updated parent pom (and fixed issues...) 2014-10-24 01:25:49 +02:00
Hervé Boutemy ca2b26ac5d fix a lot of checkstyle violations for future m-checkstyle-p 2.13, as
proof of concept for misc violations suppressions strategies
2014-08-19 00:17:28 +02:00
Hervé Boutemy 6683e8681f code formatting 2014-06-14 00:08:07 +02:00
Jason van Zyl af1ecd5f00 MNG-5645: When a number is not used in a version correctly, provide a better error.
Submitted by: Phil Pratt-Szeliga
2014-06-11 08:44:42 -04:00
Igor Fedorenko 0f1fcd7066 Revert "MNG-5552 made classifier part of MavenProject.artifactMap key"
This reverts commit f35698c790.

There are plugins that rely on the broken behaviour and I don't have the
time to fix this in backwards compatible way right now.

http://markmail.org/message/gjfuofw5gpsr5yxz

Signed-off-by: Igor Fedorenko <ifedorenko@apache.org>
2014-02-13 21:41:07 -05:00
Hervé Boutemy 4a39c02156 fixed errors reported by Checkstyle 2014-02-08 16:38:31 +01:00
Stephen Connolly 5cf05463a4 [MNG-3626] Small change to artifact version parsing.
Applied patch inspired by patch submitted by Paul Gier.

- Substantially rewrote test case to match current testing style

- Changed the patch to ensure that 4 segment number only version number are not affected... would be nice to pick them up but holding that change back for now
2014-01-07 16:38:01 +00:00
Stephen Connolly 445421051c potential NPE 2014-01-06 10:43:51 +00:00
Stephen Connolly 9bec8d7386 Use chained .append calls rather than concatenate strings in arguments to .append 2014-01-06 10:42:20 +00:00
Igor Fedorenko f35698c790 MNG-5552 made classifier part of MavenProject.artifactMap key
Signed-off-by: Igor Fedorenko <ifedorenko@apache.org>
2013-12-17 12:56:36 -05:00
Arnaud Héritier 21907a74e7 Revert "Code cleanup - It's better (for perfs) to use a chain of append() calls than a unique append with several Strings concatenations"
This reverts commit c8e94a5b08.

Decreases too much the code readibility
2013-06-14 10:29:43 +02:00
Arnaud Héritier 456268af61 Code cleanup -  Remove Redundant Cast(s) 2013-06-11 22:28:48 +02:00
Arnaud Héritier 1f84f8f296 Code cleanup - Maven requires Java 5+ : Replace String.indexOf() by String.contains() 2013-06-11 22:19:20 +02:00
Arnaud Héritier 9e5183f0ad Code cleanup - Various code simplifications (tests, loops, …) 2013-06-11 22:09:51 +02:00
Arnaud Héritier c8e94a5b08 Code cleanup - It's better (for perfs) to use a chain of append() calls than a unique append with several Strings concatenations 2013-06-11 21:58:50 +02:00