Commit Graph

5874 Commits

Author SHA1 Message Date
Jason van Zyl 8077fb59ac o Why would a plugin be executing in its own POM. I think this is a far out case and you shouldn't be testing your plugin with its own POM. The comment is "I guess...". I don't think this is right.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572868 13f79535-47bb-0310-9956-ffa450edef68
2007-09-05 03:44:55 +00:00
Mark Hobson 95759ed0c9 Added .settings to svn:ignore where missing
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572722 13f79535-47bb-0310-9956-ffa450edef68
2007-09-04 15:54:04 +00:00
Jason van Zyl ec5c9dca8f o don't need the maven-script module here any mo
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572476 13f79535-47bb-0310-9956-ffa450edef68
2007-09-04 01:14:00 +00:00
Jason van Zyl 2732a8e83c o moving the scripting stuff out of the core
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572473 13f79535-47bb-0310-9956-ffa450edef68
2007-09-04 01:12:55 +00:00
Jason van Zyl aaaed9cf00 o i'm reworking the error reporting mechanism. i am going to concretely deal with each error we can come up with instead of
the generalization we have.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572463 13f79535-47bb-0310-9956-ffa450edef68
2007-09-04 00:34:08 +00:00
Jason van Zyl ae1501b9f6 o collecting all logging/eventing into the core. i posted a list of possible errors that can occur in the core, the stuff we had was only
partially being use and we problems being emitted with messages like:

  NOTE: One or more purely derived expression elements were detected in this expression. 
  If you continue to get this error after any other expression elements are specified correctly
  please report this issue to the Maven development team.

  I think we have to make a very concerted effort to make useful messages because I'm tired of standing behind Maven
  users and being embarrassed when they look at me and ask "what does that mean?". "i actually have no idea."


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572456 13f79535-47bb-0310-9956-ffa450edef68
2007-09-04 00:05:04 +00:00
Jason van Zyl 2a241710f0 MNG-3182
MNG-3183

First cleanup of the logging code (it is still a mess), but all the console logging has been removed from the Maven component and pushed back
into the CLI code. As a result we now have a way to log to a file easily.



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572408 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 19:33:10 +00:00
Jason van Zyl 441b918f80 o try and start localizing the handling of -f, release poms, and normal poms to the embedder. just too much funk
going on in the core.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572388 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 16:52:37 +00:00
Jason van Zyl cc1ca10d74 o separating out the MavenEmbedderProjectWithExtensionReadingTest which shows that the artifacts handlers must be loaded up-front
in the readProjectWithDependencies method because it is not being done in the core unless projects are executed. So Milos' assertion
  is correct. I'm now looking at a layered approach for project resolution and then execution so that the readProjectWithDependencies
  (which is essential for IDE integration) will yield something that can be pushed into the lifecycle executor. Right now there
  is much duplication which makes the IDE integration crappy.

  Another result of this is trying to create a simple IDE import model that gives back client code the fully resolved, topo sorted
  set of projects which point to binary dependencies outside the reactor, and to source folders inside the reactor. The result will
  be a useful model for all IDE integration, right now everyone is doing their own thing. This model will need hooks for customization
  to take into account turning "workspace resolution" on/off and allow easy overriding of this process.

o Fixed IT0035



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572366 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 15:42:29 +00:00
Jason van Zyl 01f970117a o if we are given a base directory, set the actual POM file in the populator, we can eventually move a lot of the logic that is in the CLI there because it's not CLI specific
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572237 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 06:23:09 +00:00
Jason van Zyl 08ed903945 MNG-1922: Making sure that CLI properties are processed first
o fixing IT0039


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572229 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 03:56:31 +00:00
Jason van Zyl 2425f945fb o adding a validation method to the lifecycle executor so that I can tell users what is wrong before actually trying
to execute the lifecycle. Trying to do this validation shows in detail how tangled some of our code is as I need
  to create the dispatcher in order to create the session which is required to make the reactorManager which 
  is required to get the project required to validate the goal name ... yah.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572214 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 02:35:05 +00:00
Jason van Zyl 5c5c39e8ec o use ${pom.version} and not just ${version}
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572213 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 02:25:41 +00:00
Jason van Zyl ee2c127c76 o wrong directory created
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572211 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 01:41:46 +00:00
Jason van Zyl 5380116b79 MNG-2398: the lifecycle executor exception wasn't being propagated properly.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572210 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 01:39:28 +00:00
Jason van Zyl cfa367dff1 MNG-2871: improve handling for EJB artifacts so that the build will work correctly without having to install the attached client JAR. This should be handled generally but we have no way of know what plugins product attached artifacts that should be handled this way.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572207 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 00:54:19 +00:00
Jason van Zyl 0a36e611f2 o turn on envar support in 2.1, we just can't turn it off now at this point.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572190 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 23:21:23 +00:00
Jason van Zyl 4005482797 MNG-2935: make sure build tanks if the settings are bad (user and global)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572180 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 22:48:43 +00:00
Jason van Zyl 248c7199a0 o remove redundancy
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572041 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 17:25:01 +00:00
Jason van Zyl ed5868ebc7 MNG-3176 Adding a method to create the reactor manager as I want to use it for execution as well as the buildWithDependencies method.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572029 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 16:51:03 +00:00
Jason van Zyl 43dcac45b6 o get the information about whether a project is present from the request as per MNG-3177
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572023 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 16:43:20 +00:00
Jason van Zyl c184a161a3 o we assume there is a project and in DefaultMaven we will turn this off if we determine there is not one.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572021 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 16:39:26 +00:00
Jason van Zyl f6eb49fd0c MNG-3177: capture the presence of a project in the execution request
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572020 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 16:37:49 +00:00
Jason van Zyl acd024eeca o just expanding "rm" to "reactorManager" so there's some idea as to what it is
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572010 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 15:54:43 +00:00
Jason van Zyl 01fb7027ec o just expanding "rm" to "reactorManager" so there's some idea as to what it is
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572007 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 15:50:33 +00:00
Jason van Zyl 42807d7765 o remove debug output
o we don't need any but the super pom now for getting the initial repositories

git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571919 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 02:13:00 +00:00
Jason van Zyl c0ce98d89a o don't need the private method anymore for getting the super pom
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571912 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 01:20:15 +00:00
Jason van Zyl f196fefba4 o as the profile has been removed from the super pom, we do not need to inject or process any profiles
related to it. this great simplifies a lot of code
o caching the super project in the default project builder as it's never going to change now as no profiles
  are inject so it will only have to be constructed once an instance.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571910 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 00:56:30 +00:00
Jason van Zyl e0dbac1e24 o removing the release profile from the Super POM, this is for our particular flavor of releasing and the Super POM should stand as defaults for everyone using Maven. We should never again put profiles into the Super POM, it's just a bad idea. It forces us to inject the profile manager into the reading of the SuperPOM which is also bad.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571907 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 00:11:37 +00:00
Jason van Zyl fc05e3e050 o a project to test the resolution of projects when they are not installed in the local repository. this makes sure that
IDE integration works for newly created projects that have inter-module dependencies.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571905 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 00:02:23 +00:00
Jason van Zyl 9dbe865b6e o the profile manager creation now happens up front in the embedder
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571903 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 00:01:30 +00:00
Jason van Zyl 8ce69da938 o separate out the embedder tests into packages by concern
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571902 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 00:01:02 +00:00
Jason van Zyl e72f6758be o script for creating the eclipse integration jar
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571901 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 00:00:32 +00:00
Jason van Zyl c16665a086 o renaming to populator as I'm going to put a few more pieces that are currently instantiate but should be components like the profile manager. I will move this out of DefaultMaven and put it in the request to be shared in the session.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571897 13f79535-47bb-0310-9956-ffa450edef68
2007-09-01 23:21:29 +00:00
Jason van Zyl c2f29dc0a4 o sorting tests in packages by execution, validation, and project (to come)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571885 13f79535-47bb-0310-9956-ffa450edef68
2007-09-01 21:59:30 +00:00
Jason van Zyl 41977f976a o removing debug
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571883 13f79535-47bb-0310-9956-ffa450edef68
2007-09-01 21:56:32 +00:00
Jason van Zyl 9c88509721 o putting the old style assembly back as it is too much pain to for the uber jar
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571876 13f79535-47bb-0310-9956-ffa450edef68
2007-09-01 21:36:35 +00:00
Jason van Zyl 8b0aaef52f o creating two scripts for convenience for the IntelliJ and Eclipse IDE integrators
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571874 13f79535-47bb-0310-9956-ffa450edef68
2007-09-01 21:28:26 +00:00
Jason van Zyl 0307bf45dc o moved the the embedder directory
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571873 13f79535-47bb-0310-9956-ffa450edef68
2007-09-01 21:27:48 +00:00
Jason van Zyl 884f70085e o integrate changes made in maven-artifact for non fail-fast and request/result usage in the embedder for
use in IDE integration to provide as much feedback as possible.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571862 13f79535-47bb-0310-9956-ffa450edef68
2007-09-01 19:23:17 +00:00
Jason van Zyl 7097dc041a o add a little script for Vlad to build the embedder JAR for the IntelliJ integration
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571861 13f79535-47bb-0310-9956-ffa450edef68
2007-09-01 19:21:20 +00:00
Jason van Zyl 832217cae2 o don't need this with the changes to maven-artifact
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571860 13f79535-47bb-0310-9956-ffa450edef68
2007-09-01 19:20:38 +00:00
Jason van Zyl 874471b4a8 o Checking in a first cut of the resolver that Milos uses in Netbeans which catches all errors during resolution. Otherwise you have the case
where you have created one project that depends on another and the resolution will fail because it's not in the local repository. This
  is obviously dumb because someone is just starting the project. A user should not have to install the projects first in order for
  the resolution to not bomb. Milos has worked around this in a very cunning way and is the way the resolver should work so I'm 
  putting it in here because the IDEA and M2Eclipse integration are desperate for a way to have something that works because without
  this you just lose the whole parts of the UI because Maven just craps out.

  I will migrate this to the decouple Maven Artifact after I build the IDEA and Eclipse integration and test it out.



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571378 13f79535-47bb-0310-9956-ffa450edef68
2007-08-31 04:59:21 +00:00
Jason van Zyl a227a73569 o a little more documentation about the profile required for IntelliJ
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571375 13f79535-47bb-0310-9956-ffa450edef68
2007-08-31 04:48:02 +00:00
Jason van Zyl 34b4b59c7c o creating a profile for the embedder that needs to be created for IntelliJ
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571374 13f79535-47bb-0310-9956-ffa450edef68
2007-08-31 04:43:57 +00:00
Carlos Sanchez Gonzalez 9ce4680aab Use the new maven-artifact
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571188 13f79535-47bb-0310-9956-ffa450edef68
2007-08-30 14:36:59 +00:00
Carlos Sanchez Gonzalez a8f5da6950 Close properly the readers
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571120 13f79535-47bb-0310-9956-ffa450edef68
2007-08-30 12:00:09 +00:00
Carlos Sanchez Gonzalez fc1dad0d22 Remove comment
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571108 13f79535-47bb-0310-9956-ffa450edef68
2007-08-30 10:37:05 +00:00
Carlos Sanchez Gonzalez fd64c2db2a Close properly the readers
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571106 13f79535-47bb-0310-9956-ffa450edef68
2007-08-30 10:34:35 +00:00
Carlos Sanchez Gonzalez 0a0bc73d66 Remove unneeded repositories
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@570990 13f79535-47bb-0310-9956-ffa450edef68
2007-08-30 00:08:23 +00:00