Commit Graph

6169 Commits

Author SHA1 Message Date
John Dennis Casey f838337b7a Refactor the artifact-scanning logic from the realm manager and the plugin-artifact resolution logic in the plugin manager into two separate classes, one a component and one a static class, to allow the new PluginPrefixLoader to reuse some of both and create a lighter-weight approach to grabbing the PluginDescriptor for build-planning purposes...also avoids some needless error messages during build planning.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@617293 13f79535-47bb-0310-9956-ffa450edef68
2008-01-31 23:29:18 +00:00
John Dennis Casey e670bd3ea3 Adding the concept of recommended stacktrace hints for reported errors, and add the ability to directly access the list of exceptions that actually hit the error reporter (instead of having to use MavenExecutionResult.getExceptions() in conjunction with findReportedException(..) to unwrap them.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@617178 13f79535-47bb-0310-9956-ffa450edef68
2008-01-31 18:17:05 +00:00
John Dennis Casey b7ce1b8c93 Fixing the case where there were exceptions in the build, but for whatever reason they didn't trigger a reactor-manager build failure flag...in cases where there isn't really a project against which to log the error, for instance.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@616968 13f79535-47bb-0310-9956-ffa450edef68
2008-01-31 00:36:26 +00:00
John Dennis Casey f2d7a5aa5f Fine-tuning an error reporting pointcut, and also adding a method to the embedder to allow a third party access to the build plan for a specific project, given a set of goals to be invoked.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@616825 13f79535-47bb-0310-9956-ffa450edef68
2008-01-30 18:13:07 +00:00
John Dennis Casey 6c103fff87 Adding the build-plan instance for each project to the session and MavenExecutionResponse.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@616824 13f79535-47bb-0310-9956-ffa450edef68
2008-01-30 18:11:50 +00:00
John Dennis Casey 30342818f0 Make sure that all calls to buildFromRepository use a normalized List of remote repositories (a list of ArtifactRepository instances, not of model Repository instances, for example)...this should be less of a concern when we can use Java5 generics (someday).
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@616610 13f79535-47bb-0310-9956-ffa450edef68
2008-01-30 04:18:41 +00:00
John Dennis Casey ba9624676d Cleanup use of repositories for resolving plugin dependencies by using a LinkedHashSet to avoid duplicated repository defs (although two defs pointing to the same URL but with different id's will still look like two repos).
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@615004 13f79535-47bb-0310-9956-ffa450edef68
2008-01-24 21:29:12 +00:00
John Dennis Casey b7960dce75 Add a little more safety for people passing in a null activation context.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614923 13f79535-47bb-0310-9956-ffa450edef68
2008-01-24 16:51:34 +00:00
John Dennis Casey 48db18c81b Cleanup on pointcuts to make them slightly more efficient.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614756 13f79535-47bb-0310-9956-ffa450edef68
2008-01-24 00:33:24 +00:00
John Dennis Casey 268d08b8a3 [MNG-3372] Improve error handling where a mojo is referenced but the plugin doesn't contain it (in direct-invocation cases), and fix plugin-version discovery where a plugin pom gives a maven prereq.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614708 13f79535-47bb-0310-9956-ffa450edef68
2008-01-23 22:18:23 +00:00
John Dennis Casey 22e2b4ab35 Commenting out debug pointcut because it causes class sizes to balloon.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614620 13f79535-47bb-0310-9956-ffa450edef68
2008-01-23 18:54:20 +00:00
John Dennis Casey 4a4699c6ad Add a little more information for unparseable POMs during project dependency-tree discovery.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614372 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 23:24:53 +00:00
John Dennis Casey 8d42ef1ce3 Fixing error-reporting pointcut that I broke.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614342 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 22:01:57 +00:00
John Dennis Casey d78402daab separating READMEs so the bootstrap info doesn't get into the distro.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614338 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 21:53:20 +00:00
John Dennis Casey a23ed648fd adding basic bootstrapping instructions to the README.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614337 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 21:52:28 +00:00
John Dennis Casey f2ea396212 Widening the pointcut to catch more potential places where plugin-loading could be a problem.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614330 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 21:33:50 +00:00
John Dennis Casey 8b762300ef Improve diagnosis when no goals are passed in via the request (the goals List is null, not just empty). This can happen when used via the embedder in a non-cli scenario.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614319 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 20:52:11 +00:00
John Dennis Casey 77352f07f7 remove a debugging sysout.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614318 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 20:51:00 +00:00
John Dennis Casey 6d0563662c Improve error reporting bindings for two exception cases, to get away from handler(..) pointcuts which are less versatile for later debugging aspects to manipulate.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614317 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 20:50:16 +00:00
John Dennis Casey 0cee304d37 Restore JDK 1.4 compat, and add a profile to do a strict build that enforces the use of JDK 1.4.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614316 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 20:49:07 +00:00
Vincent Siveton d818cc018b o fixed the superpom version to 2.1
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614085 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 01:27:35 +00:00
Vincent Siveton 309fadbdcc o fixed duplicate license header
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614084 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 01:26:47 +00:00
Milos Kleint 3c61f8a55b 604980 doesn't seem to work when plugin accesses the field by reflection.
See:
Caused by: java.lang.NoSuchFieldException: processedProjectCache
        at java.lang.Class.getDeclaredField(Class.java:1854)
        at org.apache.maven.shared.repository.DefaultRepositoryAssembler.invalidateProccessedProjectCache(DefaultRepositoryAssembler.java:495)

git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613673 13f79535-47bb-0310-9956-ffa450edef68
2008-01-20 20:38:58 +00:00
Milos Kleint c8b4b7294c the reactorpoms modules need to be checked recursively to satisfy this case:
parent --> submodule -->subsubmodule --> subsubsubmodule where parent defines a plugin with extensions in pluginManagement section and the subsubmodule is the one using the  plugin.

git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613662 13f79535-47bb-0310-9956-ffa450edef68
2008-01-20 19:54:09 +00:00
Jason van Zyl b2dab2e0d5 o adding the backport jars as well
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613508 13f79535-47bb-0310-9956-ffa450edef68
2008-01-20 05:10:01 +00:00
Jason van Zyl 3095bcd54f o add the retrotranslator artifacts for the bootstrap
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613506 13f79535-47bb-0310-9956-ffa450edef68
2008-01-20 05:00:58 +00:00
Jason van Zyl 291d6a9199 o patch from Oleg for metadata processing required by a maven-artifact provider
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613467 13f79535-47bb-0310-9956-ffa450edef68
2008-01-19 22:05:01 +00:00
Milos Kleint 863d1fcb8c when version is defined in plugin-management section, we need to use it in mojo binding.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613256 13f79535-47bb-0310-9956-ffa450edef68
2008-01-18 20:20:46 +00:00
John Dennis Casey b731e783fa Adding new unit test for non-recursive run, where one of the modules that should NOT be read contains an invalid parent reference.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613254 13f79535-47bb-0310-9956-ffa450edef68
2008-01-18 20:14:44 +00:00
John Dennis Casey 3dbe70a25c bumping plexus-container-default to latest release version.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613239 13f79535-47bb-0310-9956-ffa450edef68
2008-01-18 19:45:31 +00:00
John Dennis Casey 776a944764 Renaming tests for error-reporting, so they're (hopefully) short enough for windows users.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613227 13f79535-47bb-0310-9956-ffa450edef68
2008-01-18 19:06:04 +00:00
Milos Kleint 73c4f0c651 use 1.2-alpha-12 of plexus-classworlds
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613224 13f79535-47bb-0310-9956-ffa450edef68
2008-01-18 18:56:00 +00:00
John Dennis Casey a0297f1d5b Fix some problems with the CLI reporter when the reactor manager hasn't been created yet (in cases where reading the projects for the reactor failed, for instance).
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613039 13f79535-47bb-0310-9956-ffa450edef68
2008-01-18 01:56:20 +00:00
John Dennis Casey facb56d1eb Fixing compilation errors.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613035 13f79535-47bb-0310-9956-ffa450edef68
2008-01-18 01:38:37 +00:00
John Dennis Casey 89f482ac37 last of the error-reporting unit tests, and an additional error type to handle modules that are referenced but don't exist, which should stop the build. All tests pass.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613032 13f79535-47bb-0310-9956-ffa450edef68
2008-01-18 01:27:23 +00:00
Vincent Siveton a16c3bf4a8 o merged from r613001 (MNG-3365: Remove trailing-backslashes from M2_HOME in mvn.bat)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613002 13f79535-47bb-0310-9956-ffa450edef68
2008-01-17 22:55:12 +00:00
John Dennis Casey 724b3db3c4 Adding more error-reporting unit tests.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612920 13f79535-47bb-0310-9956-ffa450edef68
2008-01-17 18:26:35 +00:00
John Dennis Casey 4bcfd7c5a5 more unit tests for error reporting on plugins-as-extensions.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612895 13f79535-47bb-0310-9956-ffa450edef68
2008-01-17 18:01:29 +00:00
John Dennis Casey e5c11f67c1 make things more friendly to non-standard settings and local-repo locations.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612658 13f79535-47bb-0310-9956-ffa450edef68
2008-01-17 00:37:19 +00:00
John Dennis Casey c1b1ff061e Trying to make the FileProfileActivator unit test more resilient to alternative local repository locations.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612645 13f79535-47bb-0310-9956-ffa450edef68
2008-01-16 23:50:50 +00:00
John Dennis Casey 372207fe19 Adding more logging for FileProfileActivator, to debug the build on ci.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612638 13f79535-47bb-0310-9956-ffa450edef68
2008-01-16 23:45:00 +00:00
John Dennis Casey 4e84caabf2 Adding more logging for FileProfileActivator, to debug the build on ci.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612634 13f79535-47bb-0310-9956-ffa450edef68
2008-01-16 23:41:00 +00:00
John Dennis Casey a0827ce0b6 Adding logging for FileProfileActivator, to debug the build.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612629 13f79535-47bb-0310-9956-ffa450edef68
2008-01-16 23:37:38 +00:00
John Dennis Casey 0c61152546 More unit tests, this time for plugin-related error messages.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612592 13f79535-47bb-0310-9956-ffa450edef68
2008-01-16 22:17:56 +00:00
John Dennis Casey 835488bada Adding the remaining project-related error reporting unit tests.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612493 13f79535-47bb-0310-9956-ffa450edef68
2008-01-16 15:55:08 +00:00
John Dennis Casey 1c235317d7 Adding more unit tests for error reporting. Almost done with project-based errors now.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612333 13f79535-47bb-0310-9956-ffa450edef68
2008-01-16 02:20:08 +00:00
John Dennis Casey 47b1dda978 Switch to forkmode=once to try to escape problems with 2.0.x build (possibly polluting the classpath with its own plexus container api version?)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612209 13f79535-47bb-0310-9956-ffa450edef68
2008-01-15 20:37:38 +00:00
John Dennis Casey ca169d0262 Refactor management of activated, deactivated, and default-activated profile ids, so the context tracks all of that stuff.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612186 13f79535-47bb-0310-9956-ffa450edef68
2008-01-15 18:34:58 +00:00
John Dennis Casey a35ec37b54 pinning plugin-api version to 2.0, as this is immaterial to the test.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612168 13f79535-47bb-0310-9956-ffa450edef68
2008-01-15 17:35:59 +00:00
John Dennis Casey 182b93e6b7 Adding pinned versions for plugins that are used in the error-reporting tests.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612149 13f79535-47bb-0310-9956-ffa450edef68
2008-01-15 16:34:16 +00:00