NifiRegistryFlowRegistryClient defines the PropertyDescriptor PROPERTY_URL name as small case "url". The map bases on the name property of the PropertyDescriptor object. Here searching with uppercase value of "URL" causes the map lookup to fail and cause a NPE later on. Therefore, it is changed as "url"
NIFI-10787 - Added constant for property descriptor "url" in NiFiRegistryFlowMapper to make it more clear.
NIFI-10787 - Added change to unit test.
NIFI-10787 - Updated unit test to validate that NiFi registry url is being set and retrieved.
Signed-off-by: Nathan Gough <thenatog@gmail.com>
This closes#6655.
NIFI-10703 - Also setting the maxEventDrivenThreadCount on the controller when using a versioned flow.
NIFI-10703 - Corrected to use getMaxEventDrivenThreadCount(), set a default value for event driven thread count in VersionedDataflow
NIFI-10703 - Updated log message for setMaxThreadCount in FlowController.java
NIFI-10703 - Updated default value for maxEventDrivenThreadCount
NIFI-10703 - Set private for DEFAULT_MAX_EVENT_DRIVEN_THREAD_COUNT
Signed-off-by: Matthew Burgess <mattyb149@apache.org>
This closes#6638
NIFI-10243: fix typos
NIFI-10243: re-ordered property in ControlRate
NIFI-10243: minor updates to make code cleaner based on PR comments
Signed-off-by: Nathan Gough <thenatog@gmail.com>
This closes#6506.
- Upgraded Clojure from 1.10.1 to 1.11.1
- Upgraded Groovy from 3.0.8 to 3.0.13
- Upgraded JRuby from 9.3.8.0 to 9.3.9.0
This closes#6657
Signed-off-by: David Handermann <exceptionfactory@apache.org>
- Improved ByteArrayMessageChannelHandler to call BlockingQueue.offer() while the server is not shutting down
- Improved NettyEventServer to use ChannelFuture.await() for closing the channel to allow shutdown to proceed
- Added test method for EventDroppedException handling
Signed-off-by: Nathan Gough <thenatog@gmail.com>
This closes#6634.
NIFI-10317 refactoring to remove repeated conversions to string from char
NIFI-10317 correctly handle null values: null vs "null"
NIFI-10317 adding test
NIFI-10317 - Updated ConsumeAMQPTest to test for null and empty header values.
NIFI-10317 - Updated ConsumeAMQPTest to use hard coded string values when testing. Made convertMapToString() private.
Signed-off-by: Nathan Gough <thenatog@gmail.com>
This closes#6382.
- Added test class for ListenBeats
- Removed unnecessary dependencies
- Implemented BatchDecoder for reading Beats Protocol frames
- Refactored protocol and handler classes
Signed-off-by: Nathan Gough <thenatog@gmail.com>
This closes#6608.
- Added FilteringStrategy argument to Server Factory for ListenSyslog
- Set quick shutdown quiet period for ListenSyslog and TestListenSyslog
- Added test method for batched messages with empty message included
NIFI-9398 processor verification integration-tests for nifi-elasticsearch-restapi-processors using common nifi-elasticsearch-test-utils refactored from nifi-elasticsearch-client-service
NIFI-9398 fail index exists verification for Elasticsearch processors whose operations would not create the index if it doesn't already exist
This closes#6544
Signed-off-by: Mike Thomsen <mthomsen@apache.org>
- Added Testcontainers for Neo4j integration tests
This closes#6559
Co-authored-by: David Handermann <exceptionfactory@apache.org>
Signed-off-by: David Handermann <exceptionfactory@apache.org>
Co-authored-by: Nissim Shiman <nshiman@yahoo.com>
Co-authored-by: dan-s1 <dstieg1@gmail.com>
NIFI-10287 changes for code review
NIFI-10287 modification based on reviewer comment
Signed-off-by: Matthew Burgess <mattyb149@apache.org>
This closes#6254
- Only restart ports if their scheduledState is Running.
- Adding unit tests.
- Fixing unit test to properly verify Port isn't restarted.
Signed-off-by: Nathan Gough <thenatog@gmail.com>
This closes#6582.
NIFI-10691 Removed duplicate Bouncy Castle dependencies from nifi-standard-processors
This closes#6571
Signed-off-by: David Handermann <exceptionfactory@apache.org>
- Defined PrivateKeyService in nifi-key-service-api
- Implemented StandardPrivateKeyService using Bouncy Castle library
NIFI-10667 Improved custom validation to avoid repetitive reads
NIFI-10667 Added onPropertyModified() to clear Key Reference for validation
Signed-off-by: Nathan Gough <thenatog@gmail.com>
This closes#6553.
- Adjustment avoids non-deterministic warnings related to HashMap ordering
This closes#6516
Signed-off-by: David Handermann <exceptionfactory@apache.org>
- Upgraded Jettison in nifi-framework-bundle
- Upgraded Jettison in nifi-registry-ranger
- Upgraded Jettison in nifi-spark-bundle
This closes#6548
This closes#6549
This closes#6550
Signed-off-by: David Handermann <exceptionfactory@apache.org>
- Marked nifi-iceberg-services-api as provided
- Marked multiple Hadoop and Hive dependencies as provided to avoid duplicate inclusion in nifi-iceberg-processors-nar
Signed-off-by: Matthew Burgess <mattyb149@apache.org>
This closes#6535
- Followed dependency override approach from nifi-hive-bundle based on Hive dependencies
NIFI-10651 Removed unnecessary Calcite dependency references
Signed-off-by: Matthew Burgess <mattyb149@apache.org>
This closes#6533
- Refactored unit test methods for reuse of shared operations
- Added link to JSLT Tutorial in property description
Signed-off-by: Matthew Burgess <mattyb149@apache.org>
This closes#6546
- Added org.apache.commons.text.version property in root Maven configuration
- Removed direct version references in favor of managed dependency version
Signed-off-by: Nathan Gough <thenatog@gmail.com>
This closes#6531.
- Updated XmlFlowSynchronizer to filter parsed Sensitive Dynamic Property Names using dynamic status of component Property Descriptor
- Lack of access to the Component Property Descriptor when parsing DOM elements required subsequent dynamic status filtering
ExecuteGroovyScript's "Additional classpath" property treats commas and semicolons
as delimiters
Signed-off-by: Matthew Burgess <mattyb149@apache.org>
This closes#6523
NIFI-10437 Removed old Maven Elasticsearch integration testing plugin and replaced with Testcontainers.
NIFI-10437 Converted TestSchemaRegistry from Groovy to Java.
NIFI-10437 Converted TestElasticsearchClientService from Groovy to Java.
NIFI-10437 Converted a unit test from Groovy to Java.
NIFI-10437 Converted a unit test from Groovy to Java.
NIFI-10437 Converted ElasticSearchLookupService_IT from Groovy to Java.
NIFI-10437 Converted ElasticSearchClientService_IT from Groovy to Java.
NIFI-10437 Migrated to Testcontainers.
NIFI-10437 Converted all nifi-elasticsearch-restapi-processors unit tests from Groovy to Java.
Signed-off-by: Chris Sampson <chris.sampson82@gmail.com>
This closes#6487
- Corrected logging statements with placeholders instead of concatenation
- Removed unused NiFiServerStub
Signed-off-by: Matthew Burgess <mattyb149@apache.org>
This closes#6513
This closes#6477
Co-authored-by: Andrew Lim <andrewlim.apache@gmail.com>
Co-authored-by: David Handermann <exceptionfactory@apache.org>
Signed-off-by: David Handermann <exceptionfactory@apache.org>
This closes#6414
Co-authored-by: Nissim Shiman <nshiman@yahoo.com>
Co-authored-by: Jon Shoemaker <jon.l.shoemaker@systolic.com>
Signed-off-by: David Handermann <exceptionfactory@apache.org>
- Adding dynamic property annotation on a number of extensions that were missing it.
Signed-off-by: Matthew Burgess <mattyb149@apache.org>
This closes#6501
- Added simple unit test for HandleHttpRequest to run without requests
- Removed cleanup integration test method for HandleHttpRequest
Signed-off-by: Nathan Gough <thenatog@gmail.com>
This closes#6465.
- The default configuration prioritizes ssh-rsa when Key Algorithms Allowed is not specified
Signed-off-by: Nathan Gough <thenatog@gmail.com>
This closes#6479.
* NIFI-10577 Fixed Sensitive Checkbox rendering for Fetch Parameters
- Corrected rendering of Sensitive status checkbox on Firefox using standard nf-checkbox
* NIFI-10577 Corrected canvas rendering in Safari
Merged #6473 in main.
* NIFI-10566: update availability text in Controller Settings
- fix link in controller service referencing a parameter provider
* add Registry Clients to the availability message
This closes#6463
- Made sure to check TCP is protocol set before using SSL Context Service during runtime
This closes#6441
Signed-off-by: David Handermann <exceptionfactory@apache.org>
Adding provided scope to api dependency in nifi-standard-parameter-providers module
Adding additional documentation, other minor code cleanup
Correcting error handling in StandardParameterProviderNode, updating additional details for DatabaseParameterProvider
Correcting null columm value handling
NIFI-9402: Fixed Checkstyle violation
Signed-off-by: Matthew Burgess <mattyb149@apache.org>
This closes#6391
- Upgraded Azure Event Hubs components from legacy version 3 to current version 5
- Refactored Azure dependencies using azure-sdk-bom
- Merged nifi-azure-record-sink-nar with nifi-azure-nar
- Refactored PutAzureCosmosDBRecordTest to use Jackson instead of Gson
This closes#6319.
Signed-off-by: Peter Turcsanyi <turcsanyi@apache.org>
* NIFI-10542: set sensitivity for new parameters in a synced parameter context
* show removed or missing but referenced parameters with tooltip in the selectable parameters table
- remove default parameter value
* address review feedback
- fix showing a referencing icon for a missing but removed parameter
* fix discovering new parameters
This closes#6446
* init commit
* remove test string
* display only class name for types combo
* remove commented code
* add UI support for dynamic properties
* add support for controller services
* address review feedback:
* fix syntax error
* remove console logs
* move contents of editRegistry into callback
* add name and description fields back to edit dialog
* add referencing component logic for registry clients
* implement reload logic
* more review findings
* increase size of description textarea in config
* remove location column from registry table
* remove commented out code
* post-rebase tweaks
* change if condition from assignment to evaluation
* add missing semicolons
* refactor new registry initialization into function
* more feedback addressed
* fix rebase error around controller service reference
* render registry references in their own list
* remove duplicate updateValidationError function
* remove TODO comment
* expose reload through nfSettings public variable
* show add registry dialog only after available types returns
* fix css class name
This closes#6437
* NIFI-9514 - Add UI support for Parameter Providers in Controller Services
* - Fix a dialog closing issue
* - Hide fetch parameters button if there are config errors
* - Update Fetch Parameters dialog with new UX
- Implement checkbox logic for Selectable Parameters table
* - add createNewParameterContext property to track if group will be created as a new parameter context
- update fetch parameters dialog views for editing and after applying changes
- show affected referencing components after applying changes
- disable apply button if no parameter contexts will be updated
- refactor showing and hiding fetched parameters and selectable parameters tables logic
- add tooltip for parameter context icon
* - update parameter contexts view for provided contexts
* - add affected referencing components after applying fetched parameters
- add referencing parameter contexts to the provider settings tab
- update checkbox style in the selectable parameters table
- fix updating the referencing components border
- fix lint errors
* - fix selectable parameters table checkbox styles
* - fix hasParameterContextChanged checks
- checkbox style tweaks
* - add status bar to fetch parameters dialog
* - more style tweaks and remove unnecessary code
* - fix the selectable parameters table not saving and loading correctly
* - add tooltips
- fix styles
* - link from the parameter context to the associated parameter provider
* 9514: support navigating to the controller service created in parameter providers
* fix bulletins format in status bar
* address review feedback
- manage permissions for parameter providers
- disable/enable Fetch Parameters dialog Apply button
* manage authorizations to access parameter providers and parameter contexts
* fix lint errors
* fix and refactor hasGroupsChanged to determine the Apply button state
* new parameter context name input cannot be empty in Fetch Parameters dialog
* address review feedback
* fix duplicate code
* more fixes
* update fetch parameters checkbox states
* replace slickgrid checkbox selection plugin with custom implementation for different selection types
- check for affected parameters using the parameter status
* fixed showing the correct referencing components when switching groups
* fixed selectable parameters table shifting contents on row selection
* leverage slickgrid onClick to set user-selected parameter sensitivities in the selectable parameters table
* fix statusbar bulletins in processor details
- fix updating borders for referencing components
- update referencing parameter icon
- update table title in fetch parameters dialog
* address review feedback
* populate controller services referencing components of a referenced provider
- update controller services tab name
* showing parameter providers in CS controller service
* update tooltip messages in fetch parameters dialog
- fix dialog height to make room for the status bar
* reload the parameter providers table after a referenced parameter provider change in controller services
- fix conditions for enabling/disabling fetch parameters dialog Apply button
- add affected components no permissions message in the dialog
* fix always reloading the parameter providers table
- fix disableApplyButton checks
- add dialog message for a missing new parameter context name
* remove extra reload
* more fixes for disableApplyButton
- fixed styles for dialog message
* add a check in disableApplyButton for changed parameter values that are not referenced
- add changed value icon for parameters that are not referenced
- fix border on the referencing affected components container
* removed unnused plugins
This closes#5671
* NIFI-10473: Removing referencing components check on param provider fetch
* NIFI-10473: Adding parameter status DTO to ParameterProviderDTO
* Allowing parameterStatus to be populated even when no parameters were updated
* Adding ParameterStatus enum for parameter fetching
* Adding MISSING_BUT_REFERENCED ParameterStatus
This closes#6388
- NIFI-10518: Adding intended state to ScheduledStateChangeListener
- Notifying of scheduled state change when transitionComponentState is called
- Notifying scheduled state change when reporting task state is changed
- Notifying scheduledState changes for remote group port start/stop components calls
- Removing org.apache.httpcomponents:httpclient from nifi-web-api avoids Linkage Errors with Sensitive Property Providers
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>
This closes#6423.
- Refactored nifi-vault-utils to nifi-hashicorp-vault-api and nifi-hashcorp-vault modules
- Added HashiCorpVaultClientService and Standard implementation
This closes#6304
Signed-off-by: David Handermann <exceptionfactory@apache.org>
- Updated Admin Guide with section on Logging Configuration and Deprecation Logging
- Updated Developer Guide with section on Deprecating Components and Features
- Added Deprecation Logging when adding components marked with DeprecationNotice to the Flow Configuration
- Added Deprecation Logging on deprecated methods in standard Controller Service implementations
- Removed integration tests for deprecated PersistentProvenanceRepository
- Updated logging and added documentation on minor upgrade steps
- Updated logging for HDFSNarProvider and RocksDB Repository
This closes#6390
Signed-off-by: Paul Grey <greyp@apache.org>
- Replaced individual AWS SDK versions with root managed dependency version
- Set AWS SDK 1 version to 1.12.299
- Set AWS SDK 2 version to 2.17.270
- Suppressed false positive dependency vulnerability for aws-sdk-swf-libraries
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>
This closes#6405.
NIFI-2827 Update CompressContent.java to use zstd compression format
NIFI-2827 Update test cases for CompressContent.java to include zstd format
NIFI-2827 Update JsonRecordSetWriter.java to enable zstd compression format
This closes#6294
Signed-off-by: Mike Thomsen <mthomsen@apache.org>
- Updated standard user interface error handler to clear the Access-Token-Expiration item from Session Storage when receiving an error with the WWW-Authenticate Header indicating a problem with the Bearer Token
Signed-off-by: Nathan Gough <thenatog@gmail.com>
This closes#6334.
- Added nifi-deprecation-log module with interface and implementation using SLF4J
- Updated standard logback.xml with nifi-deprecation.log appender
- Updated NiFiLegacyCipherProvider with deprecation logging
- Set Size, Time Policy, and Total Size Limit for Deprecation Log
This closes#6300
Signed-off-by: Paul Grey <greyp@apache.org>