1385 Commits

Author SHA1 Message Date
Donald Woods
ee314e9586 OPENJPA-1700 FindBugs - ignore this warning and rollback previous changes in r956705
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956959 13f79535-47bb-0310-9956-ffa450edef68
2010-06-22 17:27:41 +00:00
Donald Woods
e3075014f3 OPENJPA-1700 FindBugs - Should be a static inner class. This class is an inner class, but does not use its embedded reference to the object which created it.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956952 13f79535-47bb-0310-9956-ffa450edef68
2010-06-22 16:55:56 +00:00
Donald Woods
d5fc007b70 OPENJPA-1700 FindBugs - Inefficient use of keySet iterator instead of entrySet iterator
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956939 13f79535-47bb-0310-9956-ffa450edef68
2010-06-22 16:13:27 +00:00
Donald Woods
2747862d5f OPENJPA-1700 FindBugs - Inefficient use of keySet iterator instead of entrySet iterator. Noticed this duplciated code while looking to resolve the entrySet warning.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956938 13f79535-47bb-0310-9956-ffa450edef68
2010-06-22 16:13:04 +00:00
Donald Woods
75bd5fe6a7 OPENJPA-1700 FindBugs - Inefficient use of keySet iterator instead of entrySet iterator. Also, inefficient use of temporary Map when results can be used immediately
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956883 13f79535-47bb-0310-9956-ffa450edef68
2010-06-22 13:31:01 +00:00
Donald Woods
af772a734b OPENJPA-1700 FindBugs - Method invokes inefficient new String() constructor
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956878 13f79535-47bb-0310-9956-ffa450edef68
2010-06-22 13:16:01 +00:00
Donald Woods
c047527a4f OPENJPA-1700 FindBugs - Method may fail to clean up stream or resource
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956757 13f79535-47bb-0310-9956-ffa450edef68
2010-06-22 01:20:03 +00:00
Donald Woods
40d808099d OPENJPA-1700 FindBugs - Usage of GetResource may be unsafe if class is extended. Use DBDictionary.class.getResourceAsStream() like other places in the code.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956705 13f79535-47bb-0310-9956-ffa450edef68
2010-06-21 21:32:46 +00:00
Donald Woods
18e329cf4e OPENJPA-1700 FindBugs - Suspicious reference comparison of Boolean values
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956702 13f79535-47bb-0310-9956-ffa450edef68
2010-06-21 21:22:11 +00:00
Donald Woods
702fb78b14 OPENJPA-1700 FindBugs - equals() method does not check for null argument
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956696 13f79535-47bb-0310-9956-ffa450edef68
2010-06-21 21:16:37 +00:00
Donald Woods
004cbd9644 OPENJPA-1700 FindBugs - extraneous checks for null as a NPE would have already occurred
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956693 13f79535-47bb-0310-9956-ffa450edef68
2010-06-21 21:01:34 +00:00
Donald Woods
5e8b5afc72 OPENJPA-1700 FindBugs - was checking array and not member for null
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956687 13f79535-47bb-0310-9956-ffa450edef68
2010-06-21 20:39:47 +00:00
Donald Woods
2e827c5eab OPENJPA-1700 FindBugs - Possible null pointer dereference; There is a branch where em1 would not get set.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955402 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 21:31:23 +00:00
Fay Wang
34a865c5bd OPENJPA-1699: clean up code
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955400 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 21:28:11 +00:00
Donald Woods
bc67e474bc OPENJPA-1700 FindBugs - Possible null pointer dereference; the clss cehck against null 3 lines up doesn't protect against a null value here
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955399 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 21:25:44 +00:00
Donald Woods
13002d2025 OPENJPA-1700 FindBugs - Possible null pointer dereference; strName could be set to null.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955394 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 21:17:57 +00:00
Donald Woods
cb099098ca OPENJPA-1700 FindBugs - Possible null pointer dereference; Could be caused by using bitwise instead of logical AND. This could also have lead to unexpected code behavior.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955382 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 21:03:02 +00:00
Donald Woods
f82b866318 OPENJPA-1700 FindBugs - Null pointer dereference; changeRow was not being set before being used.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955381 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 20:59:58 +00:00
Donald Woods
8084af124c OPENJPA-1700 FindBugs - Call to equals() comparing different types. Make explicit call to getName() instead of relying on toString() to call it.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955379 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 20:56:15 +00:00
Fay Wang
7450df02a4 OPENJPA-1699: Streaming LOB support for DB2
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955283 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 16:07:14 +00:00
Michael Dick
152e5d2d4f OPENJPA-1696: setting eol-style
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954905 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 14:16:06 +00:00
Pinaki Poddar
3865aedfaa OPENJPA-1686: Upgrade to Java runtime version 5. Remove reflection.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954678 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 00:09:17 +00:00
Catalina Wei
493bfe0e14 OPENJPA-1696: Type discriminator for polymorphic queries limited to Single Table inheritance
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954007 13f79535-47bb-0310-9956-ffa450edef68
2010-06-12 14:05:43 +00:00
Richard G. Curtis
3905b52a90 OPENJPA-1692: Update method signature for BrokerFactory.getInstance(...) to take a classloader.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@953830 13f79535-47bb-0310-9956-ffa450edef68
2010-06-11 18:51:47 +00:00
Richard G. Curtis
ea8dc8b630 OPENJPA-1692: Add post creation callback to BrokerFactory
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@953760 13f79535-47bb-0310-9956-ffa450edef68
2010-06-11 16:37:30 +00:00
Pinaki Poddar
d31ec1274b OPENJPA-1686: Refactor in RelationStrategies.isRelationId()
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@952972 13f79535-47bb-0310-9956-ffa450edef68
2010-06-09 12:03:15 +00:00
Pinaki Poddar
a873065db7 OPENJPA-1686: A first draft of support for generic graph. Correct mapping strategy on MappedSuperClass (they are not Embeddables)
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@952893 13f79535-47bb-0310-9956-ffa450edef68
2010-06-09 02:43:46 +00:00
Pinaki Poddar
79b9583a46 OPENJPA-1682: Remove uncessary and incorrect method from Unique
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@952386 13f79535-47bb-0310-9956-ffa450edef68
2010-06-07 19:36:44 +00:00
Pinaki Poddar
fafc33b3cd OPENJPA-1682: Unique constraint to a column will imply the column to be non-nullable per database basis. The commit adds a new model in
internal schema design by making Column-Constraint relation bi-directional.

git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@952371 13f79535-47bb-0310-9956-ffa450edef68
2010-06-07 19:08:49 +00:00
Richard G. Curtis
97232e67b4 OPENJPA-1612: Reverting change 942871 to restore previous behaviour.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@952244 13f79535-47bb-0310-9956-ffa450edef68
2010-06-07 14:28:33 +00:00
Milosz Tylenda
18dd7e8542 OPENJPA-1667: Fix incorrect column type for LOB streaming in MySQL.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@947144 13f79535-47bb-0310-9956-ffa450edef68
2010-05-21 19:49:58 +00:00
Richard G. Curtis
2765b756bc OPENJPA-1612: Check for having a relationship to a type that is mapped to a blob field.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@942871 13f79535-47bb-0310-9956-ffa450edef68
2010-05-10 19:46:21 +00:00
Pinaki Poddar
cb77af09f2 OPENJPA-1657: Save NPE for some database connect on null properties
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@942815 13f79535-47bb-0310-9956-ffa450edef68
2010-05-10 16:33:06 +00:00
Pinaki Poddar
7bd2b4ae49 OPENJPA-1387: Unique should not impose non-null constraint automatically.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@941362 13f79535-47bb-0310-9956-ffa450edef68
2010-05-05 16:17:31 +00:00
Michael Dick
7851202ec6 OPENJPA-1641: Try JDBC standard column names as well as Sybase specific ones
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@938610 13f79535-47bb-0310-9956-ffa450edef68
2010-04-27 19:19:38 +00:00
Fay Wang
aef5474423 OPENJPA-1596: use unqualified name to check index name length
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@938571 13f79535-47bb-0310-9956-ffa450edef68
2010-04-27 17:12:26 +00:00
Fay Wang
5e6d42a5bc OPENJPA-1596: fix index name for DB2 zOS when schema is present.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@936449 13f79535-47bb-0310-9956-ffa450edef68
2010-04-21 19:11:45 +00:00
Pinaki Poddar
53e63d202f OPENJPA-703: Disable query statistics by default.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@935073 13f79535-47bb-0310-9956-ffa450edef68
2010-04-16 20:35:42 +00:00
Jeremy Bauer
5de5b5136f OPENJPA-1605 Correct regression issue with table generation issue in schema generator. Only the first table name returned in a generic DBMD query was used to populate the schema. This broke the reverse mapping tool, which uses a generic query by default.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@934493 13f79535-47bb-0310-9956-ffa450edef68
2010-04-15 17:24:02 +00:00
Fay Wang
8a034d6717 OPENJPA-1627: fix OrderBy with EmbeddedId.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@934101 13f79535-47bb-0310-9956-ffa450edef68
2010-04-14 18:37:30 +00:00
Fay Wang
53325aed75 OPENJPA-1608: the RetainUpdateLock is not supported for IDS 11.10
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@932643 13f79535-47bb-0310-9956-ffa450edef68
2010-04-09 22:48:35 +00:00
Donald Woods
20a07726f9 OPENJPA-1616 Fix TestTimeoutException tests for Oracle and re-enable for DB2
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@932139 13f79535-47bb-0310-9956-ffa450edef68
2010-04-08 21:54:21 +00:00
Pinaki Poddar
92914c0a6d OPENJPA-703: Use weak map for caches
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@932117 13f79535-47bb-0310-9956-ffa450edef68
2010-04-08 21:16:54 +00:00
Donald Woods
c6e4e39fe4 OPENJPA-1616 add comment
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@932027 13f79535-47bb-0310-9956-ffa450edef68
2010-04-08 17:42:08 +00:00
Donald Woods
e16c823464 OPENJPA-1616 Fix TestTimeoutException test failures on MySQL
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@932025 13f79535-47bb-0310-9956-ffa450edef68
2010-04-08 17:39:18 +00:00
Donald Woods
5e62924fce OPENJPA-1616 Fix TestTimeoutException test failures on MSSQL
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@931693 13f79535-47bb-0310-9956-ffa450edef68
2010-04-07 21:22:52 +00:00
Albert Lee
4555af14af OPENJPA-1609 - Commit contribution by Jody Grassel.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@931635 13f79535-47bb-0310-9956-ffa450edef68
2010-04-07 18:21:13 +00:00
Donald Woods
b2b922e1c8 OPENJPA-1614 Testcase failures in TextException on MSSQL due to missing <object-exists> value in sql-error-state-codes.xml
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@931535 13f79535-47bb-0310-9956-ffa450edef68
2010-04-07 13:31:43 +00:00
Fay Wang
f03f7b4f61 OPENJPA-1608: fix pessimistic write lock in informix
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@930889 13f79535-47bb-0310-9956-ffa450edef68
2010-04-05 15:57:13 +00:00
Michael Dick
8579593f88 OPENJPA-1603:
Decouple the QueryCache from the DataCache. Code contributed by Mike Dick and Rick Curtis.

git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@929266 13f79535-47bb-0310-9956-ffa450edef68
2010-03-30 20:42:29 +00:00