Commit Graph

3804 Commits

Author SHA1 Message Date
Donald Woods af772a734b OPENJPA-1700 FindBugs - Method invokes inefficient new String() constructor
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956878 13f79535-47bb-0310-9956-ffa450edef68
2010-06-22 13:16:01 +00:00
Richard G. Curtis a7c61414ca OPENJPA-1704: Fix PCEnhancer to generate proper readExternal method.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956875 13f79535-47bb-0310-9956-ffa450edef68
2010-06-22 13:08:35 +00:00
Donald Woods c047527a4f OPENJPA-1700 FindBugs - Method may fail to clean up stream or resource
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956757 13f79535-47bb-0310-9956-ffa450edef68
2010-06-22 01:20:03 +00:00
Donald Woods 40d808099d OPENJPA-1700 FindBugs - Usage of GetResource may be unsafe if class is extended. Use DBDictionary.class.getResourceAsStream() like other places in the code.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956705 13f79535-47bb-0310-9956-ffa450edef68
2010-06-21 21:32:46 +00:00
Donald Woods 18e329cf4e OPENJPA-1700 FindBugs - Suspicious reference comparison of Boolean values
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956702 13f79535-47bb-0310-9956-ffa450edef68
2010-06-21 21:22:11 +00:00
Donald Woods 702fb78b14 OPENJPA-1700 FindBugs - equals() method does not check for null argument
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956696 13f79535-47bb-0310-9956-ffa450edef68
2010-06-21 21:16:37 +00:00
Donald Woods 004cbd9644 OPENJPA-1700 FindBugs - extraneous checks for null as a NPE would have already occurred
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956693 13f79535-47bb-0310-9956-ffa450edef68
2010-06-21 21:01:34 +00:00
Donald Woods 5e8b5afc72 OPENJPA-1700 FindBugs - was checking array and not member for null
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956687 13f79535-47bb-0310-9956-ffa450edef68
2010-06-21 20:39:47 +00:00
Donald Woods cbe90d792b use released Apache Bean Valdiation 0.1-incubating artifacts. Move some common dependency versions to parent POM.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@956672 13f79535-47bb-0310-9956-ffa450edef68
2010-06-21 19:12:34 +00:00
Catalina Wei 3f79c25dfc OPENJPA-1697: A EnumValueHandler strategy along with XmlType annotation incorrectly mapped to XmlType in create table DDL
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955806 13f79535-47bb-0310-9956-ffa450edef68
2010-06-18 00:47:25 +00:00
Catalina Wei eac9c66b74 OPENJPA-1697: A EnumValueHandler strategy along with XmlType annotation incorrectly mapped to XmlType in create table DDL
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955805 13f79535-47bb-0310-9956-ffa450edef68
2010-06-18 00:41:16 +00:00
Catalina Wei dbaf9fa67e OPENJPA-1686: Define generic persistent graph and relation. Implement graph as a set of edges.
Fix compile errors

git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955581 13f79535-47bb-0310-9956-ffa450edef68
2010-06-17 13:07:21 +00:00
Catalina Wei 832b5048bd OPENJPA-1697: A EnumValueHandler strategy along with XmlType annotation incorrectly mapped to XmlType in create table DDL
backout changes - regression in xmlcolumn mappings

git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955474 13f79535-47bb-0310-9956-ffa450edef68
2010-06-17 04:06:56 +00:00
Pinaki Poddar a79a96b86c OPENJPA-1686: Define generic persistent graph and relation. Implement graph as a set of edges.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955425 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 23:22:31 +00:00
Donald Woods 2e827c5eab OPENJPA-1700 FindBugs - Possible null pointer dereference; There is a branch where em1 would not get set.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955402 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 21:31:23 +00:00
Fay Wang 34a865c5bd OPENJPA-1699: clean up code
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955400 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 21:28:11 +00:00
Donald Woods bc67e474bc OPENJPA-1700 FindBugs - Possible null pointer dereference; the clss cehck against null 3 lines up doesn't protect against a null value here
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955399 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 21:25:44 +00:00
Donald Woods 13002d2025 OPENJPA-1700 FindBugs - Possible null pointer dereference; strName could be set to null.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955394 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 21:17:57 +00:00
Michael Dick 7028247229 OPENJPA-1678: Update documentation re: PrintParameters
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955383 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 21:03:04 +00:00
Donald Woods cb099098ca OPENJPA-1700 FindBugs - Possible null pointer dereference; Could be caused by using bitwise instead of logical AND. This could also have lead to unexpected code behavior.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955382 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 21:03:02 +00:00
Donald Woods f82b866318 OPENJPA-1700 FindBugs - Null pointer dereference; changeRow was not being set before being used.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955381 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 20:59:58 +00:00
Donald Woods 8084af124c OPENJPA-1700 FindBugs - Call to equals() comparing different types. Make explicit call to getName() instead of relying on toString() to call it.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955379 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 20:56:15 +00:00
Fay Wang 7450df02a4 OPENJPA-1699: Streaming LOB support for DB2
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955283 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 16:07:14 +00:00
Donald Woods 8a2b1c1f08 OPENJPA-1700 FindBugs - Method invokes inefficient Number constructor; use static valueOf instead
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955046 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 20:53:38 +00:00
Donald Woods 5e2f6c2288 OPENJPA-1700 FindBugs - Method concatenates strings using + in a loop - use StringBuffer instead.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@955031 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 20:07:41 +00:00
Ravi Prakash Palacherla efa71484df OPENJPA-1695 OutOfMemoryError from CacheMarshallerImpl.setInputUrlFromResourceLocation
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954979 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 17:47:02 +00:00
Michael Dick 152e5d2d4f OPENJPA-1696: setting eol-style
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954905 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 14:16:06 +00:00
Richard G. Curtis 703bd8db8a OPENJPA-1692: Revert some of previous commit.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954898 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 14:10:46 +00:00
Richard G. Curtis 14cfcaa3cc OPENJPA-1692: Clean up extra initialization from PersistenceProviderImpl.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954891 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 14:04:26 +00:00
Donald Woods 2230521c78 OPENJPA-1700 FindBugs - Exception is caught when Exception is not thrown. This method uses a try-catch block that catches Exception objects, which could mask potential bugs.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954697 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 02:38:42 +00:00
Donald Woods 4d5d2fb2bf OPENJPA-1700 FindBugs - A null pointer is dereferenced here. This will lead to a NullPointerException when the code is executed.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954696 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 02:16:27 +00:00
Donald Woods 73692a6d32 OPENJPA-1700 FindBugs - This method might drop an exception. In general, exceptions should be handled or reported in some way, or they should be thrown out of the method.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954695 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 02:15:13 +00:00
Donald Woods 72ddd27a00 OPENJPA-1700 FindBugs - Suspicious reference comparison of Boolean values
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954694 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 02:09:06 +00:00
Donald Woods bc6c92ca64 OPENJPA-1700 Findbugs - The initial value of this parameter is ignored, and the parameter is overwritten here. This often indicates a mistaken belief that the write to the parameter will be conveyed back to the caller.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954689 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 01:29:53 +00:00
Pinaki Poddar 3865aedfaa OPENJPA-1686: Upgrade to Java runtime version 5. Remove reflection.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954678 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 00:09:17 +00:00
Pinaki Poddar 2d21d726ab OPENJPA-1686: Support when a parameterized type has parameterized type arguments
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954667 13f79535-47bb-0310-9956-ffa450edef68
2010-06-14 23:10:55 +00:00
Donald Woods 69b8e4a1fd OPENJPA-1700 Setup findbugs-maven-plugin to allow for manual usage
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954654 13f79535-47bb-0310-9956-ffa450edef68
2010-06-14 21:38:14 +00:00
Richard G. Curtis 15d2f36ab0 OPENJPA-1692: Rename TestBrokerFactory.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954532 13f79535-47bb-0310-9956-ffa450edef68
2010-06-14 16:06:31 +00:00
Catalina Wei d781b913d1 OPENJPA-1697: A EnumValueHandler strategy along with XmlType annotation incorrectly mapped to XmlType in create table DDL
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954345 13f79535-47bb-0310-9956-ffa450edef68
2010-06-14 01:47:08 +00:00
Catalina Wei 493bfe0e14 OPENJPA-1696: Type discriminator for polymorphic queries limited to Single Table inheritance
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954007 13f79535-47bb-0310-9956-ffa450edef68
2010-06-12 14:05:43 +00:00
Richard G. Curtis 3905b52a90 OPENJPA-1692: Update method signature for BrokerFactory.getInstance(...) to take a classloader.
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@953830 13f79535-47bb-0310-9956-ffa450edef68
2010-06-11 18:51:47 +00:00
Richard G. Curtis ea8dc8b630 OPENJPA-1692: Add post creation callback to BrokerFactory
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@953760 13f79535-47bb-0310-9956-ffa450edef68
2010-06-11 16:37:30 +00:00
Pinaki Poddar 59c7001e09 OPENJPA-1686: Support when a parameterized type has parameterized type arguments
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@953717 13f79535-47bb-0310-9956-ffa450edef68
2010-06-11 15:14:24 +00:00
Michael Dick 6b38f0cb8e OPENJPA-1678: delete tests which write to log files
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@953182 13f79535-47bb-0310-9956-ffa450edef68
2010-06-09 23:04:48 +00:00
Michael Dick 323ebee840 OPENJPA-1678: add printParameters property to prevent SQL parameter values from being logged in exceptions or trace
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@953169 13f79535-47bb-0310-9956-ffa450edef68
2010-06-09 21:48:44 +00:00
Pinaki Poddar 939f644e77 OPENJPA-1690: Make DistinctResultList serializable
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@953165 13f79535-47bb-0310-9956-ffa450edef68
2010-06-09 21:21:02 +00:00
Richard G. Curtis 8de998f90b OPENJPA-620: Update CHANGES.txt
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@953138 13f79535-47bb-0310-9956-ffa450edef68
2010-06-09 20:02:48 +00:00
Donald Woods ddda5ee6a0 only run apache-rat on common source files during normal builds and move the strict checking back to the release profile
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@953040 13f79535-47bb-0310-9956-ffa450edef68
2010-06-09 15:18:43 +00:00
Pinaki Poddar 10a056a073 OPENJPA-1686: Remove incompatibility of FieldMapping strategy -- not true anymore
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@952984 13f79535-47bb-0310-9956-ffa450edef68
2010-06-09 12:52:19 +00:00
Pinaki Poddar d31ec1274b OPENJPA-1686: Refactor in RelationStrategies.isRelationId()
git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@952972 13f79535-47bb-0310-9956-ffa450edef68
2010-06-09 12:03:15 +00:00