Commit Graph

7158 Commits

Author SHA1 Message Date
Andreas Beeker 1e65636048 some zips can't be opened via ZipFile in JDK6, as the central directory
contains either non-latin entries or the compression type can't be handled
the workaround is to iterate over the stream and not the directory


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736933 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 22:49:45 +00:00
Andreas Beeker 033580e1b3 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736932 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 22:46:53 +00:00
Dominik Stadler 155323ee56 Fix some compiler warnings, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736924 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 20:22:08 +00:00
Dominik Stadler bfcfaf9d34 Bug 59199: Handle null date-values in a similar way as null-Strings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736923 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 20:20:29 +00:00
Javen O'Neal 2c9d714867 assertCloseDoesNotModifyFile method was adapted from method with the same name in TestWorkbookFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736744 13f79535-47bb-0310-9956-ffa450edef68
2016-03-27 13:09:50 +00:00
Javen O'Neal 615616a506 add more commented-out tests for bug 58779: closing an XML Workbook that was not opened as read-only will modify the file on disk
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736742 13f79535-47bb-0310-9956-ffa450edef68
2016-03-27 13:04:37 +00:00
Javen O'Neal 83810e71f6 make OPCPackage logger final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736721 13f79535-47bb-0310-9956-ffa450edef68
2016-03-27 05:01:02 +00:00
Javen O'Neal 42c265b1fa bug 59224: change hasTint, add hasAlpha and unit tests. Patch from gubespam@gmail.com
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736469 13f79535-47bb-0310-9956-ffa450edef68
2016-03-24 17:29:00 +00:00
Javen O'Neal 38bad80971 make private member variable ctColor final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736395 13f79535-47bb-0310-9956-ffa450edef68
2016-03-24 06:37:34 +00:00
Javen O'Neal a1b9cb221e bug 59222: fix NPE thrown by (S)XSSFSheet.getCellComments(). Reported by Vasily Kopytov.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736347 13f79535-47bb-0310-9956-ffa450edef68
2016-03-23 16:42:04 +00:00
Javen O'Neal 0d543621ea bug 59212: Do not check for overlapping regions when adding merged regions to a sheet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736165 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 09:22:03 +00:00
Javen O'Neal da9bd80d5e bug 59212: Do not check for overlapping regions when adding merged regions to a sheet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736155 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 09:02:08 +00:00
Dominik Stadler 15d70b0828 Check for null in IOUtils.closeQuietly() to not log this unnecessarily
Add coverage for some  more methods in ExtractorFactory
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736146 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 07:51:39 +00:00
Javen O'Neal fbee1bd860 return unmodifiable shared strings to guarentee parallel data structures stay in sync
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736144 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 07:04:51 +00:00
Javen O'Neal c6e27348f8 bug 59208: correctly understand val="1" for isBold, isItalic, etc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736126 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 04:20:45 +00:00
Javen O'Neal c7980d66a6 fix inconsistent newlines (remove carriage returns), set svnprop eol-style native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736121 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 02:31:16 +00:00
Andreas Beeker 8b1b768114 findbugs fixes - SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736114 13f79535-47bb-0310-9956-ffa450edef68
2016-03-21 23:42:56 +00:00
Andreas Beeker 3dfbdc46e5 findbugs fixes - RR_NOT_CHECKED
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736112 13f79535-47bb-0310-9956-ffa450edef68
2016-03-21 23:29:06 +00:00
Andreas Beeker 95f959bcc6 another gump run fix (... try)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736091 13f79535-47bb-0310-9956-ffa450edef68
2016-03-21 20:44:32 +00:00
Andreas Beeker fe653de0e6 fix eclipse warnings
close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735912 13f79535-47bb-0310-9956-ffa450edef68
2016-03-21 00:14:21 +00:00
Andreas Beeker e826364ac2 fix eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735881 13f79535-47bb-0310-9956-ffa450edef68
2016-03-20 13:36:56 +00:00
Andreas Beeker 7df970cb99 XmlBeans generation still needs the original jar
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735876 13f79535-47bb-0310-9956-ffa450edef68
2016-03-20 13:15:04 +00:00
Andreas Beeker 78d19690c8 eclipse warning fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735706 13f79535-47bb-0310-9956-ffa450edef68
2016-03-18 23:12:28 +00:00
Andreas Beeker 86fdea9d4b sonar fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735696 13f79535-47bb-0310-9956-ffa450edef68
2016-03-18 22:21:12 +00:00
Andreas Beeker 3a8e5887b3 #59195 - POIXMLTypeLoader depends on XMLBeans 2.6.0 - remove piccolo classes from xmlbeans jars and disable xmloption in type loader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735685 13f79535-47bb-0310-9956-ffa450edef68
2016-03-18 21:34:03 +00:00
Andreas Beeker 9fe1cea901 sonar fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735514 13f79535-47bb-0310-9956-ffa450edef68
2016-03-17 22:39:20 +00:00
Andreas Beeker 93122ff358 findbugs fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735513 13f79535-47bb-0310-9956-ffa450edef68
2016-03-17 22:36:11 +00:00
Andreas Beeker defe39208c sonar fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735507 13f79535-47bb-0310-9956-ffa450edef68
2016-03-17 21:52:53 +00:00
Andreas Beeker fc83bdaf9e forgot another contains call ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735349 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 23:40:00 +00:00
Andreas Beeker ee4b65394f findbugs fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735348 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 23:36:17 +00:00
Andreas Beeker 217ae0ea8f sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735345 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 23:30:19 +00:00
Andreas Beeker 280cdd4611 increase perm gen
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735332 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 22:41:34 +00:00
Andreas Beeker 4f2e469bef sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735323 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 22:34:26 +00:00
Andreas Beeker 89c8c772c9 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735321 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 22:27:56 +00:00
Andreas Beeker 5499c36019 findbugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735319 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 22:10:27 +00:00
Andreas Beeker e6a96fd11d forbidden-apis-fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735316 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 21:59:40 +00:00
Andreas Beeker 22acc7334c findbugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735312 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 21:46:28 +00:00
Andreas Beeker 77f062c942 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735301 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 21:20:15 +00:00
Andreas Beeker 6841ce8d55 First try of uncluttering CellNumberFormatter.
Make inner classes static and remove setting of private outer properties while in constructor.
Make properties final to make sure they are only set once.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735300 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 21:18:58 +00:00
Andreas Beeker 5e5c991855 Fix for Softmaker Office files, which set encryption settings invalidly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735298 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 21:05:37 +00:00
Tim Allison 1a8a733cdf 59183 - handle timezones (even with colons) in date parsing metadata in ooxml opc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735270 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 17:52:42 +00:00
Nick Burch 2e74d762cf Ignore ODS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735079 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 14:17:47 +00:00
Nick Burch e5e066fb79 One final invalid file type check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735071 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 12:37:01 +00:00
Nick Burch 604189ae72 Before opening an OOXML file, check the first few bytes, and give helpful exceptions for common mistakes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735069 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 12:30:45 +00:00
Nick Burch 65a822e670 Push all the zip opening logic into ZipHelper
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735064 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 12:03:30 +00:00
Nick Burch b39c020941 Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735063 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 11:56:28 +00:00
Nick Burch 7aa3763735 Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735061 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 11:54:16 +00:00
Nick Burch 2115a45b05 Start to give more helpful Exceptions from OPCPackage when non-OOXML files are passed to it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735060 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 11:50:57 +00:00
Nick Burch 246ff9c99a Add a test ODS file, for more helpful error messages
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735056 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 11:15:38 +00:00
Dominik Stadler 002ec1ec70 Remove some useless lines of code, the initialAllocationSize is ignored in SXSSFRow() anyway
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734925 13f79535-47bb-0310-9956-ffa450edef68
2016-03-14 12:00:27 +00:00