7660 Commits

Author SHA1 Message Date
Nick Burch
243f46213a Add ignored test for #59780, and specially-crafted test file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751375 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 20:26:40 +00:00
Javen O'Neal
152ca83a2e bug 59796: XSSFTable#getRowCount off-by-one error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751373 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 19:09:10 +00:00
Javen O'Neal
f5b531db58 typo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751372 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 19:00:35 +00:00
Javen O'Neal
e04a555450 mark BitField as internal use only
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751371 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 18:50:26 +00:00
Javen O'Neal
480703f15b pre for-each iteration over for index iteration
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751369 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 18:43:45 +00:00
Javen O'Neal
2cb2a5a21d bug 59795: add method to synchronize start and stop cell references with CTTable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751368 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 18:25:00 +00:00
Nick Burch
9830e974c1 Try (as best as possible with no test file) to extract uncompressed HMEF test when that is there instead of Compressed RTF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751361 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 18:06:14 +00:00
Javen O'Neal
a22b230394 bug 59790,59791: add @since javadoc annotation to FormulaType and CellType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751287 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 13:49:44 +00:00
Javen O'Neal
4f92e81892 bug 59791: CellFormat#ultimateType(Cell) should return an integer for backwards compatibility (use ultimateTypeEnum for now for CellType enums); re-add SXSSFCell(SXSSFRow, int) for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751273 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 13:09:30 +00:00
Javen O'Neal
a6cd0dd6f4 bug 59791: add @since to Cell, EvaluationCell, and FormulaEvaluator CellType getter javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751264 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 12:35:49 +00:00
Javen O'Neal
04be2bb235 bug 59791: FormulaEvaluator#evaluateFormulaCell(Cell) should return an integer for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751261 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 12:21:42 +00:00
Javen O'Neal
5582593ad1 bug 59791: getCellType and getCachedFormulaResultType should return an integer for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751256 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 11:54:20 +00:00
Javen O'Neal
8a9cb7c66b reorganize imports (remove unused imports, sort alphabetically)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751244 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 10:38:25 +00:00
Javen O'Neal
8d31c01f40 bug 59791: replace deprecated Cell.CELL_TYPE_* usage with CellType.*
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751240 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 10:15:18 +00:00
Javen O'Neal
fb8c79d96c bug 59791: convert Cell Type to an enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751237 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 09:45:46 +00:00
Javen O'Neal
77bf864c07 bug 59790: convert FormulaType class to enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751210 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 05:37:06 +00:00
Javen O'Neal
4eb51da0f0 javadocs fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751209 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 05:00:55 +00:00
Javen O'Neal
11bd837623 bug 59789: move HSSFComment shifting due to rowShift outside of for-loop for performance
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751198 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 03:06:11 +00:00
Javen O'Neal
2781fb46cd rearrange JavaDocs to match constructor ordering
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751197 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 02:58:38 +00:00
Javen O'Neal
20e2d68544 findbugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751195 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 02:14:02 +00:00
Javen O'Neal
52f728ef2b bug 59773: replace for loops with for-each loops; javadocs fixes for JDK8
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751193 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 01:49:28 +00:00
Javen O'Neal
74427d18ea add missing ASL license header from bug 59788 comment 2 r1751185
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751192 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 01:28:19 +00:00
Javen O'Neal
b8ff07d064 bug 59166: suggest alternative implementations for TempFileCreationStrategy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751190 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 01:07:52 +00:00
Javen O'Neal
a2d96fe7e3 bug 59788: move DefaultTempFileCreationStrategy from TempFile inner class to its own class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751185 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 00:00:20 +00:00
Andreas Beeker
25aebedc69 javadocs fixes (jdk8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751184 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 23:38:06 +00:00
Javen O'Neal
10bf58f30d whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751183 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 23:33:36 +00:00
Javen O'Neal
7564bbea9a make class attributes final; return unmodifiable lists
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751182 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 23:23:54 +00:00
Javen O'Neal
f4d2b6361d revert whitespace changes to ASF license; previous commit r1751180 contributed by sebb
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751181 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 23:17:11 +00:00
Javen O'Neal
ca39856e91 bug 59786: fix NPE from winmail.dat files if message body is null
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751180 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 23:13:37 +00:00
Javen O'Neal
549d12fbc2 whitespace (3 spaces and tabs to 4 spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751179 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 23:05:52 +00:00
Javen O'Neal
089f54737d uncomment ignored unit tests so they at least compile
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751178 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 22:59:41 +00:00
Javen O'Neal
e3f4061bc8 bug 59788: create temporary directories
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751177 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 22:58:06 +00:00
Andreas Beeker
15cbc2684e deprecated DrawingManager
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751175 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 22:21:55 +00:00
Andreas Beeker
3e888b1a0c #59170 - Remove deprecated classes (POI 3.15) - o.a.p.hssf.model.*Shape classes removed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751174 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 21:54:17 +00:00
Javen O'Neal
ec2bb82dbb convert to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751172 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 20:04:43 +00:00
Andreas Beeker
0b3196ddcf javadocs fixes (jdk8)
(eclipse) source clean ups

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751165 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 18:25:05 +00:00
Javen O'Neal
ff0e46af6d bug 59773: move loop invariants outside of loop or change for loops to for-each loops
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751131 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 07:20:47 +00:00
Andreas Beeker
8fda0dc929 javadocs fixes (jdk8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751106 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 23:08:07 +00:00
Andreas Beeker
356991c8aa ignore *.zip
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751104 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 22:57:21 +00:00
Andreas Beeker
c579c1338f announce POI 3.15-beta2
generate snipplet for download.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751103 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 22:09:00 +00:00
Javen O'Neal
af53515279 bug 59773: move loop invariants outside of loop or change for loops to for-each loops
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751086 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 18:28:43 +00:00
Javen O'Neal
80e3a64280 bug 59781: ignore duplicate HSSF PaneInformation, which now shadows the Common SS version. The HSSF version has been deprecated and will be deleted after 2 releases
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751081 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 16:29:05 +00:00
Javen O'Neal
11bea18184 bug 59781: promote to Common SS: move PaneInformation from o.a.p.hssf.util to o.a.p.ss.util
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751044 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 09:00:13 +00:00
Javen O'Neal
3934d10809 don't shadow drawing field from XSSFShape in XSSFGraphicFrame
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751038 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 08:40:50 +00:00
Javen O'Neal
892c5bf8fc findbugs: remove implements Cloneable declaration from classes that don't implement a clone method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751035 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 08:30:34 +00:00
Javen O'Neal
966c0aed78 findbugs: remove switch statement fall-through and move default switch to bottom
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751034 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 08:20:14 +00:00
Javen O'Neal
43096c795d enable @Ignored unit test that is passing now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751024 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 05:12:19 +00:00
Javen O'Neal
eb9a3975e7 findbugs REC_CATCH_EXCEPTION: catch specific exception types and include more helpful reason rather than catching all Exceptions with one misleading reason
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751023 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 05:11:01 +00:00
Javen O'Neal
db9af88db2 +svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751022 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 05:01:43 +00:00
Javen O'Neal
4dfa29ec5b deprecate o.a.p.hssf.util.AreaReference as it shadows o.a.p.ss.util.AreaReference (findbugs) and provides no additional functionality
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751021 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 04:43:21 +00:00