Commit Graph

12663 Commits

Author SHA1 Message Date
Dominik Stadler 2e8afc0c01 Bug 66425: Avoid a StackOverflowException found via oss-fuzz
We try to avoid causing StackOverflow, but it was possible
to trigger one here with a specially crafted input-file.

This puts a limit on the number of nested properties in place
and logs a warning when the StyleSheet is not fully parsed.

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61252

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911563 13f79535-47bb-0310-9956-ffa450edef68
2023-08-09 05:45:21 +00:00
Dominik Stadler 543d6ad54b Do not disable all files for poi-integration in build.gradle
It seems doing it this way can kick in even when using JDK 11+ due 
to the Gradle toolchain.

Let's rather do a more specific exclusion in code to only exclude files
which actually cause JDK 8 to hang.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911562 13f79535-47bb-0310-9956-ffa450edef68
2023-08-09 05:44:01 +00:00
Dominik Stadler e706f37170 Bug 66425: Avoid a ClassCastException found via oss-fuzz
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61276

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911536 13f79535-47bb-0310-9956-ffa450edef68
2023-08-08 08:48:13 +00:00
Dominik Stadler 1b7613329e Bug 66425: Add memory-safeguard in one more place
We try to generally avoid overly large allocations in places
where arrays are allocated. 

We add one more such check for pictures in HSLF.

We might need to increase the used value of 10MB if users report 
larger files being used frequently. 

Overriding this check via IOUtils is possible.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911525 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 20:35:59 +00:00
Dominik Stadler 163ff25594 Bug 66425: Avoid a ClassCastException found via oss-fuzz
We try to avoid throwing NullPointerException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61266

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911523 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 20:01:19 +00:00
Dominik Stadler f3997b49ef Bug 66425: Avoid a ClassCastException found via oss-fuzz
Fix previous changes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911522 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 19:59:04 +00:00
PJ Fanning ac9da84c86 use of junit internal StringUtils is causing build issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911519 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 19:11:54 +00:00
PJ Fanning 3b9a7c42c1 use of junit internal StringUtils is causing build issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911518 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 18:33:24 +00:00
Dominik Stadler 8e40aabb18 Bug 66425: Avoid a ClassCastException found via oss-fuzz
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61259

Also fix handling of NullPointerException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911517 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 16:18:46 +00:00
Dominik Stadler 738d533a83 Reduce log4j2 level for integration tests to ERROR
Otherwise there is lots of output that is likely rarely useful. 

This can be changed locally for testing easily whenever necessary.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911516 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 15:17:10 +00:00
Dominik Stadler 5efa428ca0 Bug 66425: Avoid a ClassCastException found via oss-fuzz
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61242

Also enhance output of some test-failures and allow an empty exception message

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911515 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 15:15:38 +00:00
Dominik Stadler 2c5264277a Bug 66425: Avoid an AssertionError found via oss-fuzz
We try to avoid throwing AssertionError to be triggered by input data, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61251

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911514 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 14:32:11 +00:00
Dominik Stadler f6b1435db1 Bug 66425: Avoid a ClassCastException found via oss-fuzz
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61243

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911507 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 12:09:31 +00:00
Dominik Stadler ed12f1bb49 Open configuration file for integration-tests read-only to not fail if the file is opened by an Application locally
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911504 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 11:11:45 +00:00
Dominik Stadler a8b31c37a6 Bug 66425: Avoid a ClassCastException found via oss-fuzz
Add exception details and fix expected exceptions to make tests run again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911503 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 11:11:08 +00:00
Dominik Stadler 31fd087a48 Bug 66425: Avoid a ClassCastException found via oss-fuzz
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61249

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911501 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 09:42:17 +00:00
Dominik Stadler 6f054ddce1 Fix expected exception text and print out which FileHandler failed in integration-tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911495 13f79535-47bb-0310-9956-ffa450edef68
2023-08-06 17:13:46 +00:00
Dominik Stadler 1e8e95c3a6 Bug 66425: Avoid a ClassCastException found via oss-fuzz
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Also rework test a bit to use try-with-resources and proper formatting

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61221

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911494 13f79535-47bb-0310-9956-ffa450edef68
2023-08-06 14:57:47 +00:00
PJ Fanning e5ff0e4eb6 upgrade junit
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911476 13f79535-47bb-0310-9956-ffa450edef68
2023-08-06 08:39:16 +00:00
PJ Fanning 91c4ec6a45 avoid creating enumeration twice
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911470 13f79535-47bb-0310-9956-ffa450edef68
2023-08-05 22:20:38 +00:00
PJ Fanning ddef604f46 upgrade com.dorongold.task-tree
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911469 13f79535-47bb-0310-9956-ffa450edef68
2023-08-05 14:42:47 +00:00
PJ Fanning bfd3a59813 add back gradle wrapper jar due to windows build issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911468 13f79535-47bb-0310-9956-ffa450edef68
2023-08-05 14:15:21 +00:00
PJ Fanning 0d18765c29 update jobs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911466 13f79535-47bb-0310-9956-ffa450edef68
2023-08-05 13:43:48 +00:00
PJ Fanning 2fee41c1f7 update jobs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911465 13f79535-47bb-0310-9956-ffa450edef68
2023-08-05 13:41:30 +00:00
PJ Fanning d2f58f436c remove gradle-wrapper jar because it is against ASF policy to ship jars in source releases
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911464 13f79535-47bb-0310-9956-ffa450edef68
2023-08-05 13:34:46 +00:00
PJ Fanning afa8b99eff remove gradle-wrapper jar because it is against ASF policy to ship jars in source releases
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911463 13f79535-47bb-0310-9956-ffa450edef68
2023-08-05 13:16:21 +00:00
PJ Fanning c4e7b5174c remove gradle-wrapper jar because it is against ASF policy to ship jars in source releases
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911462 13f79535-47bb-0310-9956-ffa450edef68
2023-08-05 13:14:56 +00:00
Dominik Stadler 57d746827f Bug 66425: Avoid a ClassCastException found via oss-fuzz
We try to avoid throwing ClassCastException but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61162

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911459 13f79535-47bb-0310-9956-ffa450edef68
2023-08-05 12:13:13 +00:00
Dominik Stadler acf61f325f Use interfaces for variables and reformat source-code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911436 13f79535-47bb-0310-9956-ffa450edef68
2023-08-04 12:47:09 +00:00
Dominik Stadler ee1c914cea Use correct version for JUnit in Ant build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911435 13f79535-47bb-0310-9956-ffa450edef68
2023-08-04 12:41:34 +00:00
PJ Fanning 53cb570a0c gradle-8.2.1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911428 13f79535-47bb-0310-9956-ffa450edef68
2023-08-03 21:12:30 +00:00
PJ Fanning c488cae3f3 [bug-66827] treat VML drawing entry for a comment that has incorrect type of TEXT as invalid
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911407 13f79535-47bb-0310-9956-ffa450edef68
2023-08-02 08:58:34 +00:00
PJ Fanning dd1b0b1128 [bug-66827] add test case (that passes) - so issue is nor reproduced
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911399 13f79535-47bb-0310-9956-ffa450edef68
2023-08-01 20:49:26 +00:00
PJ Fanning 005863e1c9 gradle hates ant 1.10.13
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911398 13f79535-47bb-0310-9956-ffa450edef68
2023-08-01 20:19:38 +00:00
Dominik Stadler cb835739c6 Exclude some files in one test to avoid flakiness during parallel builds
This test failed once locally due to a temporary file
being deleted again when the test tried to access it

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911384 13f79535-47bb-0310-9956-ffa450edef68
2023-08-01 08:24:59 +00:00
Dominik Stadler 8e2b749cf6 Update Apache Ant to 1.10.13 and use newer Gradle syntax
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911383 13f79535-47bb-0310-9956-ffa450edef68
2023-08-01 08:24:54 +00:00
PJ Fanning ce1e4695e7 junit 5.10.0
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911373 13f79535-47bb-0310-9956-ffa450edef68
2023-07-31 15:02:03 +00:00
PJ Fanning 842e12d06e bouncycastle 1.76
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911371 13f79535-47bb-0310-9956-ffa450edef68
2023-07-31 14:55:12 +00:00
PJ Fanning c6aa3a1318 [github-488] Round up seconds in CellElapsedFormatter. Thanks to Anthony Schott. This closes #488
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911254 13f79535-47bb-0310-9956-ffa450edef68
2023-07-24 19:59:45 +00:00
PJ Fanning 1f446e0aef undo last change due to broken test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911233 13f79535-47bb-0310-9956-ffa450edef68
2023-07-24 12:00:17 +00:00
PJ Fanning cd2dcd3940 [github-487] Round up seconds in CellElapsedFormatter. Thanks to Anthony Schott. This closes #487
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911228 13f79535-47bb-0310-9956-ffa450edef68
2023-07-24 10:12:46 +00:00
PJ Fanning fa8650fbe3 [bug-66682] fix xslb reading support for formula cells of boolean type. This closes #485
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1910951 13f79535-47bb-0310-9956-ffa450edef68
2023-07-12 22:26:41 +00:00
PJ Fanning e1bb2a73c8 [bug-66675] fix issue with writing xlsx (core properties being added twice)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1910949 13f79535-47bb-0310-9956-ffa450edef68
2023-07-12 12:25:01 +00:00
PJ Fanning a9a0acc232 gradle 8.2
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1910822 13f79535-47bb-0310-9956-ffa450edef68
2023-07-06 16:48:24 +00:00
PJ Fanning 23caf67c58 remove release date from version.java
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1910760 13f79535-47bb-0310-9956-ffa450edef68
2023-07-03 21:01:19 +00:00
PJ Fanning 04442923f3 [bug-62181] try to handle file where shared string loading is happening twice
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1910759 13f79535-47bb-0310-9956-ffa450edef68
2023-07-03 20:54:56 +00:00
PJ Fanning cd5d0c3d07 update guava
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1910755 13f79535-47bb-0310-9956-ffa450edef68
2023-07-03 14:33:28 +00:00
PJ Fanning 20473c1b01 pdfbox 2.0.29
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1910753 13f79535-47bb-0310-9956-ffa450edef68
2023-07-03 14:32:05 +00:00
PJ Fanning 273067b103 apply some spelling fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1910659 13f79535-47bb-0310-9956-ffa450edef68
2023-06-28 11:55:29 +00:00
PJ Fanning f331d08c22 apply some spelling fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1910640 13f79535-47bb-0310-9956-ffa450edef68
2023-06-27 19:37:48 +00:00