Commit Graph

9754 Commits

Author SHA1 Message Date
Greg Woolsey 30851e44a6 #63302 Formula evaluation of names with offset or row function is incorrect
thanks to John Lincoln White for the patch, including new unit tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856644 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 18:14:14 +00:00
PJ Fanning 2a9390d683 [bug-63291] support concurrent date formatting with same DataFormatter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856449 13f79535-47bb-0310-9956-ffa450edef68
2019-03-27 23:04:40 +00:00
PJ Fanning 80dc4b34c9 add test for concurrent use of DataFormatter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856439 13f79535-47bb-0310-9956-ffa450edef68
2019-03-27 21:24:25 +00:00
PJ Fanning 89d34e6c64 use released version of xmlbeans 3.1.0
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856354 13f79535-47bb-0310-9956-ffa450edef68
2019-03-26 23:41:53 +00:00
PJ Fanning e2111d9d26 xmlbeans 3.1.0
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856093 13f79535-47bb-0310-9956-ffa450edef68
2019-03-22 23:24:35 +00:00
PJ Fanning 905c53794c [github-142] issue in ExcelComparator example. Thanks to chirkovmail. This close #142
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856053 13f79535-47bb-0310-9956-ffa450edef68
2019-03-22 13:38:05 +00:00
PJ Fanning 658268512e reorder jar files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855995 13f79535-47bb-0310-9956-ffa450edef68
2019-03-21 15:10:49 +00:00
PJ Fanning ba910bf988 reorder jar files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855994 13f79535-47bb-0310-9956-ffa450edef68
2019-03-21 15:10:25 +00:00
PJ Fanning 259d5a234f upgrade xmlsec, slf4j, batik
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855990 13f79535-47bb-0310-9956-ffa450edef68
2019-03-21 13:43:19 +00:00
PJ Fanning d66873a765 upgrade bouncycastle and curvesapi
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855978 13f79535-47bb-0310-9956-ffa450edef68
2019-03-21 10:23:05 +00:00
PJ Fanning 3aea8e7f85 commons-codec - 1.12
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855975 13f79535-47bb-0310-9956-ffa450edef68
2019-03-21 10:00:33 +00:00
PJ Fanning 4dc28798bf commons-collections4 - 4.3
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855973 13f79535-47bb-0310-9956-ffa450edef68
2019-03-21 09:49:54 +00:00
PJ Fanning fabbab41f0 try to fix gradle build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855972 13f79535-47bb-0310-9956-ffa450edef68
2019-03-21 09:38:21 +00:00
PJ Fanning dfcf588b79 try to fix gradle build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855971 13f79535-47bb-0310-9956-ffa450edef68
2019-03-21 09:34:04 +00:00
PJ Fanning f9a46c7fbf try to fix gradle build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855970 13f79535-47bb-0310-9956-ffa450edef68
2019-03-21 09:26:03 +00:00
PJ Fanning c18b7245e9 possible npe in test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855969 13f79535-47bb-0310-9956-ffa450edef68
2019-03-21 09:20:00 +00:00
PJ Fanning 92232b921a remove unncessary synchronization
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855956 13f79535-47bb-0310-9956-ffa450edef68
2019-03-20 23:41:29 +00:00
PJ Fanning 895b251367 some javadoc issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855954 13f79535-47bb-0310-9956-ffa450edef68
2019-03-20 23:33:50 +00:00
PJ Fanning cb9d33d53d use xmlbeans-3.0.3 rc version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855952 13f79535-47bb-0310-9956-ffa450edef68
2019-03-20 23:16:13 +00:00
Dominik Stadler c1dec91b00 Remove old versions of commons-collections also in ooxml-lib, we loaded
it there at some point

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855875 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 21:55:36 +00:00
Dominik Stadler bb73949f7b Switch to parameterized test and add some more information to try to find
out why this test fails from time to time

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855874 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 21:55:33 +00:00
Dominik Stadler 40f8d119c7 Remove more remnants of NPOIFSFileSystem, mostly in comments and variable names
This avoids confusion if people look at this code in the future without knowledge
about the historical transition from java.io to java.nio

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855873 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 21:55:26 +00:00
PJ Fanning f2d9c1a927 [bug-63268] fix issue where CellUtil.setFont is adding unnecessary styles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855806 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 05:59:00 +00:00
Greg Woolsey edd1f4c75e pre-release maintenance:
* add my key to the KEYS file
* update year in NOTICE (first release of 2019)
* remove svn:executable flag from random test data files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855799 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 00:35:09 +00:00
Greg Woolsey 1dbcef88f9 Fix a unit test that changed with the implementation of another function.
Didn't fail for me because I hadn't noticed the Eclipse classpath was out of date wrt some dependency versions, and therefore my local code was not compiling properly, meaning my test run ran old code and passed this one when it should have failed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855792 13f79535-47bb-0310-9956-ffa450edef68
2019-03-18 22:05:34 +00:00
Greg Woolsey 82f9c29258 #60724 - Partial implementation for SUBTOTAL() 'ignore hidden rows' variations
The function still doesn't deal with auto-filtering, but it now handles variations that should skip hidden rows.

Taught the evaluation framework to know about hidden rows similar to what was already there for skipping subtotals within subtotal ranges.

Added unit test cases.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855789 13f79535-47bb-0310-9956-ffa450edef68
2019-03-18 19:09:11 +00:00
Andreas Beeker 19005a4e63 Fix forbidden apis error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855672 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 20:44:12 +00:00
Andreas Beeker aa438b6f2d Use JPG source, otherwise we have problems with Alpha conversion in OpenJDK.
https://stackoverflow.com/questions/3432388/imageio-not-able-to-write-a-jpeg-file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855668 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 20:13:55 +00:00
Yegor Kozlov 6ef332b48e Bug 61472: Convert date/time strings to numbers when evaluating formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855662 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 15:41:46 +00:00
Greg Woolsey ee83ce5fcd Handle possible invalid date value (#61652)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855627 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 06:55:16 +00:00
Greg Woolsey 8225326b56 #63264 Conditional Format rule evaluation calculates relative references incorrectly
Fixing the offset calculation and passing the top-left-most region rather than the region matching the current cell fixed these cases.  I've augmented unit tests to check for them to avoid future regressions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855619 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 00:27:13 +00:00
PJ Fanning 126606c838 fix some cases where iterator usage does not check hasNext
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855480 13f79535-47bb-0310-9956-ffa450edef68
2019-03-14 04:01:10 +00:00
Dominik Stadler 7f12edf416 Fix URL for test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855155 13f79535-47bb-0310-9956-ffa450edef68
2019-03-10 16:13:02 +00:00
Dominik Stadler ef369931e2 Bug 63221: Add margin-settings for top, bottom, left and right to XSSFPrintSetup
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855154 13f79535-47bb-0310-9956-ffa450edef68
2019-03-10 16:12:57 +00:00
Dominik Stadler 5329f25b0a Adjust test to not fail with Xerces XML Parser, fix some IDE warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855139 13f79535-47bb-0310-9956-ffa450edef68
2019-03-10 08:18:54 +00:00
Dominik Stadler dee032b11b Jenkins DSL: Enable job for running API-Check again now that we compare 4.x to 4.0.0
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855138 13f79535-47bb-0310-9956-ffa450edef68
2019-03-10 08:18:46 +00:00
PJ Fanning d6b5e936e9 [bug-63240] make SAXHelper.newXMLReader non-synchronized]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854941 13f79535-47bb-0310-9956-ffa450edef68
2019-03-06 19:17:22 +00:00
PJ Fanning 0786ae5b57 [bug-63240] make DocumentHelper.newDocumentBuilder non-synchronized]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854935 13f79535-47bb-0310-9956-ffa450edef68
2019-03-06 18:36:12 +00:00
Dominik Stadler 178ae9a9ff Jenkins DSL: Add XMLBeans-JDK-12, still disabled, though
Print out where we get Ant from
Use new 'jenkins' target for XMLBeans and fetch compiler warnings and JUnit results

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854720 13f79535-47bb-0310-9956-ffa450edef68
2019-03-03 14:09:58 +00:00
Dominik Stadler f9c799a751 Update file-leak excludes for XMLBeans/jaxb
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854719 13f79535-47bb-0310-9956-ffa450edef68
2019-03-03 14:09:54 +00:00
Dominik Stadler 302228dc24 Close more file-handles in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854718 13f79535-47bb-0310-9956-ffa450edef68
2019-03-03 14:09:50 +00:00
Dominik Stadler 4c017a0e27 Fix a regression test failure, toString() should never return null
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854717 13f79535-47bb-0310-9956-ffa450edef68
2019-03-03 14:09:40 +00:00
Dominik Stadler a9b2a8b2bd Bug 63200: Avoid NullPointerException in XSLFShape.selectPaint() and check some more in integration tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854639 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 12:28:19 +00:00
Dominik Stadler 53a30d796e Bug 62151: Fix warnings about illegal reflective access in Java 9+ by
using a similar approach as Apache Hadoop via a CleanerUtil class which encapsulates
the two different approaches for Java <= 8 and Java >= 9

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854630 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 09:19:45 +00:00
Dominik Stadler 421fffbd3f Fix detecting Java <= 8 vs. >= 9 to not detect Java 8 for version-string "11.x"
Add system property to junit to disable optimization in jaxb which causes illegal access in Java 9+
Add argument to junit to display all illegal accesses in Java 9+

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854629 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 09:18:15 +00:00
Dominik Stadler 00a274c656 Add batik-jars to findbugs-task
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854193 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:52:29 +00:00
Dominik Stadler 6a93b3a9ed Close file-handles for slideshows also when construction fails or when dual-storage is used
Also avoid file-leak reports in some tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854192 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:52:24 +00:00
Dominik Stadler 98b620889b Remove some remnants of NFileSystem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854191 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:52:06 +00:00
Dominik Stadler 8c6e95f597 Add some more testing for bug 63151: NullPointerException in HSSFOptimiser.optimiseFonts(), also execute it as part of large regression tests in the future
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854190 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:51:57 +00:00
Dominik Stadler 34d6410bc1 Adjust BaseIntegrationTest some more to better handle invalid file extensions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854189 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:51:48 +00:00