PJ Fanning
36d940ce39
[Bug-61354] fix issue with extracting text from Word docs. This closes #66
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803250 13f79535-47bb-0310-9956-ffa450edef68
2017-07-28 07:42:23 +00:00
Greg Woolsey
3cea90e7c4
Fix data validation value list evaluation
...
One of my users found that my initial implementation was lacking a core distinction - most evaluations expect a single result, and "unwrap" 2/3D ValueEval results to a single value based on the input row/column.
However, data validation list formulas explicitly are expected to return a 2D ValueEval. This worked when the formula was simple and evaluated to a single Ptg, but only returned one value when the formula was more complex, or referenced a named range defined as a complex formula.
This change teaches WorkbookEvaluator about the distinction, by way of a new attribute for FormulaType.
There is room for discussion over how it is implemented, but this works for me.
Includes the failing workbook we had as a new unit test.
While I was in FormulaType I went ahead and removed the deprecated, unused, and redundant code marked for removal in 3.17.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803121 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 22:19:58 +00:00
Andreas Beeker
2dda87a8ce
#61350 - Use unsynchronized xmlbeans
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803120 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 22:15:27 +00:00
Greg Woolsey
515cd684e5
Another font size variation. I suspect it is my Windows 10 scaling factor, set to 100% instead of the Windows 10 default 125%.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803117 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 22:00:23 +00:00
Tim Allison
b1a0c7d53d
61337 -- try to convert assertions to exceptions. I left in the assertions for the binary search components.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803092 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 18:43:27 +00:00
Tim Allison
a9c4072071
61346 add more sanity checks before allocating byte arrays in emf/wmf
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803041 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 12:46:24 +00:00
Andreas Beeker
bf7936bc42
remove test leftover
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803024 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 08:13:16 +00:00
Andreas Beeker
e739205c1d
Bug 61182 - Invalid signature created for streamed xlsx file
...
- add hashes for other linebreaks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803011 13f79535-47bb-0310-9956-ffa450edef68
2017-07-25 22:42:22 +00:00
Tim Allison
d7959a403e
61338 -- avoid infinite loop triggered by fuzzed wmf file
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802997 13f79535-47bb-0310-9956-ffa450edef68
2017-07-25 20:26:57 +00:00
Tim Allison
1aa1e25f71
61295 -- prevent potential oom in HPSF triggered by fuzzed file
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802879 13f79535-47bb-0310-9956-ffa450edef68
2017-07-25 01:38:35 +00:00
Tim Allison
db060ecfb4
augment expected sizes in TestFonts
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802855 13f79535-47bb-0310-9956-ffa450edef68
2017-07-24 19:29:29 +00:00
Dominik Stadler
338f323b94
Refactor test somewhat to make it easier to see what it actually verifies
...
Check some more to see why it fails sometimes in CI, e.g. on node qnode1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802817 13f79535-47bb-0310-9956-ffa450edef68
2017-07-24 14:16:34 +00:00
Andreas Beeker
55a7e69b56
Fonts bugfix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802751 13f79535-47bb-0310-9956-ffa450edef68
2017-07-24 05:39:33 +00:00
Andreas Beeker
b8242721fb
Bug 61331 - Font group handling / common font interface
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802741 13f79535-47bb-0310-9956-ffa450edef68
2017-07-23 22:45:47 +00:00
Dominik Stadler
7b8e1c9150
My version of Java 6 chokes on Generics here
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802633 13f79535-47bb-0310-9956-ffa450edef68
2017-07-21 18:19:29 +00:00
Dominik Stadler
794a348dff
Adjust TestFonts for my version of Ubuntu
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802632 13f79535-47bb-0310-9956-ffa450edef68
2017-07-21 18:19:22 +00:00
Dominik Stadler
7b75e2d61e
Add note that japicmp cannot be upgrade until Gradle 4 is used
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802631 13f79535-47bb-0310-9956-ffa450edef68
2017-07-21 18:19:17 +00:00
Dominik Stadler
94b028eae0
ExtractorFactory: Try to close resources also on Errors to avoid keeping files open too long
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802630 13f79535-47bb-0310-9956-ffa450edef68
2017-07-21 18:19:11 +00:00
Dominik Stadler
d687e94d58
Fix some IntelliJ warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802629 13f79535-47bb-0310-9956-ffa450edef68
2017-07-21 18:19:03 +00:00
Dominik Stadler
45bd7df036
Exclude some more nodes for OpenJDK build
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802425 13f79535-47bb-0310-9956-ffa450edef68
2017-07-19 19:02:53 +00:00
PJ Fanning
b23a943054
fix tests broken by <br/> doc changes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802131 13f79535-47bb-0310-9956-ffa450edef68
2017-07-17 11:36:32 +00:00
PJ Fanning
52d3ea57f4
javadoc: replace invalid self enclosing elements
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802110 13f79535-47bb-0310-9956-ffa450edef68
2017-07-17 08:24:24 +00:00
PJ Fanning
69cc48aa85
some javadoc fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802035 13f79535-47bb-0310-9956-ffa450edef68
2017-07-15 22:31:09 +00:00
PJ Fanning
f9d5a16ca6
try to fix build issues since namespaces constants were changed
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802030 13f79535-47bb-0310-9956-ffa450edef68
2017-07-15 20:00:11 +00:00
Tim Allison
d320b2ea4a
bug 61300 -- prevent really long (infinite?) loop on corrupt file
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801989 13f79535-47bb-0310-9956-ffa450edef68
2017-07-14 20:47:40 +00:00
Tim Allison
5c674c92d3
clean up whitespace and indents
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801969 13f79535-47bb-0310-9956-ffa450edef68
2017-07-14 14:19:21 +00:00
Tim Allison
58453a717b
avoid using non-ascii in unit tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801968 13f79535-47bb-0310-9956-ffa450edef68
2017-07-14 14:17:55 +00:00
Tim Allison
5a9d05487d
bug 61286/bug 61287 -- allow WriteProtectRecord to have 2 bytes, and allow for HeaderFooter to be empty.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801966 13f79535-47bb-0310-9956-ffa450edef68
2017-07-14 13:54:06 +00:00
Tim Allison
1a8b5234ec
bug 61294 -- cleaned up based on PJ Fanning's code review. Went with a copy/paste from commons-io.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801952 13f79535-47bb-0310-9956-ffa450edef68
2017-07-14 12:48:28 +00:00
Javen O'Neal
b6335018c8
bug 61296: suggest de-duplication of purl dublin core namespace url
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801905 13f79535-47bb-0310-9956-ffa450edef68
2017-07-14 03:54:12 +00:00
Javen O'Neal
c4ccb85caf
bug 61296: deduplicate ooxml schema constants
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801904 13f79535-47bb-0310-9956-ffa450edef68
2017-07-14 03:47:38 +00:00
Javen O'Neal
8d912c745c
bug 61296: consolidate some of the ooxml namespace uri copy-paste in POI, prepare to make these usable by downstream libraries like Tika
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801903 13f79535-47bb-0310-9956-ffa450edef68
2017-07-14 03:39:25 +00:00
Javen O'Neal
2367c77710
bug 61296: consolidate some of the ooxml namespace uri copy-paste in POI, prepare to make these usable by downstream libraries like Tika
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801901 13f79535-47bb-0310-9956-ffa450edef68
2017-07-14 03:14:30 +00:00
Tim Allison
34cb860998
bug 61294 -- prevent infinite loop in IOUtils' skipFully.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801844 13f79535-47bb-0310-9956-ffa450edef68
2017-07-13 16:20:28 +00:00
PJ Fanning
b5e74d4b64
avoid unnecessary string concats in SXSSF SheetDataWriter
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801806 13f79535-47bb-0310-9956-ffa450edef68
2017-07-13 07:14:01 +00:00
Javen O'Neal
1d187b32e2
add 362px font height for my computer's configuration (high-dpi monitor)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801803 13f79535-47bb-0310-9956-ffa450edef68
2017-07-13 04:30:41 +00:00
Javen O'Neal
5c2267081d
replace commented-out throw-away code that writes workbook to C:\temp\xxxxx.xlsx for manual review with XSSFTestDataSamples.writeOut(wb, "bug xxxxx for manual review")
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801801 13f79535-47bb-0310-9956-ffa450edef68
2017-07-13 04:19:20 +00:00
Javen O'Neal
4364dd5d02
replace return variable assignments with return statements
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801799 13f79535-47bb-0310-9956-ffa450edef68
2017-07-13 03:42:12 +00:00
Javen O'Neal
d6c7e3e6a7
github #43 : fix roundUp and roundDown.
...
Thanks to @FishMeat on github for the patch.
This closes #43 on github.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801798 13f79535-47bb-0310-9956-ffa450edef68
2017-07-13 03:35:06 +00:00
PJ Fanning
012ab1a9ad
[Bug-61281] fix issue with export of table columns - Thanks to Daniel for the patch
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801721 13f79535-47bb-0310-9956-ffa450edef68
2017-07-12 10:46:13 +00:00
PJ Fanning
2a42bbafc6
remove more deprecated methods
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801697 13f79535-47bb-0310-9956-ffa450edef68
2017-07-12 08:38:20 +00:00
PJ Fanning
d6271eb665
remove deprecated methods from CommentsTable
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801692 13f79535-47bb-0310-9956-ffa450edef68
2017-07-12 08:15:44 +00:00
PJ Fanning
6de159d232
[Bug-61281] guard against index out of bounds in XSSFExportToXml column mapping
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801634 13f79535-47bb-0310-9956-ffa450edef68
2017-07-11 16:38:49 +00:00
PJ Fanning
f63c846c03
expand range of acceptable values in TestFonts
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801416 13f79535-47bb-0310-9956-ffa450edef68
2017-07-10 07:26:40 +00:00
Javen O'Neal
34d9764ca5
bug 60685: ignore problems with HPBF Publisher Quill Contents PLC hyperlink records so that text extraction can continue
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801405 13f79535-47bb-0310-9956-ffa450edef68
2017-07-10 01:34:30 +00:00
Javen O'Neal
61841e51e9
whitespace
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801404 13f79535-47bb-0310-9956-ffa450edef68
2017-07-10 01:31:31 +00:00
Andreas Beeker
04efd0ff8b
font rendering - handle a few system dependent textbox sizes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801401 13f79535-47bb-0310-9956-ffa450edef68
2017-07-09 23:28:41 +00:00
PJ Fanning
879a6d20c3
[Bug-61268] avoid NegativeArraySizeException parsing doc file
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801395 13f79535-47bb-0310-9956-ffa450edef68
2017-07-09 22:32:27 +00:00
PJ Fanning
6a4ffa5d6d
fix spelling
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801393 13f79535-47bb-0310-9956-ffa450edef68
2017-07-09 21:34:53 +00:00
Nick Burch
933f9c1201
#61266 Test for old unsupported MS Write WRI files, and give a more helpful exception if found, plus unit tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801376 13f79535-47bb-0310-9956-ffa450edef68
2017-07-09 16:26:33 +00:00