Commit Graph

9087 Commits

Author SHA1 Message Date
Greg Woolsey 6e67de2160 Added a couple missing null checks.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819398 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 08:17:33 +00:00
Greg Woolsey 94bec76385 Implement DMAX and DSUM functions, following the pattern from DMIN.
Refactored the D* function enum to have instances return the function implementation instances rather than using a case construct, now that Java 8 is required.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819376 13f79535-47bb-0310-9956-ffa450edef68
2017-12-27 22:33:03 +00:00
PJ Fanning 80e430f295 Remove misleading SXSSF logging
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819282 13f79535-47bb-0310-9956-ffa450edef68
2017-12-26 11:02:45 +00:00
Yegor Kozlov a96d86bfe8 Bug 61869: updating a cell with shared formula produces an unreadable file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818818 13f79535-47bb-0310-9956-ffa450edef68
2017-12-20 16:30:13 +00:00
PJ Fanning 808ec42570 use try with resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818786 13f79535-47bb-0310-9956-ffa450edef68
2017-12-20 12:15:35 +00:00
PJ Fanning 943eb6b6cf use try with resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818781 13f79535-47bb-0310-9956-ffa450edef68
2017-12-20 11:47:52 +00:00
PJ Fanning 537badf156 use StandardCharsets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818629 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 00:33:16 +00:00
PJ Fanning 819eac1f82 use StandardCharsets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818628 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 00:23:52 +00:00
PJ Fanning 2a63c7e75d use non deprecated method for adding string to shared strings table
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818623 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 20:54:39 +00:00
Yegor Kozlov 0ad8c53743 Bug 61859: support for evaluating comparison operators in array mode, detect array mode from formula ptgs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818587 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 15:54:50 +00:00
PJ Fanning a401e74ec6 Bug-61906 fix javadoc issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818248 13f79535-47bb-0310-9956-ffa450edef68
2017-12-15 09:13:16 +00:00
PJ Fanning 845c7fcdea Bug-61906 add API for working with RichStringText and deprecate API methods that use CTRst
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818247 13f79535-47bb-0310-9956-ffa450edef68
2017-12-15 09:09:50 +00:00
PJ Fanning e74e6d749a Bug-61792 simplify sxssf code that writes chars
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818223 13f79535-47bb-0310-9956-ffa450edef68
2017-12-15 00:54:52 +00:00
Javen O'Neal f79e00625a delete commented out code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817976 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 06:39:01 +00:00
Javen O'Neal 54b0cf8f93 bug 57423: add unit test demonstrating corrupted workbook where CTRow xmlbeans are not in ascending order in the CTWorksheet; unit test adapted from Luca
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817975 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 06:21:19 +00:00
Nick Burch 2ed2aa504d #61765 Another HSSF Workbook name found from (unknown) third party software produced files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817812 13f79535-47bb-0310-9956-ffa450edef68
2017-12-11 19:52:53 +00:00
Greg Woolsey 50ffe0de32 Bug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference
test file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817797 13f79535-47bb-0310-9956-ffa450edef68
2017-12-11 17:33:00 +00:00
Greg Woolsey f90801d366 Bug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference
Protect against this in the future by introducing a factory method to create XSSFColor instances from a CTColor instance and the associated workbook style indexed color map.

If the CTColor instance is null, the factory returns null.  All callers already are prepared for a null instance, but many had their own null check on the CTColor object.  This centralizes that.

This also further forces the requirement for the indexed color map.  Any time a color is created, the workbook or styleTable is available in the same context, so passing this is extra parameter is trivial and allows XSSFColor to properly reference custom/themed indexed colors.

Did not remove any methods yet, only deprecated them.  Changed the signature to one internal test-only constructor.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817796 13f79535-47bb-0310-9956-ffa450edef68
2017-12-11 17:30:04 +00:00
Andreas Beeker f182b44c62 remove package name to ease the output
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817600 13f79535-47bb-0310-9956-ffa450edef68
2017-12-09 12:06:59 +00:00
Andreas Beeker 0ddda673b3 #61881 - handle invalid font names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817599 13f79535-47bb-0310-9956-ffa450edef68
2017-12-09 11:44:19 +00:00
Greg Woolsey 990b52390f #61841
Add @Override annotations, clean up imports

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817331 13f79535-47bb-0310-9956-ffa450edef68
2017-12-07 01:54:21 +00:00
Greg Woolsey 1d2c550dbe #61841 fix typo in method name
Fixing the typo pointed out by PJ Fanning, thanks for the proof read!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817325 13f79535-47bb-0310-9956-ffa450edef68
2017-12-06 23:53:25 +00:00
Greg Woolsey d55ee57741 Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference
always with the missing license...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817254 13f79535-47bb-0310-9956-ffa450edef68
2017-12-06 00:46:42 +00:00
Greg Woolsey 8f26e2721d Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference
Found some optimizations in the general evaluation framework related to blank cells in rows beyond the last defined row of a sheet.

I don't see any issue with passing a bit of context down deeper into this framework, as it's all POI-internal and only had one calling path.

See the above bug for the performance analysis.  Not specifically related to VLOOKUP, but improves that case by more than 2/3 as well.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817252 13f79535-47bb-0310-9956-ffa450edef68
2017-12-06 00:15:51 +00:00
PJ Fanning 37a349dc19 use try-with-resources in more places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817247 13f79535-47bb-0310-9956-ffa450edef68
2017-12-05 22:31:59 +00:00
PJ Fanning 49b7fd5342 use try-with-resources in more places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817238 13f79535-47bb-0310-9956-ffa450edef68
2017-12-05 21:23:44 +00:00
Javen O'Neal 3c1ce22865 bug 61840: close workbook to prevent resource leak in unit test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816893 13f79535-47bb-0310-9956-ffa450edef68
2017-12-01 17:51:19 +00:00
Javen O'Neal 38becac30c bug 61840: add unit test showing that shiftRows does not produce #REF! formula errors if cells are not shifted above the first row
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816892 13f79535-47bb-0310-9956-ffa450edef68
2017-12-01 17:47:29 +00:00
Nick Burch 0046b3e9a5 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816453 13f79535-47bb-0310-9956-ffa450edef68
2017-11-27 14:05:17 +00:00
Nick Burch 125371b901 Bump library version to match Ant defined version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816445 13f79535-47bb-0310-9956-ffa450edef68
2017-11-27 12:42:47 +00:00
Alain Béarez 3b8f806850 XDDF usermodel for Charts closes #68 on GitHub
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816383 13f79535-47bb-0310-9956-ffa450edef68
2017-11-26 14:03:01 +00:00
Andreas Beeker cbfb179254 #61809 - Infinite loop in SectionIDMap.get() and .put()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816205 13f79535-47bb-0310-9956-ffa450edef68
2017-11-24 01:02:20 +00:00
PJ Fanning e0c8416726 use try with resources in examples
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816189 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 20:03:25 +00:00
PJ Fanning 61cad2865e use try with resources in examples
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816187 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 19:28:36 +00:00
Dominik Stadler 625c511503 Don't try to collect junit results for Maven when we only run Sonar-tasks and thus skip unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816186 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 18:54:17 +00:00
Dominik Stadler db15fe7778 Change order of handling shape-types in copy() as FreeFormShape derives from AutoShape and thus would have not been copied correctly currently
Fix some Javadoc, some warnings and code duplications

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816185 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 18:54:11 +00:00
Dominik Stadler e93f78cd13 Ensure that the tempdir exists when we use ImageIO in one of the tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816046 13f79535-47bb-0310-9956-ffa450edef68
2017-11-22 12:25:11 +00:00
PJ Fanning caf7173f4a add TestStringCodepointsIterable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816020 13f79535-47bb-0310-9956-ffa450edef68
2017-11-22 09:57:45 +00:00
PJ Fanning 913d6bc086 use codepoint iterator in a few places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815998 13f79535-47bb-0310-9956-ffa450edef68
2017-11-22 01:07:24 +00:00
PJ Fanning acc7b356ee add forbidden api checks for non-Locale toLowerCase and toUpperCase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815994 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 22:10:48 +00:00
PJ Fanning 936f29af69 add forbidden api checks for non-Locale toLowerCase and toUpperCase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815989 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 21:33:51 +00:00
PJ Fanning d0ddfa9402 remove more uses of Character.toUpperCase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815988 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 21:11:07 +00:00
Dominik Stadler 731d089005 Try to set java.io.tmpdir for tests to avoid the strange permission errors that we see in CI-builds
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815963 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 17:32:48 +00:00
Dominik Stadler 4bc4e1f4e9 Ensure that no old version of commons-codec is lingering around and causes hard to find build errors locally
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815952 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 16:29:01 +00:00
Dominik Stadler dcd40982f3 Try if using a local temporary directory avoids the permission errors in unit tests in the Maven runs:
* Collect JUnit results
* Set java.io.tmpdir in Maven unit test runs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815951 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 16:28:07 +00:00
PJ Fanning bb40ff4fd3 [bug-61792] basic test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815873 13f79535-47bb-0310-9956-ffa450edef68
2017-11-20 23:58:13 +00:00
PJ Fanning 2d8c9cbc9a [bug-61792] some changes to avoid iterating over chars of Strings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815871 13f79535-47bb-0310-9956-ffa450edef68
2017-11-20 23:35:36 +00:00
PJ Fanning 18f87a1c18 upgrade to commons-codec 1.11
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815852 13f79535-47bb-0310-9956-ffa450edef68
2017-11-20 20:46:16 +00:00
Dominik Stadler a872c3495e Handle case where the JaCoCo zip file is available, but the extracted files are missing, not sure how that happens, but we see it on some CI machines...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815755 13f79535-47bb-0310-9956-ffa450edef68
2017-11-19 19:53:44 +00:00
Mark Murphy 9d0010088b javadocs and Quick page improvements for XSSF Header/Footer
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815706 13f79535-47bb-0310-9956-ffa450edef68
2017-11-19 01:35:07 +00:00