9683 Commits

Author SHA1 Message Date
Vladislav Galas
70b4b88a3a pulled *Cell.getCellTypeEnum() to common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852252 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:19:47 +00:00
Vladislav Galas
bc30eceb02 pulled *Cell.getAddress to common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852251 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:19:41 +00:00
Vladislav Galas
a8a0cb56f7 purged usages of Cell.setCellType (left only in tests, where conversions are tested)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852247 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 19:41:36 +00:00
Vladislav Galas
39d963aa33 made call Cell.setCellType(CellType.FORMULA) illegall. Deprecated Cell.setCellType(). Purged all redundant calls from project.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852246 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 19:41:25 +00:00
Vladislav Galas
19bf8b23d5 purged calls to cell.setCellType(CellType.BLANK) from the project, replaced with setBlank()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852245 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 19:41:10 +00:00
Vladislav Galas
d60cb3a18c added Cell.setBlank() - as an alias, for now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852244 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 19:40:56 +00:00
Vladislav Galas
1253a29571 setCellFormula: blank cell gets value 0, non-blank value is preserved
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852212 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 10:09:13 +00:00
Andreas Beeker
07e190317f try to fix missing modules error and move addOpens detection into ant build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852072 13f79535-47bb-0310-9956-ffa450edef68
2019-01-24 20:35:18 +00:00
Dominik Stadler
bf59b76c22 Add required --add-opens and other settings for JDK 12 on Windows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851804 13f79535-47bb-0310-9956-ffa450edef68
2019-01-22 10:45:26 +00:00
Dominik Stadler
5a10cc9e6b Jenkins: Try to disable coverage for JDK 13 for now as it seems to cause issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851803 13f79535-47bb-0310-9956-ffa450edef68
2019-01-22 10:23:58 +00:00
Dominik Stadler
a1529d0718 Jenkins: Add initial build for JDK 13, add build for JDK 12 on Windows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851798 13f79535-47bb-0310-9956-ffa450edef68
2019-01-22 10:07:02 +00:00
Dominik Stadler
c9f3de1c0e Fix invalid comment in build.xml
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851797 13f79535-47bb-0310-9956-ffa450edef68
2019-01-22 10:04:53 +00:00
Dominik Stadler
30cae305ca Fix passing in --add-opens for Java 9+ after the poiunit refactoring, this
only caused problems with Java 9+ on Windows, which we do not run in CI (yet)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851796 13f79535-47bb-0310-9956-ffa450edef68
2019-01-22 10:01:36 +00:00
Dominik Stadler
b5fe208770 Fix some IDE warnings and JVM deprecations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851795 13f79535-47bb-0310-9956-ffa450edef68
2019-01-22 10:00:01 +00:00
PJ Fanning
5a758864b5 try to fix xmlbeans build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851667 13f79535-47bb-0310-9956-ffa450edef68
2019-01-19 11:50:14 +00:00
Andreas Beeker
074709372d update xmlbeans targets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851657 13f79535-47bb-0310-9956-ffa450edef68
2019-01-18 23:14:06 +00:00
PJ Fanning
31934922c9 [github-140] add .travis.yml. Thanks to krichter722. This closes #140
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851312 13f79535-47bb-0310-9956-ffa450edef68
2019-01-15 00:49:16 +00:00
Yegor Kozlov
698d8eb006 follow-up to Bug 62904. More tests and improved evaluation of IF in array mode
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851263 13f79535-47bb-0310-9956-ffa450edef68
2019-01-14 14:48:21 +00:00
Dominik Stadler
8c18d93a66 Don't fail on row-nums larger than Integer.MAX_VALUE, we had one sample
file which triggered this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851211 13f79535-47bb-0310-9956-ffa450edef68
2019-01-13 17:14:31 +00:00
Dominik Stadler
db14c353fc Fix some Findbugs and IDE issues, refactor some duplicated code,
improve some exception texts, add comment for missing Ptg for SxName

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851210 13f79535-47bb-0310-9956-ffa450edef68
2019-01-13 17:14:24 +00:00
Dominik Stadler
068c820ef4 Bug 62810: AreaReference ctor looses sheet name if rows or columns swapped
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851209 13f79535-47bb-0310-9956-ffa450edef68
2019-01-13 17:14:05 +00:00
Dominik Stadler
88b9e48287 Add reproducer for bug 60355
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851208 13f79535-47bb-0310-9956-ffa450edef68
2019-01-13 17:13:57 +00:00
Dominik Stadler
c41ace92b6 Revert inadvertently commented lines
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851092 13f79535-47bb-0310-9956-ffa450edef68
2019-01-11 19:31:18 +00:00
Dominik Stadler
c1940b1ccd Remove obsolete settings from JDK 11/12 build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851091 13f79535-47bb-0310-9956-ffa450edef68
2019-01-11 19:31:14 +00:00
Dominik Stadler
73128a7183 Enable weekly run of Java 12 build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851090 13f79535-47bb-0310-9956-ffa450edef68
2019-01-11 19:31:09 +00:00
Dominik Stadler
32c43c068c IDE and JavaDoc fixes, move/remove some unfixed tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851089 13f79535-47bb-0310-9956-ffa450edef68
2019-01-11 19:31:05 +00:00
Dominik Stadler
a1a1797299 Add one more test for bug 62828 and fix some IDE warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851088 13f79535-47bb-0310-9956-ffa450edef68
2019-01-11 19:30:44 +00:00
Greg Woolsey
8b69fcc642 Bug #60977 writing XSSF with custom properties twice corrupts output
turns out the output XML data buffer for the custom properties document was appended to, not replaced, when writing in the presence of existing content.  Now clearing output buffer first in this case.  When first creating custom properties, i.e. first write after changes, there is no buffer yet, so nothing to clear.

Does not affect any read operations, or other writes beyond custom properties, as that was where the problem lay, not down in the Zip stuff.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851084 13f79535-47bb-0310-9956-ffa450edef68
2019-01-11 18:20:03 +00:00
PJ Fanning
131e3ee0ed use spaces for indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850926 13f79535-47bb-0310-9956-ffa450edef68
2019-01-10 08:13:00 +00:00
Yegor Kozlov
0cdc0ee985 Bug 63054: updated formulas in test spreadsheet to keep build happy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850772 13f79535-47bb-0310-9956-ffa450edef68
2019-01-08 16:36:34 +00:00
Yegor Kozlov
b85437ee88 Bug 63054: improved evaluation of array formulas with error in arguments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850742 13f79535-47bb-0310-9956-ffa450edef68
2019-01-08 12:54:39 +00:00
Vladislav Galas
f64aef7417 unified setCellType(null/_NONE) logic, setCellFormula(null) logic. updated javadoc and tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850676 13f79535-47bb-0310-9956-ffa450edef68
2019-01-07 19:10:19 +00:00
Yegor Kozlov
81033fbad0 Bug 62904: Support array arguments in IF and logical IS*** functions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850646 13f79535-47bb-0310-9956-ffa450edef68
2019-01-07 14:34:19 +00:00
Vladislav Galas
f3eb4dd393 updated mockito to 2.23.4 to fix java 11 build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850590 13f79535-47bb-0310-9956-ffa450edef68
2019-01-06 18:56:29 +00:00
PJ Fanning
0849bbc614 throw IllegalArgumnetException if null directory specified
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850394 13f79535-47bb-0310-9956-ffa450edef68
2019-01-04 16:07:53 +00:00
Vladislav Galas
6d87e36227 Fixed build (explicitly specified charset for new String(byte[]))
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850366 13f79535-47bb-0310-9956-ffa450edef68
2019-01-04 14:25:11 +00:00
Vladislav Galas
1f9b858ae5 Bug 63057: made SXSSFCell.setCellValue(String|RichTextString) exception-safe.
Also removed unused code.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850342 13f79535-47bb-0310-9956-ffa450edef68
2019-01-04 10:10:30 +00:00
Vladislav Galas
8600f64890 Improved test coverage for *Cell classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850338 13f79535-47bb-0310-9956-ffa450edef68
2019-01-04 09:17:48 +00:00
Vladislav Galas
3b8055baa0 Bug 62993: XSSFEvaluationSheet now retrieves valid last row index from underlying XSSFSheet. Thanks to Axel Howind.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850212 13f79535-47bb-0310-9956-ffa450edef68
2019-01-03 00:08:52 +00:00
Vladislav Galas
e501d4015d Bug 62828: CellReference(Cell) now initializes sheet name.
Changed CellReference to CellAddress in XSSFHyperlink because it is what it should return.
Updated all relevant tests, added a test for CellReference(Cell).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850210 13f79535-47bb-0310-9956-ffa450edef68
2019-01-02 22:08:38 +00:00
Vladislav Galas
3aec436a34 Bug 62307: made Cell#getNumericCellValue() behavior consistent across HSSF/XSSF/SXSSF.\nAll three implementations throw ISE when trying to get numeric value from a boolean-valued cell, have it a formula set or not.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850207 13f79535-47bb-0310-9956-ffa450edef68
2019-01-02 20:45:52 +00:00
Dominik Stadler
59a7919af6 Add missing revert() in OPCPackage to close Zip-streams always
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850115 13f79535-47bb-0310-9956-ffa450edef68
2019-01-01 20:10:58 +00:00
Dominik Stadler
fa24471916 Add missing file-close in ZipInputStreamZipEntrySource seen in some mass regression tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850114 13f79535-47bb-0310-9956-ffa450edef68
2019-01-01 20:10:51 +00:00
PJ Fanning
bfecad39e5 fix since annotation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850048 13f79535-47bb-0310-9956-ffa450edef68
2018-12-31 14:27:32 +00:00
Andreas Beeker
00afbded61 exclude integrationtest/build from rat-check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850041 13f79535-47bb-0310-9956-ffa450edef68
2018-12-31 12:27:31 +00:00
Andreas Beeker
d71a65c388 #63047 - Make POILogger subclassable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850040 13f79535-47bb-0310-9956-ffa450edef68
2018-12-31 12:07:37 +00:00
Dominik Stadler
dfb613a059 Adjust test for bug 60460 to also run fine on Windows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850022 13f79535-47bb-0310-9956-ffa450edef68
2018-12-31 09:05:05 +00:00
Dominik Stadler
85d6f81076 Bug 60460: Handle null workbook or sheet names and emit #REF as Excel does
instead of throwing NullPointerException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850008 13f79535-47bb-0310-9956-ffa450edef68
2018-12-30 22:44:40 +00:00
Dominik Stadler
faf53dcdb4 IDE and JavaDoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850007 13f79535-47bb-0310-9956-ffa450edef68
2018-12-30 22:44:29 +00:00
Dominik Stadler
648c8fffa1 Jenkins DSL: Disable XMLBeans-JDK-11 as it will not work yet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849970 13f79535-47bb-0310-9956-ffa450edef68
2018-12-30 10:07:56 +00:00