Commit Graph

9729 Commits

Author SHA1 Message Date
Greg Woolsey 82f9c29258 #60724 - Partial implementation for SUBTOTAL() 'ignore hidden rows' variations
The function still doesn't deal with auto-filtering, but it now handles variations that should skip hidden rows.

Taught the evaluation framework to know about hidden rows similar to what was already there for skipping subtotals within subtotal ranges.

Added unit test cases.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855789 13f79535-47bb-0310-9956-ffa450edef68
2019-03-18 19:09:11 +00:00
Andreas Beeker 19005a4e63 Fix forbidden apis error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855672 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 20:44:12 +00:00
Andreas Beeker aa438b6f2d Use JPG source, otherwise we have problems with Alpha conversion in OpenJDK.
https://stackoverflow.com/questions/3432388/imageio-not-able-to-write-a-jpeg-file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855668 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 20:13:55 +00:00
Yegor Kozlov 6ef332b48e Bug 61472: Convert date/time strings to numbers when evaluating formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855662 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 15:41:46 +00:00
Greg Woolsey ee83ce5fcd Handle possible invalid date value (#61652)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855627 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 06:55:16 +00:00
Greg Woolsey 8225326b56 #63264 Conditional Format rule evaluation calculates relative references incorrectly
Fixing the offset calculation and passing the top-left-most region rather than the region matching the current cell fixed these cases.  I've augmented unit tests to check for them to avoid future regressions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855619 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 00:27:13 +00:00
PJ Fanning 126606c838 fix some cases where iterator usage does not check hasNext
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855480 13f79535-47bb-0310-9956-ffa450edef68
2019-03-14 04:01:10 +00:00
Dominik Stadler 7f12edf416 Fix URL for test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855155 13f79535-47bb-0310-9956-ffa450edef68
2019-03-10 16:13:02 +00:00
Dominik Stadler ef369931e2 Bug 63221: Add margin-settings for top, bottom, left and right to XSSFPrintSetup
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855154 13f79535-47bb-0310-9956-ffa450edef68
2019-03-10 16:12:57 +00:00
Dominik Stadler 5329f25b0a Adjust test to not fail with Xerces XML Parser, fix some IDE warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855139 13f79535-47bb-0310-9956-ffa450edef68
2019-03-10 08:18:54 +00:00
Dominik Stadler dee032b11b Jenkins DSL: Enable job for running API-Check again now that we compare 4.x to 4.0.0
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855138 13f79535-47bb-0310-9956-ffa450edef68
2019-03-10 08:18:46 +00:00
PJ Fanning d6b5e936e9 [bug-63240] make SAXHelper.newXMLReader non-synchronized]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854941 13f79535-47bb-0310-9956-ffa450edef68
2019-03-06 19:17:22 +00:00
PJ Fanning 0786ae5b57 [bug-63240] make DocumentHelper.newDocumentBuilder non-synchronized]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854935 13f79535-47bb-0310-9956-ffa450edef68
2019-03-06 18:36:12 +00:00
Dominik Stadler 178ae9a9ff Jenkins DSL: Add XMLBeans-JDK-12, still disabled, though
Print out where we get Ant from
Use new 'jenkins' target for XMLBeans and fetch compiler warnings and JUnit results

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854720 13f79535-47bb-0310-9956-ffa450edef68
2019-03-03 14:09:58 +00:00
Dominik Stadler f9c799a751 Update file-leak excludes for XMLBeans/jaxb
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854719 13f79535-47bb-0310-9956-ffa450edef68
2019-03-03 14:09:54 +00:00
Dominik Stadler 302228dc24 Close more file-handles in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854718 13f79535-47bb-0310-9956-ffa450edef68
2019-03-03 14:09:50 +00:00
Dominik Stadler 4c017a0e27 Fix a regression test failure, toString() should never return null
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854717 13f79535-47bb-0310-9956-ffa450edef68
2019-03-03 14:09:40 +00:00
Dominik Stadler a9b2a8b2bd Bug 63200: Avoid NullPointerException in XSLFShape.selectPaint() and check some more in integration tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854639 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 12:28:19 +00:00
Dominik Stadler 53a30d796e Bug 62151: Fix warnings about illegal reflective access in Java 9+ by
using a similar approach as Apache Hadoop via a CleanerUtil class which encapsulates
the two different approaches for Java <= 8 and Java >= 9

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854630 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 09:19:45 +00:00
Dominik Stadler 421fffbd3f Fix detecting Java <= 8 vs. >= 9 to not detect Java 8 for version-string "11.x"
Add system property to junit to disable optimization in jaxb which causes illegal access in Java 9+
Add argument to junit to display all illegal accesses in Java 9+

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854629 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 09:18:15 +00:00
Dominik Stadler 00a274c656 Add batik-jars to findbugs-task
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854193 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:52:29 +00:00
Dominik Stadler 6a93b3a9ed Close file-handles for slideshows also when construction fails or when dual-storage is used
Also avoid file-leak reports in some tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854192 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:52:24 +00:00
Dominik Stadler 98b620889b Remove some remnants of NFileSystem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854191 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:52:06 +00:00
Dominik Stadler 8c6e95f597 Add some more testing for bug 63151: NullPointerException in HSSFOptimiser.optimiseFonts(), also execute it as part of large regression tests in the future
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854190 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:51:57 +00:00
Dominik Stadler 34d6410bc1 Adjust BaseIntegrationTest some more to better handle invalid file extensions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854189 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:51:48 +00:00
Yegor Kozlov cafa57cbdd Bug 60980: Fix parsing formulas with intersections in functions args
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854037 13f79535-47bb-0310-9956-ffa450edef68
2019-02-21 11:00:40 +00:00
PJ Fanning bf4396b375 [bug-63151] handle NPE in UnicodeString
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853859 13f79535-47bb-0310-9956-ffa450edef68
2019-02-19 06:27:04 +00:00
PJ Fanning 37ff2b7fb2 [bug-63187] fix typos
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853787 13f79535-47bb-0310-9956-ffa450edef68
2019-02-18 09:56:11 +00:00
Yegor Kozlov 48bf645360 Bug 63029: fixed failing test in test-ooxml-lite
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853523 13f79535-47bb-0310-9956-ffa450edef68
2019-02-13 18:37:20 +00:00
Yegor Kozlov 8350124e9b Bug 63029: revert handling NotOfficeXmlFileException in ZipPackage as this change broke the build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853474 13f79535-47bb-0310-9956-ffa450edef68
2019-02-13 06:45:14 +00:00
Yegor Kozlov caef630c70 Bug 63029: OPCPackage Potentially clobbers files on close()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853454 13f79535-47bb-0310-9956-ffa450edef68
2019-02-12 16:55:13 +00:00
Yegor Kozlov c438465b08 Bug 62980: Make D* functions ignore case in headings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853268 13f79535-47bb-0310-9956-ffa450edef68
2019-02-09 13:00:09 +00:00
Dominik Stadler fbbf3425a9 Jenkins DSL: Add more output in test-env-build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852309 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 21:17:01 +00:00
Andreas Beeker 5acdbb23df ... link external again
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852300 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 15:29:56 +00:00
Andreas Beeker ddb65d3832 remove new documentation directory and then ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852299 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 15:27:09 +00:00
Dominik Stadler 6dbf6520f3 Jenkins DSL: Adjust the list of JDKs that we look for in the testevn-job
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852284 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 10:28:50 +00:00
Vladislav Galas 0a299339f7 removed accidentally added release-notes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852283 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 10:18:26 +00:00
Dominik Stadler b7862cfe45 Add reproducing test-case for a bug we found newly introduced in JDK 12-ea+28
and fixed again in JDK 12-ea+29

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852281 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 09:58:08 +00:00
Dominik Stadler 60a98da8e8 Fix some IDE warnings and better output in unit test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852280 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 09:58:02 +00:00
Dominik Stadler 36a42899ff Exclude one more local file from rat-checks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852279 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 09:57:54 +00:00
Dominik Stadler e8ed5e3a8c Adjust handling of some exceptions in regression tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852278 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 09:57:49 +00:00
Dominik Stadler c376d662f9 Bug 60405: Add initial support for cetab functions so some macros can be
parsed
Add some function-definitions for Excel 4 Macros and missing functions
found in regression tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852277 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 09:57:39 +00:00
Dominik Stadler e59f9c6461 Ignore file-leaks from openjpa/derby/log4j for the regression tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852276 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 09:57:19 +00:00
Vladislav Galas a08b69df80 pulled *Cell.setCellValue(String), setCellValue(RichTextString) to the common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852255 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:20:07 +00:00
Vladislav Galas 53eee01b5d pulled *Cell.setCellValue(Date) and setCellValue(Calendar) to the common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852254 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:19:59 +00:00
Vladislav Galas 5da229797f pulled *Cell.setCellValue(double) to the common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852253 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:19:53 +00:00
Vladislav Galas 70b4b88a3a pulled *Cell.getCellTypeEnum() to common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852252 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:19:47 +00:00
Vladislav Galas bc30eceb02 pulled *Cell.getAddress to common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852251 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:19:41 +00:00
Vladislav Galas a8a0cb56f7 purged usages of Cell.setCellType (left only in tests, where conversions are tested)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852247 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 19:41:36 +00:00
Vladislav Galas 39d963aa33 made call Cell.setCellType(CellType.FORMULA) illegall. Deprecated Cell.setCellType(). Purged all redundant calls from project.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852246 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 19:41:25 +00:00