Commit Graph

10616 Commits

Author SHA1 Message Date
Andreas Beeker a4ed4359cc Sonar fixes
JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885308 13f79535-47bb-0310-9956-ffa450edef68
2021-01-09 18:24:51 +00:00
Andreas Beeker 1d676a098d Sonar fixes
JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885302 13f79535-47bb-0310-9956-ffa450edef68
2021-01-09 15:49:35 +00:00
Andreas Beeker 8631e6c9c9 Sonar fixes
JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885300 13f79535-47bb-0310-9956-ffa450edef68
2021-01-09 15:35:07 +00:00
Andreas Beeker a7d741fd17 Sonar fixes
JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885283 13f79535-47bb-0310-9956-ffa450edef68
2021-01-09 00:46:52 +00:00
Andreas Beeker 606a313c4c Sonar fixes
JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885281 13f79535-47bb-0310-9956-ffa450edef68
2021-01-08 23:50:02 +00:00
Andreas Beeker fb2a96a048 Sonar fixes
Fixed offset of compare picture in resize_compare.xlsx

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885280 13f79535-47bb-0310-9956-ffa450edef68
2021-01-08 22:56:05 +00:00
Andreas Beeker 09464f1fea Sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885253 13f79535-47bb-0310-9956-ffa450edef68
2021-01-08 00:26:16 +00:00
Dominik Stadler 4bc450ef5f Properly close file handles in extractors and when handling password-protected files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885229 13f79535-47bb-0310-9956-ffa450edef68
2021-01-07 06:52:57 +00:00
Dominik Stadler 1882dc74c9 Add one more file-leak-detector exclude
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885228 13f79535-47bb-0310-9956-ffa450edef68
2021-01-07 06:52:51 +00:00
Dominik Stadler ce701485d8 Improve EmptyFileException when the file actually does not exist at all
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885227 13f79535-47bb-0310-9956-ffa450edef68
2021-01-07 06:52:46 +00:00
Andreas Beeker dde88b1102 Sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885219 13f79535-47bb-0310-9956-ffa450edef68
2021-01-07 00:27:13 +00:00
Andreas Beeker 2125c37d31 #65063 - WMF parsing failed on closed empty polygon
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885215 13f79535-47bb-0310-9956-ffa450edef68
2021-01-06 23:14:45 +00:00
Andreas Beeker 4c0d0b1381 #65061 - Handle VmlDrawings containing spreadsheet-ml default namespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885197 13f79535-47bb-0310-9956-ffa450edef68
2021-01-06 12:39:02 +00:00
Dominik Stadler eba33ddb6f Include file-name in EmptyFileException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885192 13f79535-47bb-0310-9956-ffa450edef68
2021-01-06 09:10:41 +00:00
Dominik Stadler 7aa6b06085 Try to avoid error "Start point cannot equalendpoint"
Happened when trying to apply a gradient to an empty text,
let's use at least 1 gradient step always to avoid this.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885191 13f79535-47bb-0310-9956-ffa450edef68
2021-01-06 09:10:35 +00:00
Dominik Stadler a2fa70b15d Run all integration-test steps in manual test-method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885190 13f79535-47bb-0310-9956-ffa450edef68
2021-01-06 09:10:31 +00:00
Dominik Stadler c1397afbf3 Slightly adjust error message if requested allocations are too big
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885189 13f79535-47bb-0310-9956-ffa450edef68
2021-01-06 09:10:28 +00:00
Dominik Stadler da7725e3d6 Adjust one expected error message in integration-tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885188 13f79535-47bb-0310-9956-ffa450edef68
2021-01-06 09:10:25 +00:00
Dominik Stadler 47c5e9b08d Adjust assumption for one specific font-related exception on Windows
Otherwise it triggers too much and hides actual regression bugs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885187 13f79535-47bb-0310-9956-ffa450edef68
2021-01-06 09:10:21 +00:00
Dominik Stadler 42ca20ad59 Avoid unneeded Unicode characters which break compiling if encoding is not UTF-8
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885186 13f79535-47bb-0310-9956-ffa450edef68
2021-01-06 09:10:17 +00:00
Andreas Beeker 9573f059b6 Sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885179 13f79535-47bb-0310-9956-ffa450edef68
2021-01-05 23:40:36 +00:00
Dominik Stadler b7e9cb48d0 Bug 64132: Fix regression introduced by changing factories
We need to return EscherBlipRecord for all types in the defined range of recordId,
not UnknownEscherRecord.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885092 13f79535-47bb-0310-9956-ffa450edef68
2021-01-04 05:51:24 +00:00
Dominik Stadler 43e1d6eba6 Try to make Gradle build work
Add a dependency that is reported as missing locally with JDK 11
Combine common test-dependencies
Avoid running base-class BaseTestMissingWorkbook, only the derived class is actually a unit-test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885074 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 18:19:55 +00:00
Dominik Stadler a0b0e3a4a7 Enable XML result files for Gradle build to make them available for Jenkins CI
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885071 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 17:02:24 +00:00
Dominik Stadler f34b731e3a Allow JUnit 5 access to the parmaeters also on newer JDKs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885070 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 17:02:21 +00:00
Dominik Stadler 83383cd0b7 Ignore Font-issue with JDK 8 on Windows in another test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885069 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 17:02:18 +00:00
Dominik Stadler fcf123fc5b Apply some IDE suggestions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885068 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 17:02:14 +00:00
Dominik Stadler 695bea4e68 Fix file-leak-detector excludes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885067 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 17:02:08 +00:00
Dominik Stadler 218354f5b9 Bug 64494: Ensure "applyAlignment" in cell-styles is enabled when necessary
Also check it when fetching currently defined cell-alignment

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885059 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 12:01:08 +00:00
Dominik Stadler e59e84a213 Avoid test failing on Windows with JDK 8 because of an ArrayIndexOutOfBoundsException when handling fonts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885058 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 11:50:04 +00:00
Dominik Stadler e08a1785c3 ooxml-schema: trigger loading stress-documents as part of the normal unit-tests
The integration-tests are not executed for determining the parts of the schema
to include in the "lite" package and so we need to have a normal unit-test as well.
Add more documents which drag in some more parts from the ooxml-schema

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885057 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 11:49:59 +00:00
Dominik Stadler 622574f5f4 Bug 64450: Allow to parse a file where the relationship-id is an empty string
Also improve exception reporting by including more information and not
"hiding" the actual exception-cause in a log-statement.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885056 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 11:49:51 +00:00
Dominik Stadler 400a3ae631 Adjust Github Workflow to actually use newer version of Ant
setting the PATH or calling the ant-script did not work, one
actually needs to set ANT_HOME to make it work...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885055 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 11:49:45 +00:00
Andreas Beeker 620b8d2c5c Sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885035 13f79535-47bb-0310-9956-ffa450edef68
2021-01-02 21:00:18 +00:00
Andreas Beeker 6658a0b664 forbidden-apis-fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885022 13f79535-47bb-0310-9956-ffa450edef68
2021-01-01 23:26:25 +00:00
Andreas Beeker dc72c1a009 fix year agnostic date/test values
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885021 13f79535-47bb-0310-9956-ffa450edef68
2021-01-01 23:20:02 +00:00
Dominik Stadler 8347bb64ac Apply some IDE suggestions and fix some JavaDoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885012 13f79535-47bb-0310-9956-ffa450edef68
2021-01-01 15:51:30 +00:00
Dominik Stadler 685af351d1 Bug 64750: Do not use CTDataValidations.getCount(), instead only rely on getDataValidationArray
Field "count" seems to be optional according
to the schema, so by using only the array
Apache POI can read data validations from
workbooks that do not populate the
"count" field properly.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885011 13f79535-47bb-0310-9956-ffa450edef68
2021-01-01 15:51:19 +00:00
Andreas Beeker e4b70720be workaround NullPointerException when font family (of bullets) can't be determined
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884974 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 23:33:05 +00:00
Andreas Beeker 91eb4861b7 workaround "Width (0) and height (0) cannot be <= 0" error while rendering text with textures
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884966 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 23:13:23 +00:00
Andreas Beeker f7c50cfbe3 add failing regression test files
fix ooxml-lite packaging
fix PP97 dual storage file handling in extractor

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884962 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 22:56:36 +00:00
Dominik Stadler b231366fb6 Bug 64986: Support missing or blank match_type for function Match
Excel and LibreOffice use the default value in this case

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884959 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 21:40:12 +00:00
Dominik Stadler 99dc9ea7f3 Bug 64838: Do not populate cells with a paragraph when loading an existing document
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884958 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 21:40:06 +00:00
Dominik Stadler 42c4e7d89a Add unfixed test for bug 64759 and make the ones fail which depend on manual opening of files in Microsoft Excel for verification
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884957 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 21:40:01 +00:00
Dominik Stadler 6a7003ff4f Also replace for JUnit 5 in comments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884956 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 21:39:56 +00:00
Dominik Stadler 0172ec3d50 Adjust error-message on old files and simplify code slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884950 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 17:03:30 +00:00
Dominik Stadler d406b402dc Slightly re-arrange code to only perform computations if we do not exit the loop anyway
Also simplify code somewhat

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884949 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 17:03:27 +00:00
Dominik Stadler ac2e1d761e Bug 65009: Fix incorrect index for 1-based pictures
Adjusted somewhat from Github PR #211

Closes #211

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884948 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 17:03:23 +00:00
Dominik Stadler 1303f44abf Add missing jar-file for JavaDoc generation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884919 13f79535-47bb-0310-9956-ffa450edef68
2020-12-29 19:29:29 +00:00
Dominik Stadler de1ad1c44c Adjust some JavaDoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884918 13f79535-47bb-0310-9956-ffa450edef68
2020-12-29 19:29:27 +00:00