Commit Graph

9475 Commits

Author SHA1 Message Date
Tim Allison af9142e4b7 bug 62859 -- fix two potential NPEs when initializing XWPFSDTContent
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844920 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 19:06:18 +00:00
Dominik Stadler 960cbb7714 IDE warnings, slightly more tests and fix test to not leave a modified file behind
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844894 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 10:58:37 +00:00
Dominik Stadler a8fd70ec7f Adjust sample for creating comments to also create a .xlsx file
Enhance workbook factory to allow to create new empty workbooks as well

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844881 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:57 +00:00
Dominik Stadler 1d464ed131 Typos and IDE warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844879 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:43 +00:00
Dominik Stadler ebbceee6e7 Set NOSONAR, adjust test slightly and reformat code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844878 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:30 +00:00
Dominik Stadler 15518968ee Ignore directory ooxml-testlib
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844877 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:24 +00:00
Dominik Stadler 54cb281413 Set NOSONAR and reformat code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844876 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:19 +00:00
Dominik Stadler e55b94a9e1 Jenkins DSL: Adjust the view-description, but it is still commented out
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844875 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:13 +00:00
Dominik Stadler 7606b9293a Remove the workaround for a bug in JDK 11 which was fixed in ea+28
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844874 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:01 +00:00
PJ Fanning 59ee53ca71 fix class cast issur recently introduced in BaseXSSFFormulaEvaluator
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844311 13f79535-47bb-0310-9956-ffa450edef68
2018-10-19 07:43:04 +00:00
Greg Woolsey 6b433ae8b3 #62834 FormulaEvaluator.evaluateInCell() throws Exception
added cell type = formula check when looping through the shared formula range, to ignore any non-formula cells.

Also refactored a bit to enable passing in the evaluation context, as getCellFormula() uses it behind the scenes when evaluating a shared formula cell (has to shift the formula references based on the master cell).  Review of these changes is welcome, as always.

Checked all other code referencing the "SHARED" enum, and didn't see anything else that dealt with formula cell values and thus would need to notice non-formula cells.

Added unit test based on the failing file from Bugzilla.  Test failed until the fixed code was in place.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844295 13f79535-47bb-0310-9956-ffa450edef68
2018-10-19 01:11:47 +00:00
Yegor Kozlov 8bf556e856 Bug 62373: Support for FREQUENCY function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844238 13f79535-47bb-0310-9956-ffa450edef68
2018-10-18 13:46:04 +00:00
Nick Burch f490cd7c5d #62831 Fix WorkbookFactory.create with a subclass of File, eg from JFileChooser
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844116 13f79535-47bb-0310-9956-ffa450edef68
2018-10-17 14:24:59 +00:00
Nick Burch e95fc06929 Failing unit test for bug #62831
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844115 13f79535-47bb-0310-9956-ffa450edef68
2018-10-17 14:20:02 +00:00
Alain Béarez 444c8e9966 fix more LGTM alerts, in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1843557 13f79535-47bb-0310-9956-ffa450edef68
2018-10-11 14:50:27 +00:00
Tim Allison 870c1b2cf5 62815 -- some numeric values not correctly extracted from xlsb
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1843553 13f79535-47bb-0310-9956-ffa450edef68
2018-10-11 14:14:07 +00:00
Alain Béarez 65b7c9e273 fix most alerts reported by LGTM on OOXML
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1843481 13f79535-47bb-0310-9956-ffa450edef68
2018-10-10 17:49:53 +00:00
Andreas Beeker fbdbfa3fd3 add ignored resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1843354 13f79535-47bb-0310-9956-ffa450edef68
2018-10-09 22:18:55 +00:00
PJ Fanning e07b0284cf [bug-62807] fix typo in XSLFTableCell#removeBorder
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1843180 13f79535-47bb-0310-9956-ffa450edef68
2018-10-08 18:38:19 +00:00
PJ Fanning ecc4485e27 add stax entries to forbidden apis due to android issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1843009 13f79535-47bb-0310-9956-ffa450edef68
2018-10-06 09:38:58 +00:00
PJ Fanning ac6a401fd8 small adjustments to byte sizes in TestPackage zip-bomb tests to try fix test that fails on old-xerces harness
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842980 13f79535-47bb-0310-9956-ffa450edef68
2018-10-05 20:17:39 +00:00
PJ Fanning 2172d63be9 use jaxp transformer instead of dom serializer to try fix old-xerces test failure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842979 13f79535-47bb-0310-9956-ffa450edef68
2018-10-05 20:09:45 +00:00
PJ Fanning 45bcbd9828 use jaxp transformer instead of dom serializer to try fix old-xerces test failure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842974 13f79535-47bb-0310-9956-ffa450edef68
2018-10-05 19:52:24 +00:00
Alain Béarez 5821b3b32c adding tricks from other answers on StackOverflow
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842959 13f79535-47bb-0310-9956-ffa450edef68
2018-10-05 18:07:55 +00:00
Alain Béarez cffa31ed62 example from StackOverflow question 47065690
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842925 13f79535-47bb-0310-9956-ffa450edef68
2018-10-05 14:36:18 +00:00
Alain Béarez f446df6f66 more XDDF improvements based on SO examples
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842876 13f79535-47bb-0310-9956-ffa450edef68
2018-10-05 09:59:32 +00:00
PJ Fanning 621de405a6 [bug-62800] Fix null pointer exception if a picture shape has no blip id
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842782 13f79535-47bb-0310-9956-ffa450edef68
2018-10-04 07:47:27 +00:00
Alain Béarez b8248ceb1b XDDF improvements based on StackOverflow examples
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842728 13f79535-47bb-0310-9956-ffa450edef68
2018-10-03 14:32:34 +00:00
Alain Béarez 3f7c643c74 fix lgtm alerts in examples
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842707 13f79535-47bb-0310-9956-ffa450edef68
2018-10-03 11:51:41 +00:00
Alain Béarez 28d561fc50 change chart data to experiment diverse scripts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842687 13f79535-47bb-0310-9956-ffa450edef68
2018-10-03 08:20:50 +00:00
PJ Fanning 8a2b2f7fef deprecate unused Nullable class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842684 13f79535-47bb-0310-9956-ffa450edef68
2018-10-03 07:42:33 +00:00
PJ Fanning 5b890cb228 change method to get XMLEventFactory due to issues seen on Android SDK
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842683 13f79535-47bb-0310-9956-ffa450edef68
2018-10-03 07:36:12 +00:00
PJ Fanning 09f441ca46 disable junit xml collection
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842668 13f79535-47bb-0310-9956-ffa450edef68
2018-10-02 22:47:57 +00:00
PJ Fanning b784a7bc7b get xmlbeans job to build dist artifacts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842667 13f79535-47bb-0310-9956-ffa450edef68
2018-10-02 22:43:09 +00:00
PJ Fanning 208bfc627b get xmlbeans job to build dist artifacts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842666 13f79535-47bb-0310-9956-ffa450edef68
2018-10-02 22:36:25 +00:00
PJ Fanning 95b00fda0b rename xmlbeans job
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842663 13f79535-47bb-0310-9956-ffa450edef68
2018-10-02 22:24:09 +00:00
PJ Fanning 63c25f927e [bug-62796] remove use of Stax Namespace class from PackagePropertiesMarshaller
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842647 13f79535-47bb-0310-9956-ffa450edef68
2018-10-02 19:16:00 +00:00
PJ Fanning 488a84d188 try to fix xmlbeans jenkins job
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842629 13f79535-47bb-0310-9956-ffa450edef68
2018-10-02 14:55:09 +00:00
PJ Fanning 5cc7c598e7 try to set up xmlbeans build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842599 13f79535-47bb-0310-9956-ffa450edef68
2018-10-02 08:15:41 +00:00
Alain Béarez 5199f75fe3 extract valuable code from 54470 submitted patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842548 13f79535-47bb-0310-9956-ffa450edef68
2018-10-01 19:27:32 +00:00
PJ Fanning 510947d666 use StaxHelper to get event factory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842402 13f79535-47bb-0310-9956-ffa450edef68
2018-09-30 18:14:46 +00:00
PJ Fanning 874687c490 lgtm issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842302 13f79535-47bb-0310-9956-ffa450edef68
2018-09-29 09:33:52 +00:00
Dominik Stadler a070b90728 Jenkins DSL: Remove JDK 9 and adjust location of image for the project-logo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842275 13f79535-47bb-0310-9956-ffa450edef68
2018-09-28 17:43:07 +00:00
Dominik Stadler d2afc7ff27 Remove outdated comment for japicmp
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842274 13f79535-47bb-0310-9956-ffa450edef68
2018-09-28 17:43:02 +00:00
PJ Fanning 93af1ca43a fix lgtm issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842218 13f79535-47bb-0310-9956-ffa450edef68
2018-09-28 07:48:29 +00:00
PJ Fanning b3f0d80eb6 fix gradle build issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842217 13f79535-47bb-0310-9956-ffa450edef68
2018-09-28 07:42:47 +00:00
PJ Fanning 08cfbcc90b fix lgtm issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842216 13f79535-47bb-0310-9956-ffa450edef68
2018-09-28 07:33:59 +00:00
PJ Fanning 0746b23fc4 make OPCPackage#close() unsynchronized and add javadoc note saying method is not thread-safe
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842171 13f79535-47bb-0310-9956-ffa450edef68
2018-09-27 21:22:24 +00:00
PJ Fanning 44e86832f2 [bug-62768] synchronize OPCPackage#close()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842142 13f79535-47bb-0310-9956-ffa450edef68
2018-09-27 19:06:06 +00:00
PJ Fanning 43c57c26c2 [bug-62736] Relations on XSLFPictureShape are removed unconditionally. Thanks to Mate Borcsok
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842055 13f79535-47bb-0310-9956-ffa450edef68
2018-09-26 21:42:21 +00:00