d4e3df3192
make member variables final
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756361 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 08:09:32 +00:00
abae7473fc
extract string constant out of code
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756358 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 07:36:22 +00:00
253cba0f7b
simplify unit test using assertContainsIgnoreCase
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756357 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 07:31:43 +00:00
bab2627d86
add (meta) unit test for POITestCase
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756356 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 07:27:03 +00:00
4a89cfcd0e
whitespace, remove unused variable, expose Set interface for seenNotes, append \n character instead of String
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756348 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 05:23:34 +00:00
d97ab53cc4
bug 59773: move loop invariants out of for-loop for performance, use for-each instead of for loop when possible
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756345 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 04:42:31 +00:00
e726429d5f
Slightly simplify HWPF writing code, and add in-place write tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756003 13f79535-47bb-0310-9956-ffa450edef68
2016-08-11 15:27:33 +00:00
2bb05f3071
HWPF in-place write support
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756001 13f79535-47bb-0310-9956-ffa450edef68
2016-08-11 15:14:04 +00:00
79306792a0
Fix detecting Java 6 versus Java 7 or higher for Findbugs-version, this did not really work for some reason.
...
Use real Java version, not ant.java.version as this is not correctly set sometimes .
Also print out some more Ant-version-information
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755962 13f79535-47bb-0310-9956-ffa450edef68
2016-08-11 12:00:53 +00:00
fe172d48d9
prepare for 3.15-beta4
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755880 13f79535-47bb-0310-9956-ffa450edef68
2016-08-10 21:45:12 +00:00
500154c568
release prepare for 3.15-beta3 - pin documentation
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755878 13f79535-47bb-0310-9956-ffa450edef68
2016-08-10 21:44:15 +00:00
f3d0718158
release prepare for 3.15-beta3 - pin documentation
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755876 13f79535-47bb-0310-9956-ffa450edef68
2016-08-10 21:40:39 +00:00
4f5b8adc13
Remove incorrectly set svn:executable flags
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755847 13f79535-47bb-0310-9956-ffa450edef68
2016-08-10 20:32:20 +00:00
78757a66b1
Print out version of findbugs/java to research why we chose the wrong one in CI
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755222 13f79535-47bb-0310-9956-ffa450edef68
2016-08-04 17:50:42 +00:00
5b4f46e180
Whitespace, javadocs and @Overrides for the Logger classes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755192 13f79535-47bb-0310-9956-ffa450edef68
2016-08-04 14:23:54 +00:00
a57e5b7b93
Switch XSSF onto BaseFormulaEvaluator, reducing code duplication and fixing XSSFFormulaEvaluator.evaluateAll() to mirror HSSF and use any setup referenced workbooks (stackoverflow #38706562 )
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755079 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:53:43 +00:00
8578dfe70a
Refactor out some of the common FormulaEvaluator logic from HSSF to a base class (XSSF coming shortly)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755070 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:42:04 +00:00
b61ed84a8f
Whitespace / indents
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755068 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:15:13 +00:00
07dc4cecc4
Whitespace / indents
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755066 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:12:50 +00:00
43588abe0c
Fix eclipse classpath - collections is in core lib
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755062 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 10:20:10 +00:00
6d72fb97cc
Tweak
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754849 13f79535-47bb-0310-9956-ffa450edef68
2016-08-02 08:38:17 +00:00
58603eebfc
Test
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754848 13f79535-47bb-0310-9956-ffa450edef68
2016-08-02 08:36:12 +00:00
d37c4a6fe0
Test commit
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754847 13f79535-47bb-0310-9956-ffa450edef68
2016-08-02 08:35:25 +00:00
99748cc5da
Tweak
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754846 13f79535-47bb-0310-9956-ffa450edef68
2016-08-02 08:31:52 +00:00
a8516e9ad6
Trivial change to test SVN is working again
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754845 13f79535-47bb-0310-9956-ffa450edef68
2016-08-02 08:29:37 +00:00
5217c22a98
bug 59922: rename XSSFPaswordHelper to XSSFPasswordHelper
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754786 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 18:20:43 +00:00
f8a40e8822
bug 59922: make XSSFPasswordHelper internal because it works on XmlObject objects, which are generally an internal implementation detail of POI-OOXML
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754785 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 18:03:36 +00:00
2a591f12a0
whitespace; +svn:eol-style=native
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754784 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 18:01:24 +00:00
5b5d4c6777
whitespace
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754782 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 17:36:06 +00:00
22623b78bc
Fix zero-padding and handling of empty passwords (meaning protection on, but no password to remove it) for XSSF workbook protection.
...
https://bz.apache.org/bugzilla/show_bug.cgi?id=59920
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754744 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 12:51:24 +00:00
9c591aa822
Rename and add missing license header
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754705 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 06:23:36 +00:00
ff55ea0bd1
javadoc fix: incorrect deprecated replacement
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754702 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 05:32:41 +00:00
c1d12f4dc0
revert changes made in r1754691
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754700 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 04:21:14 +00:00
7e9ba83c24
correction to junit bugs in r1754691
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754698 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 02:53:55 +00:00
378dbebea8
Javadoc fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754694 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 00:17:33 +00:00
5ec21e741d
Add new class Cell Style Template and supporting enum for drawing borders
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754691 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 23:59:02 +00:00
b9f01a0d81
Add coverage of function WEEKDAY
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754689 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 21:24:13 +00:00
cce2fb67a2
Fix download-location of commons-logging4 jar and add it to FindBugs and bin-files target correctly
...
Add ant-jar to findbugs target as it is needed for excelant-code-check now
Fail on error when running Findbugs (still not on found warnings!)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754688 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 21:23:34 +00:00
f37885267c
Allow to specify -addmods for Java 9 support, update to JaCoCo 0.7.7 for initial Java 9 support and add target to create a combined JUnit report
...
Conflicts:
build.xml
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754687 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 21:23:25 +00:00
ba1b94a012
Exclude package sl.draw.binding from coverage-counting as this is generated code
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754676 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:37 +00:00
cb43dfe6eb
Test a few more cases of function INDIRECT()
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754675 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:33 +00:00
1f15f25cb8
Bug 59736: Incorrect evaluation of SUBTOTAL with composite interval
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754674 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:27 +00:00
673bf4779b
IDE warnings and fix a few places where we do not close resources in tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754673 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:17 +00:00
1074028b9e
Adjust build:
...
* Use "skipexisting" in Get from Ant 1.8
* Do not always re-run ooxml-lite
* Findbugs does not require src- and javadocs-jars, so depend on "jar" instead of "assemble"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754672 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:05 +00:00
1728592b97
Sonar wants to know about the new commons collections dependency too!
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754620 13f79535-47bb-0310-9956-ffa450edef68
2016-07-30 12:39:16 +00:00
0890a7f703
Move commons collections 4 dependency to main
...
https://bz.apache.org/bugzilla/show_bug.cgi?id=59734
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754602 13f79535-47bb-0310-9956-ffa450edef68
2016-07-30 08:54:50 +00:00
753699e48a
As Nick suspected, the dependency is actually from HSSF too so commons collections 4 needs adding to the main POM
...
https://bz.apache.org/bugzilla/show_bug.cgi?id=59734
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754563 13f79535-47bb-0310-9956-ffa450edef68
2016-07-29 18:48:07 +00:00
e18a65b6df
Javadoc fix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754530 13f79535-47bb-0310-9956-ffa450edef68
2016-07-29 14:03:28 +00:00
aa17ae0b1e
Introduce name-based methods for access to named ranges in a workbook, and deprecate the old index-based methods.
...
Re-organise internally to use a map so that lookup is O(1) rather than O(n ranges).
Add a dependency on commons collections 4, also ASL licensed so no problem.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59734
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754521 13f79535-47bb-0310-9956-ffa450edef68
2016-07-29 13:24:00 +00:00
07b249db81
Bug 55384: Handle setting pre-evaluation string correctly in SXSSF as well
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754328 13f79535-47bb-0310-9956-ffa450edef68
2016-07-27 18:15:54 +00:00
Javen O'Neal
Nick Burch
Dominik Stadler
David North
Mark Murphy