Cwikius-Spring/spring-security
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-security.git synced 2025-06-15 16:42:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

SEC-3082: make SavedRequest parameters case sensitive

Browse Source
This commit is contained in:
Rob Winch 2015-10-29 16:51:49 -05:00
parent 56e41df964
commit 1c22ec19e6
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/main/java/org/springframework/security/web/savedrequest/DefaultSavedRequest.java
View File

@ -57,7 +57,7 @@ public class DefaultSavedRequest implements SavedRequest {
private final ArrayList<SavedCookie> cookies = new ArrayList<SavedCookie>(); private final ArrayList<SavedCookie> cookies = new ArrayList<SavedCookie>();
private final ArrayList<Locale> locales = new ArrayList<Locale>(); private final ArrayList<Locale> locales = new ArrayList<Locale>();
private final Map<String, List<String>> headers = new TreeMap<String, List<String>>(String.CASE_INSENSITIVE_ORDER); private final Map<String, List<String>> headers = new TreeMap<String, List<String>>(String.CASE_INSENSITIVE_ORDER);
private final Map<String, String[]> parameters = new TreeMap<String, String[]>(String.CASE_INSENSITIVE_ORDER); private final Map<String, String[]> parameters = new TreeMap<String, String[]>();
private final String contextPath; private final String contextPath;
private final String method; private final String method;
private final String pathInfo; private final String pathInfo;

11
web/src/test/java/org/springframework/security/web/savedrequest/DefaultSavedRequestTests.java
View File

@ -30,12 +30,15 @@ public class DefaultSavedRequestTests {
assertTrue(saved.getHeaderValues("if-none-match").isEmpty()); assertTrue(saved.getHeaderValues("if-none-match").isEmpty());
} }
// TODO: Why are parameters case insensitive. I think this is a mistake // SEC-3082
@Test @Test
public void parametersAreCaseInsensitive() throws Exception { public void parametersAreCaseSensitive() throws Exception {
MockHttpServletRequest request = new MockHttpServletRequest(); MockHttpServletRequest request = new MockHttpServletRequest();
request.addParameter("ThisIsATest", "Hi mom"); request.addParameter("AnotHerTest", "Hi dad");
DefaultSavedRequest saved = new DefaultSavedRequest(request, new MockPortResolver(8080, 8443)); request.addParameter("thisisatest", "Hi mom");
DefaultSavedRequest saved = new DefaultSavedRequest(request,
new MockPortResolver(8080, 8443));
assertEquals("Hi mom", saved.getParameterValues("thisisatest")[0]); assertEquals("Hi mom", saved.getParameterValues("thisisatest")[0]);
assertNull(saved.getParameterValues("anothertest"));
} }
} }