Lars Grefer
ff1070df36
remove redundant modifiers found by checkstyle
2019-08-10 00:18:56 +02:00
Lars Grefer
3ea9d376b2
Cleanup explicit type arguments
2019-07-10 09:32:41 -05:00
Spring Operator
b93528138e
URL Cleanup
...
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).
# Fixed URLs
## Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.
* http://www.apache.org/licenses/ with 1 occurrences migrated to:
https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/ ) result 200).
* http://www.apache.org/licenses/LICENSE-2.0 with 2691 occurrences migrated to:
https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0 ) result 200).
* http://www.apache.org/licenses/LICENSE-2.0.html with 2 occurrences migrated to:
https://www.apache.org/licenses/LICENSE-2.0.html ([https](https://www.apache.org/licenses/LICENSE-2.0.html ) result 200).
2019-03-14 15:46:20 -05:00
Johnny Lim
88181c31f1
Polish ActiveDirectoryLdapAuthenticationProviderTests
...
This commit polishes ActiveDirectoryLdapAuthenticationProviderTests.contextEnvironmentPropertiesUsed() by:
- Adding fail() to prevent from going through an unexpected path.
- Asserting that the root cause is an instance of ClassNotFoundException as the current code doesn't seem to right.
2018-08-26 21:31:39 -05:00
Yuri Konotopov
669b0ba583
ActiveDirectoryLdapAuthenticationProvider custom environment
...
This change allows to inject custom environment properties for directory
context initialization.
Fixes: gh-2312
2018-08-21 12:14:36 -05:00
Johnny Lim
57353d18e5
Use diamond type
2017-12-21 15:09:00 -06:00
Johnny Lim
b6895e6359
Apply Checkstyle WhitespaceAfterCheck module
2017-11-16 11:18:31 -06:00
Trygve Aasjord
8d717c62af
Pass username as second parameter for search filter.
...
Allows the username only (without domain) to be used in custom search filter like "sAMAccountName={1}",
in eg. situations where the userPrincipalName has a different suffix than domain.
Thanks to contributors in issue.
fixes gh-2448
2017-10-29 23:58:58 -05:00
Rob Winch
3a4a32e654
Remove LdapShaPasswordEncoder from core
...
Issue: gh-4674
2017-10-24 07:56:20 -05:00
Rob Winch
23f56f568c
Update MockitJunitRunner import
...
Issue: gh-4608
2017-10-09 16:13:33 -05:00
Rob Winch
445834784a
Update to Mockito 2.10.0
...
Issue: gh-4608
2017-10-09 16:13:11 -05:00
Rob Winch
e16b8e7976
Fix logback-test.xml
2017-08-17 16:42:01 -05:00
Rob Winch
b443baef04
Polish GrantedAuthorityDefaults
...
* Move GrantedAuthorityDefaults to config module
* Move setting of default role into config module vs
ApplicationContextAware
Issue gh-3701
2016-09-22 15:13:05 -05:00
Eddú Meléndez
eabeaf35d6
Make single definition of `defaultRolePrefix` and `rolePrefix`
...
Previous to this commit, role prefix had to be set in every class
causing repetition. Now, bean `GrantedAuthorityDefaults` can be used to
define the role prefix in a single point.
Fixes gh-3701
2016-09-21 14:55:41 -05:00
Juan Ignacio Barisich
1171e25bc7
LdapUserDetails extends CredentialsContainer
...
LdapUserDetails extends CredentialsContainer in order to clear password when erase-credentials is true.
Fixes gh-4029
2016-08-19 12:26:07 -04:00
Eddú Meléndez
13b0ddb7e6
Fix test assertions
2016-07-07 13:29:00 -05:00
Eddú Meléndez
a2ead4cf7a
Polish
...
Fixes gh-3892
2016-06-20 12:35:43 -05:00
Rob Winch
f221920a19
Clean up code to conform to basic checkstyle
...
Issue gh-3746
2016-03-14 00:15:12 -05:00
Billy Korando
71d4ce96ad
Convert to assertj
...
Fixes gh-3175
2016-03-09 14:30:17 -06:00
Rob Winch
bb600a473e
Start AssertJ Migration
...
Issue gh-3175
2016-03-09 14:26:30 -06:00
Rob Winch
ae6af5d73c
SEC-2915: Updated Java Code Formatting
2015-03-25 13:09:18 -05:00
Rob Winch
3adbf53502
SEC-2897: ActiveDirectoryLdapAuthenticationProvider uses bindPrincipal
2015-03-10 16:33:48 -05:00
Chris Bonham
d579d00892
SEC-2559: Added missing givenName attribute to Person
2015-02-24 23:50:09 -06:00
Rob Winch
c0fbd30e65
SEC-2071: Move optional constructor arg last
2015-02-24 23:35:45 -06:00
Henri Tremblay
fbb902c9b5
SEC-2071: ActiveDirectoryLdapAuthenticationProvider custom rootDn
...
Allow to provide a root DN different from the domain
2015-02-24 23:33:42 -06:00
Rob Winch
cd352f665b
SEC-1915: Polish
...
* Restore default search filter to remain passive
* Check the search filter in setSearchFilter
* Add additional tests
2015-02-24 21:37:49 -06:00
Mateusz Rasiński
c54346b690
SEC-1915: Custom ActiveDirectory search filter
...
Currently the search filter used when retrieving user details is hard coded.
New property in ActiveDirectoryLdapAuthenticationProvider:
- searchFilter - the LDAP search filter to use when searching for authorities,
default to search using 'userPrincipalName' (current) OR 'sAMAccountName'
2015-02-24 21:14:58 -06:00
Rob Winch
1761b29e58
SEC-2690: String[]->List<String>
...
Use Collections rather than Arrays since Collections can be immutable.
2014-07-28 16:25:27 -05:00
Rob Winch
6b43b261bc
SEC-2690: Formatting cleanup
2014-07-28 12:41:56 -05:00
Filip Hanik
93b863d2e5
SEC-2690: Support static nested groups in LDAP
...
This refers to groups that have member: <another group DN> as an attribute
- Add in a utility method in the SpringSecurityLdapTemplate to retrieve multiple attributes and their values from an LDAP record
- Make the DefaultLdapAuthoritiesPopulator more extensible
- Add an LdapAuthority object that holds the DN in addition to other group attributes
- Add a NestedLdapAuthoritiesPopulator to search statically nested groups
2014-07-28 12:40:19 -05:00
Rob Winch
a7005bd742
SEC-2500: Prevent anonymous bind for ActiveDirectoryLdapAuthenticator
2014-03-10 14:33:39 -05:00
Rob Winch
5bc6f64b03
SEC-2405: Added tests for OBJECT_FACTORIES
2013-11-20 14:04:15 -06:00
Mattias Hellborg Arthursson
bc6fc518d3
SEC-2405: Use DirContextAdapter directly from search. Configure OBJECT_FACTORIES on DirContext created for ActiveDirectory.
2013-11-20 13:51:51 -06:00
Rob Winch
e6593151fc
SEC-2017: Convert IncorrectResultsSizeException.size() == 0 to BadCredentialsException in ActiveDirectoryAuthenticationProvider
2012-08-01 16:19:57 -05:00
Rob Winch
a5ec116e80
SEC-1919: Log error when fail to communicate with LDAP
...
Previously communication errors with LDAP were only logged at debug level.
Communication errors (along with other non-authenticated related NamingExceptions)
are now logged as error messages. We created an InternalAuthetnicationServiceException
to represent errors that should be logged as errors to distinguish between internal
and external authentication failures. For example, we do not want an OpenID Provider
being able to report errors that cause our logs to fill up. However, an LDAP system is
internal and should be trusted so logging at an error level makes sense.
2012-07-31 16:55:48 -05:00
Rob Winch
37aed0660d
SEC-1938: Add ActiveDirectoryAuthenticationException as caused by for ActiveDirectoryAuthenticationProvider
...
Previously there was no way to extract the original exception or to easily
obtain details about the failure if Spring Security was not able to translate
the exception into a Spring Security AuthenticationException.
Now the caused by is an ActiveDirectoryAuthenticationException which contains
the original Active Directory error code.
2012-07-31 09:34:06 -05:00
Luke Taylor
373d07ce46
SEC-1181: Added mock testing, to avoid need for AD server
2011-04-15 20:10:48 +01:00
Luke Taylor
59ac4c8b96
SEC-1181: Added option to parse AD sub-error codes.
2011-04-15 20:10:48 +01:00
Luke Taylor
530f686149
SEC-1181: Basic AuthenticationProvider for Active Directory.
2011-04-15 20:10:47 +01:00
Luke Taylor
a225dc3776
SEC-1677: Split out integration tests from LDAP test code.
2011-02-14 15:02:40 +00:00
Luke Taylor
eb9482b33b
Removal of some unused internal methods, plus additional tests for some areas lacking coverage.
2011-02-07 00:24:20 +00:00
Luke Taylor
a790c7e192
SEC-1670: Take account of JNDI CompositeName escaping in value of SearchResult.getName() when performing a search for a user entry in SpringSecurityLdapTemplate.
2011-02-03 17:57:43 +00:00
Luke Taylor
077af5e187
SEC-1661: Use a DistinguishedName to wrap the search base to avoid the need for JNDI escaping.
2011-01-26 17:13:11 +00:00
Luke Taylor
592782dc7f
Added test for getAdditionalRoles in DefaultLdapAuthoritiesPopulator.
2010-12-20 17:31:14 +00:00
Luke Taylor
eebcfd28ef
Move Ldap authorities populator tests to the correct package.
2010-12-20 17:23:43 +00:00
Luke Taylor
dbe270f132
SEC-1641: Correct code and test for null groupSearchBase.
2010-12-20 16:50:37 +00:00
Luke Taylor
3547cfcc92
SEC-1641: Remove the private setGroupSearchBase method and allowed a null value to be set for the group search base in the constructor.
2010-12-19 17:33:26 +00:00
Luke Taylor
1c8d28501c
SEC-1550: Convert signatures to use Collection<? extends GrantedAuthority> where appropriate.
2010-11-03 13:48:59 +00:00
Luke Taylor
20988c8cf6
Minor refactoring of debug filter and tidying up tests.
2010-08-27 01:49:30 +01:00
Luke Taylor
bdb906e588
Enable parameterization for log levels in logback files to allow the use of command-line options for controlling log output.
2010-08-24 18:25:39 +01:00