8866fa6fb0
Always use 'this.' when accessing fields
...
Apply an Eclipse cleanup rules to ensure that fields are always accessed
using `this.`. This aligns with the style used by Spring Framework and
helps users quickly see the difference between a local and member
variable.
Issue gh-8945
2020-08-24 17:33:07 -05:00
6894ff5d12
Make classes final where possible
...
Update classes that have private constructors so that they are also
declared final. In a few cases, inner-classes used private constructors
but were subclassed. These have now been changed to have package-private
constructors.
Issue gh-8945
2020-08-24 17:33:07 -05:00
b5d499e2eb
Remove empty block
...
Refactor a few classes so that empty blocks are not longer used. For
example, rather than:
if(x) {
} else {
i++;
}
use:
if(!x) {
i++;
}
Issue gh-8945
2020-08-24 17:33:07 -05:00
37fa94fafc
Organize imports
...
Use "organize imports" from Eclipse to cleanup import statements so
that they appear in a consistent and well defined order.
Issue gh-8945
2020-08-24 17:33:07 -05:00
5f64f53c3f
Use consistent "@" tag order in Javadoc
...
Ensure that Javadoc "@" tags appear in a consistent and well defined
order.
Issue gh-8945
2020-08-24 17:33:07 -05:00
7f0653fa34
Remove array style checkstyle suppression
...
Remove the array style rules suppression since it doesn't cause any
checkstyle violations.
Issue gh-8945
2020-08-24 17:33:07 -05:00
863c0873dd
Suppress third-party code from checkstyle
...
Suppress `BCrypt` and `ComparableVersion` from checkstyle since these
source files were developed by a third-party.
Issue gh-8945
2020-08-24 17:33:07 -05:00
8142e4046f
Use compact annotation style
...
Always use compact annotations when possible. For example, replace
`@Target(value = ElementType.TYPE)` with `@Target(ElementType.TYPE)`.
Issue gh-8945
2020-08-24 17:33:07 -05:00
aea0fea5d9
Add Spring Checkstyle with all checks disabled
...
Introduce checkstyle rules from spring-javaformat, but keep them
disabled so that fixes can be introduced one commit at a time.
Issue gh-8945
2020-08-24 17:33:07 -05:00
71bc145ae4
Remove superfluous comments
...
Use '^\s+//\ \~\ .*$' and '^\s+//\ ============+$' regular expression
searches to remove superfluous comments.
Prior to this commit, many classes would have comments to indicate
blocks of code (such as constructors/methods/instance fields). These
added a lot of noise and weren't all that helpful, especially given
the outline views available in most modern IDEs.
Issue gh-8945
2020-08-24 17:33:07 -05:00
b7fc18262d
Reformat code using spring-javaformat
...
Run `./gradlew format` to reformat all java files.
Issue gh-8945
2020-08-24 17:32:56 -05:00
81d9c6cac5
Add spring-javaformat plugin
...
Add spring-javaformat plugin but disable it for all sample projects.
Issue gh-8945
2020-08-10 16:24:44 -05:00
9caa39e370
Fix malformed formatter-on/off javadoc
...
Remove the formatter-on/formatter-off comments from Javadoc examples
so that they don't confuse checkstyle. The comments are not necessary
in the Javadoc since `pre` blocks are not formatted in the same
way as code.
Issue gh-8945
2020-08-10 16:24:44 -05:00
8e092f8d2c
Add noformat blocks around withDefaultPasswordEncoder
...
Find `withDefaultPasswordEncoder` calls and protect them against
formatting.
Issue gh-8945
2020-08-10 16:24:44 -05:00
6979125ccf
Add noformat blocks around User.withUsername
...
Find `User.withUsername` calls and protect them against formatting.
Issue gh-8945
2020-08-10 16:24:44 -05:00
63b5998fad
Add noformat blocks around auth config
...
Find `auth` config using a regex search of `^\s*auths*$` and protect
them against formatting.
Issue gh-8945
2020-08-10 16:24:44 -05:00
103d822e46
Add noformat blocks around http config
...
Find `http` config using a regex search of `^\s*https*$` and protect
them against formatting.
Issue gh-8945
2020-08-10 16:24:44 -05:00
27ac046d8a
Rename *Test.java -> *Tests.java
...
Rename a few test classes that accidentally ended in `Test` instead of
`Tests`.
Issue gh-8945
2020-08-10 16:24:44 -05:00
94cf4d1de7
Fix SNAPSHOT builds
...
- Stop using deprecated RSocket APIs
- Update SNAPSHOT build to use Boot SNAPSHOT
2020-08-10 11:35:15 -05:00
12a8795c3d
Fix typo in resource server docs
2020-08-06 14:11:13 +02:00
7cc10ed277
Fix Email notifications
2020-08-05 14:11:57 -05:00
a30541fcd9
Next Development Version
...
NOTE:
The 5.4.0-RC1 release has been tagged at 74b42ba956
2020-08-05 15:03:27 -04:00
1d74d556c2
Revert "Lock Dependency Versions for 5.4.0-RC1"
...
This reverts commit f3a1e5d40c
2020-08-05 14:59:11 -04:00
74b42ba956
Move RSocket integration tests to integration tests
...
Closes gh-8944
2020-08-05 13:23:20 -05:00
10dbe140c9
Release 5.4.0-RC1
2020-08-05 13:46:57 -04:00
f3a1e5d40c
Lock Dependency Versions for 5.4.0-RC1
2020-08-05 13:46:11 -04:00
a701555318
Polish Saml2AuthenticationTokenConverter
...
Issue gh-8768
2020-08-05 10:08:47 -06:00
f82190b414
Add RelyingPartyRegistrations
...
Closes gh-8484
2020-08-05 10:08:47 -06:00
506786f46e
Replaced Spaces with Tabs
...
Updated the .gradle file for SAML 2.0 Service Provider to use tabs
2020-08-05 10:08:47 -06:00
b999faa5a0
Complete SAML 2.0 SP Metadata Endpoint
...
Closes gh-8693
2020-08-05 10:08:47 -06:00
8a355240bc
SAML 2.0 SP Metadata Endpoint Support
...
Issue gh-8693
2020-08-05 10:08:47 -06:00
31bae546e2
Removed Unused Files
...
Saml2Utils and Saml2ServletUtils are no longer used
Issue gh-8768
2020-08-05 10:08:46 -06:00
1361cb8790
Use reactor-netty-http for snapshot build
...
Closes gh-8909
2020-08-05 11:50:50 -04:00
aeafe04260
Remove need for WebSecurityConfigurerAdapter
...
Closes gh-8804
2020-08-05 10:10:12 -04:00
5061ae9e79
Add Saml2AuthenticationTokenConverter
...
Closes gh-8768
2020-08-04 18:41:43 -06:00
a10c2c6cf8
Polish DefaultSaml2AuthenticationRequestContextResolver
...
Issue gh-8360
Issue gh-8887
2020-08-04 17:29:13 -06:00
015281ff53
Add DefaultRelyingPartyRegistrationResolver
...
Closes gh-8887
2020-08-04 17:29:10 -06:00
a402c3884a
Add ConditionValidator Support
...
Closes gh-8769
2020-08-04 13:05:23 -06:00
d9d8253603
Polish OpenSamlAuthenticationProvider
...
Issue gh-8769
2020-08-04 13:05:23 -06:00
3bc0b8c144
Revert "Fix snapshot build failure related to reactor-netty"
...
This reverts commit f37714a26f
2020-08-04 14:24:32 -04:00
f37714a26f
Fix snapshot build failure related to reactor-netty
...
Closes gh-8909
2020-08-04 14:17:03 -04:00
8146b1fdda
Deprecate CustomUserTypesOAuth2UserService
...
Closes gh-8908
2020-08-04 13:23:44 -04:00
73e550a867
Polish gh-8906
2020-08-04 11:16:26 -04:00
0ed919f072
Deprecate ClientRegistration.redirectUriTemplate
...
Closes gh-8906
2020-08-04 11:03:29 -04:00
a0c10f2df6
Allow for custom ClientRegistration.clientAuthenticationMethod
...
Closes gh-8903
2020-08-04 08:48:56 -04:00
11cc94afd8
Deprecate ImplicitGrantConfigurer
...
Closes gh-8902
2020-08-04 07:26:58 -04:00
4e5a304a8a
Remove use of Mono.deferWithContext()
...
Closes gh-8901
2020-08-04 07:26:32 -04:00
dfaf251970
Resolve Bearer token after subscribing to publisher
...
Bearer token was resolved immediately after calling method convert. In situations when malformed token was provided or authorization header and access token query param were present in request exception was thrown instead of signalling error.
After this change Bearer token is resolved on subscription and invalid states are handled by signaling error to subscriber.
Closes gh-8865
2020-08-03 11:04:21 -05:00
e770a21589
Revert "Fix build error related to Mono.deferWithContext()"
...
This reverts commit 104d785210
2020-07-31 13:02:25 -05:00
f6e47830fe
Remove unused import
...
Issue gh-8589
2020-07-31 08:37:32 -06:00
Phillip Webb
Rob Winch
Eleftheria Stein
Joe Grandja
Josh Cummings
Jakub Kubrynski
Dávid Kováč