Phillip Webb
8866fa6fb0
Always use 'this.' when accessing fields
...
Apply an Eclipse cleanup rules to ensure that fields are always accessed
using `this.`. This aligns with the style used by Spring Framework and
helps users quickly see the difference between a local and member
variable.
Issue gh-8945
2020-08-24 17:33:07 -05:00
Phillip Webb
6894ff5d12
Make classes final where possible
...
Update classes that have private constructors so that they are also
declared final. In a few cases, inner-classes used private constructors
but were subclassed. These have now been changed to have package-private
constructors.
Issue gh-8945
2020-08-24 17:33:07 -05:00
Phillip Webb
37fa94fafc
Organize imports
...
Use "organize imports" from Eclipse to cleanup import statements so
that they appear in a consistent and well defined order.
Issue gh-8945
2020-08-24 17:33:07 -05:00
Phillip Webb
5f64f53c3f
Use consistent "@" tag order in Javadoc
...
Ensure that Javadoc "@" tags appear in a consistent and well defined
order.
Issue gh-8945
2020-08-24 17:33:07 -05:00
Phillip Webb
71bc145ae4
Remove superfluous comments
...
Use '^\s+//\ \~\ .*$' and '^\s+//\ ============+$' regular expression
searches to remove superfluous comments.
Prior to this commit, many classes would have comments to indicate
blocks of code (such as constructors/methods/instance fields). These
added a lot of noise and weren't all that helpful, especially given
the outline views available in most modern IDEs.
Issue gh-8945
2020-08-24 17:33:07 -05:00
Phillip Webb
b7fc18262d
Reformat code using spring-javaformat
...
Run `./gradlew format` to reformat all java files.
Issue gh-8945
2020-08-24 17:32:56 -05:00
Phillip Webb
6979125ccf
Add noformat blocks around User.withUsername
...
Find `User.withUsername` calls and protect them against formatting.
Issue gh-8945
2020-08-10 16:24:44 -05:00
Phillip Webb
27ac046d8a
Rename *Test.java -> *Tests.java
...
Rename a few test classes that accidentally ended in `Test` instead of
`Tests`.
Issue gh-8945
2020-08-10 16:24:44 -05:00
Joe Grandja
1d74d556c2
Revert "Lock Dependency Versions for 5.4.0-RC1"
...
This reverts commit f3a1e5d40c
.
2020-08-05 14:59:11 -04:00
Joe Grandja
f3a1e5d40c
Lock Dependency Versions for 5.4.0-RC1
2020-08-05 13:46:11 -04:00
Hurelhuyag
833151ce71
Mongolian translation for messages.properties
...
Closes gh-8778
2020-07-10 04:27:51 -04:00
wangsong
4269cb0d26
update comments
2020-07-07 17:11:47 -05:00
Josh Cummings
146d0b6358
Revert "Lock Dependency Versions for 5.4.0-M2"
...
This reverts commit 68538897c8
.
2020-07-01 13:11:50 -06:00
Josh Cummings
68538897c8
Lock Dependency Versions for 5.4.0-M2
2020-07-01 12:40:29 -06:00
yukihane
c177b391d4
Polish ProviderManagerTests
...
- Renamed test to follow naming convention
- Simplified mock with Mockito
- Added note regarding related ticket
Issue gh-8689
2020-06-16 15:56:04 -06:00
yukihane
5302fb776c
ProviderManager Uses CollectionUtils#contains
...
Closes gh-8689
2020-06-16 15:56:04 -06:00
Rob Winch
ca1252be94
Replace whitelist with allowlist
...
Issue gh-8676
2020-06-10 11:49:21 -05:00
Rob Winch
bb05603b3c
AbstractUserDetailsReactiveAuthenticationManager uses boundidElastic()
...
Some JVMs have blocking operations when accessing SecureRandom and thus
this needs to be performed in a pool that is larger than the number of
CPUs
Closes gh-7522
2020-05-12 13:07:24 -05:00
Pei-Tang Huang
9dcdae3269
Update Traditional Chinese translation.
...
Align with commit f7b33da577
.
2020-05-06 17:07:57 -05:00
Joe Grandja
86ca6b013c
Unlock dependencies
...
This reverts commit 206960cf44
.
2020-05-06 17:27:35 -04:00
Joe Grandja
206960cf44
Lock dependencies for 5.4.0-M1
2020-05-06 17:13:04 -04:00
Dávid Kovács
f7b33da577
ActiveDirectoryLdapAuthenticationProvider uses InternalAuthenticationServiceException
...
Closes gh-2884
2020-04-24 10:15:48 -05:00
Maksim Mednik
eacd212a5a
Adding Map support to DefaultMethodSecurityExpressionHandler
2020-04-04 15:46:07 -04:00
Rob Winch
7ad303f0ce
Replace VersionsResourceTasks with WriteProperties
...
VersionsResourceTasks wrote a date comment which prevented this from
producing the same result and caused misses in the cache.
Closes gh-8114
2020-03-13 13:26:54 -05:00
Markus Engelbrecht
d81321bc29
Fix typo 'properites' in documentation
...
Fixes gh-8095
2020-03-11 10:54:14 -06:00
Eleftheria Stein
5850a4cd73
Fix security version test
2020-03-06 18:46:00 -05:00
Eleftheria Stein
b2ea0ba775
Polish SessionIdChangedEvent
...
Add AbstractSessionEvent; clean up license headers and Javadocs
Fixes: gh-5438
2020-03-06 12:04:49 -05:00
Venkata Jaswanth
5fc6414377
SessionRegistryImpl is now aware of SessionIdChangedEvent
2020-03-06 12:04:01 -05:00
Josh Cummings
6eadf7b140
Unlock dependencies for 5.3.0.RELEASE
...
This reverts commit 147d7dadd7
.
2020-03-04 12:02:48 -07:00
Josh Cummings
147d7dadd7
Lock dependencies for 5.3.0.RELEASE
2020-03-04 10:28:39 -07:00
Josh Cummings
1b68cdb650
Polish DefaultAuthenticationEventPublisherTests
...
Fixed checkstyle violation
Issue gh-7824
2020-02-21 12:59:44 -07:00
Attoumane AHAMADI
bfc2832c6c
Authentication Event Publisher Mappings
...
Fixes gh-7824
2020-02-21 12:49:04 -07:00
Josh Cummings
653400edfa
Polish DefaultAuthenticationEventPublisher
...
Simplified the constructor selection logic.
Issue gh-7825
2020-02-06 14:13:05 -07:00
Zeeshan Adnan
51b9b2f693
DefaultAuthenticationEventPublisher Default Event
...
Fixes gh-7825
2020-02-06 14:13:04 -07:00
Eleftheria Stein
84b8a5abd7
Unlock dependencies for next development version
...
This reverts commit 064616f1ef
.
2020-02-05 15:53:04 +01:00
Eleftheria Stein
064616f1ef
Lock dependencies for 5.3.0.RC1
2020-02-05 10:20:05 +01:00
Josh Cummings
fbdecdafb8
Add Mapping to Invalid Bearer Token
...
Fixes gh-7793
2020-02-04 17:33:08 -07:00
Joe Grandja
04f3fe8af9
Add Jackson support for oauth2-client session related classes
...
Fixes gh-4886
2020-02-04 09:01:12 -05:00
Josh Cummings
d22b476983
Polish ProviderManager
...
Updated copyright date range and adjusted constructor order to better
match DelegatingReactiveAuthenticationManager
Fixes gh-7713
2020-01-30 16:08:01 -07:00
Thomas Vitale
ace89e12f2
Make code cleaner in ProviderManagerTests
2020-01-30 16:07:24 -07:00
Thomas Vitale
5ce60022d3
ProviderManager should have a varargs constructor
...
- Added varargs constructor to ProviderManager.
- Added check for null values in AuthenticationProvider list.
- Updated ProviderManagerTests to test for null values using both constructors.
Fixes gh-7713
2020-01-30 16:07:24 -07:00
Rob Winch
38c2010d21
Remove println from springVersion
...
Issue gh-7801
2020-01-13 16:39:50 -06:00
Eleftheria Stein
fcc6457bef
Unlock dependencies for next development version
...
This reverts commit 93acf8f0f1
.
2020-01-08 22:15:17 +01:00
Eleftheria Stein
93acf8f0f1
Lock dependencies for 5.3.0.M1
2020-01-08 19:41:10 +01:00
Rob Winch
f639e17491
Resolve Current Spring Version
...
Issue gh-7788
2020-01-06 15:12:04 -06:00
Rob Winch
06d7443946
Use Gradle platform and constraints
...
This was largely generated from the following script
wget bd9f8eb541/src/main/groovy/io/spring/gradle/convention/DependencySetPlugin.groovy
./dsp.gradle
cat gradle/dependency-management.gradle | grep 'management "' | cut -d ':' -f 2 | xargs -I{} sh -c "rg {} -l -g '*.gradle' -g '\!dependency-management.gradle' > /dev/null || echo {}" | xargs -I{} sed -iE '/.*{}.*/d' gradle/dependency-management.gradle
rm ./dps.gradle
Fixes gh-7787
2020-01-06 14:46:36 -06:00
Daniel Bustamante Ospina
150b66824d
Make MethodSecurityEvaluationContext Delegate to MethodBasedEvaluationContext
...
Spring Security's MethodSecurityEvaluationContext should delegate to Spring Framework's
MethodBasedEvaluationContext
Fixes: gh-6224
2020-01-03 19:49:41 -05:00
Matthias Stock
5fde3044f7
Resolve JavaType only once for whitelisted class
2020-01-02 10:30:51 -05:00
Tao Sun
f18d0fd1a7
Test details using isEqualTo
2019-12-18 17:35:51 +01:00
Tao Sun
6b0981549b
Add test for details deserialization
2019-12-18 17:35:51 +01:00