Discource-C
/
discourse-adplugin
mirror of https://github.com/discourse/discourse-adplugin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

custom targeting multiple values working

This commit is contained in:
vi 2015-08-26 16:03:15 +10:00
parent 010d11f969
commit 514fed55c9
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
assets/javascripts/discourse/components/google-dfp-ad.js.es6
View File

@ -25,8 +25,6 @@ function valueParse(value) {
return final; return final;
} }
//PageTracker.current().on('change', function(url) { //PageTracker.current().on('change', function(url) {
function loadGoogle(settings) { function loadGoogle(settings) {
if (_loaded) { if (_loaded) {
@ -45,8 +43,6 @@ function loadGoogle(settings) {
console.log('googletag is undefined!'); console.log('googletag is undefined!');
} }
// Define our ad units - extend for mobile view.
// if statement? the code should be able to run without the custom targeting settings
googletag.cmd.push(function() { googletag.cmd.push(function() {
if (settings.dfp_topic_list_top_code && !settings.dfp_show_topic_list_top && settings.topic_list_top_ad_sizes) { if (settings.dfp_topic_list_top_code && !settings.dfp_show_topic_list_top && settings.topic_list_top_ad_sizes) {
const_width = parseInt(splitWidthInt(settings.topic_list_top_ad_sizes)); const_width = parseInt(splitWidthInt(settings.topic_list_top_ad_sizes));
@ -60,7 +56,7 @@ function loadGoogle(settings) {
// This hardcoded code works: .setTargeting('category', ["clothes", "handbags", "makeup"]) // This hardcoded code works: .setTargeting('category', ["clothes", "handbags", "makeup"])
.addService(googletag.pubads()); .addService(googletag.pubads());
console.log(typeof(valueParse(settings.dfp_target_topic_list_top_value_code))); console.log(valueParse(settings.dfp_target_topic_list_top_value_code));
} }
} }
if (settings.dfp_topic_above_post_stream_code && !settings.dfp_show_topic_above_post_stream && settings.topic_above_post_stream_ad_sizes) { if (settings.dfp_topic_above_post_stream_code && !settings.dfp_show_topic_above_post_stream && settings.topic_above_post_stream_ad_sizes) {