Neil Lalonde
9a02cae641
Update README with info about new settings
...
Also remove outdated list of supported sizes. It's not a useful table.
2019-09-16 15:03:14 -04:00
Neil Lalonde
6704238c94
Update README with more info about AdButler support
2019-09-16 14:50:15 -04:00
Neil Lalonde
51c1b89a62
Prettier
2019-09-16 14:35:58 -04:00
discoursehosting
19f0457e8c
AdButler support ( #80 )
2019-09-16 14:26:17 -04:00
Neil Lalonde
b500ea171f
DEV: Add tests for no_ads_for_categories
2019-09-11 12:18:42 -04:00
Neil Lalonde
0612054da8
Bump to version 1.2.4
2019-09-10 17:09:21 -04:00
Neil Lalonde
62888e734f
FIX: handle no ad size given for AdSense and DFP ad units
...
For AdSense, assume responsive size.
For DFP, don't attempt to render the ad unit.
2019-09-10 17:07:47 -04:00
Neil Lalonde
2ad24e4a60
FEATURE: add option to disable ads in restricted categories
...
Use the new setting "no ads for restricted categories".
2019-07-22 11:43:39 -04:00
Roman Rizzi
2ceb99e151
DEV: migrate no_ads_for_groups to use IDs instead of group names ( #77 ) [Undo revert] ( #79 )
...
This reverts commit dee02ac3ba
.
2019-07-19 10:29:52 -03:00
Neil Lalonde
4991941d03
FIX: CodeFund ads in between posts on narrow widths
2019-07-18 12:16:02 -04:00
Neil Lalonde
71c51ebd8b
FIX: ads always showing in all placements for CodeFund and Carbon Ads
...
Checkboxes used to choose which placements to have ads were not handled
correctly.
2019-07-17 14:05:58 -04:00
Roman Rizzi
dee02ac3ba
Revert "DEV: migrate no_ads_for_groups to use IDs instead of group names ( #77 )" ( #78 )
...
This reverts commit 09a92f3438
.
2019-07-16 11:57:20 -03:00
Neil Lalonde
93af4587fa
FIX: Amazon ads never showing
2019-07-16 10:55:39 -04:00
Roman Rizzi
09a92f3438
DEV: migrate no_ads_for_groups to use IDs instead of group names ( #77 )
2019-07-16 11:35:16 -03:00
Neil Lalonde
3aa9cb8a0c
FIX: wrong size DFP ads when using multiple sizes
...
getWidthAndHeight was being called twice for each ad placement:
once when setting the size of the div, and once when calling the
defineSlot API. getWidthAndHeight always advances to the next size
in the list, so the wrong size ad would be inserted into the div.
2019-07-15 15:34:46 -04:00
Neil Lalonde
e8295c600c
Update translations
2019-07-15 13:59:41 -04:00
Neil Lalonde
1929ac405c
lint errors
2019-07-08 15:18:34 -04:00
Neil Lalonde
333f6cef81
FEATURE: support multiple ad sizes in AdSense and Ad Manager
...
Each ad placement in the AdSense and Ad Manager settings takes a list
of ad sizes instead of only one size. If given multiple sizes, the sizes
will alternate in order for each ad that's rendered.
2019-07-08 15:10:25 -04:00
Neil Lalonde
6f786b2f4d
Bump to version 1.2.3
2019-06-27 14:16:19 -04:00
Neil Lalonde
ad939a851a
FEATURE: option to disable ads on personal messages
...
Use the new setting "no ads for personal messages".
2019-06-27 14:13:51 -04:00
Neil Lalonde
2ba276b0fb
FIX: DFP ad units being refreshed multiple times on the same render
...
Ember is firing events multiple times when the ad component is shown.
Only solution I can find is to add a delay between calls to refresh
the ad unit. I chose 3 seconds.
2019-06-26 11:15:04 -04:00
Brahn Partridge
89200f3b99
try io instead of app to maybe workaround CORs problem
2019-06-24 09:59:58 -04:00
Neil Lalonde
3054f2539a
FEATURE: use a different Ad Manager publisher ID for mobile
...
If you want to use one Ad Manager publisher on desktop and a different
one on mobile, use the new dfp_publisher_id_mobile setting.
By default, dfp_publisher_id will be used for both desktop and mobile.
2019-06-19 11:52:23 -04:00
Neil Lalonde
8ab28f4fda
Bump to version 1.2.2
2019-06-17 21:01:33 -04:00
Neil Lalonde
25090a55a1
prettier
2019-06-17 21:00:05 -04:00
Neil Lalonde
92609c7af4
FIX: no_ads_for_tags support for hidden tags
...
Hidden tags aren't sent to the client, so they couldn't be used to
disable ads on topic pages. Do this calculation on the server.
Topic list pages for tags can continue to check on the client because
non-staff get a 404 error when trying to view a hidden tag's topic list.
2019-06-17 17:20:38 -04:00
Neil Lalonde
ca345f273c
Update translations
2019-06-17 13:56:18 -04:00
Arpit Jalan
d34b45627e
Fix the build.
2019-06-15 16:01:52 +05:30
Neil Lalonde
31efc7025d
FEATURE: new setting to disable ads based on tags
...
Enter a list of tags in the new setting no_ads_for_tags to prevent
ads from being rendered on topics with one or more of those tags,
and on topic list pages for those tags.
2019-06-14 14:44:09 -04:00
Penar Musaraj
574500ba08
Run Prettier
2019-06-14 13:24:55 -04:00
Penar Musaraj
203e14b639
Fix eslint warnings
2019-06-14 12:10:11 -04:00
Joffrey JAFFEUX
8c3fe62e90
DEV: new API s/replaceCurrentUser/updateCurrentUser
...
See https://github.com/discourse/discourse/pull/7769
2019-06-14 10:59:32 +02:00
Neil Lalonde
3a04f95916
REFACTOR: some changes to be closer to example implementation
...
https://support.google.com/admanager/answer/4578089?hl=en
* unique div ID for every ad slot
* setTargeting before calling addService
* don't destroySlots async (no examples of correct way to use this...)
2019-06-10 15:43:48 -04:00
Neil Lalonde
0432256adb
Update translations
2019-06-10 10:37:57 -04:00
Neil Lalonde
35c1af6648
Version bump to 1.2.1
2019-06-05 17:01:31 -04:00
Neil Lalonde
04525d0cf1
FIX: dfp category targeting params
...
DFP category targeting param wasn't always being updated on topic
list pages.
Also remove dependency on a category param being passed in to the
component from a template so that we can now place dfp ads
in places that don't have access to the current category and
targeting will still work.
2019-06-05 17:00:47 -04:00
Neil Lalonde
7af8f1d46b
FEATURE: new setting to disable ads based on category of current page
...
Use the "no ads for categories" setting to define which category pages
(topic list and topics) should not render any ads.
2019-06-05 16:00:24 -04:00
Penar Musaraj
f745ecfbdc
Rename adsense_ads_txt setting to ads_txt
2019-06-03 11:39:28 -04:00
Neil Lalonde
ab9cf6459e
Update translations
2019-05-30 11:30:03 -04:00
Guo Xiang Tan
546101a357
Add frozen string literal to files.
2019-05-13 10:16:50 +08:00
Neil Lalonde
d3a5927ede
Don't render inside a cloaked post
2019-05-10 14:22:18 -04:00
Neil Lalonde
2ca0adca05
Fix failing js test
2019-05-08 13:44:25 -04:00
Neil Lalonde
896e5a9838
Prettier
2019-05-08 11:22:21 -04:00
Neil Lalonde
10ab104cd8
JS test for mixed ads
2019-05-08 11:17:40 -04:00
Neil Lalonde
365f441924
FIX: groups with mixed case names not working
2019-05-08 11:01:01 -04:00
Neil Lalonde
4bd2035866
FEATURE: house ads can be configured to alternate with other ads
...
Use the new "house ads frequency" site setting to configure how often
house ads should show, as a percentage. This only applies in ad
placements where other ad networks are configured to appear.
2019-05-07 19:52:51 -04:00
Neil Lalonde
cdc14398ba
FIX: linking to house ads URLs shows not found error page
2019-05-07 14:32:32 -04:00
Neil Lalonde
d9d7f4c8f4
FIX: house ads randomized instead of showing evenly
2019-05-03 16:04:04 -04:00
Neil Lalonde
26d42e9ed7
Fix compatibility with other js tests
2019-05-03 13:26:16 -04:00
Neil Lalonde
171656304b
Version bump, update readme with House Ads info
2019-05-03 11:56:59 -04:00