Commit Graph

207 Commits

Author SHA1 Message Date
Robin Ward 1cd0bef933 FIX: Support for embedding ads via component 2016-11-23 14:29:30 -05:00
Neil Lalonde de4a8366fc FIX: don't load adsbygoogle.js when adsense publisher id isn't set 2016-11-21 15:58:29 -05:00
Neil Lalonde da1d4e0063 FIX: when dfp/adsense publisher id is missing, don't render blank ad units 2016-11-21 15:55:03 -05:00
Neil Lalonde 910b0d0e4c FIX: showing ads on mobile when mobile ad units are not defined 2016-11-17 11:45:18 -05:00
Robin Ward 883d5ecd85 FIX: Catch exception if ads can't be rendered 2016-11-09 16:46:09 -05:00
Robin Ward a70491c720 FIX: HTMLBars doesn't allow `<SCRIPT>` tags 2016-11-08 16:46:09 -05:00
Neil Lalonde dee247d0fd Merge pull request #46 from ladydanger/patch-2
updated old link on readme
2016-08-02 11:03:40 -04:00
Neil Lalonde 0c50f723ee add more ad sizes for adsense 2016-07-29 12:11:02 -04:00
Neil Lalonde 65a631e885 add regex to adsense settings, and better description for adsense_publisher_code 2016-07-21 11:54:35 -04:00
Vi Nguyen f3fe30a928 updated old link on readme 2016-07-12 08:31:18 +10:00
Neil Lalonde 8e66337b53 Merge pull request #43 from nlalonde/690
add 690x250 to dfp
2016-06-30 14:37:36 -04:00
Neil Lalonde 96307749e7 add 690x250 to dfp 2016-06-30 14:36:44 -04:00
Neil Lalonde 919e12cd81 Merge pull request #42 from nlalonde/billboard
add 970x250 billboard
2016-06-24 15:26:55 -04:00
Neil Lalonde fb68af47d5 add 970x250 billboard 2016-06-24 15:26:13 -04:00
Neil Lalonde f2045da3b3 Merge pull request #41 from nlalonde/more-sizes
add more dfp ad sizes
2016-06-23 13:58:11 -04:00
Neil Lalonde 3d85141a42 add more dfp ad sizes 2016-06-23 13:56:59 -04:00
Neil Lalonde 9aefdd4052 Merge pull request #40 from nlalonde/mobile-sizes
add ad sizes settings for mobile DFP
2016-06-21 13:21:28 -04:00
Neil Lalonde 8ce3acfb3b add ad sizes settings for mobile DFP 2016-06-21 13:13:37 -04:00
Neil Lalonde 1d907c7897 Merge pull request #38 from nlalonde/master
FIX: too much memory used by long topics
2016-05-16 14:27:51 -04:00
Neil Lalonde f930aa14ec FIX: too much memory used by long topics 2016-05-16 14:26:14 -04:00
Neil Lalonde a84ec3dd1e Merge pull request #37 from nlalonde/master
Ad every nth post, better descriptions, dfp refactor
2016-04-21 18:58:10 -04:00
Neil Lalonde 6dd726e168 Improve descriptions of DFP settings and re-order them a bit for clarity. 2016-04-21 18:53:39 -04:00
Neil Lalonde e4405dd486 Add support for showing ad after every nth post, not only after the nth post 2016-04-21 18:53:39 -04:00
Neil Lalonde cee3f66009 Render nth post dfp ads in position where post would be 2016-04-21 18:53:39 -04:00
Neil Lalonde 13b5d21565 Fix dfp ad dimensioned undefined. Refactor dfp ad component to remove unnecessary variables and rewrite copy-pasted code. 2016-04-21 18:53:39 -04:00
Neil Lalonde 196845d63f merge upstream 2016-04-21 18:52:53 -04:00
Neil Lalonde d27b67798a Improve description of the through_trust_level settings. 2016-04-18 10:43:42 -04:00
Vi Nguyen 55c9dbec23 Merge pull request #36 from nlalonde/pr2
Don't hard-code center justify of AdSense ads.
2016-04-05 06:59:46 +10:00
Vi Nguyen 08b2f136cb Merge pull request #35 from nlalonde/pr1
Improve description of DFP and AdSense settings.
2016-04-05 06:58:46 +10:00
Neil Lalonde ef45e3290e Don't hard-code center justify of AdSense ads. Let position be customized with CSS. 2016-04-04 16:51:34 -04:00
Neil Lalonde edffa20094 Improve description of DFP and AdSense settings. People keep putting javascript into those fields. Also add a constraint on the fields so people get an error when they paste javascript. 2016-04-04 16:49:01 -04:00
Neil Lalonde 240f281dab Improve description of DFP and AdSense settings. People keep putting javascript into those fields. Also add a constraint on the fields so people get an error when they paste javascript. 2016-04-04 13:42:42 -04:00
Vi Nguyen c0361c0e90 updated for broken link 2016-03-04 15:40:24 +11:00
Robin Ward 4ab0f0fab8 Upgrade to new Plugin API 2016-02-22 12:16:09 -05:00
Robin Ward ebed90fab7 Support linting, clean up some unused variables and weird spacing 2016-02-19 15:29:00 -05:00
Vi Nguyen 64996ed78c Merge pull request #28 from adcopywriter/master
Quick fix for formatting div in adsense.hbs
2015-12-25 04:27:24 +11:00
Vi Nguyen 7dd66b75f7 fixed up formatting
fixed up formatting
2015-12-25 04:24:40 +11:00
Vi Nguyen 74a073aef4 Merge pull request #27 from adcopywriter/master
Fix for Issue #25
2015-12-24 22:31:29 +11:00
Vi Nguyen 5dfa24c237 remove div label outside of the adwrapper style
fix for size of ad being cut by line in mobile view for adsense
2015-12-24 22:12:01 +11:00
Vi Nguyen 4eade6a1d9 put sizes back to their original 2015-12-24 22:10:26 +11:00
Vi Nguyen 268d180504 Update google-adsense.js.es6 2015-12-24 21:49:27 +11:00
Vi Nguyen 7759acf5be updated size of ad mobile height to mobile height
updated size of ad mobile height to mobile height
2015-12-24 21:30:09 +11:00
Vi Nguyen 05b053a110 adsense updated to a larger size container
updated to a larger size container
2015-12-24 21:15:23 +11:00
Vi Nguyen 1f0d85740e put mobile ad sizes back to original
testing on my forked version instead
2015-12-24 21:10:37 +11:00
Vi Nguyen a8c0910f5b changed ad mobile height for adsense
temp test for mobile ad height space for testing on mobile.
2015-12-24 20:50:22 +11:00
Sarah Ni c6b753ab67 variable change for amazon mobile ad
instead of user_input_mobile, use userInputMobile
2015-10-30 00:41:45 +11:00
Sarah Ni 21ef9924eb Merge pull request #24 from kcoop/master
Fixes to Amazon and Adsense mobile ad generation
2015-10-30 00:40:51 +11:00
Ken Cooper 31a59a454d Fixed: mobile iframe link for Amazon banners was generating the desktop link. 2015-10-28 19:40:37 -07:00
Ken Cooper ffbd69688e Fixed: mobile viewport was too large when presenting ads, making for a sloppy mobile experience. Restricted length of "Advertisement" label to fix it. 2015-10-28 16:51:53 -07:00
Robin Ward af22cd987d Merge pull request #23 from nlalonde/master
FIX: mobile ad with is too wide on 320px wide devices
2015-10-28 17:19:52 -04:00