203e14b639
Fix eslint warnings
2019-06-14 12:10:11 -04:00
3a04f95916
REFACTOR: some changes to be closer to example implementation
...
https://support.google.com/admanager/answer/4578089?hl=en
* unique div ID for every ad slot
* setTargeting before calling addService
* don't destroySlots async (no examples of correct way to use this...)
2019-06-10 15:43:48 -04:00
04525d0cf1
FIX: dfp category targeting params
...
DFP category targeting param wasn't always being updated on topic
list pages.
Also remove dependency on a category param being passed in to the
component from a template so that we can now place dfp ads
in places that don't have access to the current category and
targeting will still work.
2019-06-05 17:00:47 -04:00
7af8f1d46b
FEATURE: new setting to disable ads based on category of current page
...
Use the "no ads for categories" setting to define which category pages
(topic list and topics) should not render any ads.
2019-06-05 16:00:24 -04:00
896e5a9838
Prettier
2019-05-08 11:22:21 -04:00
365f441924
FIX: groups with mixed case names not working
2019-05-08 11:01:01 -04:00
4bd2035866
FEATURE: house ads can be configured to alternate with other ads
...
Use the new "house ads frequency" site setting to configure how often
house ads should show, as a percentage. This only applies in ad
placements where other ad networks are configured to appear.
2019-05-07 19:52:51 -04:00
d9d7f4c8f4
FIX: house ads randomized instead of showing evenly
2019-05-03 16:04:04 -04:00
26d42e9ed7
Fix compatibility with other js tests
2019-05-03 13:26:16 -04:00
1bd80e1afe
FEATURE: House Ads
...
Allows creating ads within Discourse admin at Plugins > House Ads.
Write the ads in html and style them with CSS in themes.
2019-05-03 11:39:34 -04:00
5272995e74
FEATURE: use groups to control who sees ads
2019-05-03 11:39:34 -04:00
369d5dfc9e
oops revert again "FEATURE: use groups to control who sees ads" and all later"
2019-04-17 16:02:19 -04:00
e6bcd96d8e
FEATURE: use groups to control who sees ads" and all later
2019-04-17 15:40:50 -04:00
50d258dc37
Revert "FEATURE: use groups to control who sees ads" and all later
...
Revert "Updates to codefund-ad"
Revert "Updates to carbonads-ad"
Revert "Updates to amazon-product-links"
2019-04-17 15:37:09 -04:00
63e604d81b
Updates to codefund-ad
2019-04-17 11:36:50 -04:00
8ef02aa351
Updates to carbonads-ad
2019-04-17 11:36:50 -04:00
881a8e5d4c
Updates to amazon-product-links
2019-04-17 11:36:50 -04:00
4fd7caffd6
FEATURE: use groups to control who sees ads
...
A new setting has been added in Admin > Settings > Ad Plugin called
"no ads for groups". Add group names to this list. If a user belongs
to any of the groups, they will not see any ads. This is an alternative
to using trust level settings like "adsense through trust level".
2019-04-17 11:36:50 -04:00
6097e6f097
Clean-up codefund-ad component
2019-04-17 11:36:50 -04:00
943acbfeb1
Add some js tests, and update adsense js
2019-04-17 11:36:47 -04:00
147b1350ea
FIX: Switch Property to Computed
2019-04-15 11:54:18 -04:00
23ece34f53
FIX: Switch Var to Const
2019-04-15 11:54:18 -04:00
c5272db7f3
UX: Init Carbon Ads
2019-04-15 11:54:18 -04:00
ec10ef4483
FIX: wrong size setting being used for post-bottom desktop
2019-03-20 11:22:47 -04:00
9b7a8830b8
FIX: resizing of ad units when they're rendered
2019-02-25 09:53:28 -05:00
9a695cc67d
refactor google-dfp-ad component to reduce repetition
2019-02-22 11:15:40 -05:00
de0a47c1a7
Update CodeFund Ads to use new CodeFund API ( #1 )
...
Update CodeFund plugin to work with CodeFund's new API
2019-01-30 13:51:22 -05:00
00789666d7
Reverts Ember.String.prototype.w monkey patching causing exception
...
The git blame of the commit is unclear on the reasons leading to this, and how to reproduce a failure.
2019-01-09 20:58:14 +01:00
2e36e2c656
DEV: Apply prettier
2018-10-22 19:49:32 +01:00
014ee3187b
Ensure CodeFund request is only made if the Property ID is provided
...
Also updated README with CodeFund instructions and link
2018-06-22 14:41:59 -06:00
9e84a89f76
Refactors per review
2018-06-20 09:15:15 -06:00
1b7f642da6
Cleanup
2018-06-12 15:21:23 -06:00
11a621fd50
Only display ad if content exists
2018-06-07 17:49:15 -06:00
75439b5af3
Cleaned up debugs
2018-06-07 17:28:20 -06:00
1cd33da722
Add CodeFund
2018-06-07 17:17:19 -06:00
136cceb1e3
FIX: resolve collision on ember's builtin w string function
2018-05-16 13:37:50 -07:00
1abeea6ff2
FIX: Amazon amazon_mobile_topic_above_suggested_src_code setting did not work
2018-02-15 14:32:10 -05:00
79d1e87dee
Make eslint happy.
2017-08-02 16:45:19 +09:00
9df93c03a7
AdSense: allow choosing ad size for mobile, including responsive
2017-05-30 18:13:49 -04:00
62377e6111
Support for AdSense responsive ad size
2017-05-30 15:54:59 -04:00
620404ab9e
FIX: AdSense ads not loading on initial page load. Only load adsbygoogle.js once because it's the async library.
2016-12-05 13:31:11 -05:00
de4a8366fc
FIX: don't load adsbygoogle.js when adsense publisher id isn't set
2016-11-21 15:58:29 -05:00
da1d4e0063
FIX: when dfp/adsense publisher id is missing, don't render blank ad units
2016-11-21 15:55:03 -05:00
883d5ecd85
FIX: Catch exception if ads can't be rendered
2016-11-09 16:46:09 -05:00
a70491c720
FIX: HTMLBars doesn't allow `<SCRIPT>` tags
2016-11-08 16:46:09 -05:00
8ce3acfb3b
add ad sizes settings for mobile DFP
2016-06-21 13:13:37 -04:00
f930aa14ec
FIX: too much memory used by long topics
2016-05-16 14:26:14 -04:00
e4405dd486
Add support for showing ad after every nth post, not only after the nth post
2016-04-21 18:53:39 -04:00
cee3f66009
Render nth post dfp ads in position where post would be
2016-04-21 18:53:39 -04:00
13b5d21565
Fix dfp ad dimensioned undefined. Refactor dfp ad component to remove unnecessary variables and rewrite copy-pasted code.
2016-04-21 18:53:39 -04:00
ef45e3290e
Don't hard-code center justify of AdSense ads. Let position be customized with CSS.
2016-04-04 16:51:34 -04:00
4ab0f0fab8
Upgrade to new Plugin API
2016-02-22 12:16:09 -05:00
ebed90fab7
Support linting, clean up some unused variables and weird spacing
2016-02-19 15:29:00 -05:00
1f0d85740e
put mobile ad sizes back to original
...
testing on my forked version instead
2015-12-24 21:10:37 +11:00
a8c0910f5b
changed ad mobile height for adsense
...
temp test for mobile ad height space for testing on mobile.
2015-12-24 20:50:22 +11:00
ffbd69688e
Fixed: mobile viewport was too large when presenting ads, making for a sloppy mobile experience. Restricted length of "Advertisement" label to fix it.
2015-10-28 16:51:53 -07:00
85d357b007
DFP: send a 0 value for discourse-category targeting on /latest, /categories, etc so that ads can show there while targeting categories
2015-10-28 12:20:16 -04:00
c5b9392ae5
FIX: ads not refreshing when going from one topic list to another
2015-10-27 17:44:03 -04:00
e13a6ecdce
DFP: send key discourse-category and value as category slug when loading ads
2015-10-27 16:42:36 -04:00
cf850b273d
FIX: refresh DFP ads after navigating between topics and lists
2015-10-15 13:58:49 -04:00
fe9c53ce58
removed all disable boxes and changed trust levels for amazon
2015-09-21 10:44:37 +10:00
0ef188766d
Modified js component
2015-09-16 12:17:46 +10:00
0adc5bfca7
Refactored to only have amazon link/banner ads and refactored for check trust levels
2015-09-16 12:11:50 +10:00
cc2572e3f1
Added working product links
2015-09-16 11:44:31 +10:00
b4f177d947
Product and Easy Ads work, still building Native Ads
2015-09-11 16:33:55 +10:00
2d752d8b2f
basic amazon product link inputs added and works
2015-09-10 22:48:14 +10:00
647eecd95b
master - more consistent naming for dfp settings and removed test folder
2015-09-10 12:07:36 +10:00
c868d4892a
Removed unused css and irrelevant comments and cleaned up formatting
2015-09-07 20:51:59 +10:00
bdc8a2dff5
Added comment to adsense
2015-09-07 20:38:53 +10:00
7062254c13
Reload fixed added googletag in - Thank you Myles!
2015-09-07 15:15:12 +10:00
8607cefcec
Added mobile slot code for adsense plugin and revisited the reloading issue
2015-09-07 14:26:53 +10:00
9e9d056d75
edited sizes for post bottom and fixed dfp googletag reload
2015-09-04 14:52:08 +10:00
b9945a6e4b
Added comments to pre and post google vars
2015-09-04 10:51:44 +10:00
fa3d25e4fd
Working mobile ads that follow desktop custom targeting
2015-09-03 21:08:21 +10:00
916e53884c
working custom targeting for all locations
2015-09-02 15:23:17 +10:00
b0a97df0da
Fixed merge conflicts
2015-09-02 14:28:33 +10:00
d656795bc1
Added all desktop slots to custom targeting
2015-09-02 14:21:17 +10:00
dbb7d1a784
Refactored trust levels
2015-09-02 13:50:47 +10:00
14bd843ac1
Merged mobile slots and trust levels to multiple targeting keys branch
2015-09-02 13:33:49 +10:00
060c5d1b7a
Added publisher id to mobile slots for dfp
2015-09-02 13:21:44 +10:00
afa2262b1c
Topic list top custom targeting multiple keys working
2015-09-02 13:13:53 +10:00
e255a65e32
Custom targeting working for one key and associated values for that one key per ad slot available - problem in multiple keys
2015-09-01 16:04:21 +10:00
5eecf0d731
Fixed up properties in ad mobile sizes for dfp and adsense
2015-09-01 13:44:56 +10:00
67141dd884
Added mobile code to topic list top position to test
2015-09-01 13:20:52 +10:00
6452c9c5b1
Added trust levels to site settings for dfp
2015-09-01 11:27:31 +10:00
2f1ac77380
Added trust levels to site setting and bug found in adsense reload comment out in line 30 to 57
2015-09-01 11:16:07 +10:00
7f13e0a1fb
Merge pull request #8 from team-melbourne-rgsoc2015/mobile-works
...
Successful mobile slots - default to 320*50
2015-09-01 10:10:09 +10:00
c38eb3134e
Fixed post-bottom if statement and reduced duplication in connectors
2015-08-31 16:10:26 +10:00
a7258f4848
For loop replaces while loop but line 50 doesn't work
2015-08-31 15:25:42 +10:00
cdb4c50eff
Added custom targeting function error on line 50 when calling f.bar
2015-08-31 14:44:47 +10:00
8989d9c5ea
fixed up with Jo's help setTargeting base method
2015-08-31 13:49:09 +10:00
6d8cbb72e4
Added key slots via url_list and created prototype setTargeting function
2015-08-31 12:21:43 +10:00
6d93faf871
Successful mobile slots - default to 320*50
2015-08-28 15:34:14 +10:00
e3dded27d9
how to approach the .setTargeting issue
2015-08-28 15:25:11 +10:00
f94bf79192
Added custom targeting to all slots and Sebastian fixed the variable issue in adsense - thanks Seb!
2015-08-28 12:21:40 +10:00
514fed55c9
custom targeting multiple values working
2015-08-26 16:03:15 +10:00
010d11f969
key working, value not working
2015-08-26 15:35:30 +10:00
67d3504296
Added working custom targeting to topic list top for one key and one value
2015-08-26 12:04:03 +10:00
50ee40cdfe
Myles fixed it - fixed cmd undefined and fixed up adsense code that was undefining all vars beginning with google
2015-08-26 10:42:43 +10:00
d272a71b08
Working ads however, on change url dfp plain ad not displaying
2015-08-25 15:53:22 +10:00
Penar Musaraj
Neil Lalonde
Diego Barreiro
Nathan Hopkins
Joffrey JAFFEUX
David Taylor
Eric Berry
Eric Berry
Jeff Wong
Guo Xiang Tan
Robin Ward
Vi Nguyen
Ken Cooper
Sarah Ni
vi
ladydanger