Commit Graph

5 Commits

Author SHA1 Message Date
Alan Guo Xiang Tan 1edd930d33
DEV: Fix custom_header_links migration to handle blank string (#69)
If the old theme setting value is set to a blank string, we will end up
not migrating it and thus cause an error to be raised.
2024-08-26 14:39:05 +08:00
Alan Guo Xiang Tan 4cc2a57c21
FIX: Allow title to be blank when migrating `custom_header_links` (#56)
This commit allows setting value of `Link Name, ,/some/path` to be
migrated. This format of the setting was allowed and the current
migration will not migrate the link if the title is empty which isn't
what we want.

Follows-up to 167bc8cee9
2024-04-26 15:46:20 +08:00
Alan Guo Xiang Tan 167bc8cee9
FIX: Ensure that custom header links migration do not fail validation (#55)
This commit is a follow up to 73747938bd
where the migration will fail because the objects created by the
migration will end up failing to save because the objects will fail the
validation given the new schema. This commit updates the migration to
ensure that we do not end up with invalid objects.
2024-04-26 12:57:46 +08:00
Alan Guo Xiang Tan 73747938bd
DEV: Migrate custom header links to new objects setting type (#53)
Why this change?

Since discourse/discourse@a440e15, we have started to support objects typed theme setting so we are switching this theme component to use it instead as it provides a much better UX for configuring the settings required for the theme component.
2024-04-23 11:50:20 +08:00
Alan Guo Xiang Tan 5006125483
DEV: Rename `Custom_header_links` settings to `custom_header_links` (#45)
Why this change?

Using uppercase in settings name is not part of our convention so
renaming it here.
2024-01-26 10:15:41 +08:00