Commit Graph

323 Commits

Author SHA1 Message Date
Discourse CI 9dcf4a6c9d DEV: Update CI workflows 2020-10-14 16:27:45 +00:00
Krzysztof Kotlarek b4bdbf7150
FIX: fix ids rake task should be evaluated only once (#76)
Without task('data_explorer:fix_query_ids').clear rake task is evaluated twice
2020-10-14 16:40:40 +11:00
jjaffeux e0e639e70f Revert "DEV: enforces no-var (#74)"
This reverts commit 94c1ef21c8.
2020-10-13 15:40:56 +02:00
Joffrey JAFFEUX 94c1ef21c8
DEV: enforces no-var (#74) 2020-10-13 15:17:33 +02:00
Discourse Translator Bot 5d86480c34 Update translations 2020-10-13 15:13:10 +02:00
Krzysztof Kotlarek 8cc2d4e4e4
FIX: flaky fix_query_id_spec because id conflict (#73)
This rake task is responsible for fixing broken ids - move them back to the original values - ones before migration to a separate table.

Rake task can only fix queries with unique names.

In the test, we are creating duplicated queries and using `original_id` 4. Spec is ensuring that after rake tasks valuation, queries id is different than `4`

However, spec run in random order may create a query with id 4 and in that case, the spec would fail.

Therefore, when we create queries for test purpose, we should control what ids they are given to avoid conflict.
2020-10-13 12:31:51 +11:00
Discourse CI 44f0eadb49 DEV: Update CI workflows 2020-10-12 08:16:43 +00:00
Discourse CI 70107eb811 DEV: Update CI workflows 2020-10-09 19:03:10 +00:00
Discourse CI 0674fb9d23 DEV: Update CI workflows 2020-10-09 16:15:00 +00:00
Discourse CI 954134bb73 DEV: Update CI workflows 2020-10-09 15:09:43 +00:00
tshenry 88f9d7176a
UX: Make group report index styling more consistent with core (#72) 2020-10-09 13:22:16 +11:00
Jarek Radosz 1085492aaa
FIX: Correct the .discourse-compatibility syntax (#71)
Fixes the core build.
2020-10-07 13:01:35 +02:00
Martin Brennan 26ccc36b5b
FIX: Resolve yarn lint complaint 2020-10-07 14:08:26 +10:00
Martin Brennan a4665c27e8
Revert "Import getURL to fix deprecation warnings (#52)"
This reverts commit d643cf742e.

A previous change was already made in this repo to import getURL,
this causes a double import which breaks the build.
2020-10-07 13:13:38 +10:00
Mark VanLandingham d643cf742e
Import getURL to fix deprecation warnings (#52) 2020-10-07 12:58:52 +11:00
Kane York 386635d693
FIX: UserAction table did not have enum help (#62)
Requires 2.6.0.beta3
2020-10-07 12:58:14 +11:00
Ricky Chon 80ffc4582f
UI: Don't show 'everyone' group for query access (#59)
* Query access for 'everyone' does not work, but trust level 0 does,
and it works the same
2020-10-07 12:56:51 +11:00
Discourse Translator Bot 5f479db2e9 Update translations 2020-10-06 15:20:13 +02:00
Roman Rizzi 51a047b60c
FIX: Store query groups in a temp table when fixing ids. (#68)
Reintroduces the migration removed in `cdfc5d4`, and fixes it to work with `query_groups`. Since the code is fairly complex, I moved into a rake task so it can be tested and make sure it works.
2020-09-28 12:23:53 -03:00
jjaffeux 4a167a7f5a DEV: attempts to fix indentation 2020-09-25 20:51:53 +02:00
Justin DiRose 541fd12823
DEV: Add plugin testing workflow 2020-09-25 11:47:21 -05:00
Justin DiRose 03231ffecb
DEV: Add linting workflow 2020-09-25 11:47:02 -05:00
Justin DiRose 065888214d
DEV: Add RubyGems as source 2020-09-25 11:46:42 -05:00
Joffrey JAFFEUX 685b5a45c1
FIX: the filtered array was not being used (#69) 2020-09-23 09:53:14 -04:00
jjaffeux 6205bb8569 DEV: linting 2020-09-22 17:11:41 +02:00
Discourse Translator Bot ca86e0b63c Update translations 2020-09-22 13:02:52 +00:00
Discourse Translator Bot aacaa6f4b5 Update translations 2020-09-16 10:17:05 +00:00
romanrizzi cdfc5d4ea9
DEV: Remove migration until it works with query groups. 2020-09-07 17:17:11 -03:00
Daniel Waterworth 0e7e51ae08 FIX: The name changes if the top function changes 2020-09-07 20:05:22 +01:00
Daniel Waterworth 49a76c9edb FIX: Missed one. Sequences need to be set to at least 1 2020-09-07 19:32:23 +01:00
Daniel Waterworth b831d736ca FIX: Sequences need to be set to at least 1 2020-09-07 19:09:45 +01:00
Krzysztof Kotlarek 933fd9ac46 FIX: rubocop in fix query ids migration 2020-09-07 10:46:46 +10:00
Krzysztof Kotlarek 856f00c1c7
FIX: Correct ids if neccessary (#65)
Migration to fix data ids if the old version of previous migration was
evaluated.
2020-09-07 10:24:17 +10:00
Joffrey JAFFEUX e0a3ad12a6
DEV: apply coding standards (#66) 2020-09-04 13:23:11 +02:00
Krzysztof Kotlarek 19e2a21444 FIX: improve queries migration to persist IDs 2020-09-03 16:34:29 +10:00
Krzysztof Kotlarek 16873e708a FIX: dont error when user id is empty string 2020-08-27 14:47:43 +10:00
Krzysztof Kotlarek 0a694215f8 FIX: dont error when user is blank 2020-08-27 14:16:39 +10:00
Krzysztof Kotlarek 7696d459a4 FIX: dont error when json don't contain hidden key 2020-08-27 12:29:27 +10:00
Guo Xiang Tan 353da45b6f
Fix failing test. 2020-08-27 09:36:51 +08:00
Guo Xiang Tan 79e8596332
Make rubocop happy. 2020-08-27 09:19:59 +08:00
Krzysztof Kotlarek fe0806eb2a
FEATURE: introduce data-explorer tables (#61)
Instead of using `PluginStoreRow` we should use plugin-specific models like `DataExplorer::Query` and `DataExplorer::QueryGroup`
2020-08-27 10:29:57 +10:00
Rishabh fe420931ba
FIX: Use updated routes to link user profiles (#60)
FIX links to user profiles from the old route `/users/` to the new route `/u/`.
2020-08-18 11:31:05 +02:00
AndreaHabib 8bdfd845db
UI: Fixed missing text above query list for sorting (#58)
* changed directory-toggle to table-header-toggle which fixed the issue
2020-08-11 12:17:36 -05:00
Discourse Translator Bot 775e4ec499 Update translations 2020-08-11 13:02:43 +00:00
Mark VanLandingham 5bf875a1ac
FIX: Do not show hidden queries in group reports (#57) 2020-08-10 15:12:06 -05:00
Gerhard Schlager e7cc6310d7 DEV: Remove mention of Transifex from locale files 2020-08-06 13:34:32 +02:00
Discourse Translator Bot 3ef3d0bc74 Update translations 2020-08-05 13:25:51 +00:00
Penar Musaraj 5a99501d88
DEV: Use CSS custom properties for colors in SCSS
Prepares the plugin for an upcoming change in core while maintaining
backwards compatiblity.
2020-08-03 21:21:23 -04:00
Ricky Chon dcfb92d7f8
FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54)
* FEATURE: Add hide button (toggleable) for all queries (frontend only)

* Switches between hide/unhide on click
* Works almost like the delete button, but toggles between the query's
hidden attribute instead
* So far this is only a frontend feature, the backend implementation
still needs work

* Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)"

This reverts commit a8771d2ad5.

REVERT: Remove button that hides queries (frontend)

* Prepare for migration of old frontend logic to backend
* We are going to reuse the existing delete button, but change its
backend logic to enable soft deletion. From the user's perspective
nothing will change, but any deletion mistakes can be reverted.

* DEV: Hide user queries upon deletion, but keep them in store

* Creating a new query will set its hidden attribute to false by
default
* Deleting a user-made query will not delete it from the store, but
set its hidden attribute to true
* User queries will not be indexed if they are hidden
* Undeleting a query will unhide it, and will be indexed
* Updating a hidden query will unhide it, and will be indexed

* SPEC: Add spec for hidden/deleted queries

* Hidden queries should not be shown

* FEATURE: Add ability to delete/hide system queries

* System queries are now able to be deleted from view, but will remain
in the backend for retrieval, if necessary

* FEATURE/DEV: Add rake commands for query soft deletion

* query:list_hidden - Shows a list of hidden queries
* query:hide_all[only_default] - Hides all queries, w/ boolean arg to
hide only default ones
* query:unhide[id] - Unhides a query by id
* query:unhide_all[exclude_default] - Unhides all hidden queries,
w/ boolean arg to exclude default ones

* Remove rails loggers

* UX/DEV: Update query rake tasks to be more user friendly

* Split query:hide_all[only_default] into two tasks:
    * query:hide_all - Hides all queries
    * query:hide_all:only_default - Hide only default queries
* Split query:unhide_all[exclude_default] into two tasks:
    * query:unhide_all - Unhides all hidden queries
    * query:unhide_all:exclude_default - Unhides all non-default
    queries
* Rename file to match task name

* UX: query:unhide can accept multiple arguments

* Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10]

* UX: Update query rake tasks to output cleaner messages

* Remove unneeded comment

* DEV: Keep only necessary rake tasks, use more specific naming

* UX/DEV: Add rake task for hard deletion, better console logs

* User is able to hard delete a query only if it is hidden, otherwise
output a message stating so
* Add commented examples above each task
* Add rainbow support for more readable console logs
* Successful messages will display green, failures display red,
additional info displays yellow
* Separate multiple queries with spaces instead of lines

* DEV: Remove rainbow colorizing in console logs

* Rainbow is a dependency of rubocop and it may go away in the future
* Rainbow is only used for dev and test environments

* DEV: Add Rails engine to enable rake tasks to be loaded at runtime

* DEV: Favor require - load files only if they are not already loaded

* SPEC: Add tests for data_explorer[id] rake command

* Test if a single query is hidden correctly
    * Expect length of query list to not be modified
    * Expect array of hidden queries to have exactly 1 element
    * Expect that one element to have the same ID as the one invoked to
    be hidden
* Test if multiple queries are hidden correctly
    * Expect length of query list to not be modified
    * Expect array of hidden queries to have the number of elements
    equal to the number invoked to be hidden
    * Expect the elements to have the same ID as the ones invoked to be
    hidden
* Test if a query exists in PluginStore
    * Expect query list to be empty

* DEV: Clear pre-existing tasks before redefining

* This prevents double invocation when user invokes the task once

* SPEC: Add tests for unhide_query rake task

* Test if a single query unhides correctly
    * Expect length of query list to not be modified
    * Expect array of hidden queries to have exactly 1 element after
    unhiding 1 of 2 queries
    * Expect remaining element to be hidden
* Test if multiple queries unhide correctly
    * Expect length of query list to not be modified
    * Expect array of hidden queries to have exactly 1 element after
    unhiding 3 of 4 queries
    * Expect remaining element to be hidden
* Test if a query exists in PluginStore
    * Expect query list to not be modified

* SPEC: Add tests for hard_delete rake task

* Test if a single query hard deletes correctly
    * Expect length of query list to be shorter by 1
    * Expect array of hidden queries to have exactly 1 element after
    hard deleting 1 of 2 queries
    * Expect 1 remaining hidden element
* Test if multiple queries hard delete correctly
    * Expect length of query list to be shorter by 3 after hard deleting
    3 of 4 queries
    * Expect array of hidden queries to have exactly 1 element after
    hard deleting 3 of 4 queries
    * Expect 1 remaining hidden element
* Test if a query exists in PluginStore
    * Expect hidden query list to not be modified
* Test if a query is not hidden
    * Expect query list to not be modified

* UX: Favor newline char in place of puts for logs

* Condensed console logs to output newline char instead of another puts
statement (reduces number of lines used significantly)
2020-07-29 16:50:24 +10:00
Discourse Translator Bot ab1ec9cb69 DEV: Switch from Transifex to Crowdin 2020-07-16 14:00:47 +02:00