2019-04-29 20:27:42 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2022-07-27 22:27:38 -04:00
|
|
|
RSpec.describe BadgeGranter do
|
2023-11-09 17:47:59 -05:00
|
|
|
fab!(:badge)
|
|
|
|
fab!(:user)
|
2014-03-05 07:52:20 -05:00
|
|
|
|
2020-05-18 05:22:39 -04:00
|
|
|
before { BadgeGranter.enable_queue }
|
|
|
|
|
|
|
|
after do
|
|
|
|
BadgeGranter.disable_queue
|
|
|
|
BadgeGranter.clear_queue!
|
|
|
|
end
|
|
|
|
|
2014-10-07 19:26:18 -04:00
|
|
|
describe "revoke_titles" do
|
2020-08-19 17:23:31 -04:00
|
|
|
let(:user) { Fabricate(:user) }
|
|
|
|
let(:badge) { Fabricate(:badge, allow_title: true) }
|
|
|
|
|
|
|
|
it "revokes title when badge is not allowed as title" do
|
|
|
|
BadgeGranter.grant(badge, user)
|
|
|
|
user.update!(title: badge.name)
|
|
|
|
|
|
|
|
BadgeGranter.revoke_ungranted_titles!
|
2014-10-07 19:26:18 -04:00
|
|
|
user.reload
|
2020-08-19 17:23:31 -04:00
|
|
|
expect(user.title).to eq(badge.name)
|
|
|
|
expect(user.user_profile.granted_title_badge_id).to eq(badge.id)
|
2014-10-07 19:26:18 -04:00
|
|
|
|
2020-08-19 17:23:31 -04:00
|
|
|
badge.update_column(:allow_title, false)
|
|
|
|
BadgeGranter.revoke_ungranted_titles!
|
|
|
|
user.reload
|
|
|
|
expect(user.title).to be_blank
|
|
|
|
expect(user.user_profile.granted_title_badge_id).to be_nil
|
|
|
|
end
|
2014-10-07 19:26:18 -04:00
|
|
|
|
2020-08-19 17:23:31 -04:00
|
|
|
it "revokes title when badge is disabled" do
|
2014-10-09 07:27:34 -04:00
|
|
|
BadgeGranter.grant(badge, user)
|
2020-08-19 17:23:31 -04:00
|
|
|
user.update!(title: badge.name)
|
2014-10-07 19:26:18 -04:00
|
|
|
|
2020-08-19 17:23:31 -04:00
|
|
|
BadgeGranter.revoke_ungranted_titles!
|
2014-10-07 19:26:18 -04:00
|
|
|
user.reload
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(user.title).to eq(badge.name)
|
2020-08-19 17:23:31 -04:00
|
|
|
expect(user.user_profile.granted_title_badge_id).to eq(badge.id)
|
2014-10-07 19:26:18 -04:00
|
|
|
|
2020-08-19 17:23:31 -04:00
|
|
|
badge.update_column(:enabled, false)
|
2014-10-07 19:26:18 -04:00
|
|
|
BadgeGranter.revoke_ungranted_titles!
|
2020-08-19 17:23:31 -04:00
|
|
|
user.reload
|
|
|
|
expect(user.title).to be_blank
|
|
|
|
expect(user.user_profile.granted_title_badge_id).to be_nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it "revokes title when user badge is revoked" do
|
|
|
|
BadgeGranter.grant(badge, user)
|
|
|
|
user.update!(title: badge.name)
|
2014-10-07 19:26:18 -04:00
|
|
|
|
2020-08-19 17:23:31 -04:00
|
|
|
BadgeGranter.revoke_ungranted_titles!
|
|
|
|
user.reload
|
|
|
|
expect(user.title).to eq(badge.name)
|
|
|
|
expect(user.user_profile.granted_title_badge_id).to eq(badge.id)
|
|
|
|
|
|
|
|
BadgeGranter.revoke(user.user_badges.first)
|
|
|
|
BadgeGranter.revoke_ungranted_titles!
|
2014-10-07 19:26:18 -04:00
|
|
|
user.reload
|
2020-08-19 17:23:31 -04:00
|
|
|
expect(user.title).to be_blank
|
|
|
|
expect(user.user_profile.granted_title_badge_id).to be_nil
|
|
|
|
end
|
2014-10-07 19:26:18 -04:00
|
|
|
|
2020-08-19 17:23:31 -04:00
|
|
|
it "does not revoke custom title" do
|
2014-10-07 19:26:18 -04:00
|
|
|
user.title = "CEO"
|
2020-08-19 17:23:31 -04:00
|
|
|
user.save!
|
2014-10-07 19:26:18 -04:00
|
|
|
|
|
|
|
BadgeGranter.revoke_ungranted_titles!
|
|
|
|
|
|
|
|
user.reload
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(user.title).to eq("CEO")
|
2014-10-07 19:26:18 -04:00
|
|
|
end
|
2020-08-19 17:23:31 -04:00
|
|
|
|
|
|
|
it "does not revoke localized title" do
|
|
|
|
badge = Badge.find(Badge::Regular)
|
|
|
|
badge_name = nil
|
|
|
|
BadgeGranter.grant(badge, user)
|
|
|
|
|
|
|
|
I18n.with_locale(:de) do
|
|
|
|
badge_name = badge.display_name
|
|
|
|
user.update!(title: badge_name)
|
|
|
|
end
|
|
|
|
|
|
|
|
user.reload
|
|
|
|
expect(user.title).to eq(badge_name)
|
|
|
|
expect(user.user_profile.granted_title_badge_id).to eq(badge.id)
|
|
|
|
|
|
|
|
BadgeGranter.revoke_ungranted_titles!
|
|
|
|
user.reload
|
|
|
|
expect(user.title).to eq(badge_name)
|
|
|
|
expect(user.user_profile.granted_title_badge_id).to eq(badge.id)
|
|
|
|
end
|
2014-10-07 19:26:18 -04:00
|
|
|
end
|
|
|
|
|
2014-08-12 22:25:56 -04:00
|
|
|
describe "preview" do
|
|
|
|
it "can correctly preview" do
|
|
|
|
Fabricate(:user, email: "sam@gmail.com")
|
2017-04-26 14:47:36 -04:00
|
|
|
result =
|
|
|
|
BadgeGranter.preview(
|
|
|
|
'select u.id user_id, null post_id, u.created_at granted_at from users u
|
|
|
|
join user_emails ue on ue.user_id = u.id AND ue.primary
|
|
|
|
where ue.email like \'%gmail.com\'',
|
|
|
|
explain: true,
|
|
|
|
)
|
|
|
|
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(result[:grant_count]).to eq(1)
|
2015-05-28 02:06:22 -04:00
|
|
|
expect(result[:query_plan]).to be_present
|
2014-08-12 22:25:56 -04:00
|
|
|
end
|
2020-03-27 14:16:14 -04:00
|
|
|
|
|
|
|
it "with badges containing trailing comments do not break generated SQL" do
|
|
|
|
query = Badge.find(1).query + "\n-- a comment"
|
|
|
|
expect(BadgeGranter.preview(query)[:errors]).to be_nil
|
|
|
|
end
|
2014-08-12 22:25:56 -04:00
|
|
|
end
|
|
|
|
|
2014-07-03 03:29:44 -04:00
|
|
|
describe "backfill" do
|
|
|
|
it "has no broken badge queries" do
|
|
|
|
Badge.all.each { |b| BadgeGranter.backfill(b) }
|
|
|
|
end
|
|
|
|
|
|
|
|
it "can backfill the welcome badge" do
|
|
|
|
post = Fabricate(:post)
|
|
|
|
user2 = Fabricate(:user)
|
2019-01-03 12:03:01 -05:00
|
|
|
PostActionCreator.like(user2, post)
|
2014-07-03 03:29:44 -04:00
|
|
|
|
|
|
|
UserBadge.destroy_all
|
|
|
|
BadgeGranter.backfill(Badge.find(Badge::Welcome))
|
2014-07-08 22:17:39 -04:00
|
|
|
BadgeGranter.backfill(Badge.find(Badge::FirstLike))
|
2014-07-03 03:29:44 -04:00
|
|
|
|
2014-07-08 00:26:53 -04:00
|
|
|
b = UserBadge.find_by(user_id: post.user_id)
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(b.post_id).to eq(post.id)
|
2014-07-08 00:26:53 -04:00
|
|
|
b.badge_id = Badge::Welcome
|
|
|
|
|
|
|
|
b = UserBadge.find_by(user_id: user2.id)
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(b.post_id).to eq(post.id)
|
2014-07-08 22:17:39 -04:00
|
|
|
b.badge_id = Badge::FirstLike
|
2014-07-03 03:29:44 -04:00
|
|
|
end
|
2014-05-04 14:15:38 -04:00
|
|
|
|
2014-07-01 08:00:31 -04:00
|
|
|
it "should grant missing badges" do
|
2019-01-04 09:17:54 -05:00
|
|
|
nice_topic = Badge.find(Badge::NiceTopic)
|
2016-02-01 02:26:45 -05:00
|
|
|
good_topic = Badge.find(Badge::GoodTopic)
|
|
|
|
|
2014-07-01 08:00:31 -04:00
|
|
|
post = Fabricate(:post, like_count: 30)
|
2019-01-04 09:17:54 -05:00
|
|
|
|
2014-07-05 04:32:06 -04:00
|
|
|
2.times do
|
2019-01-04 09:17:54 -05:00
|
|
|
BadgeGranter.backfill(nice_topic, post_ids: [post.id])
|
2016-02-01 02:26:45 -05:00
|
|
|
BadgeGranter.backfill(good_topic)
|
2023-01-09 06:18:21 -05:00
|
|
|
end
|
2014-07-01 08:00:31 -04:00
|
|
|
|
|
|
|
# TODO add welcome
|
2019-01-04 09:17:54 -05:00
|
|
|
expect(post.user.user_badges.pluck(:badge_id)).to contain_exactly(
|
|
|
|
nice_topic.id,
|
|
|
|
good_topic.id,
|
|
|
|
)
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(post.user.notifications.count).to eq(2)
|
2014-07-07 03:55:25 -04:00
|
|
|
|
2019-01-04 09:17:54 -05:00
|
|
|
data = post.user.notifications.last.data_hash
|
2016-02-01 02:26:45 -05:00
|
|
|
expect(data["badge_id"]).to eq(good_topic.id)
|
|
|
|
expect(data["badge_slug"]).to eq(good_topic.slug)
|
|
|
|
expect(data["username"]).to eq(post.user.username)
|
|
|
|
|
2019-01-04 09:17:54 -05:00
|
|
|
expect(nice_topic.grant_count).to eq(1)
|
|
|
|
expect(good_topic.grant_count).to eq(1)
|
2014-07-01 08:00:31 -04:00
|
|
|
end
|
2016-10-11 18:15:36 -04:00
|
|
|
|
|
|
|
it "should grant badges in the user locale" do
|
|
|
|
SiteSetting.allow_user_locale = true
|
|
|
|
|
|
|
|
nice_topic = Badge.find(Badge::NiceTopic)
|
|
|
|
name_english = nice_topic.name
|
|
|
|
|
|
|
|
user = Fabricate(:user, locale: "fr")
|
|
|
|
post = Fabricate(:post, like_count: 10, user: user)
|
|
|
|
|
|
|
|
BadgeGranter.backfill(nice_topic)
|
|
|
|
|
|
|
|
notification_badge_name = JSON.parse(post.user.notifications.first.data)["badge_name"]
|
|
|
|
|
|
|
|
expect(notification_badge_name).not_to eq(name_english)
|
|
|
|
end
|
2020-03-27 14:16:14 -04:00
|
|
|
|
|
|
|
it "with badges containing trailing comments do not break generated SQL" do
|
|
|
|
badge = Fabricate(:badge)
|
|
|
|
badge.query = Badge.find(1).query + "\n-- a comment"
|
|
|
|
expect { BadgeGranter.backfill(badge) }.not_to raise_error
|
|
|
|
end
|
2021-04-26 03:41:51 -04:00
|
|
|
|
|
|
|
it 'does not notify about badges "for beginners" when user skipped new user tips' do
|
|
|
|
user.user_option.update!(skip_new_user_tips: true)
|
|
|
|
post = Fabricate(:post)
|
|
|
|
PostActionCreator.like(user, post)
|
|
|
|
|
|
|
|
expect { BadgeGranter.backfill(Badge.find(Badge::FirstLike)) }.to_not change {
|
|
|
|
Notification.where(user_id: user.id).count
|
|
|
|
}
|
|
|
|
end
|
2021-07-27 02:32:59 -04:00
|
|
|
|
|
|
|
it "does not grant sharing badges to deleted users" do
|
|
|
|
post = Fabricate(:post)
|
|
|
|
incoming_links = Fabricate.times(25, :incoming_link, post: post, user: user)
|
|
|
|
user_id = user.id
|
|
|
|
user.destroy!
|
|
|
|
|
|
|
|
nice_share = Badge.find(Badge::NiceShare)
|
|
|
|
first_share = Badge.find(Badge::FirstShare)
|
|
|
|
|
|
|
|
BadgeGranter.backfill(nice_share)
|
|
|
|
BadgeGranter.backfill(first_share)
|
|
|
|
|
|
|
|
expect(UserBadge.where(user_id: user_id).count).to eq(0)
|
|
|
|
end
|
2014-07-01 08:00:31 -04:00
|
|
|
end
|
|
|
|
|
2014-03-05 07:52:20 -05:00
|
|
|
describe "grant" do
|
2016-04-12 08:08:38 -04:00
|
|
|
it "allows overriding of granted_at does not notify old bronze" do
|
2020-03-10 17:13:17 -04:00
|
|
|
freeze_time
|
2018-06-05 03:29:17 -04:00
|
|
|
badge = Badge.create!(name: "a badge", badge_type_id: BadgeType::Bronze)
|
2020-03-10 17:13:17 -04:00
|
|
|
user_badge = BadgeGranter.grant(badge, user, created_at: 1.year.ago)
|
2018-06-05 03:29:17 -04:00
|
|
|
|
2020-03-10 17:13:17 -04:00
|
|
|
expect(user_badge.granted_at).to eq_time(1.year.ago)
|
2016-04-12 08:08:38 -04:00
|
|
|
expect(Notification.where(user_id: user.id).count).to eq(0)
|
2016-08-19 15:16:37 -04:00
|
|
|
end
|
|
|
|
|
2020-12-22 09:54:51 -05:00
|
|
|
it "handles deleted badge" do
|
|
|
|
freeze_time
|
|
|
|
user_badge = BadgeGranter.grant(nil, user, created_at: 1.year.ago)
|
|
|
|
expect(user_badge).to eq(nil)
|
|
|
|
end
|
|
|
|
|
2016-08-19 15:16:37 -04:00
|
|
|
it "doesn't grant disabled badges" do
|
2020-03-10 17:13:17 -04:00
|
|
|
freeze_time
|
2016-08-19 15:16:37 -04:00
|
|
|
badge = Fabricate(:badge, badge_type_id: BadgeType::Bronze, enabled: false)
|
2016-04-12 08:08:38 -04:00
|
|
|
|
2020-03-10 17:13:17 -04:00
|
|
|
user_badge = BadgeGranter.grant(badge, user, created_at: 1.year.ago)
|
2016-08-19 15:16:37 -04:00
|
|
|
expect(user_badge).to eq(nil)
|
2016-04-12 08:08:38 -04:00
|
|
|
end
|
|
|
|
|
2021-04-26 03:41:51 -04:00
|
|
|
it "doesn't notify about badges 'for beginners' when user skipped new user tips" do
|
2020-08-18 04:13:40 -04:00
|
|
|
freeze_time
|
2021-04-26 03:41:51 -04:00
|
|
|
UserBadge.destroy_all
|
2020-08-18 04:13:40 -04:00
|
|
|
user.user_option.update!(skip_new_user_tips: true)
|
|
|
|
badge = Fabricate(:badge, badge_grouping_id: BadgeGrouping::GettingStarted)
|
|
|
|
|
2021-04-26 03:41:51 -04:00
|
|
|
expect { BadgeGranter.grant(badge, user) }.to_not change {
|
|
|
|
Notification.where(user_id: user.id).count
|
|
|
|
}
|
2020-08-18 04:13:40 -04:00
|
|
|
end
|
|
|
|
|
2021-04-26 03:41:51 -04:00
|
|
|
it "notifies about the New User of the Month badge when user skipped new user tips" do
|
2020-09-24 13:58:31 -04:00
|
|
|
freeze_time
|
|
|
|
user.user_option.update!(skip_new_user_tips: true)
|
|
|
|
badge = Badge.find(Badge::NewUserOfTheMonth)
|
|
|
|
|
2021-04-26 03:41:51 -04:00
|
|
|
expect { BadgeGranter.grant(badge, user) }.to change {
|
|
|
|
Notification.where(user_id: user.id).count
|
|
|
|
}
|
2020-09-24 13:58:31 -04:00
|
|
|
end
|
|
|
|
|
2014-08-10 19:21:06 -04:00
|
|
|
it "grants multiple badges" do
|
|
|
|
badge = Fabricate(:badge, multiple_grant: true)
|
|
|
|
user_badge = BadgeGranter.grant(badge, user)
|
2014-03-05 07:52:20 -05:00
|
|
|
user_badge = BadgeGranter.grant(badge, user)
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(user_badge).to be_present
|
2014-08-10 19:21:06 -04:00
|
|
|
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(UserBadge.where(user_id: user.id).count).to eq(2)
|
2014-03-05 07:52:20 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "sets granted_at" do
|
2020-03-10 17:13:17 -04:00
|
|
|
day_ago = freeze_time 1.day.ago
|
2014-03-05 07:52:20 -05:00
|
|
|
user_badge = BadgeGranter.grant(badge, user)
|
2020-03-10 17:13:17 -04:00
|
|
|
|
|
|
|
expect(user_badge.granted_at).to eq_time(day_ago)
|
2014-03-05 07:52:20 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "sets granted_by if the option is present" do
|
|
|
|
admin = Fabricate(:admin)
|
2014-03-19 15:30:12 -04:00
|
|
|
StaffActionLogger.any_instance.expects(:log_badge_grant).once
|
2014-03-05 07:52:20 -05:00
|
|
|
user_badge = BadgeGranter.grant(badge, user, granted_by: admin)
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(user_badge.granted_by).to eq(admin)
|
2014-03-05 07:52:20 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "defaults granted_by to the system user" do
|
2014-03-19 15:30:12 -04:00
|
|
|
StaffActionLogger.any_instance.expects(:log_badge_grant).never
|
2014-03-05 07:52:20 -05:00
|
|
|
user_badge = BadgeGranter.grant(badge, user)
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(user_badge.granted_by_id).to eq(Discourse.system_user.id)
|
2014-03-05 07:52:20 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "does not allow a regular user to grant badges" do
|
|
|
|
user_badge = BadgeGranter.grant(badge, user, granted_by: Fabricate(:user))
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(user_badge).not_to be_present
|
2014-03-05 07:52:20 -05:00
|
|
|
end
|
|
|
|
|
2014-04-16 15:59:45 -04:00
|
|
|
it "increments grant_count on the badge and creates a notification" do
|
2014-03-05 07:52:20 -05:00
|
|
|
BadgeGranter.grant(badge, user)
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(badge.reload.grant_count).to eq(1)
|
|
|
|
expect(
|
|
|
|
user.notifications.find_by(notification_type: Notification.types[:granted_badge]).data_hash[
|
|
|
|
"badge_id"
|
2023-01-09 06:18:21 -05:00
|
|
|
],
|
2015-04-25 11:18:35 -04:00
|
|
|
).to eq(badge.id)
|
2014-03-05 07:52:20 -05:00
|
|
|
end
|
|
|
|
|
2021-01-18 15:12:38 -05:00
|
|
|
it "does not fail when user is missing" do
|
|
|
|
BadgeGranter.grant(badge, nil)
|
|
|
|
expect(badge.reload.grant_count).to eq(0)
|
|
|
|
end
|
2014-03-05 07:52:20 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
describe "revoke" do
|
2023-11-09 17:47:59 -05:00
|
|
|
fab!(:admin)
|
2014-03-05 07:52:20 -05:00
|
|
|
let!(:user_badge) { BadgeGranter.grant(badge, user) }
|
|
|
|
|
2014-04-17 23:10:53 -04:00
|
|
|
it "revokes the badge and does necessary cleanup" do
|
|
|
|
user.title = badge.name
|
|
|
|
user.save!
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(badge.reload.grant_count).to eq(1)
|
2014-03-19 15:30:12 -04:00
|
|
|
StaffActionLogger.any_instance.expects(:log_badge_revoke).with(user_badge)
|
|
|
|
BadgeGranter.revoke(user_badge, revoked_by: admin)
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(UserBadge.find_by(user: user, badge: badge)).not_to be_present
|
|
|
|
expect(badge.reload.grant_count).to eq(0)
|
|
|
|
expect(
|
|
|
|
user.notifications.where(notification_type: Notification.types[:granted_badge]),
|
|
|
|
).to be_empty
|
|
|
|
expect(user.reload.title).to eq(nil)
|
2014-03-05 07:52:20 -05:00
|
|
|
end
|
|
|
|
|
2019-11-08 00:34:24 -05:00
|
|
|
context "when the badge name is customized, and the customized name is the same as the user title" do
|
|
|
|
let(:customized_badge_name) { "Merit Badge" }
|
|
|
|
|
|
|
|
before do
|
2024-05-24 10:15:53 -04:00
|
|
|
I18n.backend.store_translations(
|
|
|
|
:en,
|
|
|
|
{ badges: { Badge.i18n_name(badge.name) => { name: "Badge 0" } } },
|
|
|
|
)
|
2019-11-08 00:34:24 -05:00
|
|
|
TranslationOverride.upsert!(I18n.locale, Badge.i18n_key(badge.name), customized_badge_name)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "revokes the badge and title and does necessary cleanup" do
|
|
|
|
user.title = customized_badge_name
|
|
|
|
user.save!
|
|
|
|
expect(badge.reload.grant_count).to eq(1)
|
|
|
|
StaffActionLogger.any_instance.expects(:log_badge_revoke).with(user_badge)
|
|
|
|
StaffActionLogger
|
|
|
|
.any_instance
|
|
|
|
.expects(:log_title_revoke)
|
|
|
|
.with(
|
|
|
|
user,
|
|
|
|
revoke_reason: "user title was same as revoked badge name or custom badge name",
|
|
|
|
previous_value: user_badge.user.title,
|
|
|
|
)
|
|
|
|
BadgeGranter.revoke(user_badge, revoked_by: admin)
|
|
|
|
expect(UserBadge.find_by(user: user, badge: badge)).not_to be_present
|
|
|
|
expect(badge.reload.grant_count).to eq(0)
|
|
|
|
expect(
|
|
|
|
user.notifications.where(notification_type: Notification.types[:granted_badge]),
|
|
|
|
).to be_empty
|
|
|
|
expect(user.reload.title).to eq(nil)
|
|
|
|
end
|
|
|
|
|
|
|
|
after { TranslationOverride.revert!(I18n.locale, Badge.i18n_key(badge.name)) }
|
|
|
|
end
|
2014-03-05 07:52:20 -05:00
|
|
|
end
|
|
|
|
|
2020-01-23 12:14:58 -05:00
|
|
|
describe "revoke_all" do
|
|
|
|
it "deletes every user_badge record associated with that badge" do
|
|
|
|
described_class.grant(badge, user)
|
|
|
|
described_class.revoke_all(badge)
|
|
|
|
|
|
|
|
expect(UserBadge.exists?(badge: badge, user: user)).to eq(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "removes titles" do
|
|
|
|
another_title = "another title"
|
|
|
|
described_class.grant(badge, user)
|
|
|
|
user.update!(title: badge.name)
|
|
|
|
user2 = Fabricate(:user, title: another_title)
|
|
|
|
|
|
|
|
described_class.revoke_all(badge)
|
|
|
|
|
|
|
|
expect(user.reload.title).to be_nil
|
|
|
|
expect(user2.reload.title).to eq(another_title)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "removes custom badge titles" do
|
|
|
|
custom_badge_title = "this is a badge title"
|
2024-05-24 10:15:53 -04:00
|
|
|
I18n.backend.store_translations(
|
|
|
|
:en,
|
|
|
|
{ badges: { Badge.i18n_name(badge.name) => { name: "Badge 0" } } },
|
|
|
|
)
|
2021-01-20 15:32:22 -05:00
|
|
|
TranslationOverride.create!(
|
|
|
|
translation_key: badge.translation_key,
|
|
|
|
value: custom_badge_title,
|
|
|
|
locale: "en",
|
|
|
|
)
|
2020-01-23 12:14:58 -05:00
|
|
|
described_class.grant(badge, user)
|
|
|
|
user.update!(title: custom_badge_title)
|
|
|
|
|
|
|
|
described_class.revoke_all(badge)
|
|
|
|
|
|
|
|
expect(user.reload.title).to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
describe "update_badges" do
|
2023-12-12 22:50:13 -05:00
|
|
|
fab!(:user) { Fabricate(:user, refresh_auto_groups: true) }
|
|
|
|
fab!(:liker) { Fabricate(:user, refresh_auto_groups: true) }
|
2014-05-04 14:15:38 -04:00
|
|
|
|
2014-07-22 21:42:24 -04:00
|
|
|
it "grants autobiographer" do
|
|
|
|
user.user_profile.bio_raw = "THIS IS MY bio it a long bio I like my bio"
|
|
|
|
user.uploaded_avatar_id = 10
|
|
|
|
user.user_profile.save
|
|
|
|
user.save
|
|
|
|
|
|
|
|
BadgeGranter.process_queue!
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(UserBadge.where(user_id: user.id, badge_id: Badge::Autobiographer).count).to eq(1)
|
2014-07-22 21:42:24 -04:00
|
|
|
end
|
|
|
|
|
2021-05-20 21:43:47 -04:00
|
|
|
it "grants read guidelines" do
|
2014-07-22 21:42:24 -04:00
|
|
|
user.user_stat.read_faq = Time.now
|
|
|
|
user.user_stat.save
|
|
|
|
|
|
|
|
BadgeGranter.process_queue!
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(UserBadge.where(user_id: user.id, badge_id: Badge::ReadGuidelines).count).to eq(1)
|
2014-07-22 21:42:24 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "grants first link" do
|
|
|
|
post = create_post
|
|
|
|
post2 = create_post(raw: "#{Discourse.base_url}/t/slug/#{post.topic_id}")
|
|
|
|
|
|
|
|
BadgeGranter.process_queue!
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(UserBadge.where(user_id: post2.user.id, badge_id: Badge::FirstLink).count).to eq(1)
|
2014-07-22 21:42:24 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "grants first edit" do
|
2015-11-24 14:28:42 -05:00
|
|
|
SiteSetting.editing_grace_period = 0
|
2014-07-22 21:42:24 -04:00
|
|
|
post = create_post
|
|
|
|
user = post.user
|
|
|
|
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(UserBadge.where(user_id: user.id, badge_id: Badge::Editor).count).to eq(0)
|
2014-07-22 21:42:24 -04:00
|
|
|
|
2014-10-27 17:06:43 -04:00
|
|
|
PostRevisor.new(post).revise!(user, raw: "This is my new test 1235 123")
|
2014-07-22 21:42:24 -04:00
|
|
|
BadgeGranter.process_queue!
|
|
|
|
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(UserBadge.where(user_id: user.id, badge_id: Badge::Editor).count).to eq(1)
|
2014-07-22 21:42:24 -04:00
|
|
|
end
|
|
|
|
|
2014-05-15 13:43:04 -04:00
|
|
|
it "grants and revokes trust level badges" do
|
2014-09-05 01:20:39 -04:00
|
|
|
user.change_trust_level!(TrustLevel[4])
|
2014-07-22 21:42:24 -04:00
|
|
|
BadgeGranter.process_queue!
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(UserBadge.where(user_id: user.id, badge_id: Badge.trust_level_badge_ids).count).to eq(
|
2023-01-09 06:18:21 -05:00
|
|
|
4,
|
2015-04-25 11:18:35 -04:00
|
|
|
)
|
2014-07-22 21:42:24 -04:00
|
|
|
|
2014-09-05 01:20:39 -04:00
|
|
|
user.change_trust_level!(TrustLevel[1])
|
2014-07-22 21:42:24 -04:00
|
|
|
BadgeGranter.backfill(Badge.find(1))
|
|
|
|
BadgeGranter.backfill(Badge.find(2))
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(UserBadge.where(user_id: user.id, badge_id: 1).first).not_to eq(nil)
|
|
|
|
expect(UserBadge.where(user_id: user.id, badge_id: 2).first).to eq(nil)
|
2014-05-04 14:15:38 -04:00
|
|
|
end
|
2014-06-17 02:29:49 -04:00
|
|
|
|
|
|
|
it "grants system like badges" do
|
|
|
|
post = create_post(user: user)
|
|
|
|
# Welcome badge
|
2019-01-03 12:03:01 -05:00
|
|
|
action = PostActionCreator.like(liker, post).post_action
|
2014-07-22 21:42:24 -04:00
|
|
|
BadgeGranter.process_queue!
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(UserBadge.find_by(user_id: user.id, badge_id: 5)).not_to eq(nil)
|
2014-07-22 21:42:24 -04:00
|
|
|
|
2014-09-10 22:36:37 -04:00
|
|
|
post = create_post(topic: post.topic, user: user)
|
2019-01-03 12:03:01 -05:00
|
|
|
action = PostActionCreator.like(liker, post).post_action
|
2014-09-10 22:36:37 -04:00
|
|
|
|
2014-06-17 02:29:49 -04:00
|
|
|
# Nice post badge
|
2019-04-29 03:32:25 -04:00
|
|
|
post.update like_count: 10
|
2014-07-22 21:42:24 -04:00
|
|
|
|
|
|
|
BadgeGranter.queue_badge_grant(Badge::Trigger::PostAction, post_action: action)
|
|
|
|
BadgeGranter.process_queue!
|
|
|
|
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(UserBadge.find_by(user_id: user.id, badge_id: Badge::NicePost)).not_to eq(nil)
|
|
|
|
expect(UserBadge.where(user_id: user.id, badge_id: Badge::NicePost).count).to eq(1)
|
2014-07-22 21:42:24 -04:00
|
|
|
|
2014-06-17 02:29:49 -04:00
|
|
|
# Good post badge
|
2019-04-29 03:32:25 -04:00
|
|
|
post.update like_count: 25
|
2014-07-22 21:42:24 -04:00
|
|
|
BadgeGranter.queue_badge_grant(Badge::Trigger::PostAction, post_action: action)
|
|
|
|
BadgeGranter.process_queue!
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(UserBadge.find_by(user_id: user.id, badge_id: Badge::GoodPost)).not_to eq(nil)
|
2014-07-22 21:42:24 -04:00
|
|
|
|
2014-06-17 02:29:49 -04:00
|
|
|
# Great post badge
|
2019-04-29 03:32:25 -04:00
|
|
|
post.update like_count: 50
|
2014-07-22 21:42:24 -04:00
|
|
|
BadgeGranter.queue_badge_grant(Badge::Trigger::PostAction, post_action: action)
|
|
|
|
BadgeGranter.process_queue!
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(UserBadge.find_by(user_id: user.id, badge_id: Badge::GreatPost)).not_to eq(nil)
|
2014-07-22 21:42:24 -04:00
|
|
|
|
2014-06-17 02:29:49 -04:00
|
|
|
# Revoke badges on unlike
|
2019-04-29 03:32:25 -04:00
|
|
|
post.update like_count: 49
|
2014-07-22 21:42:24 -04:00
|
|
|
BadgeGranter.backfill(Badge.find(Badge::GreatPost))
|
2015-04-25 11:18:35 -04:00
|
|
|
expect(UserBadge.find_by(user_id: user.id, badge_id: Badge::GreatPost)).to eq(nil)
|
2014-06-17 02:29:49 -04:00
|
|
|
end
|
2022-07-19 21:33:07 -04:00
|
|
|
|
2022-07-21 21:06:02 -04:00
|
|
|
it "triggers the 'user_badge_granted' DiscourseEvent per badge when badges are backfilled" do
|
2022-07-19 21:33:07 -04:00
|
|
|
post = create_post(user: user)
|
|
|
|
action = PostActionCreator.like(liker, post).post_action
|
|
|
|
|
2022-07-21 21:06:02 -04:00
|
|
|
events = DiscourseEvent.track_events(:user_badge_granted) { BadgeGranter.process_queue! }
|
2022-07-19 21:33:07 -04:00
|
|
|
|
2022-07-21 21:06:02 -04:00
|
|
|
expect(events.length).to eq(2)
|
|
|
|
expect(events[0][:params]).to eq([Badge::FirstLike, liker.id])
|
|
|
|
expect(events[1][:params]).to eq([Badge::Welcome, user.id])
|
2022-07-19 21:33:07 -04:00
|
|
|
end
|
2014-05-04 14:15:38 -04:00
|
|
|
end
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
describe "notification locales" do
|
2020-01-20 17:08:48 -05:00
|
|
|
it "is using default locales when user locales are not set" do
|
|
|
|
SiteSetting.allow_user_locale = true
|
|
|
|
expect(BadgeGranter.notification_locale("")).to eq(SiteSetting.default_locale)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "is using default locales when user locales are set but is not allowed" do
|
|
|
|
SiteSetting.allow_user_locale = false
|
|
|
|
expect(BadgeGranter.notification_locale("pl_PL")).to eq(SiteSetting.default_locale)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "is using user locales when set and allowed" do
|
|
|
|
SiteSetting.allow_user_locale = true
|
|
|
|
expect(BadgeGranter.notification_locale("pl_PL")).to eq("pl_PL")
|
|
|
|
end
|
|
|
|
end
|
2021-07-14 22:53:26 -04:00
|
|
|
|
|
|
|
describe ".mass_grant" do
|
|
|
|
it "raises an error if the count argument is less than 1" do
|
|
|
|
expect do BadgeGranter.mass_grant(badge, user, count: 0) end.to raise_error(
|
|
|
|
ArgumentError,
|
|
|
|
"count can't be less than 1",
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "grants the badge to the user as many times as the count argument" do
|
|
|
|
BadgeGranter.mass_grant(badge, user, count: 10)
|
|
|
|
sequence = UserBadge.where(badge: badge, user: user).pluck(:seq).sort
|
|
|
|
expect(sequence).to eq((0...10).to_a)
|
|
|
|
|
|
|
|
BadgeGranter.mass_grant(badge, user, count: 10)
|
|
|
|
sequence = UserBadge.where(badge: badge, user: user).pluck(:seq).sort
|
|
|
|
expect(sequence).to eq((0...20).to_a)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe ".enqueue_mass_grant_for_users" do
|
|
|
|
before { Jobs.run_immediately! }
|
|
|
|
|
|
|
|
it "returns a list of the entries that could not be matched to any users" do
|
|
|
|
results =
|
|
|
|
BadgeGranter.enqueue_mass_grant_for_users(
|
|
|
|
badge,
|
|
|
|
emails: ["fakeemail@discourse.invalid", user.email],
|
|
|
|
usernames: [user.username, "fakeusername"],
|
|
|
|
)
|
|
|
|
expect(results[:unmatched_entries]).to contain_exactly(
|
|
|
|
"fakeemail@discourse.invalid",
|
|
|
|
"fakeusername",
|
|
|
|
)
|
|
|
|
expect(results[:matched_users_count]).to eq(1)
|
|
|
|
expect(results[:unmatched_entries_count]).to eq(2)
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when ensure_users_have_badge_once is true" do
|
|
|
|
it "ensures each user has the badge at least once and does not grant the badge multiple times to one user" do
|
|
|
|
BadgeGranter.grant(badge, user)
|
|
|
|
user_without_badge = Fabricate(:user)
|
|
|
|
|
|
|
|
Notification.destroy_all
|
|
|
|
results =
|
|
|
|
BadgeGranter.enqueue_mass_grant_for_users(
|
|
|
|
badge,
|
|
|
|
usernames: [
|
|
|
|
user.username,
|
|
|
|
user.username,
|
|
|
|
user_without_badge.username,
|
|
|
|
user_without_badge.username,
|
|
|
|
],
|
|
|
|
ensure_users_have_badge_once: true,
|
|
|
|
)
|
|
|
|
expect(results[:unmatched_entries]).to eq([])
|
|
|
|
expect(results[:matched_users_count]).to eq(2)
|
|
|
|
expect(results[:unmatched_entries_count]).to eq(0)
|
|
|
|
|
|
|
|
sequence = UserBadge.where(user: user, badge: badge).pluck(:seq)
|
|
|
|
expect(sequence).to contain_exactly(0)
|
|
|
|
# no new badge/notification because user already had the badge
|
|
|
|
# before enqueue_mass_grant_for_users was called
|
|
|
|
expect(user.reload.notifications.size).to eq(0)
|
|
|
|
|
|
|
|
sequence = UserBadge.where(user: user_without_badge, badge: badge)
|
|
|
|
expect(sequence.pluck(:seq)).to contain_exactly(0)
|
|
|
|
notifications = user_without_badge.reload.notifications
|
|
|
|
expect(notifications.size).to eq(1)
|
|
|
|
expect(sequence.first.notification_id).to eq(notifications.first.id)
|
|
|
|
expect(notifications.first.notification_type).to eq(Notification.types[:granted_badge])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when ensure_users_have_badge_once is false" do
|
|
|
|
it "grants the badge to the users as many times as they appear in the emails and usernames arguments" do
|
|
|
|
badge.update!(multiple_grant: true)
|
|
|
|
user_without_badge = Fabricate(:user)
|
|
|
|
user_with_badge = Fabricate(:user).tap { |u| BadgeGranter.grant(badge, u) }
|
|
|
|
|
|
|
|
Notification.destroy_all
|
|
|
|
emails = [user_with_badge.email.titlecase, user_without_badge.email.titlecase] * 20
|
|
|
|
usernames = [user_with_badge.username.titlecase, user_without_badge.username.titlecase] * 20
|
|
|
|
|
|
|
|
results =
|
|
|
|
BadgeGranter.enqueue_mass_grant_for_users(
|
|
|
|
badge,
|
|
|
|
emails: emails,
|
|
|
|
usernames: usernames,
|
|
|
|
ensure_users_have_badge_once: false,
|
|
|
|
)
|
|
|
|
expect(results[:unmatched_entries]).to eq([])
|
|
|
|
expect(results[:matched_users_count]).to eq(2)
|
|
|
|
expect(results[:unmatched_entries_count]).to eq(0)
|
|
|
|
|
|
|
|
sequence = UserBadge.where(user: user_with_badge, badge: badge).pluck(:seq)
|
|
|
|
expect(sequence.size).to eq(40 + 1)
|
|
|
|
expect(sequence.sort).to eq((0...(40 + 1)).to_a)
|
|
|
|
sequence = UserBadge.where(user: user_without_badge, badge: badge).pluck(:seq)
|
|
|
|
expect(sequence.size).to eq(40)
|
|
|
|
expect(sequence.sort).to eq((0...40).to_a)
|
|
|
|
|
|
|
|
# each user gets 1 notification no matter how many times
|
|
|
|
# they're repeated in the file.
|
|
|
|
[user_without_badge, user_with_badge].each do |u|
|
|
|
|
notifications = u.reload.notifications
|
|
|
|
expect(notifications.size).to eq(1)
|
|
|
|
expect(notifications.map(&:notification_type).uniq).to contain_exactly(
|
|
|
|
Notification.types[:granted_badge],
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2014-03-05 07:52:20 -05:00
|
|
|
end
|