2020-02-05 11:33:15 -05:00
|
|
|
module.exports = {
|
2022-07-06 04:37:54 -04:00
|
|
|
plugins: ["ember-template-lint-plugin-discourse"],
|
|
|
|
|
extends: "discourse:recommended",
|
2020-02-05 11:33:15 -05:00
|
|
|
|
|
|
|
|
rules: {
|
DEV: Remove usage of {{action}} modifiers - Take 2 (#18476)
This PR enables the [`no-action-modifiers`](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-action-modifiers.md) template lint rule and removes all usages of the `{{action}}` modifier in core.
In general, instances of `{{action "x"}}` have been replaced with `{{on "click" (action "x")}}`.
In many cases, such as for `a` elements, we also need to prevent default event handling to avoid unwanted side effects. While the `{{action}}` modifier internally calls `event.preventDefault()`, we need to handle these cases more explicitly. For this purpose, this PR also adds the [ember-event-helpers](https://github.com/buschtoens/ember-event-helpers) dependency so we can use the `prevent-default` handler. For instance:
```
<a href {{on "click" (prevent-default (action "x"))}}>Do X</a>
```
Note that `action` has not in general been refactored away as a helper yet. In general, all event handlers should be methods on the corresponding component and referenced directly (e.g. `{{on "click" this.doSomething}}`). However, the `action` helper is used extensively throughout the codebase and often references methods in the `actions` hash on controllers or routes. Thus this refactor will also be extensive and probably deserves a separate PR.
Note: This work was done to complement #17767 by minimizing the potential impact of the `action` modifier override, which uses private API and arguably should be replaced with an AST transform.
This is a followup to #18333, which had to be reverted because it did not account for the default treatment of modifier keys by the {{action}} modifier.
Commits:
* Enable `no-action-modifiers` template lint rule
* Replace {{action "x"}} with {{on "click" (action "x")}}
* Remove unnecessary action helper usage
* Remove ctl+click tests for user-menu
These tests now break in Chrome when used with addEventListener. As per the comment, they can probably be safely removed.
* Prevent default event handlers to avoid unwanted side effects
Uses `event.preventDefault()` in event handlers to prevent default event handling. This had been done automatically by the `action` modifier, but is not always desirable or necessary.
* Restore UserCardContents#showUser action to avoid regression
By keeping the `showUser` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showUser` argument that's been passed.
* Revert EditCategoryTab#selectTab -> EditCategoryTab#select
Avoid potential breaking change in themes / plugins
* Restore GroupCardContents#showGroup action to avoid regression
By keeping the `showGroup` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showGroup` argument that's been passed.
* Restore SecondFactorAddTotp#showSecondFactorKey action to avoid regression
By keeping the `showSecondFactorKey` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showSecondFactorKey` property that's maintained on the controller.
* Refactor away from `actions` hash in ChooseMessage component
* Modernize EmojiPicker#onCategorySelection usage
* Modernize SearchResultEntry#logClick usage
* Modernize Discovery::Categories#showInserted usage
* Modernize Preferences::Account#resendConfirmationEmail usage
* Modernize MultiSelect::SelectedCategory#onSelectedNameClick usage
* Favor fn over action in SelectedChoice component
* Modernize WizardStep event handlers
* Favor fn over action usage in buttons
* Restore Login#forgotPassword action to avoid possible regression
* Introduce modKeysPressed utility
Returns an array of modifier keys that are pressed during a given `MouseEvent` or `KeyboardEvent`.
* Don't interfere with click events on links with `href` values when modifier keys are pressed
2022-10-05 08:08:54 -04:00
|
|
|
"no-action-modifiers": true,
|
2022-10-21 16:44:14 -04:00
|
|
|
"no-args-paths": true,
|
|
|
|
|
"no-attrs-in-components": true,
|
2022-07-06 04:37:54 -04:00
|
|
|
"no-capital-arguments": false, // TODO: we extensively use `args` argument name
|
2022-07-04 08:00:11 -04:00
|
|
|
"no-curly-component-invocation": {
|
|
|
|
|
allow: [
|
|
|
|
|
// These are helpers, not components
|
|
|
|
|
"directory-item-header-title",
|
|
|
|
|
"directory-item-user-field-value",
|
|
|
|
|
"directory-item-value",
|
|
|
|
|
"directory-table-header-title",
|
|
|
|
|
"loading-spinner",
|
2023-03-02 15:10:19 -05:00
|
|
|
"directory-item-label",
|
2023-08-17 07:47:08 -04:00
|
|
|
"hide-application-footer",
|
2022-07-04 08:00:11 -04:00
|
|
|
],
|
|
|
|
|
},
|
2022-07-06 04:37:54 -04:00
|
|
|
"no-implicit-this": {
|
2023-08-17 07:47:08 -04:00
|
|
|
allow: ["loading-spinner", "hide-application-footer"],
|
2022-07-06 04:37:54 -04:00
|
|
|
},
|
2023-06-22 16:54:46 -04:00
|
|
|
"require-mandatory-role-attributes": false,
|
|
|
|
|
"require-media-caption": false,
|
2022-12-28 07:25:42 -05:00
|
|
|
// Begin prettier compatibility
|
|
|
|
|
"eol-last": false,
|
|
|
|
|
"self-closing-void-elements": false,
|
|
|
|
|
"block-indentation": false,
|
|
|
|
|
quotes: false,
|
|
|
|
|
// End prettier compatibility
|
2020-09-04 14:01:14 -04:00
|
|
|
},
|
2020-02-05 11:33:15 -05:00
|
|
|
};
|
