2019-04-29 20:27:42 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2013-02-05 14:16:51 -05:00
|
|
|
require "promotion"
|
|
|
|
|
2022-07-27 22:27:38 -04:00
|
|
|
RSpec.describe Promotion do
|
2014-06-27 12:26:03 -04:00
|
|
|
describe "review" do
|
|
|
|
it "skips regular users" do
|
|
|
|
# Reviewing users at higher trust levels is expensive, so trigger those reviews in a background job.
|
2014-09-05 01:20:39 -04:00
|
|
|
regular = Fabricate.build(:user, trust_level: TrustLevel[2])
|
2014-06-27 12:26:03 -04:00
|
|
|
promotion = described_class.new(regular)
|
2014-09-05 01:20:39 -04:00
|
|
|
promotion.expects(:review_tl2).never
|
2014-06-27 12:26:03 -04:00
|
|
|
promotion.review
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
describe "newuser" do
|
2019-05-06 23:12:20 -04:00
|
|
|
fab!(:user) { Fabricate(:user, trust_level: TrustLevel[0], created_at: 2.days.ago) }
|
2013-02-05 14:16:51 -05:00
|
|
|
let(:promotion) { Promotion.new(user) }
|
|
|
|
|
|
|
|
it "doesn't raise an error with a nil user" do
|
2015-01-09 11:34:37 -05:00
|
|
|
expect { Promotion.new(nil).review }.not_to raise_error
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
context "when user has done nothing" do
|
2013-02-05 14:16:51 -05:00
|
|
|
let!(:result) { promotion.review }
|
|
|
|
|
|
|
|
it "returns false" do
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(result).to eq(false)
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "has not changed the user's trust level" do
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(user.trust_level).to eq(TrustLevel[0])
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
context "when user has done the requisite things" do
|
2013-02-05 14:16:51 -05:00
|
|
|
before do
|
2013-10-03 23:28:49 -04:00
|
|
|
stat = user.user_stat
|
2014-09-04 16:16:46 -04:00
|
|
|
stat.topics_entered = SiteSetting.tl1_requires_topics_entered
|
|
|
|
stat.posts_read_count = SiteSetting.tl1_requires_read_posts
|
|
|
|
stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
|
2013-02-05 14:16:51 -05:00
|
|
|
@result = promotion.review
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns true" do
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(@result).to eq(true)
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "has upgraded the user to basic" do
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(user.trust_level).to eq(TrustLevel[1])
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
context "when user has not done the requisite things" do
|
2015-04-14 12:05:09 -04:00
|
|
|
it "does not promote the user" do
|
|
|
|
user.created_at = 1.minute.ago
|
|
|
|
stat = user.user_stat
|
|
|
|
stat.topics_entered = SiteSetting.tl1_requires_topics_entered
|
|
|
|
stat.posts_read_count = SiteSetting.tl1_requires_read_posts
|
|
|
|
stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
|
|
|
|
@result = promotion.review
|
|
|
|
expect(@result).to eq(false)
|
|
|
|
expect(user.trust_level).to eq(TrustLevel[0])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
context "when may send tl1 promotion messages" do
|
2018-06-22 12:51:07 -04:00
|
|
|
before do
|
|
|
|
stat = user.user_stat
|
|
|
|
stat.topics_entered = SiteSetting.tl1_requires_topics_entered
|
|
|
|
stat.posts_read_count = SiteSetting.tl1_requires_read_posts
|
|
|
|
stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
|
|
|
|
end
|
|
|
|
it "sends promotion message by default" do
|
|
|
|
SiteSetting.send_tl1_welcome_message = true
|
|
|
|
@result = promotion.review
|
2018-07-02 19:23:45 -04:00
|
|
|
expect(Jobs::SendSystemMessage.jobs.length).to eq(1)
|
|
|
|
job = Jobs::SendSystemMessage.jobs[0]
|
|
|
|
expect(job["args"][0]["user_id"]).to eq(user.id)
|
|
|
|
expect(job["args"][0]["message_type"]).to eq("welcome_tl1_user")
|
2018-06-22 12:51:07 -04:00
|
|
|
end
|
|
|
|
|
2021-05-20 21:43:47 -04:00
|
|
|
it "does not not send when the user already has the tl1 badge when recalculating" do
|
2018-09-19 15:52:45 -04:00
|
|
|
SiteSetting.send_tl1_welcome_message = true
|
|
|
|
BadgeGranter.grant(Badge.find(1), user)
|
|
|
|
stat = user.user_stat
|
|
|
|
stat.topics_entered = SiteSetting.tl1_requires_topics_entered
|
|
|
|
stat.posts_read_count = SiteSetting.tl1_requires_read_posts
|
|
|
|
stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
|
|
|
|
Promotion.recalculate(user)
|
|
|
|
expect(Jobs::SendSystemMessage.jobs.length).to eq(0)
|
|
|
|
end
|
|
|
|
|
2021-08-10 18:39:25 -04:00
|
|
|
it "does not not send when the tl1 badge is disabled" do
|
|
|
|
SiteSetting.send_tl1_welcome_message = true
|
|
|
|
Badge.find(1).update!(enabled: false)
|
|
|
|
stat = user.user_stat
|
|
|
|
stat.topics_entered = SiteSetting.tl1_requires_topics_entered
|
|
|
|
stat.posts_read_count = SiteSetting.tl1_requires_read_posts
|
|
|
|
stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
|
|
|
|
Promotion.recalculate(user)
|
2023-02-28 23:35:21 -05:00
|
|
|
|
|
|
|
expect(user.trust_level).to eq(1)
|
|
|
|
|
2021-08-10 18:39:25 -04:00
|
|
|
expect(Jobs::SendSystemMessage.jobs.length).to eq(0)
|
|
|
|
end
|
|
|
|
|
2023-02-28 23:35:21 -05:00
|
|
|
it "respects default trust level" do
|
|
|
|
SiteSetting.default_trust_level = 2
|
|
|
|
Promotion.recalculate(user)
|
|
|
|
expect(user.trust_level).to eq(2)
|
|
|
|
end
|
|
|
|
|
2018-06-22 12:51:07 -04:00
|
|
|
it "can be turned off" do
|
|
|
|
SiteSetting.send_tl1_welcome_message = false
|
|
|
|
@result = promotion.review
|
2018-07-02 19:23:45 -04:00
|
|
|
expect(Jobs::SendSystemMessage.jobs.length).to eq(0)
|
2018-06-22 12:51:07 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
context "when may send tl2 promotion messages" do
|
2020-09-21 20:17:52 -04:00
|
|
|
fab!(:user) do
|
|
|
|
Fabricate(
|
|
|
|
:user,
|
|
|
|
trust_level: TrustLevel[1],
|
|
|
|
created_at: (SiteSetting.tl2_requires_time_spent_mins * 60).minutes.ago,
|
|
|
|
)
|
2023-01-09 06:18:21 -05:00
|
|
|
end
|
2020-09-21 20:17:52 -04:00
|
|
|
|
|
|
|
before do
|
|
|
|
stat = user.user_stat
|
|
|
|
stat.topics_entered = SiteSetting.tl2_requires_topics_entered
|
|
|
|
stat.posts_read_count = SiteSetting.tl2_requires_read_posts
|
|
|
|
stat.time_read = SiteSetting.tl2_requires_time_spent_mins * 60
|
|
|
|
stat.days_visited = SiteSetting.tl2_requires_days_visited
|
|
|
|
stat.likes_received = SiteSetting.tl2_requires_likes_received
|
|
|
|
stat.likes_given = SiteSetting.tl2_requires_likes_given
|
|
|
|
SiteSetting.tl2_requires_topic_reply_count = 0
|
|
|
|
SiteSetting.send_tl2_promotion_message = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it "sends promotion message by default" do
|
|
|
|
expect_enqueued_with(
|
|
|
|
job: :send_system_message,
|
|
|
|
args: {
|
|
|
|
user_id: user.id,
|
|
|
|
message_type: "tl2_promotion_message",
|
|
|
|
},
|
|
|
|
) { @result = promotion.review }
|
|
|
|
end
|
|
|
|
|
|
|
|
it "can be turned off" do
|
|
|
|
SiteSetting.send_tl2_promotion_message = false
|
|
|
|
expect_not_enqueued_with(job: :send_system_message) { @result = promotion.review }
|
|
|
|
end
|
|
|
|
end
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
describe "basic" do
|
2019-05-06 23:12:20 -04:00
|
|
|
fab!(:user) { Fabricate(:user, trust_level: TrustLevel[1], created_at: 2.days.ago) }
|
2013-04-05 00:29:46 -04:00
|
|
|
let(:promotion) { Promotion.new(user) }
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
context "when has done nothing" do
|
2013-04-05 00:29:46 -04:00
|
|
|
let!(:result) { promotion.review }
|
|
|
|
|
|
|
|
it "returns false" do
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(result).to eq(false)
|
2013-04-05 00:29:46 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "has not changed the user's trust level" do
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(user.trust_level).to eq(TrustLevel[1])
|
2013-04-05 00:29:46 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
context "when has done the requisite things" do
|
2013-04-05 00:29:46 -04:00
|
|
|
before do
|
2020-05-14 18:42:00 -04:00
|
|
|
SiteSetting.tl2_requires_topic_reply_count = 3
|
|
|
|
|
2013-10-03 23:28:49 -04:00
|
|
|
stat = user.user_stat
|
2014-09-04 16:16:46 -04:00
|
|
|
stat.topics_entered = SiteSetting.tl2_requires_topics_entered
|
|
|
|
stat.posts_read_count = SiteSetting.tl2_requires_read_posts
|
|
|
|
stat.time_read = SiteSetting.tl2_requires_time_spent_mins * 60
|
|
|
|
stat.days_visited = SiteSetting.tl2_requires_days_visited * 60
|
|
|
|
stat.likes_received = SiteSetting.tl2_requires_likes_received
|
|
|
|
stat.likes_given = SiteSetting.tl2_requires_likes_given
|
2020-05-14 18:42:00 -04:00
|
|
|
SiteSetting.tl2_requires_topic_reply_count.times do |_|
|
|
|
|
topic = Fabricate(:topic)
|
|
|
|
reply = Fabricate(:post, topic: topic, user: user, post_number: 2)
|
|
|
|
end
|
2013-04-05 00:29:46 -04:00
|
|
|
|
|
|
|
@result = promotion.review
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns true" do
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(@result).to eq(true)
|
2013-04-05 00:29:46 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "has upgraded the user to regular" do
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(user.trust_level).to eq(TrustLevel[2])
|
2013-04-05 00:29:46 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-04-14 12:05:09 -04:00
|
|
|
context "when the account hasn't existed long enough" do
|
|
|
|
it "does not promote the user" do
|
|
|
|
user.created_at = 1.minute.ago
|
2020-05-14 18:42:00 -04:00
|
|
|
SiteSetting.tl2_requires_topic_reply_count = 3
|
2015-04-14 12:05:09 -04:00
|
|
|
|
|
|
|
stat = user.user_stat
|
|
|
|
stat.topics_entered = SiteSetting.tl2_requires_topics_entered
|
|
|
|
stat.posts_read_count = SiteSetting.tl2_requires_read_posts
|
|
|
|
stat.time_read = SiteSetting.tl2_requires_time_spent_mins * 60
|
|
|
|
stat.days_visited = SiteSetting.tl2_requires_days_visited * 60
|
|
|
|
stat.likes_received = SiteSetting.tl2_requires_likes_received
|
|
|
|
stat.likes_given = SiteSetting.tl2_requires_likes_given
|
2020-05-14 18:42:00 -04:00
|
|
|
SiteSetting.tl2_requires_topic_reply_count.times do |_|
|
|
|
|
topic = Fabricate(:topic)
|
|
|
|
reply = Fabricate(:post, topic: topic, user: user, post_number: 2)
|
|
|
|
end
|
2015-04-14 12:05:09 -04:00
|
|
|
|
|
|
|
result = promotion.review
|
|
|
|
expect(result).to eq(false)
|
|
|
|
expect(user.trust_level).to eq(TrustLevel[1])
|
|
|
|
end
|
|
|
|
end
|
2013-04-05 00:29:46 -04:00
|
|
|
end
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
describe "regular" do
|
2019-05-06 23:12:20 -04:00
|
|
|
fab!(:user) { Fabricate(:user, trust_level: TrustLevel[2]) }
|
2014-06-27 12:26:03 -04:00
|
|
|
let(:promotion) { Promotion.new(user) }
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
context "when doesn't qualify for promotion" do
|
2014-06-27 12:26:03 -04:00
|
|
|
before do
|
2014-09-05 01:20:39 -04:00
|
|
|
TrustLevel3Requirements
|
|
|
|
.any_instance
|
|
|
|
.expects(:requirements_met?)
|
|
|
|
.at_least_once
|
|
|
|
.returns(false)
|
2014-06-27 12:26:03 -04:00
|
|
|
end
|
|
|
|
|
2014-09-05 01:20:39 -04:00
|
|
|
it "review_tl2 returns false" do
|
2015-01-09 11:34:37 -05:00
|
|
|
expect { expect(promotion.review_tl2).to eq(false) }.to_not change {
|
2014-06-27 12:26:03 -04:00
|
|
|
user.reload.trust_level
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
it "doesn't promote" do
|
|
|
|
expect { promotion.review_tl2 }.to_not change { user.reload.trust_level }
|
|
|
|
end
|
2014-07-08 17:39:36 -04:00
|
|
|
|
|
|
|
it "doesn't log a trust level change" do
|
|
|
|
expect { promotion.review_tl2 }.to_not change { UserHistory.count }
|
|
|
|
end
|
2014-06-27 12:26:03 -04:00
|
|
|
end
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
context "when qualifies for promotion" do
|
2014-06-27 12:26:03 -04:00
|
|
|
before do
|
2014-09-05 01:20:39 -04:00
|
|
|
TrustLevel3Requirements.any_instance.expects(:requirements_met?).at_least_once.returns(true)
|
2014-06-27 12:26:03 -04:00
|
|
|
end
|
|
|
|
|
2014-09-05 01:20:39 -04:00
|
|
|
it "review_tl2 returns true" do
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(promotion.review_tl2).to eq(true)
|
2014-06-27 12:26:03 -04:00
|
|
|
end
|
|
|
|
|
2014-09-05 01:20:39 -04:00
|
|
|
it "promotes to tl3" do
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(promotion.review_tl2).to eq(true)
|
|
|
|
expect(user.reload.trust_level).to eq(TrustLevel[3])
|
2014-06-27 12:26:03 -04:00
|
|
|
end
|
2014-07-08 17:39:36 -04:00
|
|
|
|
|
|
|
it "logs a trust level change" do
|
2014-09-05 01:20:39 -04:00
|
|
|
expect { promotion.review_tl2 }.to change {
|
2014-07-08 17:39:36 -04:00
|
|
|
UserHistory.where(action: UserHistory.actions[:auto_trust_level_change]).count
|
|
|
|
}.by(1)
|
|
|
|
end
|
2014-06-27 12:26:03 -04:00
|
|
|
end
|
|
|
|
end
|
2023-03-29 23:52:10 -04:00
|
|
|
|
|
|
|
describe "#change_trust_level!" do
|
|
|
|
fab!(:user) { Fabricate(:user, trust_level: TrustLevel[0]) }
|
|
|
|
let(:promotion) { Promotion.new(user) }
|
|
|
|
|
|
|
|
context "when the user has no emails" do
|
|
|
|
before { user.user_emails.delete_all }
|
|
|
|
|
|
|
|
it "does not error" do
|
|
|
|
expect { promotion.change_trust_level!(TrustLevel[1]) }.not_to raise_error
|
|
|
|
expect(user.reload.trust_level).to eq(TrustLevel[1])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|