2019-04-29 20:27:42 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2022-07-27 22:27:38 -04:00
|
|
|
RSpec.describe CommonPasswords do
|
2013-12-20 16:34:34 -05:00
|
|
|
it "the passwords file should exist" do
|
2022-01-05 12:45:08 -05:00
|
|
|
expect(File.exist?(described_class::PASSWORD_FILE)).to eq(true)
|
2013-12-20 16:34:34 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
describe "#common_password?" do
|
|
|
|
before { described_class.stubs(:redis).returns(stub_everything) }
|
|
|
|
|
|
|
|
subject { described_class.common_password? @password }
|
|
|
|
|
|
|
|
it "returns false if password isn't in the common passwords list" do
|
|
|
|
described_class.stubs(:password_list).returns(stub_everything(include?: false))
|
|
|
|
@password = 'uncommonPassword'
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(subject).to eq(false)
|
2013-12-20 16:34:34 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns false if password is nil" do
|
|
|
|
described_class.expects(:password_list).never
|
|
|
|
@password = nil
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(subject).to eq(false)
|
2013-12-20 16:34:34 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns false if password is blank" do
|
|
|
|
described_class.expects(:password_list).never
|
|
|
|
@password = ""
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(subject).to eq(false)
|
2013-12-20 16:34:34 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns true if password is in the common passwords list" do
|
|
|
|
described_class.stubs(:password_list).returns(stub_everything(include?: true))
|
|
|
|
@password = "password"
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(subject).to eq(true)
|
2013-12-20 16:34:34 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#password_list' do
|
2022-02-17 19:14:38 -05:00
|
|
|
before { Discourse.redis.flushdb }
|
|
|
|
after { Discourse.redis.flushdb }
|
|
|
|
|
2013-12-20 16:34:34 -05:00
|
|
|
it "loads the passwords file if redis doesn't have it" do
|
2022-02-17 19:14:38 -05:00
|
|
|
Discourse.redis.without_namespace.stubs(:scard).returns(0)
|
2013-12-30 14:25:50 -05:00
|
|
|
described_class.expects(:load_passwords).returns(['password'])
|
2013-12-20 16:34:34 -05:00
|
|
|
list = described_class.password_list
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(list).to respond_to(:include?)
|
2013-12-20 16:34:34 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "doesn't load the passwords file if redis has it" do
|
2022-02-17 19:14:38 -05:00
|
|
|
Discourse.redis.without_namespace.stubs(:scard).returns(10000)
|
2013-12-20 16:34:34 -05:00
|
|
|
described_class.expects(:load_passwords).never
|
|
|
|
list = described_class.password_list
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(list).to respond_to(:include?)
|
2013-12-20 16:34:34 -05:00
|
|
|
end
|
2013-12-30 14:25:50 -05:00
|
|
|
|
|
|
|
it "loads the passwords file if redis has an empty list" do
|
2022-02-17 19:14:38 -05:00
|
|
|
Discourse.redis.without_namespace.stubs(:scard).returns(0)
|
2013-12-30 14:25:50 -05:00
|
|
|
described_class.expects(:load_passwords).returns(['password'])
|
|
|
|
list = described_class.password_list
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(list).to respond_to(:include?)
|
2013-12-30 14:25:50 -05:00
|
|
|
end
|
2013-12-20 16:34:34 -05:00
|
|
|
end
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
describe "missing password file" do
|
2013-12-20 16:34:34 -05:00
|
|
|
it "tolerates it" do
|
|
|
|
File.stubs(:readlines).with(described_class::PASSWORD_FILE).raises(Errno::ENOENT)
|
2015-01-09 11:34:37 -05:00
|
|
|
expect(described_class.common_password?("password")).to eq(false)
|
2013-12-20 16:34:34 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|