Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
discourse/spec/requests/onebox_controller_spec.rb

Failed to ignore revisions in .git-blame-ignore-revs.

204 lines
6.0 KiB
Ruby
Raw Normal View History

DEV: use #frozen_string_literal: true on all spec This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction
2019-04-29 20:27:42 -04:00
# frozen_string_literal: true
REFACTOR: onebox controller specs to requests (#5914)
2018-06-04 23:36:08 -04:00
require 'rails_helper'
describe OneboxController do
FIX: Cache failed onebox URL request server-side (#8421) We already cache failed onebox URL requests client-side, we now want to cache this on the server-side for extra protection. failed onebox previews will be cached for 1 hour, and any more requests for that URL will fail with a 404 status. Forcing a rebake via the Rebake HTML action will delete the failed URL cache (like how the oneboxer preview cache is deleted).
2019-11-27 16:48:29 -05:00
before do
Discourse.cache.delete(Oneboxer.onebox_failed_cache_key(url))
end
REFACTOR: onebox controller specs to requests (#5914)
2018-06-04 23:36:08 -04:00
let(:url) { "http://google.com" }
it "requires the user to be logged in" do
get "/onebox.json", params: { url: url }
expect(response.status).to eq(403)
end
describe "logged in" do
let(:user) { Fabricate(:user) }
let(:html) do
html = <<~HTML
<html>
<head>
<meta property="og:title" content="Onebox1">
<meta property="og:description" content="this is bodycontent">
</head>
<body>
<p>body</p>
</body>
<html>
HTML
html
end
let(:html2) do
html = <<~HTML
<html>
<head>
<meta property="og:title" content="Onebox2">
<meta property="og:description" content="this is bodycontent">
</head>
<body>
<p>body</p>
</body>
<html>
HTML
html
end
def bypass_limiting
Oneboxer.onebox_previewed!(user.id)
end
before do
sign_in(user)
end
it 'invalidates the cache if refresh is passed' do
stub_request(:head, url)
stub_request(:get, url).to_return(status: 200, body: html).then.to_raise
bypass_limiting
DEV: use Discourse.cache over Rails.cache Discourse.cache is a more consistent method to use and offers clean fallback if you are skipping redis This is part of a larger change that both optimizes Discoruse.cache and omits use of setex on $redis in favor of consistently using discourse cache Bench does reveal that use of Rails.cache and Discourse.cache is 1.25x slower than redis.setex / get so a re-implementation will follow prior to porting
2019-11-26 20:35:14 -05:00
Discourse.cache.delete("onebox__#{url}")
REFACTOR: onebox controller specs to requests (#5914)
2018-06-04 23:36:08 -04:00
get "/onebox.json", params: { url: url }
DEV: Assert for 200 response code to avoid changing magic helper in the future.
2018-06-07 04:11:09 -04:00
expect(response.status).to eq(200)
REFACTOR: onebox controller specs to requests (#5914)
2018-06-04 23:36:08 -04:00
expect(response.body).to include("Onebox1")
bypass_limiting
stub_request(:get, url).to_return(status: 200, body: html2).then.to_raise
get "/onebox.json", params: { url: url, refresh: 'true' }
DEV: Assert for 200 response code to avoid changing magic helper in the future.
2018-06-07 04:11:09 -04:00
expect(response.status).to eq(200)
REFACTOR: onebox controller specs to requests (#5914)
2018-06-04 23:36:08 -04:00
expect(response.body).to include("Onebox2")
end
describe "cached onebox" do
it "returns the cached onebox response in the body" do
url = "http://noodle.com/"
stub_request(:head, url)
stub_request(:get, url).to_return(body: html).then.to_raise
get "/onebox.json", params: { url: url, refresh: "true" }
DEV: Assert for 200 response code to avoid changing magic helper in the future.
2018-06-07 04:11:09 -04:00
expect(response.status).to eq(200)
REFACTOR: onebox controller specs to requests (#5914)
2018-06-04 23:36:08 -04:00
expect(response.body).to include('Onebox1')
expect(response.body).to include('bodycontent')
get "/onebox.json", params: { url: url }
DEV: Assert for 200 response code to avoid changing magic helper in the future.
2018-06-07 04:11:09 -04:00
expect(response.status).to eq(200)
REFACTOR: onebox controller specs to requests (#5914)
2018-06-04 23:36:08 -04:00
expect(response.body).to include('Onebox1')
expect(response.body).to include('bodycontent')
end
end
describe "only 1 outgoing preview per user" do
it "returns 429" do
Oneboxer.preview_onebox!(user.id)
stub_request(:head, url)
stub_request(:get, url).to_return(body: html).then.to_raise
get "/onebox.json", params: { url: url, refresh: "true" }
expect(response.status).to eq(429)
end
end
describe "found onebox" do
it 'returns the onebox response in the body' do
stub_request(:head, url)
stub_request(:get, url).to_return(body: html).then.to_raise
get "/onebox.json", params: { url: url, refresh: "true" }
DEV: Assert for 200 response code to avoid changing magic helper in the future.
2018-06-07 04:11:09 -04:00
expect(response.status).to eq(200)
REFACTOR: onebox controller specs to requests (#5914)
2018-06-04 23:36:08 -04:00
expect(response.body).to include("Onebox1")
end
end
describe "missing onebox" do
FIX: Cache failed onebox URL request server-side (#8421) We already cache failed onebox URL requests client-side, we now want to cache this on the server-side for extra protection. failed onebox previews will be cached for 1 hour, and any more requests for that URL will fail with a 404 status. Forcing a rebake via the Rebake HTML action will delete the failed URL cache (like how the oneboxer preview cache is deleted).
2019-11-27 16:48:29 -05:00
def stub_request_to_onebox_url(response_body)
REFACTOR: onebox controller specs to requests (#5914)
2018-06-04 23:36:08 -04:00
stub_request(:head, url)
FIX: Cache failed onebox URL request server-side (#8421) We already cache failed onebox URL requests client-side, we now want to cache this on the server-side for extra protection. failed onebox previews will be cached for 1 hour, and any more requests for that URL will fail with a 404 status. Forcing a rebake via the Rebake HTML action will delete the failed URL cache (like how the oneboxer preview cache is deleted).
2019-11-27 16:48:29 -05:00
stub_request(:get, url).to_return(body: response_body).then.to_raise
end
it "returns 404 if the onebox is nil" do
stub_request_to_onebox_url(nil)
REFACTOR: onebox controller specs to requests (#5914)
2018-06-04 23:36:08 -04:00
get "/onebox.json", params: { url: url, refresh: "true" }
expect(response.response_code).to eq(404)
end
it "returns 404 if the onebox is an empty string" do
FIX: Cache failed onebox URL request server-side (#8421) We already cache failed onebox URL requests client-side, we now want to cache this on the server-side for extra protection. failed onebox previews will be cached for 1 hour, and any more requests for that URL will fail with a 404 status. Forcing a rebake via the Rebake HTML action will delete the failed URL cache (like how the oneboxer preview cache is deleted).
2019-11-27 16:48:29 -05:00
stub_request_to_onebox_url(" \t ")
get "/onebox.json", params: { url: url, refresh: "true" }
expect(response.response_code).to eq(404)
end
it "cases missing onebox URLs so we do not attempt to preview again" do
stub_request_to_onebox_url(nil)
get "/onebox.json", params: { url: url, refresh: "true" }
expect(response.response_code).to eq(404)
Oneboxer.expects(:preview_onebox!).never
REFACTOR: onebox controller specs to requests (#5914)
2018-06-04 23:36:08 -04:00
get "/onebox.json", params: { url: url, refresh: "true" }
expect(response.response_code).to eq(404)
FIX: Cache failed onebox URL request server-side (#8421) We already cache failed onebox URL requests client-side, we now want to cache this on the server-side for extra protection. failed onebox previews will be cached for 1 hour, and any more requests for that URL will fail with a 404 status. Forcing a rebake via the Rebake HTML action will delete the failed URL cache (like how the oneboxer preview cache is deleted).
2019-11-27 16:48:29 -05:00
expect(
Discourse.cache.read(Oneboxer.onebox_failed_cache_key(url))
).not_to eq(nil)
REFACTOR: onebox controller specs to requests (#5914)
2018-06-04 23:36:08 -04:00
end
end
describe "local onebox" do
it 'does not cache local oneboxes' do
post = create_post
url = Discourse.base_url + post.url
get "/onebox.json", params: { url: url, category_id: post.topic.category_id }
expect(response.body).to include('blockquote')
post.trash!
get "/onebox.json", params: { url: url, category_id: post.topic.category_id }
expect(response.body).not_to include('blockquote')
end
end
it 'does not onebox when you have no permission on category' do
post = create_post
url = Discourse.base_url + post.url
get "/onebox.json", params: { url: url, category_id: post.topic.category_id }
expect(response.body).to include('blockquote')
post.topic.category.set_permissions(staff: :full)
post.topic.category.save
get "/onebox.json", params: { url: url, category_id: post.topic.category_id }
expect(response.body).not_to include('blockquote')
end
it 'does not allow onebox of PMs' do
post = create_post(archetype: 'private_message', target_usernames: [user.username])
url = Discourse.base_url + post.url
get "/onebox.json", params: { url: url }
expect(response.body).not_to include('blockquote')
end
it 'does not allow whisper onebox' do
post = create_post
whisper = create_post(topic_id: post.topic_id, post_type: Post.types[:whisper])
url = Discourse.base_url + whisper.url
get "/onebox.json", params: { url: url }
expect(response.body).not_to include('blockquote')
end
it 'allows onebox to public topics/posts in PM' do
post = create_post
url = Discourse.base_url + post.url
get "/onebox.json", params: { url: url }
expect(response.body).to include('blockquote')
end
end
end