2019-04-29 20:27:42 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2022-07-27 22:27:38 -04:00
|
|
|
RSpec.describe SiteSetting do
|
2013-02-26 11:27:59 -05:00
|
|
|
describe "topic_title_length" do
|
|
|
|
it "returns a range of min/max topic title length" do
|
2015-01-05 11:04:23 -05:00
|
|
|
expect(SiteSetting.topic_title_length).to eq(
|
2013-04-10 08:54:10 -04:00
|
|
|
(
|
|
|
|
SiteSetting.defaults[:min_topic_title_length]..SiteSetting.defaults[
|
|
|
|
:max_topic_title_length
|
2023-01-09 06:18:21 -05:00
|
|
|
]
|
|
|
|
),
|
2015-01-05 11:04:23 -05:00
|
|
|
)
|
2013-02-26 11:27:59 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-02-28 13:54:12 -05:00
|
|
|
describe "post_length" do
|
|
|
|
it "returns a range of min/max post length" do
|
2015-01-05 11:04:23 -05:00
|
|
|
expect(SiteSetting.post_length).to eq(
|
|
|
|
SiteSetting.defaults[:min_post_length]..SiteSetting.defaults[:max_post_length],
|
|
|
|
)
|
2013-02-28 13:54:12 -05:00
|
|
|
end
|
|
|
|
end
|
2013-06-04 17:58:25 -04:00
|
|
|
|
2015-03-19 10:17:55 -04:00
|
|
|
describe "first_post_length" do
|
|
|
|
it "returns a range of min/max first post length" do
|
|
|
|
expect(SiteSetting.first_post_length).to eq(
|
|
|
|
SiteSetting.defaults[:min_first_post_length]..SiteSetting.defaults[:max_post_length],
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-06-04 17:58:25 -04:00
|
|
|
describe "private_message_title_length" do
|
|
|
|
it "returns a range of min/max pm topic title length" do
|
2018-01-31 00:56:00 -05:00
|
|
|
expect(SiteSetting.private_message_title_length).to eq(
|
|
|
|
SiteSetting.defaults[:min_personal_message_title_length]..SiteSetting.defaults[
|
|
|
|
:max_topic_title_length
|
2023-01-09 06:18:21 -05:00
|
|
|
],
|
2018-01-31 00:56:00 -05:00
|
|
|
)
|
2013-06-04 17:58:25 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-06-22 23:35:06 -04:00
|
|
|
describe "in test we do some judo to ensure SiteSetting is always reset between tests" do
|
|
|
|
it "is always the correct default" do
|
|
|
|
expect(SiteSetting.contact_email).to eq("")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "sets a setting" do
|
|
|
|
SiteSetting.contact_email = "sam@sam.com"
|
|
|
|
end
|
|
|
|
|
|
|
|
it "is always the correct default" do
|
|
|
|
expect(SiteSetting.contact_email).to eq("")
|
|
|
|
end
|
2013-06-21 16:31:40 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
describe "anonymous_homepage" do
|
|
|
|
it "returns latest" do
|
|
|
|
expect(SiteSetting.anonymous_homepage).to eq("latest")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "top_menu" do
|
2018-04-26 03:00:56 -04:00
|
|
|
describe "validations" do
|
|
|
|
it "always demands latest" do
|
|
|
|
expect do SiteSetting.top_menu = "categories" end.to raise_error(
|
|
|
|
Discourse::InvalidParameters,
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not allow random text" do
|
|
|
|
expect do SiteSetting.top_menu = "latest|random" end.to raise_error(
|
|
|
|
Discourse::InvalidParameters,
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
2013-06-22 23:35:06 -04:00
|
|
|
|
2013-06-21 16:31:40 -04:00
|
|
|
describe "items" do
|
|
|
|
let(:items) { SiteSetting.top_menu_items }
|
|
|
|
|
|
|
|
it "returns TopMenuItem objects" do
|
|
|
|
expect(items[0]).to be_kind_of(TopMenuItem)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "homepage" do
|
|
|
|
it "has homepage" do
|
2018-04-26 03:00:56 -04:00
|
|
|
SiteSetting.top_menu = "bookmarks|latest"
|
|
|
|
expect(SiteSetting.homepage).to eq("bookmarks")
|
2013-06-21 16:31:40 -04:00
|
|
|
end
|
|
|
|
end
|
2013-06-22 23:35:06 -04:00
|
|
|
end
|
|
|
|
|
2016-10-11 13:22:43 -04:00
|
|
|
describe "min_redirected_to_top_period" do
|
2022-07-27 12:14:14 -04:00
|
|
|
context "when has_enough_top_topics" do
|
2016-10-11 13:22:43 -04:00
|
|
|
before do
|
2016-10-12 19:28:54 -04:00
|
|
|
SiteSetting.topics_per_period_in_top_page = 2
|
|
|
|
SiteSetting.top_page_default_timeframe = "daily"
|
2016-11-23 21:29:44 -05:00
|
|
|
|
|
|
|
2.times { TopTopic.create!(daily_score: 2.5) }
|
|
|
|
|
2016-10-12 19:28:54 -04:00
|
|
|
TopTopic.refresh!
|
2016-10-11 13:22:43 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should_return_a_time_period" do
|
2016-10-12 19:28:54 -04:00
|
|
|
expect(SiteSetting.min_redirected_to_top_period(1.days.ago)).to eq(:daily)
|
2016-10-11 13:22:43 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
context "when does_not_have_enough_top_topics" do
|
2016-10-11 13:22:43 -04:00
|
|
|
before do
|
2016-10-12 19:28:54 -04:00
|
|
|
SiteSetting.topics_per_period_in_top_page = 20
|
|
|
|
SiteSetting.top_page_default_timeframe = "daily"
|
|
|
|
TopTopic.refresh!
|
2016-10-11 13:22:43 -04:00
|
|
|
end
|
|
|
|
|
2016-10-12 19:28:54 -04:00
|
|
|
it "should_return_a_time_period" do
|
2016-10-11 13:22:43 -04:00
|
|
|
expect(SiteSetting.min_redirected_to_top_period(1.days.ago)).to eq(nil)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-12-16 05:44:59 -05:00
|
|
|
describe "scheme" do
|
2016-06-27 05:26:43 -04:00
|
|
|
before { SiteSetting.force_https = true }
|
|
|
|
|
2013-12-16 05:44:59 -05:00
|
|
|
it "returns http when ssl is disabled" do
|
2016-06-27 05:26:43 -04:00
|
|
|
SiteSetting.force_https = false
|
2015-01-05 11:04:23 -05:00
|
|
|
expect(SiteSetting.scheme).to eq("http")
|
2013-12-16 05:44:59 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns https when using ssl" do
|
2015-01-05 11:04:23 -05:00
|
|
|
expect(SiteSetting.scheme).to eq("https")
|
2013-12-16 05:44:59 -05:00
|
|
|
end
|
2018-03-13 15:59:12 -04:00
|
|
|
end
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
describe ".shared_drafts_enabled?" do
|
2018-03-13 15:59:12 -04:00
|
|
|
it "returns false by default" do
|
|
|
|
expect(SiteSetting.shared_drafts_enabled?).to eq(false)
|
|
|
|
end
|
2013-12-16 05:44:59 -05:00
|
|
|
|
2018-03-13 15:59:12 -04:00
|
|
|
it "returns false when the category is uncategorized" do
|
|
|
|
SiteSetting.shared_drafts_category = SiteSetting.uncategorized_category_id
|
|
|
|
expect(SiteSetting.shared_drafts_enabled?).to eq(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns true when the category is valid" do
|
|
|
|
SiteSetting.shared_drafts_category = Fabricate(:category).id
|
|
|
|
expect(SiteSetting.shared_drafts_enabled?).to eq(true)
|
|
|
|
end
|
2013-12-16 05:44:59 -05:00
|
|
|
end
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
describe "deprecated site settings" do
|
2018-11-07 02:02:53 -05:00
|
|
|
before do
|
|
|
|
SiteSetting.force_https = true
|
2018-11-14 03:09:26 -05:00
|
|
|
@orig_logger = Rails.logger
|
|
|
|
Rails.logger = @fake_logger = FakeLogger.new
|
|
|
|
end
|
|
|
|
|
|
|
|
after { Rails.logger = @orig_logger }
|
2016-06-27 05:26:43 -04:00
|
|
|
|
2018-11-07 02:02:53 -05:00
|
|
|
it "should act as a proxy to the new methods" do
|
|
|
|
begin
|
2021-02-22 16:55:15 -05:00
|
|
|
original_settings = SiteSettings::DeprecatedSettings::SETTINGS.dup
|
2018-11-19 22:59:38 -05:00
|
|
|
SiteSettings::DeprecatedSettings::SETTINGS.clear
|
2018-11-14 05:07:04 -05:00
|
|
|
|
2018-11-19 22:59:38 -05:00
|
|
|
SiteSettings::DeprecatedSettings::SETTINGS.push(["use_https", "force_https", true, "0.0.1"])
|
2018-11-07 02:02:53 -05:00
|
|
|
|
|
|
|
SiteSetting.setup_deprecated_methods
|
2018-01-31 13:30:14 -05:00
|
|
|
|
2018-11-14 03:09:26 -05:00
|
|
|
expect do
|
|
|
|
expect(SiteSetting.use_https).to eq(true)
|
|
|
|
expect(SiteSetting.use_https?).to eq(true)
|
|
|
|
end.to change { @fake_logger.warnings.count }.by(2)
|
|
|
|
|
|
|
|
expect do SiteSetting.use_https(warn: false) end.to_not change { @fake_logger.warnings }
|
2016-06-27 05:26:43 -04:00
|
|
|
|
|
|
|
SiteSetting.use_https = false
|
|
|
|
|
|
|
|
expect(SiteSetting.force_https).to eq(false)
|
|
|
|
expect(SiteSetting.force_https?).to eq(false)
|
2018-11-07 02:02:53 -05:00
|
|
|
ensure
|
2018-11-19 22:59:38 -05:00
|
|
|
SiteSettings::DeprecatedSettings::SETTINGS.clear
|
2018-11-14 05:07:04 -05:00
|
|
|
|
2018-11-19 22:59:38 -05:00
|
|
|
SiteSettings::DeprecatedSettings::SETTINGS.concat(original_settings)
|
2018-01-31 13:30:14 -05:00
|
|
|
end
|
|
|
|
end
|
2016-06-27 05:26:43 -04:00
|
|
|
end
|
2019-07-12 14:42:43 -04:00
|
|
|
|
|
|
|
describe "cached settings" do
|
2021-05-20 21:43:47 -04:00
|
|
|
it "should recalculate cached setting when dependent settings are changed" do
|
2020-07-26 20:23:54 -04:00
|
|
|
SiteSetting.blocked_attachment_filenames = "foo"
|
|
|
|
expect(SiteSetting.blocked_attachment_filenames_regex).to eq(/foo/)
|
2019-07-12 14:42:43 -04:00
|
|
|
|
2020-07-26 20:23:54 -04:00
|
|
|
SiteSetting.blocked_attachment_filenames = "foo|bar"
|
|
|
|
expect(SiteSetting.blocked_attachment_filenames_regex).to eq(/foo|bar/)
|
2019-07-12 14:42:43 -04:00
|
|
|
end
|
|
|
|
end
|
2021-10-27 10:33:07 -04:00
|
|
|
|
|
|
|
it "sanitizes the client settings when they are overridden" do
|
|
|
|
xss = "<b onmouseover=alert('Wufff!')>click me!</b><script>alert('TEST');</script>"
|
|
|
|
|
|
|
|
SiteSetting.global_notice = xss
|
|
|
|
|
|
|
|
expect(SiteSetting.global_notice).to eq("<b>click me!</b>alert('TEST');")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "doesn't corrupt site settings with special characters" do
|
|
|
|
value = 'OX5y3Oljb+Qt9Bu809vsBQ==<>!%{}*&!@#$%..._-A'
|
|
|
|
settings = new_settings(SiteSettings::LocalProcessProvider.new)
|
|
|
|
settings.setting(:test_setting, "", client: true)
|
|
|
|
|
|
|
|
settings.test_setting = value
|
|
|
|
|
|
|
|
expect(settings.test_setting).to eq(value)
|
|
|
|
end
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|