2019-04-29 20:27:42 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
2015-10-11 05:41:23 -04:00
|
|
|
require 'rails_helper'
|
2013-02-05 14:16:51 -05:00
|
|
|
|
|
|
|
|
describe TopicLink do
|
|
|
|
|
|
2014-12-31 09:55:03 -05:00
|
|
|
it { is_expected.to validate_presence_of :url }
|
2013-02-05 14:16:51 -05:00
|
|
|
|
|
|
|
|
def test_uri
|
|
|
|
|
URI.parse(Discourse.base_url)
|
|
|
|
|
end
|
|
|
|
|
|
2019-05-06 23:12:20 -04:00
|
|
|
fab!(:topic) do
|
2014-07-11 00:17:01 -04:00
|
|
|
Fabricate(:topic, title: 'unique topic name')
|
|
|
|
|
end
|
|
|
|
|
|
2019-05-06 23:12:20 -04:00
|
|
|
fab!(:user) do
|
2014-07-11 00:17:01 -04:00
|
|
|
topic.user
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
|
|
|
|
|
2019-05-06 23:12:20 -04:00
|
|
|
fab!(:post) { Fabricate(:post) }
|
2016-06-13 01:13:39 -04:00
|
|
|
|
2013-02-05 14:16:51 -05:00
|
|
|
it "can't link to the same topic" do
|
2014-07-11 00:17:01 -04:00
|
|
|
ftl = TopicLink.new(url: "/t/#{topic.id}",
|
2017-07-27 21:20:09 -04:00
|
|
|
topic_id: topic.id,
|
|
|
|
|
link_topic_id: topic.id)
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(ftl.valid?).to eq(false)
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
describe 'external links' do
|
2020-05-13 02:05:39 -04:00
|
|
|
it 'correctly handles links' do
|
|
|
|
|
|
|
|
|
|
non_png = "https://b.com/#{SecureRandom.hex}"
|
|
|
|
|
|
|
|
|
|
# prepare a title for one of the links
|
|
|
|
|
stub_request(:get, non_png).
|
|
|
|
|
with(headers: {
|
|
|
|
|
'Accept' => '*/*',
|
|
|
|
|
'Accept-Encoding' => 'gzip',
|
|
|
|
|
'Host' => 'b.com',
|
|
|
|
|
}).
|
|
|
|
|
to_return(status: 200, body: "<html><head><title>amazing</title></head></html>", headers: {})
|
|
|
|
|
|
|
|
|
|
# so we run crawl_topic_links
|
|
|
|
|
Jobs.run_immediately!
|
|
|
|
|
|
|
|
|
|
png_title = "#{SecureRandom.hex}.png"
|
|
|
|
|
png = "https://awesome.com/#{png_title}"
|
|
|
|
|
|
|
|
|
|
post = Fabricate(:post, raw: <<~RAW, user: user, topic: topic)
|
2018-08-14 06:23:32 -04:00
|
|
|
http://a.com/
|
2020-05-13 02:05:39 -04:00
|
|
|
#{non_png}
|
2018-08-14 06:23:32 -04:00
|
|
|
http://#{'a' * 200}.com/invalid
|
|
|
|
|
//b.com/#{'a' * 500}
|
2020-05-13 02:05:39 -04:00
|
|
|
#{png}
|
2018-08-14 06:23:32 -04:00
|
|
|
RAW
|
2014-06-25 21:38:23 -04:00
|
|
|
|
2020-05-13 02:05:39 -04:00
|
|
|
TopicLink.extract_from(post)
|
|
|
|
|
|
|
|
|
|
# we have a special rule for images title where we pull them out of the filename
|
|
|
|
|
expect(topic.topic_links.where(url: png).pluck(:title).first).to eq(png_title)
|
|
|
|
|
expect(topic.topic_links.where(url: non_png).pluck(:title).first).to eq("amazing")
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2018-08-14 06:23:32 -04:00
|
|
|
expect(topic.topic_links.pluck(:url)).to contain_exactly(
|
2020-05-13 02:05:39 -04:00
|
|
|
png,
|
|
|
|
|
non_png,
|
2019-01-03 06:59:22 -05:00
|
|
|
"http://a.com/",
|
2018-08-14 06:23:32 -04:00
|
|
|
"//b.com/#{'a' * 500}"[0...TopicLink.max_url_length]
|
|
|
|
|
)
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2018-12-05 12:16:27 -05:00
|
|
|
old_ids = topic.topic_links.pluck(:id)
|
|
|
|
|
|
2020-05-13 02:05:39 -04:00
|
|
|
TopicLink.extract_from(post)
|
2018-12-05 12:16:27 -05:00
|
|
|
|
|
|
|
|
new_ids = topic.topic_links.pluck(:id)
|
|
|
|
|
|
|
|
|
|
expect(new_ids).to contain_exactly(*old_ids)
|
|
|
|
|
end
|
|
|
|
|
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
|
|
|
|
|
2013-02-11 11:11:48 -05:00
|
|
|
describe 'internal links' do
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2014-07-11 00:17:01 -04:00
|
|
|
it "extracts onebox" do
|
|
|
|
|
other_topic = Fabricate(:topic, user: user)
|
|
|
|
|
other_topic.posts.create(user: user, raw: "some content for the first post")
|
|
|
|
|
other_post = other_topic.posts.create(user: user, raw: "some content for the second post")
|
2013-02-13 15:22:04 -05:00
|
|
|
|
2014-07-11 00:17:01 -04:00
|
|
|
url = "http://#{test_uri.host}/t/#{other_topic.slug}/#{other_topic.id}/#{other_post.post_number}"
|
|
|
|
|
invalid_url = "http://#{test_uri.host}/t/#{other_topic.slug}/9999999999999999999999999999999"
|
2013-08-08 18:14:12 -04:00
|
|
|
|
2014-07-11 00:17:01 -04:00
|
|
|
topic.posts.create(user: user, raw: 'initial post')
|
|
|
|
|
post = topic.posts.create(user: user, raw: "Link to another topic:\n\n#{url}\n\n#{invalid_url}")
|
|
|
|
|
post.reload
|
2013-02-13 15:22:04 -05:00
|
|
|
|
2014-07-11 00:17:01 -04:00
|
|
|
TopicLink.extract_from(post)
|
2013-02-13 15:22:04 -05:00
|
|
|
|
2014-07-11 00:17:01 -04:00
|
|
|
link = topic.topic_links.first
|
|
|
|
|
# should have a link
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(link).to be_present
|
2014-07-11 00:17:01 -04:00
|
|
|
# should be the canonical URL
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(link.url).to eq(url)
|
2013-02-13 15:22:04 -05:00
|
|
|
end
|
|
|
|
|
|
2014-07-11 00:17:01 -04:00
|
|
|
context 'topic link' do
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2019-05-06 23:12:20 -04:00
|
|
|
fab!(:other_topic) do
|
2014-07-11 00:17:01 -04:00
|
|
|
Fabricate(:topic, user: user)
|
|
|
|
|
end
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2014-07-11 00:17:01 -04:00
|
|
|
let(:post) do
|
|
|
|
|
other_topic.posts.create(user: user, raw: "some content")
|
2013-02-11 11:11:48 -05:00
|
|
|
end
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2013-06-04 22:48:34 -04:00
|
|
|
it 'works' do
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2014-07-11 00:17:01 -04:00
|
|
|
# ensure other_topic has a post
|
|
|
|
|
post
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2014-07-11 00:17:01 -04:00
|
|
|
url = "http://#{test_uri.host}/t/#{other_topic.slug}/#{other_topic.id}"
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2014-07-11 00:17:01 -04:00
|
|
|
topic.posts.create(user: user, raw: 'initial post')
|
|
|
|
|
linked_post = topic.posts.create(user: user, raw: "Link to another topic: #{url}")
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2016-06-10 03:24:30 -04:00
|
|
|
# this is subtle, but we had a bug were second time
|
|
|
|
|
# TopicLink.extract_from was called a reflection was nuked
|
|
|
|
|
2.times do
|
|
|
|
|
TopicLink.extract_from(linked_post)
|
|
|
|
|
|
2020-05-13 02:05:39 -04:00
|
|
|
topic.reload
|
|
|
|
|
other_topic.reload
|
|
|
|
|
|
2016-06-10 03:24:30 -04:00
|
|
|
link = topic.topic_links.first
|
|
|
|
|
expect(link).to be_present
|
|
|
|
|
expect(link).to be_internal
|
|
|
|
|
expect(link.url).to eq(url)
|
|
|
|
|
expect(link.domain).to eq(test_uri.host)
|
2020-05-13 02:05:39 -04:00
|
|
|
expect(link.link_topic_id). to eq(other_topic.id)
|
2016-06-10 03:24:30 -04:00
|
|
|
expect(link).not_to be_reflection
|
|
|
|
|
|
|
|
|
|
reflection = other_topic.topic_links.first
|
|
|
|
|
|
|
|
|
|
expect(reflection).to be_present
|
|
|
|
|
expect(reflection).to be_reflection
|
|
|
|
|
expect(reflection.post_id).to be_present
|
|
|
|
|
expect(reflection.domain).to eq(test_uri.host)
|
|
|
|
|
expect(reflection.url).to eq("http://#{test_uri.host}/t/unique-topic-name/#{topic.id}/#{linked_post.post_number}")
|
|
|
|
|
expect(reflection.link_topic_id).to eq(topic.id)
|
|
|
|
|
expect(reflection.link_post_id).to eq(linked_post.id)
|
|
|
|
|
|
|
|
|
|
expect(reflection.user_id).to eq(link.user_id)
|
|
|
|
|
end
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2016-06-15 01:45:07 -04:00
|
|
|
PostOwnerChanger.new(
|
|
|
|
|
post_ids: [linked_post.id],
|
|
|
|
|
topic_id: topic.id,
|
|
|
|
|
acting_user: user,
|
|
|
|
|
new_owner: Fabricate(:user)
|
|
|
|
|
).change_owner!
|
|
|
|
|
|
|
|
|
|
TopicLink.extract_from(linked_post)
|
|
|
|
|
expect(topic.topic_links.first.url).to eq(url)
|
|
|
|
|
|
2017-07-27 21:20:09 -04:00
|
|
|
linked_post.revise(post.user, raw: "no more linkies https://eviltrout.com")
|
2017-08-31 00:06:56 -04:00
|
|
|
expect(other_topic.reload.topic_links.where(link_post_id: linked_post.id)).to be_blank
|
2013-02-25 11:42:20 -05:00
|
|
|
end
|
2019-12-04 01:13:20 -05:00
|
|
|
|
|
|
|
|
it 'works without id' do
|
|
|
|
|
post
|
|
|
|
|
url = "http://#{test_uri.host}/t/#{other_topic.slug}"
|
|
|
|
|
topic.posts.create(user: user, raw: 'initial post')
|
|
|
|
|
linked_post = topic.posts.create(user: user, raw: "Link to another topic: #{url}")
|
|
|
|
|
|
|
|
|
|
TopicLink.extract_from(linked_post)
|
|
|
|
|
link = topic.topic_links.first
|
|
|
|
|
|
|
|
|
|
reflection = other_topic.topic_links.first
|
|
|
|
|
|
|
|
|
|
expect(reflection).to be_present
|
|
|
|
|
expect(reflection).to be_reflection
|
|
|
|
|
expect(reflection.post_id).to be_present
|
|
|
|
|
expect(reflection.domain).to eq(test_uri.host)
|
|
|
|
|
expect(reflection.url).to eq("http://#{test_uri.host}/t/unique-topic-name/#{topic.id}/#{linked_post.post_number}")
|
|
|
|
|
expect(reflection.link_topic_id).to eq(topic.id)
|
|
|
|
|
expect(reflection.link_post_id).to eq(linked_post.id)
|
|
|
|
|
expect(reflection.user_id).to eq(link.user_id)
|
|
|
|
|
end
|
2013-02-11 11:11:48 -05:00
|
|
|
end
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2013-02-11 12:27:32 -05:00
|
|
|
context "link to a user on discourse" do
|
2017-03-28 14:27:54 -04:00
|
|
|
let(:post) { topic.posts.create(user: user, raw: "<a href='/u/#{user.username_lower}'>user</a>") }
|
2013-02-05 14:16:51 -05:00
|
|
|
before do
|
2013-02-11 11:11:48 -05:00
|
|
|
TopicLink.extract_from(post)
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
|
|
|
|
|
2013-02-25 11:42:20 -05:00
|
|
|
it 'does not extract a link' do
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(topic.topic_links).to be_blank
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
2013-02-11 11:11:48 -05:00
|
|
|
end
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2013-02-11 12:27:32 -05:00
|
|
|
context "link to a discourse resource like a FAQ" do
|
2014-07-11 00:17:01 -04:00
|
|
|
let(:post) { topic.posts.create(user: user, raw: "<a href='/faq'>faq link here</a>") }
|
2013-02-11 12:27:32 -05:00
|
|
|
before do
|
|
|
|
|
TopicLink.extract_from(post)
|
|
|
|
|
end
|
|
|
|
|
|
2013-02-25 11:42:20 -05:00
|
|
|
it 'does not extract a link' do
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(topic.topic_links).to be_present
|
2013-02-11 12:27:32 -05:00
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2014-07-11 00:17:01 -04:00
|
|
|
context "mention links" do
|
|
|
|
|
let(:post) { topic.posts.create(user: user, raw: "Hey #{user.username_lower}") }
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2013-02-11 11:11:48 -05:00
|
|
|
before do
|
|
|
|
|
TopicLink.extract_from(post)
|
|
|
|
|
end
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2013-02-25 11:42:20 -05:00
|
|
|
it 'does not extract a link' do
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(topic.topic_links).to be_blank
|
2014-07-11 00:17:01 -04:00
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2018-04-19 06:29:35 -04:00
|
|
|
context "email address" do
|
|
|
|
|
it "does not extract a link" do
|
|
|
|
|
post = topic.posts.create(user: user, raw: "Valid email: foo@bar.com\n\nInvalid email: rfc822;name@domain.com")
|
|
|
|
|
TopicLink.extract_from(post)
|
|
|
|
|
expect(topic.topic_links).to be_blank
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2016-04-04 18:43:11 -04:00
|
|
|
context "mail link" do
|
|
|
|
|
let(:post) { topic.posts.create(user: user, raw: "[email]bar@example.com[/email]") }
|
|
|
|
|
|
|
|
|
|
it 'does not extract a link' do
|
|
|
|
|
TopicLink.extract_from(post)
|
|
|
|
|
expect(topic.topic_links).to be_blank
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2014-07-11 00:17:01 -04:00
|
|
|
context "quote links" do
|
|
|
|
|
it "sets quote correctly" do
|
|
|
|
|
linked_post = topic.posts.create(user: user, raw: "my test post")
|
|
|
|
|
quoting_post = Fabricate(:post, raw: "[quote=\"#{user.username}, post: #{linked_post.post_number}, topic: #{topic.id}\"]\nquote\n[/quote]")
|
|
|
|
|
|
|
|
|
|
TopicLink.extract_from(quoting_post)
|
|
|
|
|
link = quoting_post.topic.topic_links.first
|
|
|
|
|
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(link.link_post_id).to eq(linked_post.id)
|
|
|
|
|
expect(link.quote).to eq(true)
|
2013-02-11 11:11:48 -05:00
|
|
|
end
|
2013-02-25 11:42:20 -05:00
|
|
|
end
|
|
|
|
|
|
2013-07-18 19:26:23 -04:00
|
|
|
context "link to a local attachments" do
|
2017-06-19 11:09:54 -04:00
|
|
|
let(:post) { topic.posts.create(user: user, raw: '<a class="attachment" href="/uploads/default/208/87bb3d8428eb4783.rb?foo=bar">ruby.rb</a>') }
|
2013-07-18 19:26:23 -04:00
|
|
|
|
|
|
|
|
it "extracts the link" do
|
|
|
|
|
TopicLink.extract_from(post)
|
2014-07-11 00:17:01 -04:00
|
|
|
link = topic.topic_links.first
|
2013-07-18 19:26:23 -04:00
|
|
|
# extracted the link
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(link).to be_present
|
2013-07-18 19:26:23 -04:00
|
|
|
# is set to internal
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(link).to be_internal
|
2013-07-18 19:26:23 -04:00
|
|
|
# has the correct url
|
2017-06-19 11:09:54 -04:00
|
|
|
expect(link.url).to eq("/uploads/default/208/87bb3d8428eb4783.rb?foo=bar")
|
2013-07-18 19:26:23 -04:00
|
|
|
# should not be the reflection
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(link).not_to be_reflection
|
2017-06-19 11:09:54 -04:00
|
|
|
# should have file extension
|
|
|
|
|
expect(link.extension).to eq('rb')
|
2013-07-18 19:26:23 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context "link to an attachments uploaded on S3" do
|
2014-07-11 00:17:01 -04:00
|
|
|
let(:post) { topic.posts.create(user: user, raw: '<a class="attachment" href="//s3.amazonaws.com/bucket/2104a0211c9ce41ed67989a1ed62e9a394c1fbd1446.rb">ruby.rb</a>') }
|
2013-07-18 19:26:23 -04:00
|
|
|
|
|
|
|
|
it "extracts the link" do
|
|
|
|
|
TopicLink.extract_from(post)
|
2014-07-11 00:17:01 -04:00
|
|
|
link = topic.topic_links.first
|
2013-07-18 19:26:23 -04:00
|
|
|
# extracted the link
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(link).to be_present
|
2013-07-18 19:26:23 -04:00
|
|
|
# is not internal
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(link).not_to be_internal
|
2013-07-18 19:26:23 -04:00
|
|
|
# has the correct url
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(link.url).to eq("//s3.amazonaws.com/bucket/2104a0211c9ce41ed67989a1ed62e9a394c1fbd1446.rb")
|
2013-07-18 19:26:23 -04:00
|
|
|
# should not be the reflection
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(link).not_to be_reflection
|
2017-06-19 11:09:54 -04:00
|
|
|
# should have file extension
|
|
|
|
|
expect(link.extension).to eq('rb')
|
2013-07-18 19:26:23 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
end
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
|
|
|
|
|
2013-02-25 11:42:20 -05:00
|
|
|
describe 'internal link from pm' do
|
2014-07-11 00:17:01 -04:00
|
|
|
it 'works' do
|
2014-09-11 03:39:20 -04:00
|
|
|
pm = Fabricate(:topic, user: user, category_id: nil, archetype: 'private_message')
|
2014-07-11 00:17:01 -04:00
|
|
|
pm.posts.create(user: user, raw: "some content")
|
2013-02-25 11:42:20 -05:00
|
|
|
|
2014-07-11 00:17:01 -04:00
|
|
|
url = "http://#{test_uri.host}/t/topic-slug/#{topic.id}"
|
2013-02-25 11:42:20 -05:00
|
|
|
|
2014-07-11 00:17:01 -04:00
|
|
|
pm.posts.create(user: user, raw: 'initial post')
|
|
|
|
|
linked_post = pm.posts.create(user: user, raw: "Link to another topic: #{url}")
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2014-07-11 00:17:01 -04:00
|
|
|
TopicLink.extract_from(linked_post)
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(topic.topic_links.first).to eq(nil)
|
|
|
|
|
expect(pm.topic_links.first).not_to eq(nil)
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
end
|
|
|
|
|
|
2017-08-22 04:58:01 -04:00
|
|
|
describe 'internal link from unlisted topic' do
|
|
|
|
|
it 'works' do
|
|
|
|
|
unlisted_topic = Fabricate(:topic, user: user, visible: false)
|
|
|
|
|
url = "http://#{test_uri.host}/t/topic-slug/#{topic.id}"
|
|
|
|
|
|
|
|
|
|
unlisted_topic.posts.create(user: user, raw: 'initial post')
|
|
|
|
|
linked_post = unlisted_topic.posts.create(user: user, raw: "Link to another topic: #{url}")
|
|
|
|
|
|
|
|
|
|
TopicLink.extract_from(linked_post)
|
|
|
|
|
|
|
|
|
|
expect(topic.topic_links.first).to eq(nil)
|
|
|
|
|
expect(unlisted_topic.topic_links.first).not_to eq(nil)
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2013-02-05 14:16:51 -05:00
|
|
|
describe 'internal link with non-standard port' do
|
|
|
|
|
it 'includes the non standard port if present' do
|
2014-07-11 00:17:01 -04:00
|
|
|
other_topic = Fabricate(:topic, user: user)
|
|
|
|
|
SiteSetting.port = 5678
|
2013-02-05 14:16:51 -05:00
|
|
|
alternate_uri = URI.parse(Discourse.base_url)
|
2014-07-11 00:17:01 -04:00
|
|
|
|
|
|
|
|
url = "http://#{alternate_uri.host}:5678/t/topic-slug/#{other_topic.id}"
|
2016-06-08 16:08:41 -04:00
|
|
|
post = topic.posts.create(user: user, raw: "Link to another topic: #{url}")
|
2014-07-11 00:17:01 -04:00
|
|
|
TopicLink.extract_from(post)
|
|
|
|
|
reflection = other_topic.topic_links.first
|
|
|
|
|
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(reflection.url).to eq("http://#{alternate_uri.host}:5678/t/unique-topic-name/#{topic.id}")
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2016-06-06 16:58:35 -04:00
|
|
|
describe 'query methods' do
|
2013-06-05 02:10:26 -04:00
|
|
|
it 'returns blank without posts' do
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(TopicLink.counts_for(Guardian.new, nil, nil)).to be_blank
|
2013-06-05 02:10:26 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'with data' do
|
|
|
|
|
|
|
|
|
|
let(:post) do
|
|
|
|
|
topic = Fabricate(:topic)
|
|
|
|
|
Fabricate(:post_with_external_links, user: topic.user, topic: topic)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
let(:counts_for) do
|
|
|
|
|
TopicLink.counts_for(Guardian.new, post.topic, [post])
|
|
|
|
|
end
|
|
|
|
|
|
2016-06-06 16:58:35 -04:00
|
|
|
it 'creates a valid topic lookup' do
|
|
|
|
|
TopicLink.extract_from(post)
|
|
|
|
|
|
|
|
|
|
lookup = TopicLink.duplicate_lookup(post.topic)
|
|
|
|
|
expect(lookup).to be_present
|
|
|
|
|
expect(lookup['google.com']).to be_present
|
|
|
|
|
|
|
|
|
|
ch = lookup['www.codinghorror.com/blog']
|
|
|
|
|
expect(ch).to be_present
|
|
|
|
|
expect(ch[:domain]).to eq('www.codinghorror.com')
|
|
|
|
|
expect(ch[:username]).to eq(post.username)
|
|
|
|
|
expect(ch[:posted_at]).to be_present
|
2016-06-09 14:31:32 -04:00
|
|
|
expect(ch[:post_number]).to be_present
|
2016-06-06 16:58:35 -04:00
|
|
|
end
|
2013-06-05 02:10:26 -04:00
|
|
|
|
|
|
|
|
it 'has the correct results' do
|
|
|
|
|
TopicLink.extract_from(post)
|
2018-07-18 00:14:50 -04:00
|
|
|
topic_link_first = post.topic.topic_links.first
|
|
|
|
|
TopicLinkClick.create!(topic_link: topic_link_first, ip_address: '192.168.1.1')
|
|
|
|
|
TopicLinkClick.create!(topic_link: topic_link_first, ip_address: '192.168.1.2')
|
|
|
|
|
topic_link_second = post.topic.topic_links.second
|
|
|
|
|
TopicLinkClick.create!(topic_link: topic_link_second, ip_address: '192.168.1.1')
|
2013-06-05 02:10:26 -04:00
|
|
|
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(counts_for[post.id]).to be_present
|
2018-07-18 00:14:50 -04:00
|
|
|
expect(counts_for[post.id].first[:clicks]).to eq(2)
|
|
|
|
|
expect(counts_for[post.id].second[:clicks]).to eq(1)
|
2013-06-05 02:10:26 -04:00
|
|
|
|
2013-11-15 12:15:46 -05:00
|
|
|
array = TopicLink.topic_map(Guardian.new, post.topic_id)
|
2018-07-18 00:14:50 -04:00
|
|
|
expect(array.length).to eq(2)
|
|
|
|
|
expect(array[0].clicks).to eq(2)
|
|
|
|
|
expect(array[1].clicks).to eq(1)
|
2013-06-05 02:10:26 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'secures internal links correctly' do
|
|
|
|
|
category = Fabricate(:category)
|
|
|
|
|
secret_topic = Fabricate(:topic, category: category)
|
|
|
|
|
|
|
|
|
|
url = "http://#{test_uri.host}/t/topic-slug/#{secret_topic.id}"
|
|
|
|
|
post = Fabricate(:post, raw: "hello test topic #{url}")
|
|
|
|
|
TopicLink.extract_from(post)
|
2018-07-18 00:14:50 -04:00
|
|
|
TopicLinkClick.create!(topic_link: post.topic.topic_links.first, ip_address: '192.168.1.1')
|
2013-06-05 02:10:26 -04:00
|
|
|
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(TopicLink.topic_map(Guardian.new, post.topic_id).count).to eq(1)
|
|
|
|
|
expect(TopicLink.counts_for(Guardian.new, post.topic, [post]).length).to eq(1)
|
2013-06-05 02:10:26 -04:00
|
|
|
|
2017-07-27 21:20:09 -04:00
|
|
|
category.set_permissions(staff: :full)
|
2013-06-05 02:10:26 -04:00
|
|
|
category.save
|
|
|
|
|
|
|
|
|
|
admin = Fabricate(:admin)
|
|
|
|
|
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(TopicLink.topic_map(Guardian.new, post.topic_id).count).to eq(0)
|
|
|
|
|
expect(TopicLink.topic_map(Guardian.new(admin), post.topic_id).count).to eq(1)
|
2013-06-05 02:10:26 -04:00
|
|
|
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(TopicLink.counts_for(Guardian.new, post.topic, [post]).length).to eq(0)
|
|
|
|
|
expect(TopicLink.counts_for(Guardian.new(admin), post.topic, [post]).length).to eq(1)
|
2013-06-05 02:10:26 -04:00
|
|
|
end
|
|
|
|
|
|
2017-08-31 14:14:54 -04:00
|
|
|
it 'does not include links from whisper' do
|
|
|
|
|
url = "https://blog.codinghorror.com/hacker-hack-thyself/"
|
|
|
|
|
post = Fabricate(:post, raw: "whisper post... #{url}", post_type: Post.types[:whisper])
|
|
|
|
|
TopicLink.extract_from(post)
|
|
|
|
|
|
|
|
|
|
expect(TopicLink.topic_map(Guardian.new, post.topic_id).count).to eq(0)
|
|
|
|
|
end
|
2013-06-05 02:10:26 -04:00
|
|
|
end
|
2016-06-13 01:13:39 -04:00
|
|
|
|
|
|
|
|
describe ".duplicate_lookup" do
|
2019-05-06 23:12:20 -04:00
|
|
|
fab!(:user) { Fabricate(:user, username: "junkrat") }
|
2016-06-13 01:13:39 -04:00
|
|
|
|
|
|
|
|
let(:post_with_internal_link) do
|
|
|
|
|
Fabricate(:post, user: user, raw: "Check out this topic #{post.topic.url}/122131")
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "should return the right response" do
|
|
|
|
|
TopicLink.extract_from(post_with_internal_link)
|
|
|
|
|
|
|
|
|
|
result = TopicLink.duplicate_lookup(post_with_internal_link.topic)
|
|
|
|
|
expect(result.count).to eq(1)
|
|
|
|
|
|
|
|
|
|
lookup = result["test.localhost/t/#{post.topic.slug}/#{post.topic.id}/122131"]
|
|
|
|
|
|
|
|
|
|
expect(lookup[:domain]).to eq("test.localhost")
|
|
|
|
|
expect(lookup[:username]).to eq("junkrat")
|
|
|
|
|
expect(lookup[:posted_at].to_s).to eq(post_with_internal_link.created_at.to_s)
|
|
|
|
|
expect(lookup[:post_number]).to eq(1)
|
|
|
|
|
|
|
|
|
|
result = TopicLink.duplicate_lookup(post.topic)
|
2016-06-13 01:16:24 -04:00
|
|
|
expect(result).to eq({})
|
2016-06-13 01:13:39 -04:00
|
|
|
end
|
|
|
|
|
end
|
2017-10-19 09:26:37 -04:00
|
|
|
|
|
|
|
|
it "works with invalid link target" do
|
|
|
|
|
post = Fabricate(:post, raw: '<a href="http:geturl">http:geturl</a>', user: user, topic: topic, cook_method: Post.cook_methods[:raw_html])
|
|
|
|
|
expect { TopicLink.extract_from(post) }.to_not raise_error
|
|
|
|
|
end
|
2013-06-05 02:10:26 -04:00
|
|
|
end
|
|
|
|
|
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
