2019-04-29 20:27:42 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2015-10-11 05:41:23 -04:00
|
|
|
require 'rails_helper'
|
2014-03-05 07:52:20 -05:00
|
|
|
|
|
|
|
describe Admin::BadgesController do
|
|
|
|
context "while logged in as an admin" do
|
2019-05-06 23:12:20 -04:00
|
|
|
fab!(:admin) { Fabricate(:admin) }
|
|
|
|
fab!(:badge) { Fabricate(:badge) }
|
2014-03-05 07:52:20 -05:00
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
before do
|
|
|
|
sign_in(admin)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#index' do
|
2014-07-29 18:35:15 -04:00
|
|
|
it 'returns badge index' do
|
2018-06-11 00:50:56 -04:00
|
|
|
get "/admin/badges.json"
|
2018-06-07 04:11:09 -04:00
|
|
|
expect(response.status).to eq(200)
|
2014-07-29 18:35:15 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
describe '#preview' do
|
2016-07-27 19:03:00 -04:00
|
|
|
it 'allows preview enable_badge_sql is enabled' do
|
|
|
|
SiteSetting.enable_badge_sql = true
|
2017-08-31 00:06:56 -04:00
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
post "/admin/badges/preview.json", params: {
|
2017-08-31 00:06:56 -04:00
|
|
|
sql: 'select id as user_id, created_at granted_at from users'
|
2018-06-11 00:50:56 -04:00
|
|
|
}
|
2017-08-31 00:06:56 -04:00
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
expect(response.status).to eq(200)
|
2020-05-07 11:04:12 -04:00
|
|
|
expect(response.parsed_body["grant_count"]).to be > 0
|
2016-07-27 19:03:00 -04:00
|
|
|
end
|
2018-06-11 00:50:56 -04:00
|
|
|
|
2016-07-27 19:03:00 -04:00
|
|
|
it 'does not allow anything if enable_badge_sql is disabled' do
|
|
|
|
SiteSetting.enable_badge_sql = false
|
2017-08-31 00:06:56 -04:00
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
post "/admin/badges/preview.json", params: {
|
2017-08-31 00:06:56 -04:00
|
|
|
sql: 'select id as user_id, created_at granted_at from users'
|
2018-06-11 00:50:56 -04:00
|
|
|
}
|
2017-08-31 00:06:56 -04:00
|
|
|
|
|
|
|
expect(response.status).to eq(403)
|
2016-07-27 19:03:00 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
describe '#create' do
|
2017-05-09 09:25:57 -04:00
|
|
|
it 'can create badges correctly' do
|
|
|
|
SiteSetting.enable_badge_sql = true
|
2017-08-31 00:06:56 -04:00
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
post "/admin/badges.json", params: {
|
2017-08-31 00:06:56 -04:00
|
|
|
name: 'test', query: 'select 1 as user_id, null as granted_at', badge_type_id: 1
|
2018-06-11 00:50:56 -04:00
|
|
|
}
|
2017-08-31 00:06:56 -04:00
|
|
|
|
2020-05-07 11:04:12 -04:00
|
|
|
json = response.parsed_body
|
2017-08-31 00:06:56 -04:00
|
|
|
expect(response.status).to eq(200)
|
2017-05-09 09:25:57 -04:00
|
|
|
expect(json["badge"]["name"]).to eq('test')
|
|
|
|
expect(json["badge"]["query"]).to eq('select 1 as user_id, null as granted_at')
|
2018-05-17 12:09:27 -04:00
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
expect(UserHistory.where(acting_user_id: admin.id, action: UserHistory.actions[:create_badge]).exists?).to eq(true)
|
2017-05-09 09:25:57 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
describe '#save_badge_groupings' do
|
2014-07-27 04:22:01 -04:00
|
|
|
it 'can save badge groupings' do
|
|
|
|
groupings = BadgeGrouping.all.order(:position).to_a
|
|
|
|
groupings << BadgeGrouping.new(name: 'Test 1')
|
|
|
|
groupings << BadgeGrouping.new(name: 'Test 2')
|
|
|
|
|
|
|
|
groupings.shuffle!
|
|
|
|
|
|
|
|
names = groupings.map { |g| g.name }
|
|
|
|
ids = groupings.map { |g| g.id.to_s }
|
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
post "/admin/badges/badge_groupings.json", params: { ids: ids, names: names }
|
|
|
|
expect(response.status).to eq(200)
|
2014-07-27 04:22:01 -04:00
|
|
|
|
|
|
|
groupings2 = BadgeGrouping.all.order(:position).to_a
|
|
|
|
|
2015-01-09 12:04:02 -05:00
|
|
|
expect(groupings2.map { |g| g.name }).to eq(names)
|
|
|
|
expect((groupings.map(&:id) - groupings2.map { |g| g.id }).compact).to be_blank
|
2020-05-07 11:04:12 -04:00
|
|
|
expect(response.parsed_body["badge_groupings"].length).to eq(groupings2.length)
|
2014-07-27 04:22:01 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
describe '#badge_types' do
|
2014-03-05 07:52:20 -05:00
|
|
|
it 'returns JSON' do
|
2018-06-11 00:50:56 -04:00
|
|
|
get "/admin/badges/types.json"
|
2017-08-31 00:06:56 -04:00
|
|
|
|
2018-06-07 04:11:09 -04:00
|
|
|
expect(response.status).to eq(200)
|
2020-05-07 11:04:12 -04:00
|
|
|
expect(response.parsed_body["badge_types"]).to be_present
|
2014-03-05 07:52:20 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
describe '#destroy' do
|
2014-03-05 07:52:20 -05:00
|
|
|
it 'deletes the badge' do
|
2018-06-11 00:50:56 -04:00
|
|
|
delete "/admin/badges/#{badge.id}.json"
|
2018-06-07 04:11:09 -04:00
|
|
|
expect(response.status).to eq(200)
|
2018-05-17 12:09:27 -04:00
|
|
|
expect(Badge.where(id: badge.id).exists?).to eq(false)
|
2018-06-11 00:50:56 -04:00
|
|
|
expect(UserHistory.where(acting_user_id: admin.id, action: UserHistory.actions[:delete_badge]).exists?).to eq(true)
|
2014-03-05 07:52:20 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
describe '#update' do
|
2017-02-20 08:35:05 -05:00
|
|
|
it 'does not update the name of system badges' do
|
|
|
|
editor_badge = Badge.find(Badge::Editor)
|
|
|
|
editor_badge_name = editor_badge.name
|
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
put "/admin/badges/#{editor_badge.id}.json", params: {
|
2017-08-31 00:06:56 -04:00
|
|
|
name: "123456"
|
2018-06-11 00:50:56 -04:00
|
|
|
}
|
2017-02-20 08:35:05 -05:00
|
|
|
|
2018-06-07 04:11:09 -04:00
|
|
|
expect(response.status).to eq(200)
|
2017-02-20 08:35:05 -05:00
|
|
|
editor_badge.reload
|
|
|
|
expect(editor_badge.name).to eq(editor_badge_name)
|
2018-05-17 12:09:27 -04:00
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
expect(UserHistory.where(acting_user_id: admin.id, action: UserHistory.actions[:change_badge]).exists?).to eq(true)
|
2017-02-20 08:35:05 -05:00
|
|
|
end
|
|
|
|
|
2016-07-27 19:03:00 -04:00
|
|
|
it 'does not allow query updates if badge_sql is disabled' do
|
|
|
|
badge.query = "select 123"
|
|
|
|
badge.save
|
|
|
|
|
|
|
|
SiteSetting.enable_badge_sql = false
|
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
put "/admin/badges/#{badge.id}.json", params: {
|
2017-08-31 00:06:56 -04:00
|
|
|
name: "123456",
|
|
|
|
query: "select id user_id, created_at granted_at from users",
|
|
|
|
badge_type_id: badge.badge_type_id,
|
|
|
|
allow_title: false,
|
|
|
|
multiple_grant: false,
|
|
|
|
enabled: true
|
2018-06-11 00:50:56 -04:00
|
|
|
}
|
2016-07-27 19:03:00 -04:00
|
|
|
|
2018-06-07 04:11:09 -04:00
|
|
|
expect(response.status).to eq(200)
|
2016-07-27 19:03:00 -04:00
|
|
|
badge.reload
|
|
|
|
expect(badge.name).to eq('123456')
|
|
|
|
expect(badge.query).to eq('select 123')
|
2014-03-05 07:52:20 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'updates the badge' do
|
2016-07-27 19:03:00 -04:00
|
|
|
SiteSetting.enable_badge_sql = true
|
|
|
|
sql = "select id user_id, created_at granted_at from users"
|
|
|
|
|
2018-06-11 00:50:56 -04:00
|
|
|
put "/admin/badges/#{badge.id}.json", params: {
|
2017-08-31 00:06:56 -04:00
|
|
|
name: "123456",
|
|
|
|
query: sql,
|
|
|
|
badge_type_id: badge.badge_type_id,
|
|
|
|
allow_title: false,
|
|
|
|
multiple_grant: false,
|
|
|
|
enabled: true
|
2018-06-11 00:50:56 -04:00
|
|
|
}
|
2016-07-27 19:03:00 -04:00
|
|
|
|
2018-06-07 04:11:09 -04:00
|
|
|
expect(response.status).to eq(200)
|
2016-07-27 19:03:00 -04:00
|
|
|
badge.reload
|
|
|
|
expect(badge.name).to eq('123456')
|
|
|
|
expect(badge.query).to eq(sql)
|
2014-03-05 07:52:20 -05:00
|
|
|
end
|
2019-11-08 00:34:24 -05:00
|
|
|
|
|
|
|
context 'when there is a user with a title granted using the badge' do
|
|
|
|
fab!(:user_with_badge_title) { Fabricate(:active_user) }
|
|
|
|
fab!(:badge) { Fabricate(:badge, name: 'Oathbreaker', allow_title: true) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
BadgeGranter.grant(badge, user_with_badge_title)
|
|
|
|
user_with_badge_title.update(title: 'Oathbreaker')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'updates the user title in a job' do
|
|
|
|
Jobs.expects(:enqueue).with(
|
|
|
|
:bulk_user_title_update,
|
|
|
|
new_title: 'Shieldbearer',
|
|
|
|
granted_badge_id: badge.id,
|
|
|
|
action: Jobs::BulkUserTitleUpdate::UPDATE_ACTION
|
|
|
|
)
|
|
|
|
|
|
|
|
put "/admin/badges/#{badge.id}.json", params: {
|
|
|
|
name: "Shieldbearer"
|
|
|
|
}
|
|
|
|
end
|
|
|
|
end
|
2014-03-05 07:52:20 -05:00
|
|
|
end
|
2020-01-13 09:20:26 -05:00
|
|
|
|
|
|
|
describe '#mass_award' do
|
2020-02-27 09:07:46 -05:00
|
|
|
before { @user = Fabricate(:user, email: 'user1@test.com', username: 'username1') }
|
|
|
|
|
2020-01-13 09:20:26 -05:00
|
|
|
it 'does nothing when there is no file' do
|
|
|
|
post "/admin/badges/award/#{badge.id}.json", params: { file: '' }
|
|
|
|
|
|
|
|
expect(response.status).to eq(400)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does nothing when the badge id is not valid' do
|
|
|
|
post '/admin/badges/award/fake_id.json', params: { file: fixture_file_upload(Tempfile.new) }
|
|
|
|
|
|
|
|
expect(response.status).to eq(400)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does nothing when the file is not a csv' do
|
|
|
|
file = file_from_fixtures('cropped.png')
|
|
|
|
|
|
|
|
post "/admin/badges/award/#{badge.id}.json", params: { file: fixture_file_upload(file) }
|
|
|
|
|
|
|
|
expect(response.status).to eq(400)
|
|
|
|
end
|
|
|
|
|
2020-02-18 08:53:12 -05:00
|
|
|
it 'awards the badge using a list of user emails' do
|
2020-01-13 09:20:26 -05:00
|
|
|
Jobs.run_immediately!
|
|
|
|
|
|
|
|
file = file_from_fixtures('user_emails.csv', 'csv')
|
|
|
|
|
|
|
|
post "/admin/badges/award/#{badge.id}.json", params: { file: fixture_file_upload(file) }
|
|
|
|
|
2020-02-27 09:07:46 -05:00
|
|
|
expect(UserBadge.exists?(user: @user, badge: badge)).to eq(true)
|
2020-01-13 09:20:26 -05:00
|
|
|
end
|
2020-02-18 08:53:12 -05:00
|
|
|
|
|
|
|
it 'awards the badge using a list of usernames' do
|
|
|
|
Jobs.run_immediately!
|
|
|
|
|
|
|
|
file = file_from_fixtures('usernames.csv', 'csv')
|
|
|
|
|
|
|
|
post "/admin/badges/award/#{badge.id}.json", params: { file: fixture_file_upload(file) }
|
|
|
|
|
2020-02-27 09:07:46 -05:00
|
|
|
expect(UserBadge.exists?(user: @user, badge: badge)).to eq(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'works with a CSV containing nil values' do
|
|
|
|
Jobs.run_immediately!
|
|
|
|
|
|
|
|
file = file_from_fixtures('usernames_with_nil_values.csv', 'csv')
|
|
|
|
|
|
|
|
post "/admin/badges/award/#{badge.id}.json", params: { file: fixture_file_upload(file) }
|
|
|
|
|
|
|
|
expect(UserBadge.exists?(user: @user, badge: badge)).to eq(true)
|
2020-02-18 08:53:12 -05:00
|
|
|
end
|
2020-01-13 09:20:26 -05:00
|
|
|
end
|
2014-03-05 07:52:20 -05:00
|
|
|
end
|
|
|
|
end
|