discourse/spec/models/digest_email_site_setting_s...

# frozen_string_literal: true

require 'rails_helper'

describe DigestEmailSiteSetting do
  describe 'valid_value?' do
    it 'returns true for a valid value as an int' do
      expect(DigestEmailSiteSetting.valid_value?(1440)).to eq true
    end

    it 'returns true for a valid value as a string' do
      expect(DigestEmailSiteSetting.valid_value?('1440')).to eq true
    end

    it 'returns false for an invalid value' do
      expect(DigestEmailSiteSetting.valid_value?('7 dogs')).to eq false
    end
  end
end
DEV: use #frozen_string_literal: true on all spec This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction 2019-04-29 20:27:42 -04:00			`# frozen_string_literal: true`

Prepare for separation of RSpec helper files Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails. 2015-10-11 05:41:23 -04:00			`require 'rails_helper'`
Enum site settings can have translatable names in dropdown. Add setting for how often users get digest emails by default: default_digest_email_frequency. 2013-08-23 17:35:01 -04:00
			`describe DigestEmailSiteSetting do`
			`describe 'valid_value?' do`
			`it 'returns true for a valid value as an int' do`
FEATURE: More digest email frequency options. Digests can be sent as often as every 30 minutes. 2016-03-02 15:26:27 -05:00			`expect(DigestEmailSiteSetting.valid_value?(1440)).to eq true`
Enum site settings can have translatable names in dropdown. Add setting for how often users get digest emails by default: default_digest_email_frequency. 2013-08-23 17:35:01 -04:00			`end`

			`it 'returns true for a valid value as a string' do`
FEATURE: More digest email frequency options. Digests can be sent as often as every 30 minutes. 2016-03-02 15:26:27 -05:00			`expect(DigestEmailSiteSetting.valid_value?('1440')).to eq true`
Enum site settings can have translatable names in dropdown. Add setting for how often users get digest emails by default: default_digest_email_frequency. 2013-08-23 17:35:01 -04:00			`end`

			`it 'returns false for an invalid value' do`
Update rspec syntax to v3 update rspec syntax to v3 change syntax to rspec v3 oops. fix typo mailers classes with rspec3 syntax helpers with rspec3 syntax jobs with rspec3 syntax serializers with rspec3 syntax views with rspec3 syntax support to rspec3 syntax category spec with rspec3 syntax 2014-12-31 09:55:03 -05:00			`expect(DigestEmailSiteSetting.valid_value?('7 dogs')).to eq false`
Enum site settings can have translatable names in dropdown. Add setting for how often users get digest emails by default: default_digest_email_frequency. 2013-08-23 17:35:01 -04:00			`end`
			`end`
			`end`