2019-04-29 20:27:42 -04:00
|
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
2019-01-03 12:03:01 -05:00
|
|
|
|
RSpec.describe ReviewableQueuedPost, type: :model do
|
2019-05-06 23:12:20 -04:00
|
|
|
|
fab!(:category) { Fabricate(:category) }
|
|
|
|
|
fab!(:moderator) { Fabricate(:moderator) }
|
2019-01-03 12:03:01 -05:00
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
|
describe "creating a post" do
|
2019-01-03 12:03:01 -05:00
|
|
|
|
let!(:topic) { Fabricate(:topic, category: category) }
|
|
|
|
|
let(:reviewable) { Fabricate(:reviewable_queued_post, topic: topic) }
|
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
|
context "when creating" do
|
2019-01-03 12:03:01 -05:00
|
|
|
|
it "triggers queued_post_created" do
|
|
|
|
|
event = DiscourseEvent.track(:queued_post_created) { reviewable.save! }
|
|
|
|
|
expect(event).to be_present
|
|
|
|
|
expect(event[:params][0]).to eq(reviewable)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "returns the appropriate create options" do
|
|
|
|
|
create_options = reviewable.create_options
|
|
|
|
|
|
|
|
|
|
expect(create_options[:topic_id]).to eq(topic.id)
|
|
|
|
|
expect(create_options[:raw]).to eq("hello world post contents.")
|
|
|
|
|
expect(create_options[:reply_to_post_number]).to eq(1)
|
|
|
|
|
expect(create_options[:via_email]).to eq(true)
|
|
|
|
|
expect(create_options[:raw_email]).to eq("store_me")
|
|
|
|
|
expect(create_options[:auto_track]).to eq(true)
|
|
|
|
|
expect(create_options[:custom_fields]).to eq("hello" => "world")
|
|
|
|
|
expect(create_options[:cooking_options]).to eq(cat: "hat")
|
|
|
|
|
expect(create_options[:cook_method]).to eq(Post.cook_methods[:raw_html])
|
|
|
|
|
expect(create_options[:not_create_option]).to eq(nil)
|
|
|
|
|
expect(create_options[:image_sizes]).to eq(
|
|
|
|
|
"http://foo.bar/image.png" => {
|
|
|
|
|
"width" => 0,
|
|
|
|
|
"height" => 222,
|
|
|
|
|
},
|
|
|
|
|
)
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
|
describe "actions" do
|
|
|
|
|
context "with approve_post" do
|
2019-01-03 12:03:01 -05:00
|
|
|
|
it "triggers an extensibility event" do
|
2019-04-23 12:18:39 -04:00
|
|
|
|
event =
|
|
|
|
|
DiscourseEvent.track(:approved_post) { reviewable.perform(moderator, :approve_post) }
|
2019-01-03 12:03:01 -05:00
|
|
|
|
expect(event).to be_present
|
|
|
|
|
expect(event[:params].first).to eq(reviewable)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "creates a post" do
|
|
|
|
|
topic_count, post_count = Topic.count, Post.count
|
2019-04-23 17:29:46 -04:00
|
|
|
|
result = nil
|
|
|
|
|
|
|
|
|
|
Jobs.run_immediately!
|
|
|
|
|
event =
|
|
|
|
|
DiscourseEvent.track(:before_create_notifications_for_users) do
|
|
|
|
|
result = reviewable.perform(moderator, :approve_post)
|
|
|
|
|
end
|
|
|
|
|
|
2019-01-03 12:03:01 -05:00
|
|
|
|
expect(result.success?).to eq(true)
|
|
|
|
|
expect(result.created_post).to be_present
|
2019-04-23 17:29:46 -04:00
|
|
|
|
expect(event).to be_present
|
2019-01-03 12:03:01 -05:00
|
|
|
|
expect(result.created_post).to be_valid
|
|
|
|
|
expect(result.created_post.topic).to eq(topic)
|
|
|
|
|
expect(result.created_post.custom_fields["hello"]).to eq("world")
|
|
|
|
|
expect(result.created_post_topic).to eq(topic)
|
2023-07-18 07:50:31 -04:00
|
|
|
|
expect(result.created_post.user).to eq(reviewable.target_created_by)
|
2021-05-26 14:43:18 -04:00
|
|
|
|
expect(reviewable.target_id).to eq(result.created_post.id)
|
2019-01-03 12:03:01 -05:00
|
|
|
|
|
|
|
|
|
expect(Topic.count).to eq(topic_count)
|
|
|
|
|
expect(Post.count).to eq(post_count + 1)
|
|
|
|
|
|
2019-04-15 16:19:32 -04:00
|
|
|
|
notifications =
|
|
|
|
|
Notification.where(
|
2023-07-18 07:50:31 -04:00
|
|
|
|
user: reviewable.target_created_by,
|
2019-04-15 16:19:32 -04:00
|
|
|
|
notification_type: Notification.types[:post_approved],
|
|
|
|
|
)
|
|
|
|
|
expect(notifications).to be_present
|
|
|
|
|
|
2019-01-03 12:03:01 -05:00
|
|
|
|
# We can't approve twice
|
2022-02-25 21:51:39 -05:00
|
|
|
|
expect { reviewable.perform(moderator, :approve_post) }.to raise_error(
|
|
|
|
|
Reviewable::InvalidAction,
|
|
|
|
|
)
|
2019-01-03 12:03:01 -05:00
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "skips validations" do
|
|
|
|
|
reviewable.payload["raw"] = "x"
|
2019-04-23 12:18:39 -04:00
|
|
|
|
result = reviewable.perform(moderator, :approve_post)
|
2019-01-03 12:03:01 -05:00
|
|
|
|
expect(result.created_post).to be_present
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "Allows autosilenced users to post" do
|
|
|
|
|
newuser = reviewable.created_by
|
|
|
|
|
newuser.update!(trust_level: 0)
|
|
|
|
|
post = Fabricate(:post, user: newuser)
|
|
|
|
|
PostActionCreator.spam(moderator, post)
|
2019-05-24 14:13:03 -04:00
|
|
|
|
Reviewable.set_priorities(high: 1.0)
|
2021-12-08 12:12:24 -05:00
|
|
|
|
SiteSetting.silence_new_user_sensitivity = Reviewable.sensitivities[:low]
|
2019-01-03 12:03:01 -05:00
|
|
|
|
SiteSetting.num_users_to_silence_new_user = 1
|
|
|
|
|
expect(Guardian.new(newuser).can_create_post?(topic)).to eq(false)
|
|
|
|
|
|
2019-04-23 12:18:39 -04:00
|
|
|
|
result = reviewable.perform(moderator, :approve_post)
|
2019-01-03 12:03:01 -05:00
|
|
|
|
expect(result.success?).to eq(true)
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
|
context "with reject_post" do
|
2019-01-03 12:03:01 -05:00
|
|
|
|
it "triggers an extensibility event" do
|
2019-04-23 12:18:39 -04:00
|
|
|
|
event =
|
|
|
|
|
DiscourseEvent.track(:rejected_post) { reviewable.perform(moderator, :reject_post) }
|
2019-01-03 12:03:01 -05:00
|
|
|
|
expect(event).to be_present
|
|
|
|
|
expect(event[:params].first).to eq(reviewable)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "doesn't create a post" do
|
|
|
|
|
post_count = Post.count
|
2019-04-23 12:18:39 -04:00
|
|
|
|
result = reviewable.perform(moderator, :reject_post)
|
2019-01-03 12:03:01 -05:00
|
|
|
|
expect(result.success?).to eq(true)
|
|
|
|
|
expect(result.created_post).to be_nil
|
|
|
|
|
expect(Post.count).to eq(post_count)
|
|
|
|
|
|
|
|
|
|
# We can't reject twice
|
2022-02-25 21:51:39 -05:00
|
|
|
|
expect { reviewable.perform(moderator, :reject_post) }.to raise_error(
|
|
|
|
|
Reviewable::InvalidAction,
|
|
|
|
|
)
|
2019-01-03 12:03:01 -05:00
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2023-10-12 21:28:31 -04:00
|
|
|
|
context "with revise_and_reject_post" do
|
|
|
|
|
it "doesn't create the post the user intended" do
|
|
|
|
|
post_count = Post.public_posts.count
|
|
|
|
|
result = reviewable.perform(moderator, :revise_and_reject_post)
|
|
|
|
|
expect(result.success?).to eq(true)
|
|
|
|
|
expect(result.created_post).to be_nil
|
|
|
|
|
expect(Post.public_posts.count).to eq(post_count)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "creates a private message to the creator of the post" do
|
|
|
|
|
args = { revise_reason: "Duplicate", revise_feedback: "This is old news" }
|
|
|
|
|
expect { reviewable.perform(moderator, :revise_and_reject_post, args) }.to change {
|
|
|
|
|
Topic.where(archetype: Archetype.private_message).count
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
topic = Topic.where(archetype: Archetype.private_message).last
|
|
|
|
|
expect(topic.title).to eq(
|
|
|
|
|
I18n.t(
|
|
|
|
|
"system_messages.reviewable_queued_post_revise_and_reject.subject_template",
|
|
|
|
|
topic_title: reviewable.topic.title,
|
|
|
|
|
),
|
|
|
|
|
)
|
|
|
|
|
translation_params = {
|
|
|
|
|
username: reviewable.target_created_by.username,
|
|
|
|
|
topic_title: reviewable.topic.title,
|
|
|
|
|
topic_url: reviewable.topic.url,
|
|
|
|
|
reason: args[:revise_reason],
|
|
|
|
|
feedback: args[:revise_feedback],
|
|
|
|
|
original_post: reviewable.payload["raw"],
|
|
|
|
|
site_name: SiteSetting.title,
|
|
|
|
|
}
|
|
|
|
|
expect(topic.first_post.raw.chomp).to eq(
|
|
|
|
|
I18n.t(
|
|
|
|
|
"system_messages.reviewable_queued_post_revise_and_reject.text_body_template",
|
|
|
|
|
translation_params,
|
|
|
|
|
).chomp,
|
|
|
|
|
)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "supports sending a custom revise reason" do
|
|
|
|
|
args = {
|
|
|
|
|
revise_reason: "Other...",
|
|
|
|
|
revise_feedback: "This is old news",
|
|
|
|
|
revise_custom_reason: "Boring",
|
|
|
|
|
}
|
|
|
|
|
expect { reviewable.perform(moderator, :revise_and_reject_post, args) }.to change {
|
|
|
|
|
Topic.where(archetype: Archetype.private_message).count
|
|
|
|
|
}
|
|
|
|
|
topic = Topic.where(archetype: Archetype.private_message).last
|
|
|
|
|
|
|
|
|
|
expect(topic.first_post.raw).not_to include("Other...")
|
|
|
|
|
expect(topic.first_post.raw).to include("Boring")
|
|
|
|
|
end
|
2023-10-26 23:05:41 -04:00
|
|
|
|
|
|
|
|
|
context "when the topic is nil in the case of a new topic being created" do
|
|
|
|
|
let(:reviewable) { Fabricate(:reviewable_queued_post_topic) }
|
|
|
|
|
|
|
|
|
|
it "works" do
|
|
|
|
|
args = { revise_reason: "Duplicate", revise_feedback: "This is old news" }
|
|
|
|
|
expect { reviewable.perform(moderator, :revise_and_reject_post, args) }.to change {
|
|
|
|
|
Topic.where(archetype: Archetype.private_message).count
|
|
|
|
|
}
|
|
|
|
|
topic = Topic.where(archetype: Archetype.private_message).last
|
|
|
|
|
|
|
|
|
|
expect(topic.title).to eq(
|
|
|
|
|
I18n.t(
|
|
|
|
|
"system_messages.reviewable_queued_post_revise_and_reject_new_topic.subject_template",
|
|
|
|
|
topic_title: reviewable.payload["title"],
|
|
|
|
|
),
|
|
|
|
|
)
|
|
|
|
|
translation_params = {
|
|
|
|
|
username: reviewable.target_created_by.username,
|
|
|
|
|
topic_title: reviewable.payload["title"],
|
|
|
|
|
topic_url: nil,
|
|
|
|
|
reason: args[:revise_reason],
|
|
|
|
|
feedback: args[:revise_feedback],
|
|
|
|
|
original_post: reviewable.payload["raw"],
|
|
|
|
|
site_name: SiteSetting.title,
|
|
|
|
|
}
|
|
|
|
|
expect(topic.first_post.raw.chomp).to eq(
|
|
|
|
|
I18n.t(
|
|
|
|
|
"system_messages.reviewable_queued_post_revise_and_reject_new_topic.text_body_template",
|
|
|
|
|
translation_params,
|
|
|
|
|
).chomp,
|
|
|
|
|
)
|
|
|
|
|
end
|
|
|
|
|
end
|
2023-10-12 21:28:31 -04:00
|
|
|
|
end
|
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
|
context "with delete_user" do
|
2019-01-03 12:03:01 -05:00
|
|
|
|
it "deletes the user and rejects the post" do
|
2023-07-18 07:50:31 -04:00
|
|
|
|
other_reviewable =
|
|
|
|
|
Fabricate(:reviewable_queued_post, created_by: reviewable.target_created_by)
|
2019-01-03 12:03:01 -05:00
|
|
|
|
|
|
|
|
|
result = reviewable.perform(moderator, :delete_user)
|
|
|
|
|
expect(result.success?).to eq(true)
|
2023-07-18 07:50:31 -04:00
|
|
|
|
expect(User.find_by(id: reviewable.target_created_by)).to be_blank
|
|
|
|
|
|
2019-01-03 12:03:01 -05:00
|
|
|
|
expect(result.remove_reviewable_ids).to include(reviewable.id)
|
|
|
|
|
expect(result.remove_reviewable_ids).to include(other_reviewable.id)
|
|
|
|
|
|
2023-07-18 07:50:31 -04:00
|
|
|
|
expect(ReviewableQueuedPost.where(id: reviewable.id)).to be_present
|
2019-01-03 12:03:01 -05:00
|
|
|
|
expect(ReviewableQueuedPost.where(id: other_reviewable.id)).to be_blank
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
|
describe "creating a topic" do
|
2019-01-03 12:03:01 -05:00
|
|
|
|
let(:reviewable) { Fabricate(:reviewable_queued_post_topic, category: category) }
|
|
|
|
|
|
2020-08-10 18:14:15 -04:00
|
|
|
|
before do
|
|
|
|
|
SiteSetting.tagging_enabled = true
|
|
|
|
|
SiteSetting.min_trust_to_create_tag = 0
|
|
|
|
|
SiteSetting.min_trust_level_to_tag_topics = 0
|
|
|
|
|
end
|
|
|
|
|
|
2022-07-27 12:14:14 -04:00
|
|
|
|
context "when editing" do
|
2019-01-03 12:03:01 -05:00
|
|
|
|
it "is editable and returns the fields" do
|
2019-05-01 14:48:49 -04:00
|
|
|
|
fields = reviewable.editable_for(Guardian.new(moderator))
|
2019-01-03 12:03:01 -05:00
|
|
|
|
expect(fields.has?("category_id")).to eq(true)
|
|
|
|
|
expect(fields.has?("payload.raw")).to eq(true)
|
|
|
|
|
expect(fields.has?("payload.title")).to eq(true)
|
|
|
|
|
expect(fields.has?("payload.tags")).to eq(true)
|
|
|
|
|
end
|
2019-05-01 14:48:49 -04:00
|
|
|
|
|
|
|
|
|
it "is editable by a category group reviewer" do
|
|
|
|
|
fields = reviewable.editable_for(Guardian.new(Fabricate(:user)))
|
|
|
|
|
expect(fields.has?("category_id")).to eq(false)
|
|
|
|
|
expect(fields.has?("payload.raw")).to eq(true)
|
|
|
|
|
expect(fields.has?("payload.title")).to eq(true)
|
|
|
|
|
expect(fields.has?("payload.tags")).to eq(true)
|
|
|
|
|
end
|
2019-01-03 12:03:01 -05:00
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "returns the appropriate create options for a topic" do
|
|
|
|
|
create_options = reviewable.create_options
|
|
|
|
|
expect(create_options[:category]).to eq(reviewable.category.id)
|
|
|
|
|
expect(create_options[:archetype]).to eq("regular")
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "creates the post and topic when approved" do
|
|
|
|
|
topic_count, post_count = Topic.count, Post.count
|
2019-04-23 12:18:39 -04:00
|
|
|
|
result = reviewable.perform(moderator, :approve_post)
|
2019-01-03 12:03:01 -05:00
|
|
|
|
|
|
|
|
|
expect(result.success?).to eq(true)
|
|
|
|
|
expect(result.created_post).to be_present
|
|
|
|
|
expect(result.created_post).to be_valid
|
|
|
|
|
expect(result.created_post_topic).to be_present
|
|
|
|
|
expect(result.created_post_topic).to be_valid
|
2021-05-26 14:43:18 -04:00
|
|
|
|
expect(reviewable.target_id).to eq(result.created_post.id)
|
|
|
|
|
expect(reviewable.topic_id).to eq(result.created_post_topic.id)
|
2019-01-03 12:03:01 -05:00
|
|
|
|
|
|
|
|
|
expect(Topic.count).to eq(topic_count + 1)
|
|
|
|
|
expect(Post.count).to eq(post_count + 1)
|
|
|
|
|
end
|
|
|
|
|
|
2023-01-05 09:01:37 -05:00
|
|
|
|
it "creates a topic with staff tag when approved" do
|
|
|
|
|
hidden_tag = Fabricate(:tag)
|
|
|
|
|
staff_tag_group =
|
|
|
|
|
Fabricate(:tag_group, permissions: { "staff" => 1 }, tag_names: [hidden_tag.name])
|
|
|
|
|
reviewable.payload["tags"] += [hidden_tag.name]
|
|
|
|
|
|
|
|
|
|
result = reviewable.perform(moderator, :approve_post)
|
|
|
|
|
|
|
|
|
|
expect(result.success?).to eq(true)
|
|
|
|
|
expect(result.created_post_topic).to be_present
|
|
|
|
|
expect(result.created_post_topic).to be_valid
|
|
|
|
|
expect(reviewable.topic_id).to eq(result.created_post_topic.id)
|
|
|
|
|
expect(result.created_post_topic.tags.pluck(:name)).to match_array(reviewable.payload["tags"])
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "does not create the post and topic when rejected" do
|
2019-01-03 12:03:01 -05:00
|
|
|
|
topic_count, post_count = Topic.count, Post.count
|
2019-04-23 12:18:39 -04:00
|
|
|
|
result = reviewable.perform(moderator, :reject_post)
|
2019-01-03 12:03:01 -05:00
|
|
|
|
|
|
|
|
|
expect(result.success?).to eq(true)
|
|
|
|
|
expect(result.created_post).to be_blank
|
|
|
|
|
expect(result.created_post_topic).to be_blank
|
|
|
|
|
|
|
|
|
|
expect(Topic.count).to eq(topic_count)
|
|
|
|
|
expect(Post.count).to eq(post_count)
|
|
|
|
|
end
|
|
|
|
|
end
|
2021-08-26 12:16:00 -04:00
|
|
|
|
|
|
|
|
|
describe "Callbacks" do
|
|
|
|
|
context "when creating a new pending reviewable" do
|
|
|
|
|
let(:reviewable) do
|
2023-07-18 07:50:31 -04:00
|
|
|
|
Fabricate.build(
|
|
|
|
|
:reviewable_queued_post_topic,
|
|
|
|
|
category: category,
|
|
|
|
|
created_by: moderator,
|
|
|
|
|
target_created_by: user,
|
|
|
|
|
)
|
2023-01-09 06:18:21 -05:00
|
|
|
|
end
|
2021-08-26 12:16:00 -04:00
|
|
|
|
let(:user) { Fabricate(:user) }
|
|
|
|
|
let(:user_stats) { user.user_stat }
|
|
|
|
|
|
|
|
|
|
it "updates user stats" do
|
|
|
|
|
user_stats.expects(:update_pending_posts)
|
|
|
|
|
reviewable.save!
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context "when updating an existing reviewable" do
|
|
|
|
|
let!(:reviewable) { Fabricate(:reviewable_queued_post_topic, category: category) }
|
2023-07-18 07:50:31 -04:00
|
|
|
|
let(:user_stats) { reviewable.target_created_by.user_stat }
|
2021-08-26 12:16:00 -04:00
|
|
|
|
|
|
|
|
|
context "when status changes from 'pending' to something else" do
|
|
|
|
|
it "updates user stats" do
|
|
|
|
|
user_stats.expects(:update_pending_posts)
|
2021-12-08 12:12:24 -05:00
|
|
|
|
reviewable.update!(status: :approved)
|
2021-08-26 12:16:00 -04:00
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context "when status doesn’t change" do
|
|
|
|
|
it "doesn’t update user stats" do
|
|
|
|
|
user_stats.expects(:update_pending_posts).never
|
|
|
|
|
reviewable.update!(score: 10)
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
end
|
2019-01-03 12:03:01 -05:00
|
|
|
|
end
|